59224 2011-04-22 13:01:06 -0700 Don't rely on hasSpinButton to check if an input type can be stepped 2011-04-22 16:19:01 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned abarth eric joepeck simon.fraser tkent webkit.review.bot oldest_to_newest 390987 0 joepeck 2011-04-22 13:01:06 -0700 Add isSteppable. This almost removes the last usage of isRangeControl, but it is used once later on in the function. We shouldn't assert that a steppable control has a spinner, since a spinner is a UI detail and steppability is functionality. 390995 1 90746 joepeck 2011-04-22 13:10:35 -0700 Created attachment 90746 [PATCH] Proposed Fix - Add isSteppable 391008 2 90746 tkent 2011-04-22 13:35:34 -0700 Comment on attachment 90746 [PATCH] Proposed Fix - Add isSteppable ok 391075 3 joepeck 2011-04-22 14:33:28 -0700 Landed in <http://trac.webkit.org/changeset/84683>. 391077 4 joepeck 2011-04-22 14:37:57 -0700 Arg, I should also have removed the now unused HTMLInputElement::hasSpinButton. I'll be working on a follow-up patch that will do that soon. 391210 5 webkit.review.bot 2011-04-22 16:19:01 -0700 http://trac.webkit.org/changeset/84683 might have broken GTK Linux 64-bit Debug 90746 2011-04-22 13:10:35 -0700 2011-04-22 14:33:18 -0700 [PATCH] Proposed Fix - Add isSteppable steppable.patch text/plain 7270 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzODg1ZWEyLi42NThkZDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcg QEAKKzIwMTEtMDQtMjIgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCByZWx5 IG9uIGhhc1NwaW5Db250cm9sIHRvIGNoZWNrIGlmIGFuIGlucHV0IHR5cGUgY2FuIGJlIHN0ZXBw ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MjI0 CisKKyAgICAgICAgQWRkIGlzU3RlcHBhYmxlIHRvIGtub3cgZm9yIGNlcnRhaW4gaWYgYW4gaW5w dXQgdHlwZSBjYW4KKyAgICAgICAgYmUgc3RlcHBlZCBvciBub3QuIFByZXZpb3VzbHkgd2Ugd2Vy ZSBjaGVja2luZyBpZiB0aGUgaW5wdXQKKyAgICAgICAgaGFzIGEgc3BpbiBjb250cm9sIG9yIGlz IHRoZSByYW5nZSBpbnB1dCB0eXBlLiBUaGVzZSBhcmUgVUkKKyAgICAgICAgZGV0YWlscywgYnV0 IHRoZSBzdGVwIGZ1bmN0aW9uYWxpdHkgZG9lcyBub3QgcmVxdWlyZSB0aGVyZQorICAgICAgICB0 byBiZSBhIFVJLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlvciwgY292ZXJlZCBieSBl eGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJhc2VEYXRlQW5kVGltZUlucHV0VHlwZTo6aXNTdGVw cGFibGUpOgorICAgICAgICAqIGh0bWwvQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBlLmg6CisgICAg ICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJ bnB1dEVsZW1lbnQ6OmlzU3RlcHBhYmxlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVs ZW1lbnQ6OnN0ZXBVcEZyb21SZW5kZXJlcik6IHJlbW92ZSB0aGUKKyAgICAgICAgY2hlY2sgZm9y IGEgc3Bpbm5lciBhbmQgcmFuZ2UgY29udHJvbCBhbmQgaW5zdGVhZCBBU1NFUlQKKyAgICAgICAg dGhhdCB0aGUgdHlwZSBpcyBzdGVwcGFibGUuCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVt ZW50Lmg6CisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW5wdXRUeXBlOjppc1N0ZXBwYWJsZSk6CisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuaDoKKyAg ICAgICAgKiBodG1sL051bWJlcklucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOdW1i ZXJJbnB1dFR5cGU6OmlzU3RlcHBhYmxlKToKKyAgICAgICAgKiBodG1sL051bWJlcklucHV0VHlw ZS5oOgorICAgICAgICAqIGh0bWwvUmFuZ2VJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmFuZ2VJbnB1dFR5cGU6OmlzU3RlcHBhYmxlKToKKyAgICAgICAgKiBodG1sL1JhbmdlSW5w dXRUeXBlLmg6CisKIDIwMTEtMDQtMTkgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUuY3BwCmluZGV4 IGI2NzJlNTEuLmQ4NWFiN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQmFzZURh dGVBbmRUaW1lSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VEYXRl QW5kVGltZUlucHV0VHlwZS5jcHAKQEAgLTEwOCw2ICsxMDgsMTEgQEAgZG91YmxlIEJhc2VEYXRl QW5kVGltZUlucHV0VHlwZTo6ZGVmYXVsdFZhbHVlRm9yU3RlcFVwKCkgY29uc3QKICAgICByZXR1 cm4gbXMgKyAob2Zmc2V0ICogbXNQZXJNaW51dGUpOwogfQogCitib29sIEJhc2VEYXRlQW5kVGlt ZUlucHV0VHlwZTo6aXNTdGVwcGFibGUoKSBjb25zdAoreworICAgIHJldHVybiB0cnVlOworfQor CiBib29sIEJhc2VEYXRlQW5kVGltZUlucHV0VHlwZTo6c3RlcE1pc21hdGNoKGNvbnN0IFN0cmlu ZyYgdmFsdWUsIGRvdWJsZSBzdGVwKSBjb25zdAogewogICAgIGNvbnN0IGRvdWJsZSBuYW4gPSBu dW1lcmljX2xpbWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0Jhc2VEYXRlQW5kVGltZUlucHV0VHlwZS5oCmluZGV4IDg2NzExNWQuLjQ4MzAxMDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUuaApAQCAt NTYsNiArNTYsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCByYW5nZU92ZXJmbG93KGNv bnN0IFN0cmluZyYpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c1JhbmdlTGltaXRh dGlvbigpIGNvbnN0OwogICAgIHZpcnR1YWwgZG91YmxlIGRlZmF1bHRWYWx1ZUZvclN0ZXBVcCgp IGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc1N0ZXBwYWJsZSgpIGNvbnN0OwogICAgIHZpcnR1 YWwgYm9vbCBzdGVwTWlzbWF0Y2goY29uc3QgU3RyaW5nJiwgZG91YmxlKSBjb25zdDsKICAgICB2 aXJ0dWFsIGRvdWJsZSBzdGVwQmFzZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVL ZXlkb3duRXZlbnQoS2V5Ym9hcmRFdmVudCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5jcHAKaW5kZXggNjMwOTc4YS4uZTI4ZTQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0xMzI2LDYgKzEzMjYsMTEgQEAgSFRNTE9wdGlvbkVs ZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6OnNlbGVjdGVkT3B0aW9uKCkgY29uc3QKIAogI2VuZGlm IC8vIEVOQUJMRShEQVRBTElTVCkKIAorYm9vbCBIVE1MSW5wdXRFbGVtZW50Ojppc1N0ZXBwYWJs ZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1faW5wdXRUeXBlLT5pc1N0ZXBwYWJsZSgpOworfQor CiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnN0ZXBVcEZyb21SZW5kZXJlcihpbnQgbikKIHsKICAg ICAvLyBUaGUgZGlmZmVyZW5jZXMgZnJvbSBzdGVwVXAoKS9zdGVwRG93bigpOgpAQCAtMTM2Myw4 ICsxMzY4LDggQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpzdGVwVXBGcm9tUmVuZGVyZXIoaW50 IG4pCiAgICAgLy8KICAgICAvLyBuIGlzIGFzc3VtZWQgYXMgLW4gaWYgc3RlcCA8IDAuCiAKLSAg ICBBU1NFUlQoaGFzU3BpbkJ1dHRvbigpIHx8IG1faW5wdXRUeXBlLT5pc1JhbmdlQ29udHJvbCgp KTsKLSAgICBpZiAoIWhhc1NwaW5CdXR0b24oKSAmJiAhbV9pbnB1dFR5cGUtPmlzUmFuZ2VDb250 cm9sKCkpCisgICAgQVNTRVJUKGlzU3RlcHBhYmxlKCkpOworICAgIGlmICghaXNTdGVwcGFibGUo KSkKICAgICAgICAgcmV0dXJuOwogICAgIEFTU0VSVChuKTsKICAgICBpZiAoIW4pCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IDJhOThiMTMuLmYyM2JlN2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC03OCw2ICs3OCw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIHN0ZXBVcChFeGNlcHRpb25Db2RlJiBlYykgeyBzdGVwVXAoMSwgZWMpOyB9 CiAgICAgdm9pZCBzdGVwRG93bihFeGNlcHRpb25Db2RlJiBlYykgeyBzdGVwRG93bigxLCBlYyk7 IH0KICAgICAvLyBzdGVwVXAoKS9zdGVwRG93bigpIGZvciB1c2VyLWludGVyYWN0aW9uLgorICAg IGJvb2wgaXNTdGVwcGFibGUoKSBjb25zdDsKICAgICB2b2lkIHN0ZXBVcEZyb21SZW5kZXJlcihp bnQpOwogCiAgICAgYm9vbCBpc1RleHRCdXR0b24oKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRU eXBlLmNwcAppbmRleCBiYTI3NDA4Li40YzI2MDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0lucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUu Y3BwCkBAIC02MzEsNiArNjMxLDExIEBAIGJvb2wgSW5wdXRUeXBlOjppc0NoZWNrYWJsZSgpCiAg ICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIElucHV0VHlwZTo6aXNTdGVwcGFibGUoKSBjb25z dAoreworICAgIHJldHVybiBmYWxzZTsKK30KKwogYm9vbCBJbnB1dFR5cGU6Omhhc1NwaW5CdXR0 b24oKQogewogICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCmluZGV4IDJl OTEzODcuLmJiNTg1MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaApAQCAtMjA2LDYgKzIwNiw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkUmVzcGVjdFNwZWVjaEF0dHJpYnV0 ZSgpOwogICAgIHZpcnR1YWwgYm9vbCBpc0VudW1lcmF0YWJsZSgpOwogICAgIHZpcnR1YWwgYm9v bCBpc0NoZWNrYWJsZSgpOworICAgIHZpcnR1YWwgYm9vbCBpc1N0ZXBwYWJsZSgpIGNvbnN0Owog ICAgIHZpcnR1YWwgYm9vbCBoYXNTcGluQnV0dG9uKCk7CiAgICAgdmlydHVhbCBib29sIHNob3Vs ZFJlc3BlY3RIZWlnaHRBbmRXaWR0aEF0dHJpYnV0ZXMoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9O dW1iZXJJbnB1dFR5cGUuY3BwCmluZGV4IGFmMzAzNDUuLjU1NzE3YWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL051bWJlcklucHV0VHlwZS5jcHAKQEAgLTEyMSw2ICsxMjEsMTEgQEAgZG91YmxlIE51 bWJlcklucHV0VHlwZTo6bWF4aW11bSgpIGNvbnN0CiAgICAgcmV0dXJuIHBhcnNlVG9Eb3VibGUo ZWxlbWVudCgpLT5mYXN0R2V0QXR0cmlidXRlKG1heEF0dHIpLCBudW1lcmljX2xpbWl0czxmbG9h dD46Om1heCgpKTsKIH0KIAorYm9vbCBOdW1iZXJJbnB1dFR5cGU6OmlzU3RlcHBhYmxlKCkgY29u c3QKK3sKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogYm9vbCBOdW1iZXJJbnB1dFR5cGU6OnN0ZXBN aXNtYXRjaChjb25zdCBTdHJpbmcmIHZhbHVlLCBkb3VibGUgc3RlcCkgY29uc3QKIHsKICAgICBk b3VibGUgZG91YmxlVmFsdWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL051bWJl cklucHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuaAppbmRl eCBlYTVkYzEwLi4yYjY1ODY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL051bWJl cklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmgK QEAgLTUxLDYgKzUxLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNSYW5n ZUxpbWl0YXRpb24oKSBjb25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBtaW5pbXVtKCkgY29uc3Q7 CiAgICAgdmlydHVhbCBkb3VibGUgbWF4aW11bSgpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBp c1N0ZXBwYWJsZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBzdGVwTWlzbWF0Y2goY29uc3Qg U3RyaW5nJiwgZG91YmxlKSBjb25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBzdGVwQmFzZSgpIGNv bnN0OwogICAgIHZpcnR1YWwgZG91YmxlIHN0ZXBCYXNlV2l0aERlY2ltYWxQbGFjZXModW5zaWdu ZWQqKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5 cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5jcHAKaW5kZXggMjhh YWE3Ny4uMzFiMGE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0 VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5jcHAKQEAg LTEyMSw2ICsxMjEsMTEgQEAgZG91YmxlIFJhbmdlSW5wdXRUeXBlOjptYXhpbXVtKCkgY29uc3QK ICAgICByZXR1cm4gbWF4OwogfQogCitib29sIFJhbmdlSW5wdXRUeXBlOjppc1N0ZXBwYWJsZSgp IGNvbnN0Cit7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIGJvb2wgUmFuZ2VJbnB1dFR5cGU6OnN0 ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmLCBkb3VibGUpIGNvbnN0CiB7CiAgICAgLy8gc3RlcE1p c21hdGNoIGRvZXNuJ3Qgb2NjdXIgZm9yIHR5cGU9cmFuZ2UuIFJlbmRlclNsaWRlciBndWFyYW50 ZWVzIHRoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlwZS5oCmluZGV4IDc1ZTdhMTcuLjQ3 MDgzODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5cGUuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmgKQEAgLTUzLDYgKzUzLDcg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNSYW5nZUxpbWl0YXRpb24oKSBj b25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBtaW5pbXVtKCkgY29uc3Q7CiAgICAgdmlydHVhbCBk b3VibGUgbWF4aW11bSgpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc1N0ZXBwYWJsZSgpIGNv bnN0OwogICAgIHZpcnR1YWwgYm9vbCBzdGVwTWlzbWF0Y2goY29uc3QgU3RyaW5nJiwgZG91Ymxl KSBjb25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBzdGVwQmFzZSgpIGNvbnN0OwogICAgIHZpcnR1 YWwgZG91YmxlIGRlZmF1bHRTdGVwKCkgY29uc3Q7Cg==