59223 2011-04-22 12:51:57 -0700 REGRESSION (r82185): iframe not displayed after navigation back to cached page 2011-04-22 16:04:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin abarth bdakin eric webkit.review.bot oldest_to_newest 390983 0 bdakin 2011-04-22 12:51:57 -0700 * SUMMARY After navigating back to a page in the page cache with an iframe, the iframe is not loaded. * STEPS TO REPRODUCE 1. Navigate to <data:text/html,%3ciframe%20src=%22http://webkit.org/%22%3E%3C/iframe%3E> 2. Navigate in the same tab to <about:blank> 3. Go back * RESULTS The iframe is now empty * NOTES Only happens if the back/forward cache is enabled. This is a regression from http://trac.webkit.org/changeset/82185 Patch forthcoming! <rdar://problem/9323763> 390990 1 90745 bdakin 2011-04-22 13:04:44 -0700 Created attachment 90745 Patch I made a test that works for this in Safari, but it is not a valid DRT test since it passes in DRT even without my patch. 391100 2 90745 mjs 2011-04-22 14:54:27 -0700 Comment on attachment 90745 Patch What's different about DRT? IS it the fact that DRT doesn't use overlay scrollers? I'd suggest at least adding it as a manual test so we don't forget about it. r=me 391109 3 bdakin 2011-04-22 14:59:12 -0700 (In reply to comment #2) > (From update of attachment 90745 [details]) > What's different about DRT? IS it the fact that DRT doesn't use overlay scrollers? I'd suggest at least adding it as a manual test so we don't forget about it. r=me No, the bug occurs with all types of scrollbars. For some reason DRT just lays out and paints the iframe after going back to the page, which is not true in Safar/WebKit without this patch. I thought it would at least work as a pixel test, but it does not. There must be something sufficiently different about about DRT's back mechanism and "back" in the browser that causes the necessary layout to happen. I can add it as a manual test though. 391118 4 bdakin 2011-04-22 15:03:37 -0700 Do we have manual tests checked in anymore? I can't seem to find them. 391124 5 bdakin 2011-04-22 15:11:02 -0700 Committed the change with revision 84688. Not sure if there's a place for my still-manual test, so I will just hold onto it for now. 391156 6 ap 2011-04-22 15:34:50 -0700 > Do we have manual tests checked in anymore? I can't seem to find them. Source/WebCore/manual-tests. Not that anyone ever runs those. 391160 7 bdakin 2011-04-22 15:37:13 -0700 (In reply to comment #6) > > Do we have manual tests checked in anymore? I can't seem to find them. > > Source/WebCore/manual-tests. Not that anyone ever runs those. WebCore! That's where they are hiding. Yeah, it's not super useful, but I will check it in there anyway. 391163 8 bdakin 2011-04-22 15:43:08 -0700 Manual test added with revision 84694. 391178 9 webkit.review.bot 2011-04-22 16:04:10 -0700 http://trac.webkit.org/changeset/84688 might have broken SnowLeopard Intel Release (Build) 391183 10 webkit.review.bot 2011-04-22 16:04:32 -0700 http://trac.webkit.org/changeset/84694 might have broken SnowLeopard Intel Release (Build) 391184 11 webkit.review.bot 2011-04-22 16:04:36 -0700 http://trac.webkit.org/changeset/84695 might have broken SnowLeopard Intel Release (Build) 90745 2011-04-22 13:04:44 -0700 2011-04-22 14:54:27 -0700 Patch for-review.txt text/plain 2497 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMjIgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 OTIyMworICAgICAgICBSRUdSRVNTSU9OIChyODIxODUpOiBpZnJhbWUgbm90IGRpc3BsYXllZCBh ZnRlciBuYXZpZ2F0aW9uIGJhY2sgdG8gY2FjaGVkIHBhZ2UKKyAgICAgICAgLWFuZCBjb3JyZXNw b25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTMyMzc2Mz4KKworICAgICAgICBDYWNo ZSB0aGUgc2Nyb2xsIHBvc2l0aW9uIGluIERvY3VtZW50OjpzZXRJblBhZ2VDYWNoZSgpIGluc3Rl YWQgb2YgCisgICAgICAgIEZyYW1lVmlldzo6cmVzZXRTY3JvbGxiYXJzQW5kQ2xlYXJDb250ZW50 c1NpemUoKSwgYW5kIG9ubHkgY2xlYXIgdGhlIGNvbnRlbnRzIHNpemUgCisgICAgICAgIGZvciB0 aGUgbWFpbkZyYW1lKCkuIFN0aWxsIHJlc2V0U2Nyb2xsYmFycygpIGZvciBvdGhlciBmcmFtZXMs IHdoaWNoIG1hdGNoZXMgcHJlLQorICAgICAgICByODIxODUgY29kZS4KKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldEluUGFnZUNhY2hl KToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZVZpZXc6OnJlc2V0U2Nyb2xsYmFyc0FuZENsZWFyQ29udGVudHNTaXplKToKKwogMjAxMS0wNC0y MiAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2aWQgSHlhdHQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDg0NjQ4 KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt Mzg3NCw4ICszODc0LDEzIEBAIHZvaWQgRG9jdW1lbnQ6OnNldEluUGFnZUNhY2hlKGJvb2wgZmxh ZykKICAgICBpZiAoZmxhZykgewogICAgICAgICBBU1NFUlQoIW1fc2F2ZWRSZW5kZXJlcik7CiAg ICAgICAgIG1fc2F2ZWRSZW5kZXJlciA9IHJlbmRlcmVyKCk7Ci0gICAgICAgIGlmIChGcmFtZVZp ZXcqIHYgPSB2aWV3KCkpCi0gICAgICAgICAgICB2LT5yZXNldFNjcm9sbGJhcnNBbmRDbGVhckNv bnRlbnRzU2l6ZSgpOworICAgICAgICBpZiAoRnJhbWVWaWV3KiB2ID0gdmlldygpKSB7CisgICAg ICAgICAgICB2LT5jYWNoZUN1cnJlbnRTY3JvbGxQb3NpdGlvbigpOworICAgICAgICAgICAgaWYg KHBhZ2UoKSAmJiBwYWdlKCktPm1haW5GcmFtZSgpID09IG1fZnJhbWUpCisgICAgICAgICAgICAg ICAgdi0+cmVzZXRTY3JvbGxiYXJzQW5kQ2xlYXJDb250ZW50c1NpemUoKTsKKyAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICB2LT5yZXNldFNjcm9sbGJhcnMoKTsKKyAgICAgICAgfQog ICAgICAgICBtX3N0eWxlUmVjYWxjVGltZXIuc3RvcCgpOwogICAgIH0gZWxzZSB7CiAgICAgICAg IEFTU0VSVCghcmVuZGVyZXIoKSB8fCByZW5kZXJlcigpID09IG1fc2F2ZWRSZW5kZXJlcik7Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lvbiA4NDY0OCkKKysrIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU4LDEwICsy NTgsNiBAQCB2b2lkIEZyYW1lVmlldzo6cmVzZXRTY3JvbGxiYXJzKCkKIAogdm9pZCBGcmFtZVZp ZXc6OnJlc2V0U2Nyb2xsYmFyc0FuZENsZWFyQ29udGVudHNTaXplKCkKIHsKLSAgICAvLyBTaW5j ZSB0aGUgY29udGVudHMgc2l6ZSBpcyBiZWluZyBjbGVhcmVkLCB0aGUgc2Nyb2xsIHBvc2l0aW9u IHdpbGwgbG9zdCBhcyBhIGNvbnNlcXVlbmNlLgotICAgIC8vIENhY2hlIHRoZSBzY3JvbGwgcG9z aXRpb24gc28gaXQgY2FuIGJlIHJlc3RvcmVkIGJ5IHRoZSBwYWdlIGNhY2hlIGlmIG5lY2Vzc2Fy eS4gCi0gICAgY2FjaGVDdXJyZW50U2Nyb2xsUG9zaXRpb24oKTsKLQogICAgIHJlc2V0U2Nyb2xs YmFycygpOwogCiAgICAgc2V0U2Nyb2xsYmFyc1N1cHByZXNzZWQodHJ1ZSk7Cg==