59210 2011-04-22 10:30:36 -0700 WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes 2011-04-29 11:25:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein aroben sam oldest_to_newest 390868 0 bweinstein 2011-04-22 10:30:36 -0700 We should stop the responsiveness timer when a WebPageProxy closes or when the WebProcess crashes. 390871 1 90721 bweinstein 2011-04-22 10:33:22 -0700 Created attachment 90721 [PATCH] Fix 390874 2 90721 sam 2011-04-22 10:35:58 -0700 Comment on attachment 90721 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=90721&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:182 > + process()->responsivenessTimer()->stop(); This should probably be in close(), not the destructor. 390878 3 90723 bweinstein 2011-04-22 10:43:03 -0700 Created attachment 90723 [PATCH] Fix v2 390880 4 90723 sam 2011-04-22 10:45:03 -0700 Comment on attachment 90723 [PATCH] Fix v2 View in context: https://bugs.webkit.org/attachment.cgi?id=90723&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:357 > + process()->responsivenessTimer()->stop(); The remove webpage thing call should be last, please move this above the call to process()->send(Messages::WebPage::Close(), m_pageID) to keep consistency. 390884 5 bweinstein 2011-04-22 10:47:36 -0700 Landed in r84643. 395384 6 aroben 2011-04-29 11:25:36 -0700 For posterity's sake: The issue this was trying to fix was: clicking the "close" button in the docked Web Inspector would cause the UI process to think the web process had become unresponsive. Our theory for why this was happening was that the Web Inspector's WebPage wasn't having time to send the DidHandleEvent message back to the UI process before it was closed. Thus we tried to fix the issue by always stopping the responsiveness timer whenever a WebPage gets closed. 90721 2011-04-22 10:33:22 -0700 2011-04-22 10:43:03 -0700 [PATCH] Fix stop_responsiveness_timer.patch text/plain 1536 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjQwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjIgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFN0b3AgUmVzcG9uc2l2ZW5lc3MgVGlt ZXIgd2hlbiBXZWJQYWdlUHJveHkgY2xvc2VzIG9yIFdlYlByb2Nlc3MgY3Jhc2hlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkyMTAKKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl UHJveHk6On5XZWJQYWdlUHJveHkpOiBTdG9wIHRoZSByZXNwb25zaXZlbmVzcyB0aW1lci4KKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkQ3Jhc2gpOiBEaXR0by4KKwog MjAxMS0wNC0yMSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgR2l2 ZSB3aW5kb3dsZXNzIHBsdWdpbnMnIGNvbnRleHQgbWVudXMgYW4gb3duZXIgd2luZG93IGluIHRo ZSBzYW1lIHRocmVhZCBhcyB0aGUgcGx1Z2luCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gODQ1MjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc4LDYgKzE3OCw4 IEBAIFdlYlBhZ2VQcm94eTo6fldlYlBhZ2VQcm94eSgpCiAjaWZuZGVmIE5ERUJVRwogICAgIHdl YlBhZ2VQcm94eUNvdW50ZXIuZGVjcmVtZW50KCk7CiAjZW5kaWYKKworICAgIHByb2Nlc3MoKS0+ cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdG9wKCk7CiB9CiAKIFdlYlByb2Nlc3NQcm94eSogV2Vi UGFnZVByb3h5Ojpwcm9jZXNzKCkgY29uc3QKQEAgLTI3OTksNiArMjgwMSw4IEBAIHZvaWQgV2Vi UGFnZVByb3h5Ojpwcm9jZXNzRGlkQ3Jhc2goKQogICAgIGRpc21pc3NDb3JyZWN0aW9uUGFuZWwo UmVhc29uRm9yRGlzbWlzc2luZ0NvcnJlY3Rpb25QYW5lbElnbm9yZWQpOwogICAgIG1fcGFnZUNs aWVudC0+ZGlzbWlzc0RpY3Rpb25hcnlMb29rdXBQYW5lbCgpOwogI2VuZGlmCisKKyAgICBwcm9j ZXNzKCktPnJlc3BvbnNpdmVuZXNzVGltZXIoKS0+c3RvcCgpOwogfQogCiBXZWJQYWdlQ3JlYXRp b25QYXJhbWV0ZXJzIFdlYlBhZ2VQcm94eTo6Y3JlYXRpb25QYXJhbWV0ZXJzKCkgY29uc3QK 90723 2011-04-22 10:43:03 -0700 2011-04-22 10:45:03 -0700 [PATCH] Fix v2 stop_responsiveness_timer.patch text/plain 1549 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjQwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjIgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFN0b3AgUmVzcG9uc2l2ZW5lc3MgVGlt ZXIgd2hlbiBXZWJQYWdlUHJveHkgY2xvc2VzIG9yIFdlYlByb2Nlc3MgY3Jhc2hlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkyMTAKKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl UHJveHk6OmNsb3NlKTogU3RvcCB0aGUgcmVzcG9uc2l2ZW5lc3MgdGltZXIuCisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZENyYXNoKTogRGl0dG8uCisKIDIwMTEtMDQt MjEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEdpdmUgd2luZG93 bGVzcyBwbHVnaW5zJyBjb250ZXh0IG1lbnVzIGFuIG93bmVyIHdpbmRvdyBpbiB0aGUgc2FtZSB0 aHJlYWQgYXMgdGhlIHBsdWdpbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAJKHJldmlzaW9uIDg0NTI5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1Myw2ICszNTMsOCBAQCB2b2lk IFdlYlBhZ2VQcm94eTo6Y2xvc2UoKQogCiAgICAgcHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlOjpDbG9zZSgpLCBtX3BhZ2VJRCk7CiAgICAgcHJvY2VzcygpLT5yZW1vdmVXZWJQYWdl KG1fcGFnZUlEKTsKKworICAgIHByb2Nlc3MoKS0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdG9w KCk7CiB9CiAKIGJvb2wgV2ViUGFnZVByb3h5Ojp0cnlDbG9zZSgpCkBAIC0yNzk5LDYgKzI4MDEs OCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZENyYXNoKCkKICAgICBkaXNtaXNzQ29y cmVjdGlvblBhbmVsKFJlYXNvbkZvckRpc21pc3NpbmdDb3JyZWN0aW9uUGFuZWxJZ25vcmVkKTsK ICAgICBtX3BhZ2VDbGllbnQtPmRpc21pc3NEaWN0aW9uYXJ5TG9va3VwUGFuZWwoKTsKICNlbmRp ZgorCisgICAgcHJvY2VzcygpLT5yZXNwb25zaXZlbmVzc1RpbWVyKCktPnN0b3AoKTsKIH0KIAog V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyBXZWJQYWdlUHJveHk6OmNyZWF0aW9uUGFyYW1ldGVy cygpIGNvbnN0Cg==