59207 2011-04-22 10:10:41 -0700 webkit-patch rebaseline is broken 2011-04-22 16:18:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dglazkov eric abarth commit-queue dpranke eric mihaip ojan webkit.review.bot oldest_to_newest 390855 0 dglazkov 2011-04-22 10:10:41 -0700 Not sure what's going on yet, filing bug on the spot. Attempting to choose a build from the list makes Python barf: $ webkit-patch rebaseline 11 builders failing Which builder to pull results from: 1. Leopard Intel Release (Tests) 2. Leopard Intel Debug (Tests) 3. SnowLeopard Intel Release (WebKit2 Tests) 4. Windows XP Debug (Tests) 5. GTK Linux 32-bit Release 6. GTK Linux 32-bit Debug 7. GTK Linux 64-bit Debug 8. Qt Linux Release 9. Chromium Win Release (Tests) 10. Chromium Mac Release (Tests) 11. Chromium Linux Release (Tests) Enter a number: 6 Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 71, in <module> main() File "./Tools/Scripts/webkit-patch", line 66, in main WebKitPatch(__file__).main() File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 105, in execute for test in self._tests_to_update(build): File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 92, in _tests_to_update failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch]) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 251, in layout_test_results self._layout_test_results = LayoutTestResults.results_from_string(self._fetch_results_html()) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 136, in results_from_string test_results = ResultsJSONParser.parse_results_json(string) File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 95, in parse_results_json if not json_results_generator.has_json_wrapper(json_string): File "/Volumes/Work/WebKitForRolls/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py", line 50, in has_json_wrapper return string.startswith(_JSON_PREFIX) and string.endswith(_JSON_SUFFIX) AttributeError: addinfourl instance has no attribute 'startswith' 390892 1 abarth 2011-04-22 10:54:15 -0700 I bet Eric broke it. 390893 2 eric 2011-04-22 10:54:36 -0700 We just need to wrap that in str() 390894 3 eric 2011-04-22 10:54:54 -0700 It wasn't tested! :p 390895 4 eric 2011-04-22 10:55:31 -0700 The testing failure is of course all mine, since this is my new code. Will fix now. 390906 5 90727 eric 2011-04-22 11:05:52 -0700 Created attachment 90727 Patch 390914 6 90727 dglazkov 2011-04-22 11:17:50 -0700 Comment on attachment 90727 Patch ok. 391020 7 commit-queue 2011-04-22 13:43:26 -0700 The commit-queue encountered the following flaky tests while processing attachment 90727: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 391024 8 90727 commit-queue 2011-04-22 13:44:57 -0700 Comment on attachment 90727 Patch Clearing flags on attachment: 90727 Committed r84676: <http://trac.webkit.org/changeset/84676> 391025 9 commit-queue 2011-04-22 13:45:02 -0700 All reviewed patches have been landed. Closing bug. 391204 10 webkit.review.bot 2011-04-22 16:18:31 -0700 http://trac.webkit.org/changeset/84676 might have broken GTK Linux 64-bit Debug 90727 2011-04-22 11:05:52 -0700 2011-04-22 13:44:57 -0700 Patch bug-59207-20110422110551.patch text/plain 2505 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODQ2MzkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3OTZkMDk5MmJhNWFjOTFiOGY3NDA4Y2EyN2ViMjc3N2Zm NGIzNmY2Li5lMTEyOWVkNjMwN2ZlZTcwZGNiYzM3N2RmOTk4ZDdiZmU0OWEwOTA2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDQtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCByZWJh c2VsaW5lIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTkyMDcKKworICAgICAgICBNeSByZWNlbnQgY2hhbmdlcyB0byBob3cgTGF5b3V0 VGVzdFJlc3VsdHMucmVzdWx0c19mcm9tX3N0cmluZworICAgICAgICB1bmNvdmVyZWQgYSBidWcg aW4gb3VyIHVzZSBvZiB1cmxsaWIyLgorICAgICAgICBXZSBub3cgYXJlIHRyZWF0aW5nIHRoZSBy ZXR1cm4gdmFsdWUgZnJvbSBfZmV0Y2hfcmVzdWx0c19odG1sKCkKKyAgICAgICAgKHdoaWNoIHJl dHVybnMgdXJsbGliMi5vcGVudXJsKCkpIGFzIGEgc3RyaW5nLiAgVGhhdCdzIGluY29ycmVjdCwK KyAgICAgICAgdGhlIHJldHVybiB2YWx1ZSBpcyBhIGZpbGUtbGlrZSBvYmplY3QgKHdoaWNoIGF1 dG8tY29udmVydHMgdG8gYQorICAgICAgICBzdHJpbmcgaW4gbW9zdCBjYXNlcykuCisKKyAgICAg ICAgSSd2ZSB1cGRhdGVkIG91ciB1cmxsaWIyLXVzaW5nIGNvZGUgdG8gY29ycmVjdGx5IGNhbGwg LnJlYWQoKSBvbiB0aGUKKyAgICAgICAgcmVzdWx0aW5nIG9iamVjdCBiZWZvcmUgdHJlYXRpbmcg aXQgbGlrZSBhIHN0cmluZy4KKyAgICAgICAgVW5mb3J0dW5hdGVseSB0aGVyZSBpcyBubyBlYXN5 IHdheSB0byB0ZXN0IHRoaXMgbWlzLXVuZGVyc3RhbmRpbmcKKyAgICAgICAgb2YgdGhlIG9wZW51 cmwoKSBzZW1hbnRpY3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv YnVpbGRib3QvYnVpbGRib3QucHk6CisKIDIwMTEtMDQtMjIgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNv bi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJv dC9idWlsZGJvdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJv dC9idWlsZGJvdC5weQppbmRleCA1ZmRmMTg0MTBjZmFjNzFmZGVlMDJkMTYwNTE5ZGI2Y2IyZDE3 Y2JhLi44OTI2Yzg5ZmJhYjY1MjVmYjM0Njg0ZWU2MzQ0ZDUwNDk2YjIzNWJiIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90 LnB5CkBAIC0yMzcsMTAgKzIzNywxNiBAQCBjbGFzcyBCdWlsZChvYmplY3QpOgogCiAgICAgZGVm IF9mZXRjaF9yZXN1bHRzX2h0bWwoc2VsZik6CiAgICAgICAgIHJlc3VsdHNfaHRtbCA9ICIlcy9y ZXN1bHRzLmh0bWwiICUgKHNlbGYucmVzdWx0c191cmwoKSkKLSAgICAgICAgIyBGSVhNRTogVGhp cyBzaG91bGQgdXNlIE5ldHdvcmtUcmFuc2FjdGlvbidzIDQwNCBoYW5kbGluZyBpbnN0ZWFkLgor ICAgICAgICAjIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgTmV0d29ya1RyYW5zYWN0aW9uJ3MgNDA0 IGhhbmRsaW5nIG9yIGF0IGxlYXN0IG1vdmUKKyAgICAgICAgIyB0byBtZWNoYW5pemUncyB0byBi ZSBtb3JlIGNvbnNpc3RlbnQgd2l0aCB0aGUgcmVzdCBvZiBvdXIgY29kZS4KICAgICAgICAgdHJ5 OgogICAgICAgICAgICAgIyBJdCBzZWVtcyB0aGlzIGNhbiByZXR1cm4gTm9uZSBpZiB0aGUgdXJs IHJlZGlyZWN0cyBhbmQgdGhlbiByZXR1cm5zIDQwNC4KLSAgICAgICAgICAgIHJldHVybiB1cmxs aWIyLnVybG9wZW4ocmVzdWx0c19odG1sKQorICAgICAgICAgICAgcmVzdWx0ID0gdXJsbGliMi51 cmxvcGVuKHJlc3VsdHNfaHRtbCkKKyAgICAgICAgICAgIGlmIG5vdCByZXN1bHQ6CisgICAgICAg ICAgICAgICAgcmV0dXJuIE5vbmUKKyAgICAgICAgICAgICMgdXJsb3BlbiByZXR1cm5zIGEgZmls ZS1saWtlIG9iamVjdCB3aGljaCBzb21ldGltZXMgd29ya3MgZmluZSB3aXRoIHN0cigpCisgICAg ICAgICAgICAjIGJ1dCBzb21ldGltZXMgaXMgYSBhZGRpbmZvdXJsIG9iamVjdC4gIEluIGVpdGhl ciBjYXNlIGNhbGxpbmcgcmVhZCgpIGlzIGNvcnJlY3QuCisgICAgICAgICAgICByZXR1cm4gcmVz dWx0LnJlYWQoKQogICAgICAgICBleGNlcHQgdXJsbGliMi5IVFRQRXJyb3IsIGVycm9yOgogICAg ICAgICAgICAgaWYgZXJyb3IuY29kZSAhPSA0MDQ6CiAgICAgICAgICAgICAgICAgcmFpc2UK