59176 2011-04-21 22:20:19 -0700 Don't do manually style resolution for SVGElements with renderer 2011-05-22 04:55:12 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned rwlbuis zimmermann oldest_to_newest 390612 0 krit 2011-04-21 22:20:19 -0700 https://bugs.webkit.org/show_bug.cgi?id=52513#c16 390614 1 90670 krit 2011-04-21 22:27:44 -0700 Created attachment 90670 Patch 390729 2 90670 zimmermann 2011-04-22 05:36:31 -0700 Comment on attachment 90670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90670&action=review Excellent cleanup, r=me. > Source/WebCore/ChangeLog:11 > + Don't do manually style resolution for SVGElements with renderer. Instead get RenderStyle > + from the renderer. Don't resolve style manually, instead ask the RenderObject for its style. > Source/WebCore/ChangeLog:13 > + Removed SVG element names from SVG attribute list. Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes. 406111 3 rwlbuis 2011-05-18 17:03:16 -0700 Reminder for Dirk, seems this is ready to land! Cheers, Rob. 406255 4 krit 2011-05-18 23:20:45 -0700 Oops! I'll land it later today. 407613 5 krit 2011-05-22 04:55:12 -0700 Committed r87028: <http://trac.webkit.org/changeset/87028> 90670 2011-04-21 22:27:44 -0700 2011-04-22 05:36:31 -0700 Patch bug-59176-20110422072743.patch text/plain 4898 krit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDQtMjEgIERpcmsgU2No dWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEb24ndCBkbyBtYW51YWxseSBzdHlsZSByZXNvbHV0aW9uIGZvciBT VkdFbGVtZW50cyB3aXRoIHJlbmRlcmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTE3NgorCisgICAgICAgIEdlbmVyYWwgY2xlYW4tdXAuCisKKyAg ICAgICAgRG9uJ3QgZG8gbWFudWFsbHkgc3R5bGUgcmVzb2x1dGlvbiBmb3IgU1ZHRWxlbWVudHMg d2l0aCByZW5kZXJlci4gSW5zdGVhZCBnZXQgUmVuZGVyU3R5bGUKKyAgICAgICAgZnJvbSB0aGUg cmVuZGVyZXIuCisKKyAgICAgICAgUmVtb3ZlZCBTVkcgZWxlbWVudCBuYW1lcyBmcm9tIFNWRyBh dHRyaWJ1dGUgbGlzdC4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLiBObyBjaGFuZ2Ug b2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBzdmcvU1ZHRkVEaWZmdXNlTGlnaHRpbmdFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0ZFRGlmZnVzZUxpZ2h0aW5nRWxlbWVudDo6YnVp bGQpOgorICAgICAgICAqIHN2Zy9TVkdGRURyb3BTaGFkb3dFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNWR0ZFRHJvcFNoYWRvd0VsZW1lbnQ6OmJ1aWxkKToKKyAgICAgICAgKiBzdmcv U1ZHRkVGbG9vZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHRkVGbG9vZEVsZW1l bnQ6OmJ1aWxkKToKKyAgICAgICAgKiBzdmcvU1ZHRkVTcGVjdWxhckxpZ2h0aW5nRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdGRVNwZWN1bGFyTGlnaHRpbmdFbGVtZW50OjpidWls ZCk6CisgICAgICAgICogc3ZnL3N2Z2F0dHJzLmluOgorCiAyMDExLTA0LTIxICBDaHJpcyBGbGVp emFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBE YWtpbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGRURpZmZ1c2VMaWdodGluZ0VsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGRURpZmZ1c2VMaWdo dGluZ0VsZW1lbnQuY3BwCShyZXZpc2lvbiA4NDU0MSkKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9T VkdGRURpZmZ1c2VMaWdodGluZ0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDUsOCAr MjA1LDEyIEBAIFBhc3NSZWZQdHI8RmlsdGVyRWZmZWN0PiBTVkdGRURpZmZ1c2VMaWcKICAgICBp ZiAoIWxpZ2h0U291cmNlKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIFJlZlB0cjxSZW5kZXJT dHlsZT4gZmlsdGVyU3R5bGUgPSBzdHlsZUZvclJlbmRlcmVyKCk7Ci0gICAgQ29sb3IgY29sb3Ig PSBmaWx0ZXJTdHlsZS0+c3ZnU3R5bGUoKS0+bGlnaHRpbmdDb2xvcigpOworICAgIFJlbmRlck9i amVjdCogcmVuZGVyZXIgPSB0aGlzLT5yZW5kZXJlcigpOworICAgIGlmICghcmVuZGVyZXIpCisg ICAgICAgIHJldHVybiAwOworICAgIAorICAgIEFTU0VSVChyZW5kZXJlci0+c3R5bGUoKSk7Cisg ICAgQ29sb3IgY29sb3IgPSByZW5kZXJlci0+c3R5bGUoKS0+c3ZnU3R5bGUoKS0+bGlnaHRpbmdD b2xvcigpOwogCiAgICAgUmVmUHRyPEZpbHRlckVmZmVjdD4gZWZmZWN0ID0gRkVEaWZmdXNlTGln aHRpbmc6OmNyZWF0ZShmaWx0ZXIsIGNvbG9yLCBzdXJmYWNlU2NhbGUoKSwgZGlmZnVzZUNvbnN0 YW50KCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAga2VybmVsVW5pdExlbmd0aFgoKSwga2VybmVsVW5pdExlbmd0aFkoKSwg bGlnaHRTb3VyY2UucmVsZWFzZSgpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGRURy b3BTaGFkb3dFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZH RkVEcm9wU2hhZG93RWxlbWVudC5jcHAJKHJldmlzaW9uIDg0NTQxKQorKysgU291cmNlL1dlYkNv cmUvc3ZnL1NWR0ZFRHJvcFNoYWRvd0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIs NyArMTMyLDYgQEAgUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+IFNWR0ZFRHJvcFNoYWRvdwogICAg ICAgICByZXR1cm4gMDsKICAgICAKICAgICBBU1NFUlQocmVuZGVyZXItPnN0eWxlKCkpOwotICAg IEFTU0VSVChyZW5kZXJlci0+c3R5bGUoKS0+c3ZnU3R5bGUoKSk7CiAgICAgY29uc3QgU1ZHUmVu ZGVyU3R5bGUqIHN2Z1N0eWxlID0gcmVuZGVyZXItPnN0eWxlKCktPnN2Z1N0eWxlKCk7CiAgICAg CiAgICAgQ29sb3IgY29sb3IgPSBzdmdTdHlsZS0+Zmxvb2RDb2xvcigpOwpJbmRleDogU291cmNl L1dlYkNvcmUvc3ZnL1NWR0ZFRmxvb2RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHRkVGbG9vZEVsZW1lbnQuY3BwCShyZXZpc2lvbiA4NDU0MSkKKysrIFNv dXJjZS9XZWJDb3JlL3N2Zy9TVkdGRUZsb29kRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTYwLDEwICs2MCwxNSBAQCBib29sIFNWR0ZFRmxvb2RFbGVtZW50OjpzZXRGaWx0ZXJFZmZlY3RB CiAKIFBhc3NSZWZQdHI8RmlsdGVyRWZmZWN0PiBTVkdGRUZsb29kRWxlbWVudDo6YnVpbGQoU1ZH RmlsdGVyQnVpbGRlciosIEZpbHRlciogZmlsdGVyKQogewotICAgIFJlZlB0cjxSZW5kZXJTdHls ZT4gZmlsdGVyU3R5bGUgPSBzdHlsZUZvclJlbmRlcmVyKCk7CisgICAgUmVuZGVyT2JqZWN0KiBy ZW5kZXJlciA9IHRoaXMtPnJlbmRlcmVyKCk7CisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAg cmV0dXJuIDA7CisgICAgCisgICAgQVNTRVJUKHJlbmRlcmVyLT5zdHlsZSgpKTsKKyAgICBjb25z dCBTVkdSZW5kZXJTdHlsZSogc3ZnU3R5bGUgPSByZW5kZXJlci0+c3R5bGUoKS0+c3ZnU3R5bGUo KTsKIAotICAgIENvbG9yIGNvbG9yID0gZmlsdGVyU3R5bGUtPnN2Z1N0eWxlKCktPmZsb29kQ29s b3IoKTsKLSAgICBmbG9hdCBvcGFjaXR5ID0gZmlsdGVyU3R5bGUtPnN2Z1N0eWxlKCktPmZsb29k T3BhY2l0eSgpOworICAgIENvbG9yIGNvbG9yID0gc3ZnU3R5bGUtPmZsb29kQ29sb3IoKTsKKyAg ICBmbG9hdCBvcGFjaXR5ID0gc3ZnU3R5bGUtPmZsb29kT3BhY2l0eSgpOwogCiAgICAgcmV0dXJu IEZFRmxvb2Q6OmNyZWF0ZShmaWx0ZXIsIGNvbG9yLCBvcGFjaXR5KTsKIH0KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdGRVNwZWN1bGFyTGlnaHRpbmdFbGVtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRkVTcGVjdWxhckxpZ2h0aW5nRWxlbWVudC5jcHAJ KHJldmlzaW9uIDg0NTQxKQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZFU3BlY3VsYXJMaWdo dGluZ0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsOSArMjE2LDEyIEBAIFBhc3NS ZWZQdHI8RmlsdGVyRWZmZWN0PiBTVkdGRVNwZWN1bGFyTGkKICAgICBpZiAoIWxpZ2h0U291cmNl KQogICAgICAgICByZXR1cm4gMDsKIAotICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gZmlsdGVyU3R5 bGUgPSBzdHlsZUZvclJlbmRlcmVyKCk7Ci0KLSAgICBDb2xvciBjb2xvciA9IGZpbHRlclN0eWxl LT5zdmdTdHlsZSgpLT5saWdodGluZ0NvbG9yKCk7CisgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJl ciA9IHRoaXMtPnJlbmRlcmVyKCk7CisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAgcmV0dXJu IDA7CisgICAgCisgICAgQVNTRVJUKHJlbmRlcmVyLT5zdHlsZSgpKTsKKyAgICBDb2xvciBjb2xv ciA9IHJlbmRlcmVyLT5zdHlsZSgpLT5zdmdTdHlsZSgpLT5saWdodGluZ0NvbG9yKCk7CiAKICAg ICBSZWZQdHI8RmlsdGVyRWZmZWN0PiBlZmZlY3QgPSBGRVNwZWN1bGFyTGlnaHRpbmc6OmNyZWF0 ZShmaWx0ZXIsIGNvbG9yLCBzdXJmYWNlU2NhbGUoKSwgc3BlY3VsYXJDb25zdGFudCgpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3BlY3VsYXJFeHBvbmVudCgp LCBrZXJuZWxVbml0TGVuZ3RoWCgpLCBrZXJuZWxVbml0TGVuZ3RoWSgpLCBsaWdodFNvdXJjZS5y ZWxlYXNlKCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL3N2Z2F0dHJzLmluCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9zdmdhdHRycy5pbgkocmV2aXNpb24gODQ1NDEpCisr KyBTb3VyY2UvV2ViQ29yZS9zdmcvc3ZnYXR0cnMuaW4JKHdvcmtpbmcgY29weSkKQEAgLTU0LDEx ICs1NCw2IEBAIGVuYWJsZS1iYWNrZ3JvdW5kCiBlbmQKIGV4cG9uZW50CiBleHRlcm5hbFJlc291 cmNlc1JlcXVpcmVkCi1mZUNvbG9yTWF0cml4Ci1mZUNvbXBvc2l0ZQotZmVHYXVzc2lhbkJsdXIK LWZlTW9ycGhvbG9neQotZmVUaWxlCiBmaWxsCiBmaWxsLW9wYWNpdHkKIGZpbGwtcnVsZQo=