59169 2011-04-21 20:18:21 -0700 Minimize synchronous calls during loading 2011-04-21 21:26:45 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 ap ap andersca sam oldest_to_newest 390569 0 ap 2011-04-21 20:18:21 -0700 r84526 added synchronous calls to web process to discard marked text when selection changes. The code was structured so that the same call was made when navigating to a new page, which is obviously unnecessary, as everything in Editor best reset anyway. Unfortunately, CoreIPC delivers sync and async calls out of order while serving a sync call in other direction, causing havoc, freezes and crashes as the UI process got confused about web process state. So, we should minimize sync calls, especially when we know that something else is happening in the web process. 390572 1 90659 ap 2011-04-21 20:22:30 -0700 Created attachment 90659 proposed patch 390599 2 ap 2011-04-21 21:26:45 -0700 Committed <http://trac.webkit.org/changeset/84598>. 90659 2011-04-21 20:22:30 -0700 2011-04-21 20:50:15 -0700 proposed patch OutOfOrder.txt text/plain 1734 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTkyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWluaW1pemUgc3luY2hyb25vdXMgY2FsbHMgZHVyaW5nIGxv YWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5 MTY5CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkzMjAxMjg+IFJFR1JFU1NJT04ocjg0NTI2 KTogV0syIHdpbmRvd3MgdW5yZXNwb25zaXZlCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyByZXNpZ25GaXJzdFJlc3BvbmRlcl0pOgor ICAgICAgICAoLVtXS1ZpZXcgX3Jlc2V0VGV4dElucHV0U3RhdGVdKToKKyAgICAgICAgTWFkZSBf cmVzZXRUZXh0SW5wdXRTdGF0ZSBkZWFsIHdpdGggY2xpZW50IHNpZGUgc3RhdGUgb25seSwgbGV0 dGluZyBFZGl0b3IgY29tcG9zaXRpb24gYmUKKyAgICAgICAgZGlzY2FyZGVkIG1vcmUgZGlzY3Jp bWluYXRlbHkuCisKIDIwMTEtMDQtMjEgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gODQ1MjYpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAg LTMxMCw2ICszMTAsOCBAQCAtIChCT09MKXJlc2lnbkZpcnN0UmVzcG9uZGVyCiB7CiAgICAgX2Rh dGEtPl9pblJlc2lnbkZpcnN0UmVzcG9uZGVyID0gdHJ1ZTsKIAorICAgIGlmIChfZGF0YS0+X3Bh Z2UtPmVkaXRvclN0YXRlKCkuaGFzQ29tcG9zaXRpb24gJiYgIV9kYXRhLT5fcGFnZS0+ZWRpdG9y U3RhdGUoKS5zaG91bGRJZ25vcmVDb21wb3NpdGlvblNlbGVjdGlvbkNoYW5nZSkKKyAgICAgICAg X2RhdGEtPl9wYWdlLT5jb25maXJtQ29tcG9zaXRpb25XaXRob3V0RGlzdHVyYmluZ1NlbGVjdGlv bigpOwogICAgIFtzZWxmIF9yZXNldFRleHRJbnB1dFN0YXRlXTsKICAgICAKICAgICBfZGF0YS0+ X3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc0ZvY3VzZWQpOwpA QCAtMjM0Nyw3ICsyMzQ5LDYgQEAgLSAodm9pZClfdXBkYXRlVGV4dElucHV0U3RhdGVJbmNsdWRp bmdTZQogCiAtICh2b2lkKV9yZXNldFRleHRJbnB1dFN0YXRlCiB7Ci0gICAgX2RhdGEtPl9wYWdl LT5jb25maXJtQ29tcG9zaXRpb25XaXRob3V0RGlzdHVyYmluZ1NlbGVjdGlvbigpOwogICAgIFtb c3VwZXIgaW5wdXRDb250ZXh0XSBkaXNjYXJkTWFya2VkVGV4dF07CiAKICAgICBpZiAoX2RhdGEt Pl9pblNlY3VyZUlucHV0U3RhdGUpIHsK