59164 2011-04-21 18:05:18 -0700 Object.create creates uncachable objects 2011-04-22 18:16:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59173 1 oliver oliver abarth eric ggaren webkit.review.bot oldest_to_newest 390508 0 oliver 2011-04-21 18:05:18 -0700 Object.create creates uncachable objects 390510 1 90645 oliver 2011-04-21 18:06:45 -0700 Created attachment 90645 Patch 390518 2 90645 ggaren 2011-04-21 18:24:59 -0700 Comment on attachment 90645 Patch r=me 390526 3 oliver 2011-04-21 18:32:54 -0700 Committed r84583: <http://trac.webkit.org/changeset/84583> 390544 4 webkit.review.bot 2011-04-21 19:16:26 -0700 http://trac.webkit.org/changeset/84583 might have broken Qt Linux Release The following tests are not passing: fast/js/Object-create.html 390547 5 ggaren 2011-04-21 19:16:55 -0700 Broke a test: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r84585%20(21737)/fast/js/Object-create-pretty-diff.html FAIL Object.getPrototypeOf(Object.create(null)) should be null. Was [object Object]. You changed to unconditionally use an empty object prototype, even if null is passed in. 390905 6 ggaren 2011-04-22 11:05:13 -0700 BTW, I think the right way to fix this is to give JSGlobalObject (or maybe JSGlobalData) a nullPrototypeStructure, just like the emptyObjectStructure. That way, Object.create will be correct for null prototypes, and still efficient. 391040 7 90757 oliver 2011-04-22 14:05:33 -0700 Created attachment 90757 Patch 391042 8 90757 ggaren 2011-04-22 14:08:08 -0700 Comment on attachment 90757 Patch r=me 391206 9 webkit.review.bot 2011-04-22 16:18:43 -0700 http://trac.webkit.org/changeset/84679 might have broken GTK Linux 64-bit Debug 391300 10 oliver 2011-04-22 18:16:40 -0700 Committed r84679: <http://trac.webkit.org/changeset/84679> 90645 2011-04-21 18:06:45 -0700 2011-04-22 14:05:28 -0700 Patch bug-59164-20110421180644.patch text/plain 1865 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODQ1NjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUw ZjA4MjM3NmRmNTYwNTkwNzYxNjM3MDIzODEzZDE4NDEwYTZiMzQuLmM5YWJhNzdkMTEwMmE4OWVi NWQzYjQ5MTczNWFhZjc3YTg5ZTliYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE4IEBACiAyMDExLTA0LTIxICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT2JqZWN0LmNy ZWF0ZSBjcmVhdGVzIHVuY2FjaGFibGUgb2JqZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkxNjQKKworICAgICAgICBVc2UgdGhlIHByb3RvdHlw ZSBvYmplY3QncyBpbmhlcml0b3JJRCwgYXMgd2UKKyAgICAgICAgc2hvdWxkIGFsd2F5cyBoYXZl IGRvbmUKKworICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwOgorICAgICAg ICAoSlNDOjpvYmplY3RDb25zdHJ1Y3RvckNyZWF0ZSk6CisKKzIwMTEtMDQtMjEgIE9saXZlciBI dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBH YXJlbi4KIAogICAgICAgICBTdGFydCBtb3ZpbmcgdG8gYSBnZW5lcmFsIHZpc2l0b3IgcGF0dGVy biBmb3IgR0MgdHJhdmVyc2FsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAKaW5kZXggYWVkNWUyNDZhNDNkZmU1NmUwYmQzNTNlN2Ni NjdjOTlhMTI2Yjk0Yy4uMDNkNjJkY2NmNTk4NWJjZWM3NzFkZGNiMzAzN2VlYThmZTIzNDI1YyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0 b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVj dG9yLmNwcApAQCAtMzQxLDggKzM0MSw4IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg b2JqZWN0Q29uc3RydWN0b3JDcmVhdGUoRXhlY1N0YXRlKiBleGVjKQogewogICAgIGlmICghZXhl Yy0+YXJndW1lbnQoMCkuaXNPYmplY3QoKSAmJiAhZXhlYy0+YXJndW1lbnQoMCkuaXNOdWxsKCkp CiAgICAgICAgIHJldHVybiB0aHJvd1ZNRXJyb3IoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMs ICJPYmplY3QgcHJvdG90eXBlIG1heSBvbmx5IGJlIGFuIE9iamVjdCBvciBudWxsLiIpKTsKLSAg ICBKU09iamVjdCogbmV3T2JqZWN0ID0gY29uc3RydWN0RW1wdHlPYmplY3QoZXhlYyk7Ci0gICAg bmV3T2JqZWN0LT5zZXRQcm90b3R5cGUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBleGVjLT5hcmd1bWVu dCgwKSk7CisgICAgSlNWYWx1ZSBwcm90byA9IGV4ZWMtPmFyZ3VtZW50KDApOworICAgIEpTT2Jq ZWN0KiBuZXdPYmplY3QgPSBwcm90by5pc09iamVjdCgpID8gY29uc3RydWN0RW1wdHlPYmplY3Qo ZXhlYywgYXNPYmplY3QocHJvdG8pLT5pbmhlcml0b3JJRChleGVjLT5nbG9iYWxEYXRhKCkpKSA6 IGNvbnN0cnVjdEVtcHR5T2JqZWN0KGV4ZWMpOwogICAgIGlmIChleGVjLT5hcmd1bWVudCgxKS5p c1VuZGVmaW5lZCgpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKG5ld09iamVjdCk7 CiAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgxKS5pc09iamVjdCgpKQo= 90757 2011-04-22 14:05:33 -0700 2011-04-22 14:08:08 -0700 Patch bug-59164-20110422140531.patch text/plain 4973 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODQ1ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk2 YjY1MWM5NDk0ODdhMzkxNTZmNDIzMDVkOTE5YzAyNjk1ZDcwMjMuLjgzOGNkZWQwN2Y1N2IyODhi YjQwYzhmMmU1Y2NhNjlmZTVjNzVmNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIxIEBACisyMDExLTA0LTIyICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT2JqZWN0LmNy ZWF0ZSBjcmVhdGVzIHVuY2FjaGFibGUgb2JqZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkxNjQKKworICAgICAgICBVc2UgdGhlIHByb3RvdHlw ZSBvYmplY3QncyBpbmhlcml0b3JJRCwgYXMgd2UKKyAgICAgICAgc2hvdWxkIGFsd2F5cyBoYXZl IGRvbmUKKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwOgorICAgICAgICAo SlNDOjpKU0dsb2JhbE9iamVjdDo6cmVzZXQpOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVj dDo6dmlzaXRDaGlsZHJlbik6CisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdC5oOgor ICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6bnVsbFByb3RvdHlwZU9iamVjdFN0cnVjdHVy ZSk6CisgICAgICAgICogcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAgIChK U0M6Om9iamVjdENvbnN0cnVjdG9yQ3JlYXRlKToKKwogMjAxMS0wNC0yMiAgU2hlcmlmZiBCb3Qg IDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjg0NjUwIGFuZCByODQ2NTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAKaW5kZXggMmU4NGVkMTkzOTg0MzY0YzM0NWNlYzMy MzJmMjRhMzY2MzU4ODdiYS4uMTM5ZTFmZjhkMTc1OTZhZjBmNGE2NWUxNDU2ODBjMWYzYjU4N2Q4 YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmpl Y3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0 LmNwcApAQCAtMTgxLDYgKzE4MSw3IEBAIHZvaWQgSlNHbG9iYWxPYmplY3Q6OnJlc2V0KEpTVmFs dWUgcHJvdG90eXBlKQogICAgIG1fZnVuY3Rpb25Qcm90b3R5cGUtPnN0cnVjdHVyZSgpLT5zZXRQ cm90b3R5cGVXaXRob3V0VHJhbnNpdGlvbihleGVjLT5nbG9iYWxEYXRhKCksIG1fb2JqZWN0UHJv dG90eXBlLmdldCgpKTsKIAogICAgIG1fZW1wdHlPYmplY3RTdHJ1Y3R1cmUuc2V0KGV4ZWMtPmds b2JhbERhdGEoKSwgdGhpcywgbV9vYmplY3RQcm90b3R5cGUtPmluaGVyaXRvcklEKGV4ZWMtPmds b2JhbERhdGEoKSkpOworICAgIG1fbnVsbFByb3RvdHlwZU9iamVjdFN0cnVjdHVyZS5zZXQoZXhl Yy0+Z2xvYmFsRGF0YSgpLCB0aGlzLCBjcmVhdGVFbXB0eU9iamVjdFN0cnVjdHVyZShleGVjLT5n bG9iYWxEYXRhKCksIGpzTnVsbCgpKSk7CiAKICAgICBtX2NhbGxiYWNrRnVuY3Rpb25TdHJ1Y3R1 cmUuc2V0KGV4ZWMtPmdsb2JhbERhdGEoKSwgdGhpcywgSlNDYWxsYmFja0Z1bmN0aW9uOjpjcmVh dGVTdHJ1Y3R1cmUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBtX2Z1bmN0aW9uUHJvdG90eXBlLmdldCgp KSk7CiAgICAgbV9hcmd1bWVudHNTdHJ1Y3R1cmUuc2V0KGV4ZWMtPmdsb2JhbERhdGEoKSwgdGhp cywgQXJndW1lbnRzOjpjcmVhdGVTdHJ1Y3R1cmUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBtX29iamVj dFByb3RvdHlwZS5nZXQoKSkpOwpAQCAtMzQ0LDYgKzM0NSw3IEBAIHZvaWQgSlNHbG9iYWxPYmpl Y3Q6OnZpc2l0Q2hpbGRyZW4oU2xvdFZpc2l0b3ImIHZpc2l0b3IpCiAgICAgdmlzaXRJZk5lZWRl ZCh2aXNpdG9yLCAmbV9jYWxsYmFja09iamVjdFN0cnVjdHVyZSk7CiAgICAgdmlzaXRJZk5lZWRl ZCh2aXNpdG9yLCAmbV9kYXRlU3RydWN0dXJlKTsKICAgICB2aXNpdElmTmVlZGVkKHZpc2l0b3Is ICZtX2VtcHR5T2JqZWN0U3RydWN0dXJlKTsKKyAgICB2aXNpdElmTmVlZGVkKHZpc2l0b3IsICZt X251bGxQcm90b3R5cGVPYmplY3RTdHJ1Y3R1cmUpOwogICAgIHZpc2l0SWZOZWVkZWQodmlzaXRv ciwgJm1fZXJyb3JTdHJ1Y3R1cmUpOwogICAgIHZpc2l0SWZOZWVkZWQodmlzaXRvciwgJm1fZnVu Y3Rpb25TdHJ1Y3R1cmUpOwogICAgIHZpc2l0SWZOZWVkZWQodmlzaXRvciwgJm1fbnVtYmVyT2Jq ZWN0U3RydWN0dXJlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTR2xvYmFsT2JqZWN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2Jh bE9iamVjdC5oCmluZGV4IGQyYWQwYWQ0NDRiYTM5MmNkOWJkNDBiNGY3NWEyMWZjNzAzNmI4ODYu LmZhNGU1MGU5ZmFlNzhhNGZjMjNkY2M2YTJhM2ZhZGE3OTAyM2U2MGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuaApAQCAtOTUsNiArOTUsNyBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgV3JpdGVCYXJyaWVyPFN0cnVjdHVyZT4gbV9jYWxs YmFja09iamVjdFN0cnVjdHVyZTsKICAgICAgICAgV3JpdGVCYXJyaWVyPFN0cnVjdHVyZT4gbV9k YXRlU3RydWN0dXJlOwogICAgICAgICBXcml0ZUJhcnJpZXI8U3RydWN0dXJlPiBtX2VtcHR5T2Jq ZWN0U3RydWN0dXJlOworICAgICAgICBXcml0ZUJhcnJpZXI8U3RydWN0dXJlPiBtX251bGxQcm90 b3R5cGVPYmplY3RTdHJ1Y3R1cmU7CiAgICAgICAgIFdyaXRlQmFycmllcjxTdHJ1Y3R1cmU+IG1f ZXJyb3JTdHJ1Y3R1cmU7CiAgICAgICAgIFdyaXRlQmFycmllcjxTdHJ1Y3R1cmU+IG1fZnVuY3Rp b25TdHJ1Y3R1cmU7CiAgICAgICAgIFdyaXRlQmFycmllcjxTdHJ1Y3R1cmU+IG1fbnVtYmVyT2Jq ZWN0U3RydWN0dXJlOwpAQCAtMjAyLDYgKzIwMyw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAg ICBTdHJ1Y3R1cmUqIGNhbGxiYWNrT2JqZWN0U3RydWN0dXJlKCkgY29uc3QgeyByZXR1cm4gbV9j YWxsYmFja09iamVjdFN0cnVjdHVyZS5nZXQoKTsgfQogICAgICAgICBTdHJ1Y3R1cmUqIGRhdGVT dHJ1Y3R1cmUoKSBjb25zdCB7IHJldHVybiBtX2RhdGVTdHJ1Y3R1cmUuZ2V0KCk7IH0KICAgICAg ICAgU3RydWN0dXJlKiBlbXB0eU9iamVjdFN0cnVjdHVyZSgpIGNvbnN0IHsgcmV0dXJuIG1fZW1w dHlPYmplY3RTdHJ1Y3R1cmUuZ2V0KCk7IH0KKyAgICAgICAgU3RydWN0dXJlKiBudWxsUHJvdG90 eXBlT2JqZWN0U3RydWN0dXJlKCkgY29uc3QgeyByZXR1cm4gbV9udWxsUHJvdG90eXBlT2JqZWN0 U3RydWN0dXJlLmdldCgpOyB9CiAgICAgICAgIFN0cnVjdHVyZSogZXJyb3JTdHJ1Y3R1cmUoKSBj b25zdCB7IHJldHVybiBtX2Vycm9yU3RydWN0dXJlLmdldCgpOyB9CiAgICAgICAgIFN0cnVjdHVy ZSogZnVuY3Rpb25TdHJ1Y3R1cmUoKSBjb25zdCB7IHJldHVybiBtX2Z1bmN0aW9uU3RydWN0dXJl LmdldCgpOyB9CiAgICAgICAgIFN0cnVjdHVyZSogbnVtYmVyT2JqZWN0U3RydWN0dXJlKCkgY29u c3QgeyByZXR1cm4gbV9udW1iZXJPYmplY3RTdHJ1Y3R1cmUuZ2V0KCk7IH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcAppbmRleCBh ZWQ1ZTI0NmE0M2RmZTU2ZTBiZDM1M2U3Y2I2N2M5OWExMjZiOTRjLi5jMzI1ZmEwNzBiMWY3YmI5 NDYwYzIxOGIyMGI2MmU3OGJiZDRiOGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCkBAIC0zNDEsOCArMzQxLDggQEAgRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBvYmplY3RDb25zdHJ1Y3RvckNyZWF0ZShFeGVjU3Rh dGUqIGV4ZWMpCiB7CiAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgwKS5pc09iamVjdCgpICYmICFl eGVjLT5hcmd1bWVudCgwKS5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihl eGVjLCBjcmVhdGVUeXBlRXJyb3IoZXhlYywgIk9iamVjdCBwcm90b3R5cGUgbWF5IG9ubHkgYmUg YW4gT2JqZWN0IG9yIG51bGwuIikpOwotICAgIEpTT2JqZWN0KiBuZXdPYmplY3QgPSBjb25zdHJ1 Y3RFbXB0eU9iamVjdChleGVjKTsKLSAgICBuZXdPYmplY3QtPnNldFByb3RvdHlwZShleGVjLT5n bG9iYWxEYXRhKCksIGV4ZWMtPmFyZ3VtZW50KDApKTsKKyAgICBKU1ZhbHVlIHByb3RvID0gZXhl Yy0+YXJndW1lbnQoMCk7CisgICAgSlNPYmplY3QqIG5ld09iamVjdCA9IHByb3RvLmlzT2JqZWN0 KCkgPyBjb25zdHJ1Y3RFbXB0eU9iamVjdChleGVjLCBhc09iamVjdChwcm90byktPmluaGVyaXRv cklEKGV4ZWMtPmdsb2JhbERhdGEoKSkpIDogY29uc3RydWN0RW1wdHlPYmplY3QoZXhlYywgZXhl Yy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5udWxsUHJvdG90eXBlT2JqZWN0U3RydWN0dXJlKCkp OwogICAgIGlmIChleGVjLT5hcmd1bWVudCgxKS5pc1VuZGVmaW5lZCgpKQogICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKG5ld09iamVjdCk7CiAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgx KS5pc09iamVjdCgpKQo=