59155 2011-04-21 16:56:58 -0700 [Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared. 2011-04-21 19:49:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jiapu.mail jiapu.mail commit-queue oldest_to_newest 390464 0 jiapu.mail 2011-04-21 16:56:58 -0700 In some situation, m_correctionPanelInfo.rangeToBeReplaced has been cleared when entering SpellingCorrectionController::correctionPanelTimerFired(), in which case, calling windowRectForRange() on the range will crash. <rdar://problem/9261698> 390467 1 90636 jiapu.mail 2011-04-21 17:01:56 -0700 Created attachment 90636 Patch (v1) 390478 2 90636 mjs 2011-04-21 17:15:27 -0700 Comment on attachment 90636 Patch (v1) r=me Is it possible to make a regression test for this? 390481 3 jiapu.mail 2011-04-21 17:21:39 -0700 (In reply to comment #2) > (From update of attachment 90636 [details]) > r=me > > Is it possible to make a regression test for this? I will add one if I can nail down the exact sequence of actions that leads to the crash. 390557 4 90636 commit-queue 2011-04-21 19:49:37 -0700 Comment on attachment 90636 Patch (v1) Clearing flags on attachment: 90636 Committed r84592: <http://trac.webkit.org/changeset/84592> 390558 5 commit-queue 2011-04-21 19:49:41 -0700 All reviewed patches have been landed. Closing bug. 90636 2011-04-21 17:01:56 -0700 2011-04-21 19:49:37 -0700 Patch (v1) bug-59155-20110421170154.patch text/plain 4833 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogODQ1NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3OWVhMTJjNjhmYjMzNmQ4 OWQ4OGM1NTg3NWZiYTkyNmMzOTJmM2EyLi5iZjY2YTBlOTg0Mzg5Nzk3YTcyNGMzZWNhM2M2Njc3 YzU1MjJlYzJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMjEgIEppYSBQ dSAgPGpwdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW01hY10gY29ycmVjdGlvblBhbmVsVGltZXJGaXJlZCgpIGNyYXNoZXMgZHVl IHRvIHJhbmdlVG9CZVJlcGxhY2VkIGJlaW5nIGNsZWFyZWQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTE1NQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vOTI2MTY5OD4KKworICAgICAgICBNYWtlIHN1cmUgdGhlIHJhbmdlIGlzbid0IGNsZWFyZWQg YmVmb3JlIGNhbGxpbmcgd2luZG93UmVjdEZvclJhbmdlKCkgb24gaXQuIEFsc28gcmVtb3ZlZCB1 bnVzZWQgZnVuY3Rpb25zIGluIEVkaXRvci5oLAorICAgICAgICBhbmQgZml4ZWQgYSB0eXBvIGlu IGZ1bmN0aW9uIG5hbWUuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5oOgorICAgICAgICAq IGVkaXRpbmcvU3BlbGxpbmdDb3JyZWN0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTcGVsbGluZ0NvcnJlY3Rpb25Db250cm9sbGVyOjpjb3JyZWN0aW9uUGFuZWxUaW1lckZp cmVkKToKKyAgICAgICAgKFdlYkNvcmU6OlNwZWxsaW5nQ29ycmVjdGlvbkNvbnRyb2xsZXI6OnJl c3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24pOgorICAgICAgICAqIGVkaXRpbmcvU3BlbGxpbmdDb3Jy ZWN0aW9uQ29udHJvbGxlci5oOgorICAgICAgICAoV2ViQ29yZTo6U3BlbGxpbmdDb3JyZWN0aW9u Q29udHJvbGxlcjo6c2hvdWxkU3RhcnRUaW1lckZvcik6CisKIDIwMTEtMDQtMjEgIE5hdCBEdWNh ICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmlu c29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKaW5kZXggOTA5OTg1NDM1OWNkNGYxNjMwYzNjYjI4 Nzg0ZTM3OGVhYjY3NTdhMS4uZWNjMzc3OTIzMzVkYmJlMjIxOTMzYTU1Mjg5ODdkMTJjMmU2YzMx ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCkBAIC00MjgsMTEgKzQyOCw2IEBAIHByaXZhdGU6 CiAgICAgdm9pZCBjaGFuZ2VTZWxlY3Rpb25BZnRlckNvbW1hbmQoY29uc3QgVmlzaWJsZVNlbGVj dGlvbiYgbmV3U2VsZWN0aW9uLCBib29sIGNsb3NlVHlwaW5nLCBib29sIGNsZWFyVHlwaW5nU3R5 bGUpOwogCiAgICAgTm9kZSogZmluZEV2ZW50VGFyZ2V0RnJvbVNlbGVjdGlvbigpIGNvbnN0Owot ICAgIHZvaWQgc3RvcENvcnJlY3Rpb25QYW5lbFRpbWVyKCk7Ci0KLSAgICB2b2lkIGFwcGx5Q29y cmVjdGlvblBhbmVsSW5mbyhjb25zdCBWZWN0b3I8RG9jdW1lbnRNYXJrZXI6Ok1hcmtlclR5cGU+ JiBtYXJrZXJUeXBlc1RvQWRkKTsKLSAgICAvLyBSZXR1cm4gdHJ1ZSBpZiBjb3JyZWN0aW9uIHdh cyBhcHBsaWVkLCBmYWxzZSBvdGhlcndpc2UuCi0gICAgYm9vbCBhcHBseUF1dG9jb3JyZWN0aW9u QmVmb3JlVHlwaW5nSWZBcHByb3ByaWF0ZSgpOwogfTsKIAogaW5saW5lIHZvaWQgRWRpdG9yOjpz ZXRTdGFydE5ld0tpbGxSaW5nU2VxdWVuY2UoYm9vbCBmbGFnKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZWRpdGluZy9TcGVsbGluZ0NvcnJlY3Rpb25Db250cm9sbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvU3BlbGxpbmdDb3JyZWN0aW9uQ29udHJvbGxlci5jcHAKaW5kZXgg YmNhNmY1YTg1YmI0Y2RlYTk4MmRlNTJhNTg3NjdjMmExZTE4YTMyZS4uNTU4MGJmZTYyZDgwYjY2 MTI1MjIyN2IzYTViNzFlYzBhNTI0NWFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9TcGVsbGluZ0NvcnJlY3Rpb25Db250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL1NwZWxsaW5nQ29ycmVjdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC0yOTIsNiArMjky LDggQEAgdm9pZCBTcGVsbGluZ0NvcnJlY3Rpb25Db250cm9sbGVyOjpjb3JyZWN0aW9uUGFuZWxU aW1lckZpcmVkKFRpbWVyPFNwZWxsaW5nQ29ycmUKICAgICB9CiAgICAgICAgIGJyZWFrOwogICAg IGNhc2UgQ29ycmVjdGlvblBhbmVsSW5mbzo6UGFuZWxUeXBlUmV2ZXJzaW9uOiB7CisgICAgICAg IGlmICghbV9jb3JyZWN0aW9uUGFuZWxJbmZvLnJhbmdlVG9CZVJlcGxhY2VkKQorICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIG1fY29ycmVjdGlvblBhbmVsSW5mby5pc0FjdGl2ZSA9IHRydWU7 CiAgICAgICAgIG1fY29ycmVjdGlvblBhbmVsSW5mby5yZXBsYWNlZFN0cmluZyA9IHBsYWluVGV4 dChtX2NvcnJlY3Rpb25QYW5lbEluZm8ucmFuZ2VUb0JlUmVwbGFjZWQuZ2V0KCkpOwogICAgICAg ICBGbG9hdFJlY3QgYm91bmRpbmdCb3ggPSB3aW5kb3dSZWN0Rm9yUmFuZ2UobV9jb3JyZWN0aW9u UGFuZWxJbmZvLnJhbmdlVG9CZVJlcGxhY2VkLmdldCgpKTsKQEAgLTMwMCw3ICszMDIsNyBAQCB2 b2lkIFNwZWxsaW5nQ29ycmVjdGlvbkNvbnRyb2xsZXI6OmNvcnJlY3Rpb25QYW5lbFRpbWVyRmly ZWQoVGltZXI8U3BlbGxpbmdDb3JyZQogICAgIH0KICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBD b3JyZWN0aW9uUGFuZWxJbmZvOjpQYW5lbFR5cGVTcGVsbGluZ1N1Z2dlc3Rpb25zOiB7Ci0gICAg ICAgIGlmIChwbGFpblRleHQobV9jb3JyZWN0aW9uUGFuZWxJbmZvLnJhbmdlVG9CZVJlcGxhY2Vk LmdldCgpKSAhPSBtX2NvcnJlY3Rpb25QYW5lbEluZm8ucmVwbGFjZWRTdHJpbmcpCisgICAgICAg IGlmICghbV9jb3JyZWN0aW9uUGFuZWxJbmZvLnJhbmdlVG9CZVJlcGxhY2VkIHx8IHBsYWluVGV4 dChtX2NvcnJlY3Rpb25QYW5lbEluZm8ucmFuZ2VUb0JlUmVwbGFjZWQuZ2V0KCkpICE9IG1fY29y cmVjdGlvblBhbmVsSW5mby5yZXBsYWNlZFN0cmluZykKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICBTdHJpbmcgcGFyYWdyYXBoVGV4dCA9IHBsYWluVGV4dChUZXh0Q2hlY2tpbmdQYXJhZ3Jh cGgobV9jb3JyZWN0aW9uUGFuZWxJbmZvLnJhbmdlVG9CZVJlcGxhY2VkKS5wYXJhZ3JhcGhSYW5n ZSgpLmdldCgpKTsKICAgICAgICAgVmVjdG9yPFN0cmluZz4gc3VnZ2VzdGlvbnM7CkBAIC0zOTcs NyArMzk5LDcgQEAgdm9pZCBTcGVsbGluZ0NvcnJlY3Rpb25Db250cm9sbGVyOjpyZXNwb25kVG9D aGFuZ2VkU2VsZWN0aW9uKGNvbnN0IFZpc2libGVTZWxlY3QKICAgICBzaXplX3QgbWFya2VyQ291 bnQgPSBtYXJrZXJzLnNpemUoKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1hcmtlckNv dW50OyArK2kpIHsKICAgICAgICAgY29uc3QgRG9jdW1lbnRNYXJrZXImIG1hcmtlciA9IG1hcmtl cnNbaV07Ci0gICAgICAgIGlmICghc2hvdWxkU3RhcnRUaW1lRm9yKG1hcmtlciwgZW5kT2Zmc2V0 KSkKKyAgICAgICAgaWYgKCFzaG91bGRTdGFydFRpbWVyRm9yKG1hcmtlciwgZW5kT2Zmc2V0KSkK ICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBSZWZQdHI8UmFuZ2U+IHdvcmRSYW5nZSA9 IFJhbmdlOjpjcmVhdGUobV9mcmFtZS0+ZG9jdW1lbnQoKSwgbm9kZSwgbWFya2VyLnN0YXJ0T2Zm c2V0LCBub2RlLCBtYXJrZXIuZW5kT2Zmc2V0KTsKICAgICAgICAgU3RyaW5nIGN1cnJlbnRXb3Jk ID0gcGxhaW5UZXh0KHdvcmRSYW5nZS5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL1NwZWxsaW5nQ29ycmVjdGlvbkNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvU3BlbGxpbmdDb3JyZWN0aW9uQ29udHJvbGxlci5oCmluZGV4IDBiM2U4YjdiZDkx NDE4YTdhYzgxZmYwNWQ1MTM4Zjc1ZWE1OWY2NzMuLmJmM2M0MTQyZjA4MDA5ODJkNGM0MDMzMTRh NWQxZDIzNzE2MDNjZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU3BlbGxp bmdDb3JyZWN0aW9uQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvU3Bl bGxpbmdDb3JyZWN0aW9uQ29udHJvbGxlci5oCkBAIC0xMjEsNyArMTIxLDcgQEAgcHVibGljOgog cHJpdmF0ZToKICAgICB2b2lkIHJlY29yZEF1dG9jb3JyZWN0aW9uUmVzcG9uc2VSZXZlcnNlZChj b25zdCBTdHJpbmcmIHJlcGxhY2VkU3RyaW5nLCBjb25zdCBTdHJpbmcmIHJlcGxhY2VtZW50U3Ry aW5nKTsKIAotICAgIGJvb2wgc2hvdWxkU3RhcnRUaW1lRm9yKGNvbnN0IERvY3VtZW50TWFya2Vy JiBtYXJrZXIsIGludCBlbmRPZmZzZXQpIGNvbnN0CisgICAgYm9vbCBzaG91bGRTdGFydFRpbWVy Rm9yKGNvbnN0IERvY3VtZW50TWFya2VyJiBtYXJrZXIsIGludCBlbmRPZmZzZXQpIGNvbnN0CiAg ICAgewogICAgICAgICByZXR1cm4gKCgobWFya2VyLnR5cGUgPT0gRG9jdW1lbnRNYXJrZXI6OlJl cGxhY2VtZW50ICYmICFtYXJrZXIuZGVzY3JpcHRpb24uaXNOdWxsKCkpIAogICAgICAgICAgICAg ICAgICB8fCBtYXJrZXIudHlwZSA9PSBEb2N1bWVudE1hcmtlcjo6U3BlbGxpbmcpICYmIHN0YXRp Y19jYXN0PGludD4obWFya2VyLmVuZE9mZnNldCkgPT0gZW5kT2Zmc2V0KTsK