59151 2011-04-21 16:07:27 -0700 Provide default constructors for HashMap iterators 2011-04-22 15:01:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth mjs sam oldest_to_newest 390422 0 vitalyr 2011-04-21 16:07:27 -0700 [WTF] Provide default constructors for HashMap iterators 390430 1 90625 vitalyr 2011-04-21 16:14:44 -0700 Created attachment 90625 patch 390444 2 90625 abarth 2011-04-21 16:30:05 -0700 Comment on attachment 90625 patch View in context: https://bugs.webkit.org/attachment.cgi?id=90625&action=review > Source/JavaScriptCore/wtf/HashTable.h:1123 > + HashTableConstIteratorAdapter() {} Do we need to initialize m_impl to anything (like null) or does it do that itself? 390445 3 abarth 2011-04-21 16:30:18 -0700 +mjs for WTF foo. 390447 4 vitalyr 2011-04-21 16:32:12 -0700 (In reply to comment #2) > (From update of attachment 90625 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90625&action=review > > > Source/JavaScriptCore/wtf/HashTable.h:1123 > > + HashTableConstIteratorAdapter() {} > > Do we need to initialize m_impl to anything (like null) or does it do that itself? Unlike the adapter it has a default constructor. So I don't think it should be initialized. 390561 5 sam 2011-04-21 19:56:48 -0700 Why are these needed? What will they be used for? 390568 6 vitalyr 2011-04-21 20:16:46 -0700 (In reply to comment #5) > Why are these needed? What will they be used for? Right now you can't declare a variable or class field of type HashMap::iterator without immediately initializing it. This is inconsistent with wtf::Vector and STL iterators. My specific intended usage for them is to implement a lightweight iterator over EventTarget's listeners. EventTarget has a map of vectors. So the listener iterator simply combines a map iterator and an index. The problem is that the listener map is optional and the map iterator can't be initialized when it's NULL without using some dummy map. 390609 7 abarth 2011-04-21 22:11:37 -0700 I asked Vitaly to post this as a separate patch because the folks who would review this patch might not be the same folks who would be interested in reviewing the rest of his change. 390804 8 90625 abarth 2011-04-22 09:02:41 -0700 Comment on attachment 90625 patch View in context: https://bugs.webkit.org/attachment.cgi?id=90625&action=review > Source/JavaScriptCore/ChangeLog:7 > + I would add some more explanation here about why you're making this change (i.e., that you plan to use it in another patch shortly). 391117 9 vitalyr 2011-04-22 15:01:40 -0700 M Source/JavaScriptCore/ChangeLog M Source/JavaScriptCore/wtf/HashTable.h Committed r84687 90625 2011-04-21 16:14:44 -0700 2011-04-22 09:02:41 -0700 patch wtf_iter.patch text/plain 1644 vitalyr ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRmYWY2MDcuLjY5MjZiOTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTIxICBWaXRhbHkgUmVwZXNo a28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV1RGXSBQcm92aWRlIGRlZmF1bHQgY29uc3RydWN0b3JzIGZv ciBIYXNoTWFwIGl0ZXJhdG9ycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU5MTUxCisKKyAgICAgICAgKiB3dGYvSGFzaFRhYmxlLmg6CisgICAgICAg IChXVEY6Okhhc2hUYWJsZUNvbnN0SXRlcmF0b3JBZGFwdGVyOjpIYXNoVGFibGVDb25zdEl0ZXJh dG9yQWRhcHRlcik6CisgICAgICAgIChXVEY6Okhhc2hUYWJsZUl0ZXJhdG9yQWRhcHRlcjo6SGFz aFRhYmxlSXRlcmF0b3JBZGFwdGVyKToKKwogMjAxMS0wNC0xNSAgR2F2aW4gQmFycmFjbG91Z2gg IDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2Fy ZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9IYXNoVGFibGUuaAppbmRleCBjMmJjNDliLi41YWNh MjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvSGFzaFRhYmxlLmgKQEAgLTExMjAsNiArMTEy MCw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIC8vIGl0ZXJhdG9yIGFkYXB0ZXJzCiAKICAgICB0 ZW1wbGF0ZTx0eXBlbmFtZSBIYXNoVGFibGVUeXBlLCB0eXBlbmFtZSBWYWx1ZVR5cGU+IHN0cnVj dCBIYXNoVGFibGVDb25zdEl0ZXJhdG9yQWRhcHRlciB7CisgICAgICAgIEhhc2hUYWJsZUNvbnN0 SXRlcmF0b3JBZGFwdGVyKCkge30KICAgICAgICAgSGFzaFRhYmxlQ29uc3RJdGVyYXRvckFkYXB0 ZXIoY29uc3QgdHlwZW5hbWUgSGFzaFRhYmxlVHlwZTo6Y29uc3RfaXRlcmF0b3ImIGltcGwpIDog bV9pbXBsKGltcGwpIHt9CiAKICAgICAgICAgY29uc3QgVmFsdWVUeXBlKiBnZXQoKSBjb25zdCB7 IHJldHVybiAoY29uc3QgVmFsdWVUeXBlKiltX2ltcGwuZ2V0KCk7IH0KQEAgLTExMzMsNiArMTEz NCw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIH07CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBI YXNoVGFibGVUeXBlLCB0eXBlbmFtZSBWYWx1ZVR5cGU+IHN0cnVjdCBIYXNoVGFibGVJdGVyYXRv ckFkYXB0ZXIgeworICAgICAgICBIYXNoVGFibGVJdGVyYXRvckFkYXB0ZXIoKSB7fQogICAgICAg ICBIYXNoVGFibGVJdGVyYXRvckFkYXB0ZXIoY29uc3QgdHlwZW5hbWUgSGFzaFRhYmxlVHlwZTo6 aXRlcmF0b3ImIGltcGwpIDogbV9pbXBsKGltcGwpIHt9CiAKICAgICAgICAgVmFsdWVUeXBlKiBn ZXQoKSBjb25zdCB7IHJldHVybiAoVmFsdWVUeXBlKiltX2ltcGwuZ2V0KCk7IH0K