59140 2011-04-21 14:24:54 -0700 WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables 2011-04-21 22:02:01 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin webkit.review.bot oldest_to_newest 390335 0 cfleizach 2011-04-21 14:24:54 -0700 WebKit is calling setAttribute('aria-selected', 'true') on each row. Notice the second table turns completely purple as the VO cursor goes through each row. Even if WebKit were cleaning up after itself, it should not be modifying the DOM at all. 390336 1 cfleizach 2011-04-21 14:25:10 -0700 rdar://9275872 390489 2 90641 cfleizach 2011-04-21 17:34:02 -0700 Created attachment 90641 patch 390493 3 webkit.review.bot 2011-04-21 17:36:21 -0700 Attachment 90641 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/acce..." exit_code: 1 Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1639: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2240: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 390504 4 90641 bdakin 2011-04-21 17:56:22 -0700 Comment on attachment 90641 patch View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 > Is there any reason to leave this empty function around? It seems like we should just get rid of it. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 > Same here. 390505 5 cfleizach 2011-04-21 17:57:49 -0700 (In reply to comment #4) > (From update of attachment 90641 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90641&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1641 > > > > Is there any reason to leave this empty function around? It seems like we should just get rid of it. > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2242 > > > > Same here. I think eventually we want to put something there, but agreed, for now we should just remove 390520 6 90641 bdakin 2011-04-21 18:26:05 -0700 Comment on attachment 90641 patch r=me, but I would prefer for those functions to be removed for now. 390521 7 cfleizach 2011-04-21 18:28:35 -0700 (In reply to comment #6) > (From update of attachment 90641 [details]) > r=me, but I would prefer for those functions to be removed for now. thanks. will remove 390605 8 cfleizach 2011-04-21 22:02:01 -0700 http://trac.webkit.org/changeset/84600 90641 2011-04-21 17:34:02 -0700 2011-04-21 18:26:05 -0700 patch patch.txt text/plain 6755 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTczKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMjEgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgaXMgZXJyb25lb3VzbHkgbW9kaWZ5aW5nIHRo ZSBET007IGFkZGluZyAnYXJpYS1zZWxlY3RlZCcgdG8gdGFibGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTE0MAorCisgICAgICAgIFdlYktpdCBz aG91bGQgbm90IG1vZGlmeSB0aGUgRE9NIHdoZW4gdGhlIHNjcmVlbiByZWFkZXIgcmVxdWVzdHMg Y2VydGFpbiB0aGluZ3MgYmUgc2V0LiBUaGVyZSBpcyBubworICAgICAgICBzcGVjaWZpY2F0aW9u IHRoYXQgYWxsb3dzIHRoaXMgYmVoYXZpb3IgeWV0LCBidXQgd2UgYXJlIHdvcmtpbmcgb24gc29t ZXRoaW5nIGZvciB0aGUgZnV0dXJlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3Q6OnNldEFSSUFHcmFiYmVkKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3Q6OnNldElzRXhwYW5kZWQpOgorICAgICAgICAoV2ViQ29yZTo6QWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c2V0U2VsZWN0ZWQpOgorICAgICAgICAoV2ViQ29yZTo6 QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c2V0VmFsdWUpOgorCiAyMDExLTA0LTIxICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2hvb3BzLCBjaGFuZ2UgbG9z dCBkdXJpbmcgbWVyZ2UKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmls aXR5L2FyaWEtY29tYm9ib3gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtY29tYm9ib3gtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiA4NDU0NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5 L2FyaWEtY29tYm9ib3gtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC03LDcgKzcsNyBA QAogCiBQQVNTIGNvbWJvYm94LnJvbGUgaXMgJ0FYUm9sZTogQVhDb21ib0JveCcKIFBBU1MgY29t Ym9ib3guaXNFeHBhbmRlZCBpcyBmYWxzZQotUEFTUyBjb21ib2JveC5pc0V4cGFuZGVkIGlzIHRy dWUKK1BBU1MgY29tYm9ib3guaXNFeHBhbmRlZCBpcyBmYWxzZQogUEFTUyBmaXJzdENoaWxkLnJv bGUgaXMgJ0FYUm9sZTogQVhMaXN0JwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQog CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNsaWRl ci12YWx1ZS1jaGFuZ2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtc2xpZGVyLXZhbHVlLWNoYW5nZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDg0NTQ1KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvYXJpYS1zbGlkZXItdmFsdWUtY2hhbmdlLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtNSw4ICs1LDggQEAKIAogCiBQQVNTIHNsaWRlci5pbnRWYWx1ZSBpcyA1MAotUEFT UyBzbGlkZXIuaW50VmFsdWUgPiA1MCBpcyB0cnVlCi1QQVNTIHNsaWRlci5pbnRWYWx1ZSA8IDUw IGlzIHRydWUKK1BBU1Mgc2xpZGVyLmludFZhbHVlIGlzIDUwCitQQVNTIHNsaWRlci5pbnRWYWx1 ZSBpcyA1MAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRF CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNsaWRl ci12YWx1ZS1jaGFuZ2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNsaWRlci12YWx1ZS1jaGFuZ2UuaHRtbAkocmV2aXNpb24g ODQ1NDUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNs aWRlci12YWx1ZS1jaGFuZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjcsMTEgKzI3LDEzIEBA CiAgICAgICAgICAgc2hvdWxkQmUoInNsaWRlci5pbnRWYWx1ZSIsICI1MCIpOwogCiAgICAgICAg ICAgc2xpZGVyLmluY3JlbWVudCgpOwotICAgICAgICAgIHNob3VsZEJlKCJzbGlkZXIuaW50VmFs dWUgPiA1MCIsICJ0cnVlIik7CisgICAgICAgICAgLy8gQXMgb2Ygbm93LCB0aGVyZSdzIG5vIHNw ZWNpZmljYXRpb24gZGVzaWduZWQgdG8gdXBkYXRlIHRoZSBET00gYWZ0ZXIgYW4gQVggY2FsbC4K KyAgICAgICAgICBzaG91bGRCZSgic2xpZGVyLmludFZhbHVlIiwgIjUwIik7CiAKICAgICAgICAg ICBzbGlkZXIuZGVjcmVtZW50KCk7CiAgICAgICAgICAgc2xpZGVyLmRlY3JlbWVudCgpOwotICAg ICAgICAgIHNob3VsZEJlKCJzbGlkZXIuaW50VmFsdWUgPCA1MCIsICJ0cnVlIik7CisgICAgICAg ICAgLy8gQXMgb2Ygbm93LCB0aGVyZSdzIG5vIHNwZWNpZmljYXRpb24gZGVzaWduZWQgdG8gdXBk YXRlIHRoZSBET00gYWZ0ZXIgYW4gQVggY2FsbC4KKyAgICAgICAgICBzaG91bGRCZSgic2xpZGVy LmludFZhbHVlIiwgIjUwIik7CiAKICAgICB9CiAKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvYXJpYS1jb21ib2JveC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvYXJpYS1jb21ib2JveC5odG1sCShyZXZpc2lvbiA4NDU0NSkKKysrIExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1jb21ib2JveC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw3ICszNiw4IEBACiAgICAgCiAgICAgICAgICAgY29tYm9ib3guc2hvd01lbnUoKTsKIAotICAg ICAgICAgIHNob3VsZEJlKCJjb21ib2JveC5pc0V4cGFuZGVkIiwgInRydWUiKTsKKyAgICAgICAg ICAvLyBBcyBvZiBub3csIHRoZSBpc0V4cGFuZGVkIHZhbHVlIHdvbid0IGJlIHVwZGF0ZWQgdGhy b3VnaCBhbiBBWCBjYWxsLgorICAgICAgICAgIHNob3VsZEJlKCJjb21ib2JveC5pc0V4cGFuZGVk IiwgImZhbHNlIik7CiAKICAgICAgICAgICB2YXIgZmlyc3RDaGlsZCA9IGNvbWJvYm94LmNoaWxk QXRJbmRleCgwKTsKICAgICAgICAgICBzaG91bGRCZSgiZmlyc3RDaGlsZC5yb2xlIiwgIidBWFJv bGU6IEFYTGlzdCciKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTczKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjEgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgaXMgZXJyb25lb3VzbHkgbW9kaWZ5 aW5nIHRoZSBET007IGFkZGluZyAnYXJpYS1zZWxlY3RlZCcgdG8gdGFibGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTE0MAorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9hcmlhLWNvbWJvYm94Lmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvYXJpYS1jb21ib2JveC1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1zbGlkZXItdmFsdWUtY2hhbmdlLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNsaWRlci12 YWx1ZS1jaGFuZ2UuaHRtbDoKKwogMjAxMS0wNC0yMSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldml3ZWQsIGV4cGVjYXRpb25zIGNoYW5nZS4gUGlj ayB1cCBjaHJvbWl1bS13aW4gYmFzZWxpbmVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJl dmlzaW9uIDg0NTQ1KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzNCw5ICsxNjM0LDkgQEAK ICAgICByZXR1cm4gZWxlbWVudEF0dHJpYnV0ZVZhbHVlKGFyaWFfZ3JhYmJlZEF0dHIpOwogfQog Ci12b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnNldEFSSUFHcmFiYmVkKGJvb2wgZ3Jh YmJlZCkKK3ZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c2V0QVJJQUdyYWJiZWQoYm9v bCkKIHsKLSAgICBzZXRFbGVtZW50QXR0cmlidXRlVmFsdWUoYXJpYV9ncmFiYmVkQXR0ciwgZ3Jh YmJlZCk7CisgICAgLy8gTm8gdmFsaWQgc3BlY2lmaWNhdGlvbiBhbGxvd3Mgc2V0dGluZyB0aGUg ZXhwYW5kZWQgc3RhdGUgYmFjayB0byB0aGUgRE9NLiAgICAKIH0KIAogdm9pZCBBY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0OjpkZXRlcm1pbmVBUklBRHJvcEVmZmVjdHMoVmVjdG9yPFN0cmluZz4m IGVmZmVjdHMpCkBAIC0yMTAxLDE2ICsyMTAxLDE1IEBACiAgICAgcmV0dXJuIGVxdWFsSWdub3Jp bmdDYXNlKGdldEF0dHJpYnV0ZShhdHRyaWJ1dGVOYW1lKSwgInRydWUiKTsKIH0KICAgICAKLXZv aWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c2V0SXNFeHBhbmRlZChib29sIGlzRXhwYW5k ZWQpCit2b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnNldElzRXhwYW5kZWQoYm9vbCkK IHsKICAgICAvLyBDb21ibyBib3hlcywgdHJlZSBpdGVtcyBhbmQgcm93cyBjYW4gYmUgZXhwYW5k ZWQgKGluIGRpZmZlcmVudCB3YXlzIG9uIGRpZmZlcmVudCBwbGF0Zm9ybXMpLgotICAgIC8vIFRo YXQgYWN0aW9uIHRyYW5zbGF0ZXMgaW50byBzZXR0aW5nIHRoZSBhcmlhLWV4cGFuZGVkIGF0dHJp YnV0ZSB0byB0cnVlLgorICAgIC8vIEhvd2V2ZXIsIHRoZXJlJ3Mgbm8gd29ya2luZyBzcGVjZmlj YXRpb24gKHlldCkgdGhhdCBhbGxvd3MgdGhpcyB0byBiZSBwcm9wYWdlZCB0byB0aGUgRE9NLgog ICAgIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGUgPSByb2xlVmFsdWUoKTsKICAgICBzd2l0Y2ggKHJv bGUpIHsKICAgICBjYXNlIENvbWJvQm94Um9sZToKICAgICBjYXNlIFRyZWVJdGVtUm9sZToKICAg ICBjYXNlIFJvd1JvbGU6Ci0gICAgICAgIHNldEVsZW1lbnRBdHRyaWJ1dGVWYWx1ZShhcmlhX2V4 cGFuZGVkQXR0ciwgaXNFeHBhbmRlZCk7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAg ICAgICAgIGJyZWFrOwpAQCAtMjIzNiw5ICsyMjM1LDkgQEAKICAgICBheE9iamVjdENhY2hlKCkt PnBvc3ROb3RpZmljYXRpb24obV9yZW5kZXJlciwgQVhPYmplY3RDYWNoZTo6QVhWYWx1ZUNoYW5n ZWQsIHRydWUpOwogfQogICAgIAotdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzZXRT ZWxlY3RlZChib29sIGVuYWJsZWQpCit2b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnNl dFNlbGVjdGVkKGJvb2wpCiB7Ci0gICAgc2V0RWxlbWVudEF0dHJpYnV0ZVZhbHVlKGFyaWFfc2Vs ZWN0ZWRBdHRyLCBlbmFibGVkKTsKKyAgICAvLyBObyB2YWxpZCBzcGVjaWZpY2F0aW9uIGFsbG93 cyBzZXR0aW5nIHRoZSBleHBhbmRlZCBzdGF0ZSBiYWNrIHRvIHRoZSBET00uICAgIAogfQogCiB2 b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnNldFNlbGVjdGVkUm93cyhBY2Nlc3NpYmls aXR5Q2hpbGRyZW5WZWN0b3ImIHNlbGVjdGVkUm93cykKQEAgLTIyNjMsOSArMjI2Miw2IEBACiAg ICAgICAgIHJldHVybjsKICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxlbWVu dCo+KG1fcmVuZGVyZXItPm5vZGUoKSk7CiAKLSAgICBpZiAocm9sZVZhbHVlKCkgPT0gU2xpZGVy Um9sZSkKLSAgICAgICAgZWxlbWVudC0+c2V0QXR0cmlidXRlKGFyaWFfdmFsdWVub3dBdHRyLCBz dHJpbmcpOwotCiAgICAgaWYgKCFtX3JlbmRlcmVyLT5pc0JveE1vZGVsT2JqZWN0KCkpCiAgICAg ICAgIHJldHVybjsKICAgICBSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVuZGVyZXIgPSB0b1JlbmRl ckJveE1vZGVsT2JqZWN0KG1fcmVuZGVyZXIpOwo=