59128 2011-04-21 12:20:34 -0700 HTMLFormControlElement::labels should allow custom attributes. 2011-04-22 16:04:26 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abarth ap commit-queue eric sam webkit.review.bot oldest_to_newest 390241 0 yael 2011-04-21 12:20:34 -0700 This was introduced in http://trac.webkit.org/changeset/60232. HTMLFormControlElement::labels() needlessly caches its labels list. 390244 1 90576 yael 2011-04-21 12:23:16 -0700 Created attachment 90576 Patch. 390277 2 90576 sam 2011-04-21 13:12:21 -0700 Comment on attachment 90576 Patch. This leaves the node list cache in NodeRareData. I am also not sure we don't want to cache this value. Consider the following test. inputElement.labels.customProperty = 1; alert(inputElement.labels.customProperty); That should probably work, but probably won't with this patch or the current code. 390344 3 yael 2011-04-21 14:36:08 -0700 (In reply to comment #2) > (From update of attachment 90576 [details]) > This leaves the node list cache in NodeRareData. I am also not sure we don't want to cache this value. Consider the following test. > > inputElement.labels.customProperty = 1; > alert(inputElement.labels.customProperty); > > That should probably work, but probably won't with this patch or the current code. Right, I was a bit too quick :) I'll rework this patch. 390404 4 90617 yael 2011-04-21 15:37:55 -0700 Created attachment 90617 Patch. Cache the node this time. We do want the test in comment #2 to pass :) Sam, I did not quite understand your comment on irc about strong pointers and could not catch you afterwards. If it is still a problem please let me know and I'll address that. 390407 5 90617 ap 2011-04-21 15:47:21 -0700 Comment on attachment 90617 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=90617&action=review I don't deeply understand what's going one like Sam does, but I've got a few comments. > LayoutTests/fast/forms/script-tests/labels-custom-property.js:1 > +description('Test that we can set and get custom properties on the labels attribute. '); Could you please merge these .js and .html files? Keeping them separate causes nothing but difficulties, as you need a second step to get from test to its content. > LayoutTests/fast/forms/script-tests/labels-custom-property.js:11 > +labels.customProperty = 1; > +shouldBe('labels.customProperty', '1'); Can you add a gc() call between these? I can't easily find any code marking the JS wrapper. 390470 6 90617 sam 2011-04-21 17:04:46 -0700 Comment on attachment 90617 Patch. I think you need to change m_labelsNodeListCache to be a weak pointer for this not leak. 390512 7 yael 2011-04-21 18:09:12 -0700 (In reply to comment #6) > (From update of attachment 90617 [details]) > I think you need to change m_labelsNodeListCache to be a weak pointer for this not leak. Thank you for the review. I am not sure I know what you mean by "weak pointer" ? I cannot find it in wtf. Do you mean DynamicNodeList* or something else? 390737 8 yael 2011-04-22 06:03:43 -0700 (In reply to comment #5) > (From update of attachment 90617 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90617&action=review > Thank you for your comments. > I don't deeply understand what's going one like Sam does, but I've got a few comments. > > > LayoutTests/fast/forms/script-tests/labels-custom-property.js:1 > > +description('Test that we can set and get custom properties on the labels attribute. '); > > Could you please merge these .js and .html files? Keeping them separate causes nothing but difficulties, as you need a second step to get from test to its content. > Will do :) > > LayoutTests/fast/forms/script-tests/labels-custom-property.js:11 > > +labels.customProperty = 1; > > +shouldBe('labels.customProperty', '1'); > > Can you add a gc() call between these? I can't easily find any code marking the JS wrapper. Will do :) I'll submit a new patch once the pointer issue is resolved. Going through the logs, I see that the way we cache the DynamicNodeList wrappers was changed this week. Please look at r84309 and r83990. 390805 9 90710 yael 2011-04-22 09:05:15 -0700 Created attachment 90710 Patch. Address comment #5 and commnet #6. 390806 10 yael 2011-04-22 09:06:21 -0700 (In reply to comment #9) > Created an attachment (id=90710) [details] > Patch. > > Address comment #5 and comment #6. Verified that the LabelsNodeList is being garbage collected and the C++ object is being deleted. 390817 11 90711 yael 2011-04-22 09:17:32 -0700 Created attachment 90711 Patch. Resolved conflicts. 390870 12 ap 2011-04-22 10:32:47 -0700 Wait, it''s not a weak pointer, it's a potentially dangling pointer... For those following along at home, could you please explain why this pointer will never point to released memory? 390901 13 90711 ap 2011-04-22 11:02:11 -0700 Comment on attachment 90711 Patch. Could you please answer that before committing? If the code is wrong in that respect, the patch would be introducing a security bug. 390928 14 90731 yael 2011-04-22 11:32:00 -0700 Created attachment 90731 Patch. Change LabelsNodeList::create() to take a pointer Node* instead of PassRefPtr. Change m_labelsNodeListCache to be of type LabelsNodeList*. 390930 15 yael 2011-04-22 11:33:51 -0700 (In reply to comment #12) > Wait, it''s not a weak pointer, it's a potentially dangling pointer... > > For those following along at home, could you please explain why this pointer will never point to released memory? The pointer is cleared in the destructor of LabelsListNode. 391158 16 90731 commit-queue 2011-04-22 15:37:01 -0700 Comment on attachment 90731 Patch. Clearing flags on attachment: 90731 Committed r84693: <http://trac.webkit.org/changeset/84693> 391159 17 commit-queue 2011-04-22 15:37:06 -0700 All reviewed patches have been landed. Closing bug. 391182 18 webkit.review.bot 2011-04-22 16:04:26 -0700 http://trac.webkit.org/changeset/84693 might have broken SnowLeopard Intel Release (Build) 90576 2011-04-21 12:23:16 -0700 2011-04-21 15:37:55 -0700 Patch. 59128.patch text/plain 1849 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTM2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQgc2hvdWxkIG5vdCBjYWNoZSBpdHMgbGFiZWxzIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MTI4CisKKyAgICAgICAgUmVtb3ZlIHRo ZSBjYWNoZSBhcyBpdCBpcyBub3QgdXNlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg aXMgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1D b250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVt ZW50OjpsYWJlbHMpOgorICAgICAgICAqIGh0bWwvTGFiZWxzTm9kZUxpc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGFiZWxzTm9kZUxpc3Q6On5MYWJlbHNOb2RlTGlzdCk6CisKIDIwMTEtMDQt MjEgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBL ZW5uZXRoIFJ1c3NlbGwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1D b250cm9sRWxlbWVudC5jcHAJKHJldmlzaW9uIDg0MjQ3KQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYyLDE0ICs0 NjIsNiBAQCBQYXNzUmVmUHRyPE5vZGVMaXN0PiBIVE1MRm9ybUNvbnRyb2xFbGVtCiB7CiAgICAg aWYgKCFpc0xhYmVsYWJsZSgpKQogICAgICAgICByZXR1cm4gMDsKLSAgICBpZiAoIWRvY3VtZW50 KCkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgTm9kZVJhcmVEYXRhKiBkYXRhID0gTm9kZTo6 ZW5zdXJlUmFyZURhdGEoKTsKLSAgICBpZiAoIWRhdGEtPm5vZGVMaXN0cygpKSB7Ci0gICAgICAg IGRhdGEtPnNldE5vZGVMaXN0cyhOb2RlTGlzdHNOb2RlRGF0YTo6Y3JlYXRlKCkpOwotICAgICAg ICBkb2N1bWVudCgpLT5hZGROb2RlTGlzdENhY2hlKCk7Ci0gICAgfQogCiAgICAgcmV0dXJuIExh YmVsc05vZGVMaXN0OjpjcmVhdGUodGhpcyk7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L0xhYmVsc05vZGVMaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0xh YmVsc05vZGVMaXN0LmNwcAkocmV2aXNpb24gODQyNDcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L0xhYmVsc05vZGVMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksNyArMzksNiBAQCBMYWJl bHNOb2RlTGlzdDo6TGFiZWxzTm9kZUxpc3QoUGFzc1JlZlB0CiAKIExhYmVsc05vZGVMaXN0Ojp+ TGFiZWxzTm9kZUxpc3QoKQogewotICAgIG1fZm9yTm9kZS0+cmVtb3ZlQ2FjaGVkTGFiZWxzTm9k ZUxpc3QodGhpcyk7CiB9IAogICAgIAogYm9vbCBMYWJlbHNOb2RlTGlzdDo6bm9kZU1hdGNoZXMo RWxlbWVudCogdGVzdE5vZGUpIGNvbnN0Cg== 90617 2011-04-21 15:37:55 -0700 2011-04-22 09:05:15 -0700 Patch. 59128.patch text/plain 4394 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscyBzaG91 bGQgYWxsb3cgY3VzdG9tIGF0dHJpYnV0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTEyOAorCisgICAgICAgIENhY2hlIHRoZSBsYWJlbHMgbGlz dCB3aGVuIGl0IGlzIGNyZWF0ZWQgYW5kIGtlZXAgdXNpbmcgaXQgZm9yIGZ1dHVyZQorICAgICAg ICBsYWJlbHMgY2FsbHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9t LXByb3BlcnR5Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMpOgor CiAyMDExLTA0LTIxICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAkocmV2aXNpb24gODQ1NDIpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NzEsNyArNDcxLDEwIEBAIFBhc3NSZWZQdHI8Tm9kZUxpc3Q+IEhUTUxGb3JtQ29udHJvbEVs ZW0KICAgICAgICAgZG9jdW1lbnQoKS0+YWRkTm9kZUxpc3RDYWNoZSgpOwogICAgIH0KIAotICAg IHJldHVybiBMYWJlbHNOb2RlTGlzdDo6Y3JlYXRlKHRoaXMpOworICAgIGlmICghZGF0YS0+bm9k ZUxpc3RzKCktPm1fbGFiZWxzTm9kZUxpc3RDYWNoZSkKKyAgICAgICAgZGF0YS0+bm9kZUxpc3Rz KCktPm1fbGFiZWxzTm9kZUxpc3RDYWNoZSA9IExhYmVsc05vZGVMaXN0OjpjcmVhdGUodGhpcyk7 CisKKyAgICByZXR1cm4gZGF0YS0+bm9kZUxpc3RzKCktPm1fbGFiZWxzTm9kZUxpc3RDYWNoZTsK IH0KIAogSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZTo6SFRNTEZvcm1Db250cm9sRWxl bWVudFdpdGhTdGF0ZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCogZG9j LCBIVE1MRm9ybUVsZW1lbnQqIGYpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NDU1MCkKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0 LTIxICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50 OjpsYWJlbHMgc2hvdWxkIGFsbG93IGN1c3RvbSBhdHRyaWJ1dGVzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkxMjgKKworICAgICAgICAqIGZhc3Qv Zm9ybXMvbGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZm9ybXMvbGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LmpzOiBB ZGRlZC4KKwogMjAxMS0wNC0yMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIGVtYmVkZGluZyBjaGVja3N1bXMgaW4gcG5nIGZpbGVzIG5vdCBp biBMYXlvdXRUZXN0cy9wbGF0Zm9ybS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFi ZWxzLWN1c3RvbS1wcm9wZXJ0eS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3QgdGhhdCB3ZSBj YW4gc2V0IGFuZCBnZXQgY3VzdG9tIHByb3BlcnRpZXMgb24gdGhlIGxhYmVscyBhdHRyaWJ1dGUu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGxhYmVscy5jdXN0b21Qcm9w ZXJ0eSBpcyAxCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidG4iKS5sYWJlbHMuY3Vz dG9tUHJvcGVydHkgaXMgMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNU IENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxzLWN1c3RvbS1w cm9wZXJ0eS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxz LWN1c3RvbS1wcm9wZXJ0eS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxo dG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMv cmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxw IGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0 IHNyYz0ic2NyaXB0LXRlc3RzL2xhYmVscy1jdXN0b20tcHJvcGVydHkuanMiPjwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nj cmlwdC10ZXN0cy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZm9ybXMvc2NyaXB0LXRlc3RzL2xhYmVscy1jdXN0b20tcHJvcGVydHkuanMJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9sYWJl bHMtY3VzdG9tLXByb3BlcnR5LmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACitkZXNj cmlwdGlvbignVGVzdCB0aGF0IHdlIGNhbiBzZXQgYW5kIGdldCBjdXN0b20gcHJvcGVydGllcyBv biB0aGUgbGFiZWxzIGF0dHJpYnV0ZS4gJyk7CisKK3ZhciBwYXJlbnQgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdkaXYnKTsKKworcGFyZW50LmlubmVySFRNTCA9ICc8YnV0dG9uIGlkPSJidG4i PjwvYnV0dG9uPjxsYWJlbCBpZD0ibGJsMSIgZm9yPSJidG4iPjwvbGFiZWw+PGxhYmVsIGlkPSJs YmwyIiBmb3I9ImJ0biI+PC9sYWJlbD4nOworCitkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBh cmVudCk7CisKK2xhYmVscyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidG4iKS5sYWJlbHM7 CitsYWJlbHMuY3VzdG9tUHJvcGVydHkgPSAxOworc2hvdWxkQmUoJ2xhYmVscy5jdXN0b21Qcm9w ZXJ0eScsICcxJyk7CitzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJ0biIpLmxh YmVscy5jdXN0b21Qcm9wZXJ0eScsICcxJyk7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOwo= 90710 2011-04-22 09:05:15 -0700 2011-04-22 09:17:32 -0700 Patch. 59128.patch text/plain 4603 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscyBzaG91 bGQgYWxsb3cgY3VzdG9tIGF0dHJpYnV0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTEyOAorCisgICAgICAgIENhY2hlIHRoZSBsYWJlbHMgbGlz dCB3aGVuIGl0IGlzIGNyZWF0ZWQgYW5kIGtlZXAgdXNpbmcgaXQgZm9yIGZ1dHVyZQorICAgICAg ICBsYWJlbHMgY2FsbHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9t LXByb3BlcnR5Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMpOgor CiAyMDExLTA0LTIxICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl UmFyZURhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJhcmVEYXRh LmgJKHJldmlzaW9uIDg0NTQyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJlRGF0YS5o CSh3b3JraW5nIGNvcHkpCkBAIC01Myw3ICs1Myw3IEBAIHB1YmxpYzoKICAgICB0eXBlZGVmIEhh c2hNYXA8UmVmUHRyPFF1YWxpZmllZE5hbWU6OlF1YWxpZmllZE5hbWVJbXBsPiwgVGFnTm9kZUxp c3QqPiBUYWdOb2RlTGlzdENhY2hlOwogICAgIFRhZ05vZGVMaXN0Q2FjaGUgbV90YWdOb2RlTGlz dENhY2hlOwogCi0gICAgUmVmUHRyPER5bmFtaWNOb2RlTGlzdD4gbV9sYWJlbHNOb2RlTGlzdENh Y2hlOworICAgIER5bmFtaWNOb2RlTGlzdCogbV9sYWJlbHNOb2RlTGlzdENhY2hlOwogICAgIAog ICAgIHN0YXRpYyBQYXNzT3duUHRyPE5vZGVMaXN0c05vZGVEYXRhPiBjcmVhdGUoKQogICAgIHsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNw cAkocmV2aXNpb24gODQ1NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzEsNyArNDcxLDEyIEBAIFBhc3NSZWZQ dHI8Tm9kZUxpc3Q+IEhUTUxGb3JtQ29udHJvbEVsZW0KICAgICAgICAgZG9jdW1lbnQoKS0+YWRk Tm9kZUxpc3RDYWNoZSgpOwogICAgIH0KIAotICAgIHJldHVybiBMYWJlbHNOb2RlTGlzdDo6Y3Jl YXRlKHRoaXMpOworICAgIGlmIChkYXRhLT5ub2RlTGlzdHMoKS0+bV9sYWJlbHNOb2RlTGlzdENh Y2hlKQorICAgICAgICByZXR1cm4gZGF0YS0+bm9kZUxpc3RzKCktPm1fbGFiZWxzTm9kZUxpc3RD YWNoZTsKKworICAgIFJlZlB0cjxMYWJlbHNOb2RlTGlzdD4gbGlzdCA9IExhYmVsc05vZGVMaXN0 OjpjcmVhdGUodGhpcyk7CisgICAgZGF0YS0+bm9kZUxpc3RzKCktPm1fbGFiZWxzTm9kZUxpc3RD YWNoZSA9IGxpc3QuZ2V0KCk7CisgICAgcmV0dXJuIGxpc3QucmVsZWFzZSgpOwogfQogCiBIVE1M Rm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0 YXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2MsIEhUTUxGb3Jt RWxlbWVudCogZikKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NTUwKQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMjEgIFlhZWwg QWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscyBz aG91bGQgYWxsb3cgY3VzdG9tIGF0dHJpYnV0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTEyOAorCisgICAgICAgICogZmFzdC9mb3Jtcy9sYWJl bHMtY3VzdG9tLXByb3BlcnR5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9m b3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5Lmh0bWw6IEFkZGVkLgorCiAyMDExLTA0LTIxICBU b255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZW1i ZWRkaW5nIGNoZWNrc3VtcyBpbiBwbmcgZmlsZXMgbm90IGluIExheW91dFRlc3RzL3BsYXRmb3Jt LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1j dXN0b20tcHJvcGVydHktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwxMSBAQAorVGVzdCB0aGF0IHdlIGNhbiBzZXQgYW5kIGdldCBjdXN0b20g cHJvcGVydGllcyBvbiB0aGUgbGFiZWxzIGF0dHJpYnV0ZS4KKworT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUiLgorCisKK1BBU1MgbGFiZWxzLmN1c3RvbVByb3BlcnR5IGlzIDEKK1BBU1MgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImJ0biIpLmxhYmVscy5jdXN0b21Qcm9wZXJ0eSBpcyAxCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5Lmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5Lmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJv cGVydHkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIEhUTUwg UFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJl bD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHls ZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCB0 aGF0IHdlIGNhbiBzZXQgYW5kIGdldCBjdXN0b20gcHJvcGVydGllcyBvbiB0aGUgbGFiZWxzIGF0 dHJpYnV0ZS4gJyk7CisKK3ZhciBwYXJlbnREaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdk aXYnKTsKKworcGFyZW50RGl2LmlubmVySFRNTCA9ICc8YnV0dG9uIGlkPSJidG4iPjwvYnV0dG9u PjxsYWJlbCBpZD0ibGJsMSIgZm9yPSJidG4iPjwvbGFiZWw+PGxhYmVsIGlkPSJsYmwyIiBmb3I9 ImJ0biI+PC9sYWJlbD4nOworCitkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVudERpdik7 CisKK2xhYmVscyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidG4iKS5sYWJlbHM7CitsYWJl bHMuY3VzdG9tUHJvcGVydHkgPSAxOworZ2MoKTsKK3Nob3VsZEJlKCdsYWJlbHMuY3VzdG9tUHJv cGVydHknLCAnMScpOworc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidG4iKS5s YWJlbHMuY3VzdG9tUHJvcGVydHknLCAnMScpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 90711 2011-04-22 09:17:32 -0700 2011-04-22 11:32:00 -0700 Patch. 59128.patch text/plain 4574 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscyBzaG91 bGQgYWxsb3cgY3VzdG9tIGF0dHJpYnV0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTEyOAorCisgICAgICAgIENhY2hlIHRoZSBsYWJlbHMgbGlz dCB3aGVuIGl0IGlzIGNyZWF0ZWQgYW5kIGtlZXAgdXNpbmcgaXQgZm9yIGZ1dHVyZQorICAgICAg ICBsYWJlbHMgY2FsbHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9t LXByb3BlcnR5Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMpOgor CiAyMDExLTA0LTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9k b20vTm9kZVJhcmVEYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL05vZGVS YXJlRGF0YS5oCShyZXZpc2lvbiA4NDYzMSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFy ZURhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsNyArNTYsNyBAQCBwdWJsaWM6CiAgICAgdHlw ZWRlZiBIYXNoTWFwPFJlZlB0cjxRdWFsaWZpZWROYW1lOjpRdWFsaWZpZWROYW1lSW1wbD4sIFRh Z05vZGVMaXN0Kj4gVGFnTm9kZUxpc3RDYWNoZU5TOwogICAgIFRhZ05vZGVMaXN0Q2FjaGVOUyBt X3RhZ05vZGVMaXN0Q2FjaGVOUzsKICAKLSAgICBSZWZQdHI8RHluYW1pY05vZGVMaXN0PiBtX2xh YmVsc05vZGVMaXN0Q2FjaGU7CisgICAgRHluYW1pY05vZGVMaXN0KiBtX2xhYmVsc05vZGVMaXN0 Q2FjaGU7CiAgCiAgICAgc3RhdGljIFBhc3NPd25QdHI8Tm9kZUxpc3RzTm9kZURhdGE+IGNyZWF0 ZSgpCiAgICAgewpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwCShyZXZpc2lvbiA4NDYzMSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3MSw3ICs0NzEsMTIg QEAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gSFRNTEZvcm1Db250cm9sRWxlbQogICAgICAgICBkb2N1 bWVudCgpLT5hZGROb2RlTGlzdENhY2hlKCk7CiAgICAgfQogCi0gICAgcmV0dXJuIExhYmVsc05v ZGVMaXN0OjpjcmVhdGUodGhpcyk7CisgICAgaWYgKGRhdGEtPm5vZGVMaXN0cygpLT5tX2xhYmVs c05vZGVMaXN0Q2FjaGUpCisgICAgICAgIHJldHVybiBkYXRhLT5ub2RlTGlzdHMoKS0+bV9sYWJl bHNOb2RlTGlzdENhY2hlOworCisgICAgUmVmUHRyPExhYmVsc05vZGVMaXN0PiBsaXN0ID0gTGFi ZWxzTm9kZUxpc3Q6OmNyZWF0ZSh0aGlzKTsKKyAgICBkYXRhLT5ub2RlTGlzdHMoKS0+bV9sYWJl bHNOb2RlTGlzdENhY2hlID0gbGlzdC5nZXQoKTsKKyAgICByZXR1cm4gbGlzdC5yZWxlYXNlKCk7 CiB9CiAKIEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGU6OkhUTUxGb3JtQ29udHJvbEVs ZW1lbnRXaXRoU3RhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRv YywgSFRNTEZvcm1FbGVtZW50KiBmKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODQ2MzEpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0w NC0yMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVu dDo6bGFiZWxzIHNob3VsZCBhbGxvdyBjdXN0b20gYXR0cmlidXRlcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MTI4CisKKyAgICAgICAgKiBmYXN0 L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJvcGVydHktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJvcGVydHkuaHRtbDogQWRkZWQuCisKIDIw MTEtMDQtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9y bXMvbGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5LWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxzLWN1c3RvbS1wcm9w ZXJ0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3QgdGhh dCB3ZSBjYW4gc2V0IGFuZCBnZXQgY3VzdG9tIHByb3BlcnRpZXMgb24gdGhlIGxhYmVscyBhdHRy aWJ1dGUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGxhYmVscy5jdXN0 b21Qcm9wZXJ0eSBpcyAxCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJidG4iKS5sYWJl bHMuY3VzdG9tUHJvcGVydHkgaXMgMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxzLWN1 c3RvbS1wcm9wZXJ0eS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMv bGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9tLXByb3BlcnR5Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VO Ij4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8 c2NyaXB0PgorZGVzY3JpcHRpb24oJ1Rlc3QgdGhhdCB3ZSBjYW4gc2V0IGFuZCBnZXQgY3VzdG9t IHByb3BlcnRpZXMgb24gdGhlIGxhYmVscyBhdHRyaWJ1dGUuICcpOworCit2YXIgcGFyZW50RGl2 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisKK3BhcmVudERpdi5pbm5lckhUTUwg PSAnPGJ1dHRvbiBpZD0iYnRuIj48L2J1dHRvbj48bGFiZWwgaWQ9ImxibDEiIGZvcj0iYnRuIj48 L2xhYmVsPjxsYWJlbCBpZD0ibGJsMiIgZm9yPSJidG4iPjwvbGFiZWw+JzsKKworZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChwYXJlbnREaXYpOworCitsYWJlbHMgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgiYnRuIikubGFiZWxzOworbGFiZWxzLmN1c3RvbVByb3BlcnR5ID0gMTsKK2djKCk7 CitzaG91bGRCZSgnbGFiZWxzLmN1c3RvbVByb3BlcnR5JywgJzEnKTsKK3Nob3VsZEJlKCdkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiYnRuIikubGFiZWxzLmN1c3RvbVByb3BlcnR5JywgJzEnKTsK KwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo= 90731 2011-04-22 11:32:00 -0700 2011-04-22 15:37:01 -0700 Patch. 59128.patch text/plain 5865 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NjMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjEgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscyBzaG91 bGQgYWxsb3cgY3VzdG9tIGF0dHJpYnV0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTEyOAorCisgICAgICAgIENhY2hlIHRoZSBsYWJlbHMgbGlz dCB3aGVuIGl0IGlzIGNyZWF0ZWQgYW5kIGtlZXAgdXNpbmcgaXQgZm9yIGZ1dHVyZQorICAgICAg ICBsYWJlbHMgY2FsbHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9sYWJlbHMtY3VzdG9t LXByb3BlcnR5Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMpOgor CiAyMDExLTA0LTIxICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlUmFyZURhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJh cmVEYXRhLmgJKHJldmlzaW9uIDg0NjMyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJl RGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAorY2xhc3MgTGFiZWxzTm9kZUxpc3Q7CiBjbGFzcyBUcmVlU2NvcGU7CiAKIHN0cnVj dCBOb2RlTGlzdHNOb2RlRGF0YSB7CkBAIC01Niw3ICs1Nyw3IEBAIHB1YmxpYzoKICAgICB0eXBl ZGVmIEhhc2hNYXA8UmVmUHRyPFF1YWxpZmllZE5hbWU6OlF1YWxpZmllZE5hbWVJbXBsPiwgVGFn Tm9kZUxpc3QqPiBUYWdOb2RlTGlzdENhY2hlTlM7CiAgICAgVGFnTm9kZUxpc3RDYWNoZU5TIG1f dGFnTm9kZUxpc3RDYWNoZU5TOwogIAotICAgIFJlZlB0cjxEeW5hbWljTm9kZUxpc3Q+IG1fbGFi ZWxzTm9kZUxpc3RDYWNoZTsKKyAgICBMYWJlbHNOb2RlTGlzdCogbV9sYWJlbHNOb2RlTGlzdENh Y2hlOwogIAogICAgIHN0YXRpYyBQYXNzT3duUHRyPE5vZGVMaXN0c05vZGVEYXRhPiBjcmVhdGUo KQogICAgIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xF bGVtZW50LmNwcAkocmV2aXNpb24gODQ2MzIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzEsNyArNDcxLDEyIEBA IFBhc3NSZWZQdHI8Tm9kZUxpc3Q+IEhUTUxGb3JtQ29udHJvbEVsZW0KICAgICAgICAgZG9jdW1l bnQoKS0+YWRkTm9kZUxpc3RDYWNoZSgpOwogICAgIH0KIAotICAgIHJldHVybiBMYWJlbHNOb2Rl TGlzdDo6Y3JlYXRlKHRoaXMpOworICAgIGlmIChkYXRhLT5ub2RlTGlzdHMoKS0+bV9sYWJlbHNO b2RlTGlzdENhY2hlKQorICAgICAgICByZXR1cm4gZGF0YS0+bm9kZUxpc3RzKCktPm1fbGFiZWxz Tm9kZUxpc3RDYWNoZTsKKworICAgIFJlZlB0cjxMYWJlbHNOb2RlTGlzdD4gbGlzdCA9IExhYmVs c05vZGVMaXN0OjpjcmVhdGUodGhpcyk7CisgICAgZGF0YS0+bm9kZUxpc3RzKCktPm1fbGFiZWxz Tm9kZUxpc3RDYWNoZSA9IGxpc3QuZ2V0KCk7CisgICAgcmV0dXJuIGxpc3QucmVsZWFzZSgpOwog fQogCiBIVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlOjpIVE1MRm9ybUNvbnRyb2xFbGVt ZW50V2l0aFN0YXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2Ms IEhUTUxGb3JtRWxlbWVudCogZikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvTGFiZWxzTm9k ZUxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvTGFiZWxzTm9kZUxp c3QuY3BwCShyZXZpc2lvbiA4NDYzMikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvTGFiZWxzTm9k ZUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAotTGFiZWxzTm9kZUxpc3Q6Okxh YmVsc05vZGVMaXN0KFBhc3NSZWZQdHI8Tm9kZT4gZm9yTm9kZSApCitMYWJlbHNOb2RlTGlzdDo6 TGFiZWxzTm9kZUxpc3QoTm9kZSogZm9yTm9kZSApCiAgICAgOiBEeW5hbWljTm9kZUxpc3QoZm9y Tm9kZS0+ZG9jdW1lbnQoKSkgLCBtX2Zvck5vZGUoZm9yTm9kZSkKIHsKIH0KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2h0bWwvTGFiZWxzTm9kZUxpc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9odG1sL0xhYmVsc05vZGVMaXN0LmgJKHJldmlzaW9uIDg0NjMyKQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9MYWJlbHNOb2RlTGlzdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMiwxNCArMzIs MTQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBMYWJlbHNOb2RlTGlzdCA6IHB1Ymxp YyBEeW5hbWljTm9kZUxpc3QgewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPExhYmVs c05vZGVMaXN0PiBjcmVhdGUoUGFzc1JlZlB0cjxOb2RlPiBmb3JOb2RlKQorICAgIHN0YXRpYyBQ YXNzUmVmUHRyPExhYmVsc05vZGVMaXN0PiBjcmVhdGUoTm9kZSogZm9yTm9kZSkKICAgICB7CiAg ICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgTGFiZWxzTm9kZUxpc3QoZm9yTm9kZSkpOwogICAg IH0KICAgICB+TGFiZWxzTm9kZUxpc3QoKTsKIAogcHJvdGVjdGVkOgotICAgIExhYmVsc05vZGVM aXN0KFBhc3NSZWZQdHI8Tm9kZT4gZm9yTm9kZSk7CisgICAgTGFiZWxzTm9kZUxpc3QoTm9kZSog Zm9yTm9kZSk7CiAKICAgICB2aXJ0dWFsIGJvb2wgbm9kZU1hdGNoZXMoRWxlbWVudCopIGNvbnN0 OwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NDYzMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTA0LTIxICBZYWVsIEFoYXJvbiAg PHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMgc2hvdWxkIGFs bG93IGN1c3RvbSBhdHRyaWJ1dGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTkxMjgKKworICAgICAgICAqIGZhc3QvZm9ybXMvbGFiZWxzLWN1c3Rv bS1wcm9wZXJ0eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvbGFi ZWxzLWN1c3RvbS1wcm9wZXJ0eS5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0yMSAgTU9SSVRBIEhh amltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp IEdsYXprb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJv cGVydHktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMv bGFiZWxzLWN1c3RvbS1wcm9wZXJ0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJvcGVydHktZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACitUZXN0IHRoYXQgd2UgY2FuIHNldCBhbmQgZ2V0 IGN1c3RvbSBwcm9wZXJ0aWVzIG9uIHRoZSBsYWJlbHMgYXR0cmlidXRlLgorCitPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCisKKworUEFTUyBsYWJlbHMuY3VzdG9tUHJvcGVydHkgaXMgMQorUEFT UyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYnRuIikubGFiZWxzLmN1c3RvbVByb3BlcnR5IGlz IDEKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJvcGVydHkuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xhYmVscy1jdXN0b20tcHJvcGVy dHkuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGFiZWxzLWN1 c3RvbS1wcm9wZXJ0eS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI5IEBACis8IURPQ1RZ UEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgor PGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10 ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRp b24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9u KCdUZXN0IHRoYXQgd2UgY2FuIHNldCBhbmQgZ2V0IGN1c3RvbSBwcm9wZXJ0aWVzIG9uIHRoZSBs YWJlbHMgYXR0cmlidXRlLiAnKTsKKwordmFyIHBhcmVudERpdiA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoJ2RpdicpOworCitwYXJlbnREaXYuaW5uZXJIVE1MID0gJzxidXR0b24gaWQ9ImJ0biI+ PC9idXR0b24+PGxhYmVsIGlkPSJsYmwxIiBmb3I9ImJ0biI+PC9sYWJlbD48bGFiZWwgaWQ9Imxi bDIiIGZvcj0iYnRuIj48L2xhYmVsPic7CisKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQocGFy ZW50RGl2KTsKKworbGFiZWxzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJ0biIpLmxhYmVs czsKK2xhYmVscy5jdXN0b21Qcm9wZXJ0eSA9IDE7CitnYygpOworc2hvdWxkQmUoJ2xhYmVscy5j dXN0b21Qcm9wZXJ0eScsICcxJyk7CitzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImJ0biIpLmxhYmVscy5jdXN0b21Qcm9wZXJ0eScsICcxJyk7CisKK3ZhciBzdWNjZXNzZnVsbHlQ YXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K