59125 2011-04-21 11:42:38 -0700 [Qt][WK2] Cannot play flash with NSPluginWrapper 2011-04-22 09:43:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 390203 0 kbalazs 2011-04-21 11:42:38 -0700 NSPluginWrapper flash player is not working with WebKit2. Way to reproduce: chose a youtube video with MiniBrowser. Expected: video is playing. Current result: white screen, error message: *** NSPlugin Wrapper *** WARNING:(/usr/src/packages/BUILD/nspluginwrapper-1.3.0/src/npw-wrapper.c:3160):invoke_NP_Initialize: assertion failed: (rpc_method_invoke_possible(g_rpc_connection)) 390767 1 kbalazs 2011-04-22 07:18:54 -0700 This is actually a crash (web process), so set it to P1. 390768 2 90706 kbalazs 2011-04-22 07:21:10 -0700 Created attachment 90706 Patch 390770 3 90706 kenneth 2011-04-22 07:27:03 -0700 Comment on attachment 90706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90706&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:513 > + // Cheat the GTK version if we now that this plugin needs it or if the plugin call us know* > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:520 > + RefPtr<NetscapePlugin> plugin = NetscapePlugin::fromNPP(npp); > + needToCheatGTKVersion = plugin->quirks().contains(PluginQuirks::RequiresGTKToolKit); this doesnt seem like cheating. Why not just call the variable "requiresGTKToolKit" 390773 4 90707 kbalazs 2011-04-22 07:36:54 -0700 Created attachment 90707 Patch 390832 5 kbalazs 2011-04-22 09:43:27 -0700 Fixed in http://trac.webkit.org/changeset/84634 90706 2011-04-22 07:21:10 -0700 2011-04-22 07:36:50 -0700 Patch bug-59125-20110422162108.patch text/plain 2234 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1MTNlYmNhNmQ5OGY0Yzdk OWQyOTBmYTI2ZGRkMDMzMmNjM2UzMGZkLi40MGQ0ZGU2OTlkZmFkNjk4ODFjNzgwNjM1YzhhNjZl MmVkZWJiMjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjIgIEJhbGF6 cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBDYW5ub3QgcGxheSBmbGFzaCB3aXRo IE5TUGx1Z2luV3JhcHBlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTkxMjUKKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9HZXRWYWx1ZSk6 IEhhbmRsZSB0aGUgY2FzZSB3aGVuIHdlIGhhdmUgYmVlbgorICAgICAgICBjYWxsZWQgd2l0aCBh IG51bGwgcGx1Z2luIGluc3RhbmNlLgorCiAyMDExLTA0LTIwICBEb21pbmljIENvb25leSAgPGRv bWluaWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcAppbmRleCBhNTQ4ZmQ2Mjgz OThjNDg0ZWU4YTFmZWNhZjVjYmViMDllNTcwOGJjLi43OWRkNDVjYmM4YTk1OGI2ZGE4Yjk5NGJk OWVkMDM3MzBlNjc2ODQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAK QEAgLTUxMCw5ICs1MTAsMTcgQEAgc3RhdGljIE5QRXJyb3IgTlBOX0dldFZhbHVlKE5QUCBucHAs IE5QTlZhcmlhYmxlIHZhcmlhYmxlLCB2b2lkICp2YWx1ZSkKICAgICAgICBjYXNlIE5QTlZUb29s a2l0OiB7CiAgICAgICAgICAgIGNvbnN0IHVpbnQzMl90IGV4cGVjdGVkR1RLVG9vbEtpdFZlcnNp b24gPSAyOwogCi0gICAgICAgICAgIFJlZlB0cjxOZXRzY2FwZVBsdWdpbj4gcGx1Z2luID0gTmV0 c2NhcGVQbHVnaW46OmZyb21OUFAobnBwKTsKLSAgICAgICAgICAgKnJlaW50ZXJwcmV0X2Nhc3Q8 dWludDMyX3QqPih2YWx1ZSkgPSBwbHVnaW4tPnF1aXJrcygpLmNvbnRhaW5zKFBsdWdpblF1aXJr czo6UmVxdWlyZXNHVEtUb29sS2l0KSA/Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXhwZWN0ZWRHVEtUb29sS2l0VmVyc2lvbiA6IDA7CisgICAgICAg ICAgIC8vIENoZWF0IHRoZSBHVEsgdmVyc2lvbiBpZiB3ZSBub3cgdGhhdCB0aGlzIHBsdWdpbiBu ZWVkcyBpdCBvciBpZiB0aGUgcGx1Z2luIGNhbGwgdXMKKyAgICAgICAgICAgLy8gd2l0aCBhIG51 bGwgaW5zdGFuY2UuIFRoZSBsYXR0ZXIgaXMgdGhlIGNhc2Ugd2l0aCBOU1BsdWdpbldyYXBwZXIg cGx1Z2lucy4KKyAgICAgICAgICAgYm9vbCBuZWVkVG9DaGVhdEdUS1ZlcnNpb247CisgICAgICAg ICAgIGlmICghbnBwKQorICAgICAgICAgICAgICAgbmVlZFRvQ2hlYXRHVEtWZXJzaW9uID0gdHJ1 ZTsKKyAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICBSZWZQdHI8TmV0c2NhcGVQbHVn aW4+IHBsdWdpbiA9IE5ldHNjYXBlUGx1Z2luOjpmcm9tTlBQKG5wcCk7CisgICAgICAgICAgICAg ICBuZWVkVG9DaGVhdEdUS1ZlcnNpb24gPSBwbHVnaW4tPnF1aXJrcygpLmNvbnRhaW5zKFBsdWdp blF1aXJrczo6UmVxdWlyZXNHVEtUb29sS2l0KTsKKyAgICAgICAgICAgfQorCisgICAgICAgICAg ICpyZWludGVycHJldF9jYXN0PHVpbnQzMl90Kj4odmFsdWUpID0gbmVlZFRvQ2hlYXRHVEtWZXJz aW9uID8gZXhwZWN0ZWRHVEtUb29sS2l0VmVyc2lvbiA6IDA7CiAgICAgICAgICAgIGJyZWFrOwog ICAgICAgIH0KIAo= 90707 2011-04-22 07:36:54 -0700 2011-04-22 09:43:40 -0700 Patch bug-59125-20110422163652.patch text/plain 2258 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1MTNlYmNhNmQ5OGY0Yzdk OWQyOTBmYTI2ZGRkMDMzMmNjM2UzMGZkLi40MGQ0ZGU2OTlkZmFkNjk4ODFjNzgwNjM1YzhhNjZl MmVkZWJiMjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjIgIEJhbGF6 cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBDYW5ub3QgcGxheSBmbGFzaCB3aXRo IE5TUGx1Z2luV3JhcHBlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTkxMjUKKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5QTl9HZXRWYWx1ZSk6 IEhhbmRsZSB0aGUgY2FzZSB3aGVuIHdlIGhhdmUgYmVlbgorICAgICAgICBjYWxsZWQgd2l0aCBh IG51bGwgcGx1Z2luIGluc3RhbmNlLgorCiAyMDExLTA0LTIwICBEb21pbmljIENvb25leSAgPGRv bWluaWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcAppbmRleCBhNTQ4ZmQ2Mjgz OThjNDg0ZWU4YTFmZWNhZjVjYmViMDllNTcwOGJjLi43YzZiNGJjMzE1MDY4NmE3NzgzNmNmNzQy ZWExMjFhYzI1Y2M5MGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAK QEAgLTUxMCw5ICs1MTAsMTcgQEAgc3RhdGljIE5QRXJyb3IgTlBOX0dldFZhbHVlKE5QUCBucHAs IE5QTlZhcmlhYmxlIHZhcmlhYmxlLCB2b2lkICp2YWx1ZSkKICAgICAgICBjYXNlIE5QTlZUb29s a2l0OiB7CiAgICAgICAgICAgIGNvbnN0IHVpbnQzMl90IGV4cGVjdGVkR1RLVG9vbEtpdFZlcnNp b24gPSAyOwogCi0gICAgICAgICAgIFJlZlB0cjxOZXRzY2FwZVBsdWdpbj4gcGx1Z2luID0gTmV0 c2NhcGVQbHVnaW46OmZyb21OUFAobnBwKTsKLSAgICAgICAgICAgKnJlaW50ZXJwcmV0X2Nhc3Q8 dWludDMyX3QqPih2YWx1ZSkgPSBwbHVnaW4tPnF1aXJrcygpLmNvbnRhaW5zKFBsdWdpblF1aXJr czo6UmVxdWlyZXNHVEtUb29sS2l0KSA/Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXhwZWN0ZWRHVEtUb29sS2l0VmVyc2lvbiA6IDA7CisgICAgICAg ICAgIC8vIFNldCB0aGUgZXhwZWN0ZWQgR1RLIHZlcnNpb24gaWYgd2Uga25vdyB0aGF0IHRoaXMg cGx1Z2luIG5lZWRzIGl0IG9yIGlmIHRoZSBwbHVnaW4gY2FsbCB1cworICAgICAgICAgICAvLyB3 aXRoIGEgbnVsbCBpbnN0YW5jZS4gVGhlIGxhdHRlciBpcyB0aGUgY2FzZSB3aXRoIE5TUGx1Z2lu V3JhcHBlciBwbHVnaW5zLgorICAgICAgICAgICBib29sIHJlcXVpcmVzR1RLVG9vbEtpdFZlcnNp b247CisgICAgICAgICAgIGlmICghbnBwKQorICAgICAgICAgICAgICAgcmVxdWlyZXNHVEtUb29s S2l0VmVyc2lvbiA9IHRydWU7CisgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgUmVm UHRyPE5ldHNjYXBlUGx1Z2luPiBwbHVnaW4gPSBOZXRzY2FwZVBsdWdpbjo6ZnJvbU5QUChucHAp OworICAgICAgICAgICAgICAgcmVxdWlyZXNHVEtUb29sS2l0VmVyc2lvbiA9IHBsdWdpbi0+cXVp cmtzKCkuY29udGFpbnMoUGx1Z2luUXVpcmtzOjpSZXF1aXJlc0dUS1Rvb2xLaXQpOworICAgICAg ICAgICB9CisKKyAgICAgICAgICAgKnJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPih2YWx1ZSkg PSByZXF1aXJlc0dUS1Rvb2xLaXRWZXJzaW9uID8gZXhwZWN0ZWRHVEtUb29sS2l0VmVyc2lvbiA6 IDA7CiAgICAgICAgICAgIGJyZWFrOwogICAgICAgIH0KIAo=