59112 2011-04-21 10:22:35 -0700 [chromium] Don't upload partially drawn tiles in the compositor 2011-04-21 13:19:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr nduca vangelis oldest_to_newest 390121 0 enne 2011-04-21 10:22:35 -0700 [chromium] Don't upload partially drawn tiles in the compositor 390156 1 90557 enne 2011-04-21 10:53:45 -0700 Created attachment 90557 Patch 390168 2 enne 2011-04-21 11:11:41 -0700 This corresponds to http://crbug.com/79960. What was happening is this convoluted chain of events: Content layer passes some update rect to update. Update function finds all the tiles that intersect that rect. Paint rect is calculated from the union of the dirty rects of those tiles. Upload function finds all the tiles that intersects with that paint rect. Because of tile border texels, the set of tiles intersecting the paint rect is larger than that of the set of tiles intersecting the update rect. One of these tiles that was not in the update rect but in the paint rect only partially intersects the paint rect. Part of the tile is uploaded even though more of it is dirty. The tile's dirty rect is cleared even though only part of the tile has been uploaded. The tile has been partially modified, so it looks wrong. The real problem is that we're trying to upload data for tiles that we didn't intend to update. If we had intended to upload data for them, we would have painted their entire dirty rect. So the simplest fix is to iterate over the same set of tiles in both update and upload. 390200 3 90557 jamesr 2011-04-21 11:39:38 -0700 Comment on attachment 90557 Patch Bleh 390280 4 enne 2011-04-21 13:19:48 -0700 Committed r84542: <http://trac.webkit.org/changeset/84542> 90557 2011-04-21 10:53:45 -0700 2011-04-21 11:39:38 -0700 Patch bug-59112-20110421105344.patch text/plain 5564 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQ1MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNTBlMDdmYjY3YTVmOWI2 Yjk1YWJhZDg3MTg3NDc3NzlmODlmZjE4Li5lMzE5OGYxZjJjNzMwZjVlN2U4ZGVlODI0YTQ2MDky YjM2YTM5Mzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDQtMjEgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIERvbid0IHVwbG9hZCBwYXJ0aWFsbHkg ZHJhd24gdGlsZXMgaW4gdGhlIGNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MTEyCisKKyAgICAgICAgVXNlIHRoZSBzYW1lIHNldCBv ZiB0aWxlcyBmb3IgcGFpbnRpbmcgYXMgaXMgdXNlZCBmb3IgdXBkYXRpbmcuCisgICAgICAgIEJl Zm9yZSwgYSBsYXJnZXIgc2V0IG9mIHRpbGVzIHdlcmUgYmVpbmcgdXBsb2FkZWQsIGNhdXNpbmcg c29tZSB0bworICAgICAgICBvbmx5IGJlIHBhcnRpYWxseSB1bmRpcnRpZWQgYmVjYXVzZSB0aGV5 IHdlcmUgbm90IGZ1bGx5IHBhaW50ZWQuCisgICAgICAgIEFzIHRpbGVzIGFyZSBjbGVhciB0aGVp ciBkaXJ0eSByZWN0IGFmdGVyIGJlaW5nIHVucGFpbnRlZCwgdGhpcyBjYXVzZWQKKyAgICAgICAg YXJ0aWZhY3RzIHRvIGFwcGVhciB3aGVuIHNjcm9sbGluZy4KKworICAgICAgICBVbmZvcnR1bmF0 ZWx5LCBubyBsYXlvdXQgdGVzdCBjYW4gdGVzdCB0aGlzIGJlaGF2aW9yIHlldCBiZWNhdXNlCisg ICAgICAgIHNjcm9sbGluZyBpbnZhbGlkYXRpb25zIGFyZSBkb25lIGRpZmZlcmVudGx5IGluIHRl c3Qgc2hlbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxh eWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VMYXllckNocm9taXVtOjp1 cGRhdGVDb21wb3NpdG9yUmVzb3VyY2VzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJU aWxlckNocm9taXVtOjp1cGRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJUaWxlckNocm9t aXVtOjp1cGxvYWRDYW52YXMpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJUaWxlckNocm9taXVt Ojp1cGRhdGVGcm9tUGl4ZWxzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9MYXllclRpbGVyQ2hyb21pdW0uaDoKKwogMjAxMS0wNC0yMCAgTWF0dGhldyBEZWxhbmV5ICA8 bWRlbGFuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93 aWFrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vSW1hZ2VMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggZDcyZmIxZWZhOGY5OTBk NDAwMTA4YmU0NjFlMzk0ZmQwMGE5ZTg5Yy4uNTU1NzNjY2VkODUzNzc3MzdkNmI5ZmY4ODM1OTFl Y2ZmYTNiNDNjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uY3BwCkBAIC04Niw3ICs4 Niw3IEBAIHZvaWQgSW1hZ2VMYXllckNocm9taXVtOjp1cGRhdGVDb21wb3NpdG9yUmVzb3VyY2Vz KCkKICAgICAgICAgbV90aWxlci0+aW52YWxpZGF0ZVJlY3QocGFpbnRSZWN0KTsKICAgICAgICAg bV9kaXJ0eVJlY3QgPSBJbnRSZWN0KCk7CiAgICAgfQotICAgIG1fdGlsZXItPnVwZGF0ZUZyb21Q aXhlbHMocGFpbnRSZWN0LCBtX2RlY29kZWRJbWFnZS5waXhlbHMoKSk7CisgICAgbV90aWxlci0+ dXBkYXRlRnJvbVBpeGVscyhwYWludFJlY3QsIHBhaW50UmVjdCwgbV9kZWNvZGVkSW1hZ2UucGl4 ZWxzKCkpOwogfQogCiBJbnRSZWN0IEltYWdlTGF5ZXJDaHJvbWl1bTo6bGF5ZXJCb3VuZHMoKSBj b25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAKaW5kZXggNTRjNmFjMmI2OGFjYjUy YWNhODk2ZDUzYWMyYzAxZGU4MGMzZDA2My4uZTM3MDY5NjczNGM4NTI3ZmUzNWE5MTY0ODVmYjlj NjdkMjE4MmEzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCkBAIC0yNTIsMTAg KzI1MiwxNCBAQCB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlKFRpbGVQYWludEludGVy ZmFjZSYgcGFpbnRlciwgY29uc3QgSW50UmVjdCYgY29udAogICAgICAgICB9CiAgICAgfQogCi0g ICAgaWYgKGRpcnR5TGF5ZXJSZWN0LmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOworICAgIC8v IER1ZSB0byBib3JkZXJzLCB3aGVuIHRoZSBwYWludCByZWN0IGlzIGV4dGVuZGVkIHRvIHRpbGUg Ym91bmRhcmllcywgaXQKKyAgICAvLyBtYXkgZW5kIHVwIG92ZXJsYXBwaW5nIG1vcmUgdGlsZXMg dGhhbiB0aGUgb3JpZ2luYWwgY29udGVudCByZWN0LiBSZWNvcmQKKyAgICAvLyB0aGF0IG9yaWdp bmFsIHJlY3Qgc28gd2UgZG9uJ3QgdXBsb2FkIG1vcmUgdGlsZXMgdGhhbiBuZWNlc3NhcnkuCisg ICAgbV91cGRhdGVSZWN0ID0gY29udGVudFJlY3Q7CiAKICAgICBtX3BhaW50UmVjdCA9IGxheWVy UmVjdFRvQ29udGVudFJlY3QoZGlydHlMYXllclJlY3QpOworICAgIGlmIChkaXJ0eUxheWVyUmVj dC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKIAogICAgIG1fY2FudmFzLnJlc2l6ZShtX3Bh aW50UmVjdC5zaXplKCkpOwogCkBAIC0yNzYsMTEgKzI4MCwxMSBAQCB2b2lkIExheWVyVGlsZXJD aHJvbWl1bTo6dXBsb2FkQ2FudmFzKCkKICAgICBQbGF0Zm9ybUNhbnZhczo6QXV0b0xvY2tlciBs b2NrZXIoJm1fY2FudmFzKTsKICAgICB7CiAgICAgICAgIFRSQUNFX0VWRU5UKCJMYXllclRpbGVy Q2hyb21pdW06OnVwZGF0ZUZyb21QaXhlbHMiLCB0aGlzLCAwKTsKLSAgICAgICAgdXBkYXRlRnJv bVBpeGVscyhtX3BhaW50UmVjdCwgbG9ja2VyLnBpeGVscygpKTsKKyAgICAgICAgdXBkYXRlRnJv bVBpeGVscyhtX3VwZGF0ZVJlY3QsIG1fcGFpbnRSZWN0LCBsb2NrZXIucGl4ZWxzKCkpOwogICAg IH0KIH0KIAotdm9pZCBMYXllclRpbGVyQ2hyb21pdW06OnVwZGF0ZUZyb21QaXhlbHMoY29uc3Qg SW50UmVjdCYgcGFpbnRSZWN0LCBjb25zdCB1aW50OF90KiBwYWludFBpeGVscykKK3ZvaWQgTGF5 ZXJUaWxlckNocm9taXVtOjp1cGRhdGVGcm9tUGl4ZWxzKGNvbnN0IEludFJlY3QmIGNvbnRlbnRS ZWN0LCBjb25zdCBJbnRSZWN0JiBwYWludFJlY3QsIGNvbnN0IHVpbnQ4X3QqIHBhaW50UGl4ZWxz KQogewogICAgIC8vIFBhaW50aW5nIGNvdWxkIGNhdXNlIGNvbXBvc2l0aW5nIHRvIGdldCB0dXJu ZWQgb2ZmLCB3aGljaCBtYXkgY2F1c2UgdGhlIHRpbGVyIHRvIGJlY29tZSBpbnZhbGlkYXRlZCBt aWQtdXBkYXRlLgogICAgIGlmICghbV90aWxpbmdEYXRhLnRvdGFsU2l6ZVgoKSB8fCAhbV90aWxp bmdEYXRhLnRvdGFsU2l6ZVkoKSkKQEAgLTI4OSw3ICsyOTMsNyBAQCB2b2lkIExheWVyVGlsZXJD aHJvbWl1bTo6dXBkYXRlRnJvbVBpeGVscyhjb25zdCBJbnRSZWN0JiBwYWludFJlY3QsIGNvbnN0 IHVpbnQ4XwogICAgIEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0ID0gbGF5ZXJSZW5kZXJlckNv bnRleHQoKTsKIAogICAgIGludCBsZWZ0LCB0b3AsIHJpZ2h0LCBib3R0b207Ci0gICAgY29udGVu dFJlY3RUb1RpbGVJbmRpY2VzKHBhaW50UmVjdCwgbGVmdCwgdG9wLCByaWdodCwgYm90dG9tKTsK KyAgICBjb250ZW50UmVjdFRvVGlsZUluZGljZXMoY29udGVudFJlY3QsIGxlZnQsIHRvcCwgcmln aHQsIGJvdHRvbSk7CiAgICAgZm9yIChpbnQgaiA9IHRvcDsgaiA8PSBib3R0b207ICsraikgewog ICAgICAgICBmb3IgKGludCBpID0gbGVmdDsgaSA8PSByaWdodDsgKytpKSB7CiAgICAgICAgICAg ICBUaWxlKiB0aWxlID0gdGlsZUF0KGksIGopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaApp bmRleCAxMTFkZDdlZDExNWFlMjY4MmJhZjNmZjhlODdmYWVmYmRkODQ1ZjZiLi4wYWE5YTRhMDEy NzIwMjA3YjdmMWY2NTVmMzAyMDUyZmQ5ZmViMDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21p dW0uaApAQCAtNjgsNyArNjgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGxvYWRDYW52YXMoKTsK IAogICAgIC8vIFJlc2VydmUgYW5kIHVwbG9hZCB0aWxlIHRleHR1cmVzIGZyb20gYW4gZXh0ZXJu YWxseSBwYWludGVkIGJ1ZmZlci4KLSAgICB2b2lkIHVwZGF0ZUZyb21QaXhlbHMoY29uc3QgSW50 UmVjdCYgcGFpbnRSZWN0LCBjb25zdCB1aW50OF90KiBwaXhlbHMpOworICAgIHZvaWQgdXBkYXRl RnJvbVBpeGVscyhjb25zdCBJbnRSZWN0JiBjb250ZW50UmVjdCwgY29uc3QgSW50UmVjdCYgcGFp bnRSZWN0LCBjb25zdCB1aW50OF90KiBwaXhlbHMpOwogCiAgICAgLy8gRHJhdyBhbGwgdGlsZXMg dGhhdCBpbnRlcnNlY3Qgd2l0aCB0aGUgY29udGVudCByZWN0LgogICAgIHZvaWQgZHJhdyhjb25z dCBJbnRSZWN0JiBjb250ZW50UmVjdCwgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmLCBmbG9h dCBvcGFjaXR5KTsKQEAgLTE2MSw3ICsxNjEsOSBAQCBwcml2YXRlOgogICAgIC8vIFRpZ2h0bHkg cGFja2VkIHNldCBvZiB1bnVzZWQgdGlsZXMuCiAgICAgVmVjdG9yPFJlZlB0cjxUaWxlPiA+IG1f dW51c2VkVGlsZXM7CiAKKyAgICAvLyBTdGF0ZSBoZWxkIGJldHdlZW4gdXBkYXRlIGFuZCB1cGxv YWRDYW52YXMuCiAgICAgSW50UmVjdCBtX3BhaW50UmVjdDsKKyAgICBJbnRSZWN0IG1fdXBkYXRl UmVjdDsKICAgICBQbGF0Zm9ybUNhbnZhcyBtX2NhbnZhczsKIAogICAgIC8vIENhY2hlIGEgdGls ZS1zaXplZCBwaXhlbCBidWZmZXIgdG8gZHJhdyBpbnRvLgo=