59105 2011-04-21 08:24:00 -0700 Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor 2011-04-21 09:57:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 390047 0 caseq 2011-04-21 08:24:00 -0700 Many calls to WebInspector.ObjectPropertiesSection() are missing one of the arguments (apparently, empty placeholder). This results in "true" being shown for objects with no properties (i.e. in case when object's __proto__ === null). 390070 1 90544 caseq 2011-04-21 09:05:18 -0700 Created attachment 90544 patch 390072 2 90544 pfeldman 2011-04-21 09:08:52 -0700 Comment on attachment 90544 patch View in context: https://bugs.webkit.org/attachment.cgi?id=90544&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:600 > + elem.appendChild(new WebInspector.ObjectPropertiesSection(obj, obj.description, null, null, false).element); Just trim the call site here and in all changes below. 390097 3 caseq 2011-04-21 09:57:27 -0700 Manually committed r84510: http://trac.webkit.org/changeset/84510 90544 2011-04-21 09:05:18 -0700 2011-04-21 09:08:52 -0700 patch object-properties.diff text/plain 4105 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNzI4NzFmLi42ZjlhZmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDQtMjEgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBmaXggY2FsbHMgdG8gV2ViSW5zcGVjdG9yLk9iamVjdFByb3BlcnRpZXNTZWN0aW9uIGNv bnN0cnVjdG9yCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IGNhbGxzIHRvIFdlYkluc3Bl Y3Rvci5PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbiBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkxMDUKKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLl9mb3Jt YXRvYmplY3QpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uUGFuZWwu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uU2lkZWJhclBhbmUucHJvdG90eXBl Ll9zZXRPYmplY3QpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VKU09O Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZUpTT05WaWV3LnBhcnNlSlNP Ti5XZWJJbnNwZWN0b3IuUmVzb3VyY2VKU09OVmlldy5wcm90b3R5cGUuX2luaXRpYWxpemUpOgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9zaG93UG9wdXAuc2hvd09iamVjdFBv cHVwKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuX3Nob3dQ b3B1cCk6CisKIDIwMTEtMDQtMjAgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKaW5kZXggNGFiMTZkOS4u YWVlMmJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9D b25zb2xlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv bnNvbGVWaWV3LmpzCkBAIC01OTcsNyArNTk3LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZSA9IHsKIAogICAgIF9mb3JtYXRvYmplY3Q6IGZ1bmN0aW9uKG9iaiwgZWxlbSkK ICAgICB7Ci0gICAgICAgIGVsZW0uYXBwZW5kQ2hpbGQobmV3IFdlYkluc3BlY3Rvci5PYmplY3RQ cm9wZXJ0aWVzU2VjdGlvbihvYmosIG9iai5kZXNjcmlwdGlvbiwgbnVsbCwgdHJ1ZSkuZWxlbWVu dCk7CisgICAgICAgIGVsZW0uYXBwZW5kQ2hpbGQobmV3IFdlYkluc3BlY3Rvci5PYmplY3RQcm9w ZXJ0aWVzU2VjdGlvbihvYmosIG9iai5kZXNjcmlwdGlvbiwgbnVsbCwgbnVsbCwgZmFsc2UpLmVs ZW1lbnQpOwogICAgIH0sCiAKICAgICBfZm9ybWF0bm9kZTogZnVuY3Rpb24ob2JqZWN0LCBlbGVt KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNp b25QYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9u UGFuZWwuanMKaW5kZXggOGIyMzBkNS4uMjEzNTI5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25QYW5lbC5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpzCkBAIC0xMTUsNyArMTE1 LDcgQEAgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblNpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAg ICBfc2V0T2JqZWN0OiBmdW5jdGlvbihvYmplY3QsIHRpdGxlKQogICAgIHsKICAgICAgICAgdGhp cy5ib2R5RWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwotICAgICAgICB2YXIgc2VjdGlvbiA9IG5l dyBXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydGllc1NlY3Rpb24ob2JqZWN0LCB0aXRsZSwgbnVs bCwgdHJ1ZSk7CisgICAgICAgIHZhciBzZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5PYmplY3RQ cm9wZXJ0aWVzU2VjdGlvbihvYmplY3QsIHRpdGxlLCBudWxsLCBudWxsLCBmYWxzZSk7CiAgICAg ICAgIGlmICghdGl0bGUpCiAgICAgICAgICAgICBzZWN0aW9uLmhlYWRlckVsZW1lbnQuYWRkU3R5 bGVDbGFzcygiaGlkZGVuIik7CiAgICAgICAgIHNlY3Rpb24uZXhwYW5kZWQgPSB0cnVlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZUpTT05W aWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZUpTT05W aWV3LmpzCmluZGV4IDY5NGIxMDAuLmI1NTE5OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VKU09OVmlldy5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlSlNPTlZpZXcuanMKQEAgLTY4LDcgKzY4 LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlSlNPTlZpZXcucHJvdG90eXBlID0gewogICAgICAg ICB0aGlzLl9pbml0aWFsaXplZCA9IHRydWU7CiAKICAgICAgICAgdmFyIG9iaiA9IFdlYkluc3Bl Y3Rvci5SZW1vdGVPYmplY3QuZnJvbUxvY2FsT2JqZWN0KHRoaXMuX3BhcnNlZEpTT04pOwotICAg ICAgICB0aGlzLmVsZW1lbnQuYXBwZW5kQ2hpbGQobmV3IFdlYkluc3BlY3Rvci5PYmplY3RQcm9w ZXJ0aWVzU2VjdGlvbihvYmosIG9iai5kZXNjcmlwdGlvbiwgbnVsbCwgdHJ1ZSkuZWxlbWVudCk7 CisgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZChuZXcgV2ViSW5zcGVjdG9yLk9iamVj dFByb3BlcnRpZXNTZWN0aW9uKG9iaiwgb2JqLmRlc2NyaXB0aW9uLCBudWxsLCBudWxsLCBmYWxz ZSkuZWxlbWVudCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwppbmRleCBjNjZlNGQ1Li41ZmNmNmI1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKQEAg LTgyNCw3ICs4MjQsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlID0gewog ICAgICAgICAgICAgICAgIHRpdGxlRWxlbWVudC50ZXh0Q29udGVudCA9IHJlc3VsdC5kZXNjcmlw dGlvbjsKICAgICAgICAgICAgICAgICBwb3B1cENvbnRlbnRFbGVtZW50LmFwcGVuZENoaWxkKHRp dGxlRWxlbWVudCk7CiAKLSAgICAgICAgICAgICAgICB2YXIgc2VjdGlvbiA9IG5ldyBXZWJJbnNw ZWN0b3IuT2JqZWN0UHJvcGVydGllc1NlY3Rpb24ocmVzdWx0LCAiIiwgbnVsbCwgZmFsc2UpOwor ICAgICAgICAgICAgICAgIHZhciBzZWN0aW9uID0gbmV3IFdlYkluc3BlY3Rvci5PYmplY3RQcm9w ZXJ0aWVzU2VjdGlvbihyZXN1bHQsICIiLCBudWxsLCBudWxsLCBmYWxzZSk7CiAgICAgICAgICAg ICAgICAgc2VjdGlvbi5leHBhbmRlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgc2VjdGlvbi5l bGVtZW50LmFkZFN0eWxlQ2xhc3MoInNvdXJjZS1mcmFtZS1wb3BvdmVyLXRyZWUiKTsKICAgICAg ICAgICAgICAgICBzZWN0aW9uLmhlYWRlckVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7 Cg==