59091 2011-04-21 05:58:40 -0700 [EFL] Remove ewk_eapi.h 2011-04-25 11:07:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned abarth commit-queue eric gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 389958 0 ryuan.choi 2011-04-21 05:58:40 -0700 IMO, ewk_eapi.h is just for EAPI macro provided by Eina. 389961 1 90518 ryuan.choi 2011-04-21 06:03:03 -0700 Created attachment 90518 Patch 390479 2 gyuyoung.kim 2011-04-21 17:16:05 -0700 LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? 390516 3 ryuan.choi 2011-04-21 18:19:14 -0700 (In reply to comment #2) > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? Does we need to change visibility? Although we need, it will not work well because Eina.h will redefine EAPI. About other macro, we can make better one at that time if needed. ewk_eapi.h looks just for eapi. 390527 4 gyuyoung.kim 2011-04-21 18:39:33 -0700 (In reply to comment #3) > (In reply to comment #2) > > LGTM. BTW, if we want to change EAPI visibility, how to change it ? And also, if we want to define additional macro to adjust ewk files, is it good to keep the file ? > > Does we need to change visibility? > Although we need, it will not work well because Eina.h will redefine EAPI. > > About other macro, > we can make better one at that time if needed. > ewk_eapi.h looks just for eapi. OK, LGTM. 391739 5 90518 commit-queue 2011-04-25 04:18:15 -0700 Comment on attachment 90518 Patch Clearing flags on attachment: 90518 Committed r84771: <http://trac.webkit.org/changeset/84771> 391740 6 commit-queue 2011-04-25 04:18:20 -0700 All reviewed patches have been landed. Closing bug. 391839 7 webkit.review.bot 2011-04-25 11:07:16 -0700 http://trac.webkit.org/changeset/84771 might have broken SnowLeopard Intel Release (WebKit2 Tests) 90518 2011-04-21 06:03:03 -0700 2011-04-25 04:18:15 -0700 Patch bug-59091-20110421220259.patch text/plain 7033 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBhYWM4Mjk4ZDAy YjM2NDEwYjMwZjI4ODE1NGI3OGRjYjU0YjRkZjUxLi4xODMzY2IyYTkxMWIxOTdiZWExNGM1OTg2 OGIzZjM3MzE1NDJmMTc5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEt MDQtMjEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSBld2tfZWFw aS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTA5 MQorCisgICAgICAgICogZXdrL0VXZWJLaXQuaDoKKyAgICAgICAgKiBld2svZXdrX2NvbnRleHRt ZW51Lmg6CisgICAgICAgICogZXdrL2V3a19jb29raWVzLmg6CisgICAgICAgICogZXdrL2V3a19l YXBpLmg6IFJlbW92ZWQuCisgICAgICAgICogZXdrL2V3a19mcmFtZS5oOgorICAgICAgICAqIGV3 ay9ld2tfaGlzdG9yeS5oOgorICAgICAgICAqIGV3ay9ld2tfbWFpbi5oOgorICAgICAgICAqIGV3 ay9ld2tfc2V0dGluZ3MuaDoKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21hdHJpeC5oOgorICAg ICAgICAqIGV3ay9ld2tfdGlsZWRfbW9kZWwuaDoKKyAgICAgICAgKiBld2svZXdrX3dpbmRvd19m ZWF0dXJlcy5oOgorCiAyMDExLTA0LTE5ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svRVdlYktpdC5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L0VXZWJLaXQuaAppbmRleCA2ZDc0MWU5OWUwZWJhOTc1YTAxMTgzNTE3NTNlNDQzMTQ3ODRhMGY3 Li5kOTcyNDU0MzYyNmRmNzQ4MzE2ZGVjZjI1MzJmNDBjZTRmNjMyYTYwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svRVdlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9FV2ViS2l0LmgKQEAgLTMxLDcgKzMxLDYgQEAKIAogI2luY2x1ZGUgImV3a19jb250ZXh0bWVu dS5oIgogI2luY2x1ZGUgImV3a19jb29raWVzLmgiCi0jaW5jbHVkZSAiZXdrX2VhcGkuaCIKICNp bmNsdWRlICJld2tfZnJhbWUuaCIKICNpbmNsdWRlICJld2tfaGlzdG9yeS5oIgogI2luY2x1ZGUg ImV3a19tYWluLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRl eHRtZW51LmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmgKaW5kZXgg ZDllM2U4MzFhMDRlZThhMjlhMzg5OTJjYWZjZjczNjYyMTFkODQ0Ny4uYzlhMTE4MWY4ZDdkODc1 N2M1ZGE0MzQwZDU3MWRkZjc0M2IyM2Q3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19jb250ZXh0bWVudS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29u dGV4dG1lbnUuaApAQCAtMjYsOCArMjYsNiBAQAogI2lmbmRlZiBld2tfY29udGV4dG1lbnVfaAog I2RlZmluZSBld2tfY29udGV4dG1lbnVfaAogCi0jaW5jbHVkZSAiZXdrX2VhcGkuaCIKLQogI2lu Y2x1ZGUgPEVpbmEuaD4KICNpbmNsdWRlIDxFdmFzLmg+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfY29va2llcy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19j b29raWVzLmgKaW5kZXggZWMwZTg0ZjdkMzRkNTQ0NjI0NTBkMjU2ZTBjYjhlMzdiNWU0MDZhNC4u ZTc5NzFiYzlmZmE3MmY3N2I5NTIxOGYwNGEzYTc0OGU4ZDQ3ZjMzYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb29raWVzLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19jb29raWVzLmgKQEAgLTI2LDcgKzI2LDYgQEAKICNpZm5kZWYgZXdrX2Nvb2tpZXNf aAogI2RlZmluZSBld2tfY29va2llc19oCiAKLSNpbmNsdWRlICJld2tfZWFwaS5oIgogI2luY2x1 ZGUgPEVpbmEuaD4KIAogI2lmZGVmIF9fY3BsdXNwbHVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX2VhcGkuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZWFwaS5o CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAxMWY0MzcxZGY1YWFjNDlkNDJmZDNjZTkw NzNlMGI2NGNkYmYxYzgwLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZWFwaS5oCisrKyAvZGV2L251bGwKQEAg LTEsNTkgKzAsMCBAQAotLyoKLSAgICBDb3B5cmlnaHQgKEMpIDIwMDktMjAxMCBQcm9GVVNJT04g ZW1iZWRkZWQgc3lzdGVtcwotICAgIENvcHlyaWdodCAoQykgMjAwOS0yMDEwIFNhbXN1bmcgRWxl Y3Ryb25pY3MKLQotICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IKLSAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo ZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwotICAgIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5 IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgotICAgIHZlcnNpb24gMiBvZiB0 aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KLQotICAg IFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAotICAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBp bXBsaWVkIHdhcnJhbnR5IG9mCi0gICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKLSAgICBMaWJyYXJ5IEdlbmVyYWwgUHVi bGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KLQotICAgIFlvdSBzaG91bGQgaGF2ZSByZWNl aXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKLSAg ICBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAgSWYg bm90LCB3cml0ZSB0bwotICAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUx IEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCi0gICAgQm9zdG9uLCBNQSAwMjExMC0xMzAx LCBVU0EuCi0qLwotCi0vKioKLSAqIEBmaWxlICAgIGV3a19lYXBpLmgKLSAqIEBicmllZiAgIERl ZmluZXMgRUFQSSBtYWNyby4KLSAqCi0gKiBUaGUgbWFjcm8gbXVzdCBiZSB1c2VkIGluIGRlY2xh cmF0aW9uIG9mIHB1YmxpYyBmdW5jdGlvbnMuCi0gKiBGdW5jdGlvbnMgd2l0aG91dCBFQVBJIG1h Y3JvIGhhdmUgaGlkZGVuIG1vc3Qgb2Ygc3ltYm9scyBhbmQKLSAqIHRoZXkgYXJlIG5vdCB2aXNp YmxlIGZvciB0YXJnZXQgYXBwbGljYXRpb25zLgotICovCi0KLSNpZm5kZWYgZXdrX2VhcGlfaAot I2RlZmluZSBld2tfZWFwaV9oCi0KLSNpZmRlZiBFQVBJCi0jIHVuZGVmIEVBUEkKLSNlbmRpZgot Ci0jaWZkZWYgX1dJTjMyCi0jIGlmZGVmIEJVSUxESU5HX1dFQktJVAotIyAgaWZkZWYgRExMX0VY UE9SVAotIyAgIGRlZmluZSBFQVBJIF9fZGVjbHNwZWMoZGxsZXhwb3J0KQotIyAgZWxzZQotIyAg IGRlZmluZSBFQVBJCi0jICBlbmRpZiAvKiAhIERMTF9FWFBPUlQgKi8KLSMgZWxzZQotIyAgZGVm aW5lIEVBUEkgX19kZWNsc3BlYyhkbGxpbXBvcnQpCi0jIGVuZGlmIC8qICEgRUZMX0VJTkFfQlVJ TEQgKi8KLSNlbHNlCi0jIGlmZGVmIF9fR05VQ19fCi0jICBpZiBfX0dOVUNfXyA+PSA0Ci0jICAg ZGVmaW5lIEVBUEkgX19hdHRyaWJ1dGVfXyAoKHZpc2liaWxpdHkoImRlZmF1bHQiKSkpCi0jICBl bHNlCi0jICAgZGVmaW5lIEVBUEkKLSMgIGVuZGlmCi0jIGVsc2UKLSMgIGRlZmluZSBFQVBJCi0j IGVuZGlmCi0jZW5kaWYKLQotI2VuZGlmIC8vIGV3a19lYXBpX2gKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf ZnJhbWUuaAppbmRleCA2MzkzNmYzZjlmMWE5YzJkMzMzNDJkYjJkMTllODc2NmJmZGE2MDNkLi5h NWNlMTlmYzdkNzM5ZmQxZDljYzJjMTBkNDRkZmNiNTEyM2YzMWUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19mcmFtZS5oCkBAIC0yMSw3ICsyMSw2IEBACiAjaWZuZGVmIGV3a19mcmFtZV9oCiAjZGVm aW5lIGV3a19mcmFtZV9oCiAKLSNpbmNsdWRlICJld2tfZWFwaS5oIgogI2luY2x1ZGUgPEV2YXMu aD4KIAogI2lmZGVmIF9fY3BsdXNwbHVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX2hpc3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5oCmlu ZGV4IDNjYWU3NGVjYzg5MDZkNjE0MDc2Nzk2ZjA5NWMyNzI2ZTFhYTcxNWYuLjg1NjMxZmMzNzZj NmQzOWZjYTdhYWFkNzU2NzkyN2Y0MmU4ZDM4NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfaGlzdG9yeS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlz dG9yeS5oCkBAIC0yMSw4ICsyMSw2IEBACiAjaWZuZGVmIGV3a19oaXN0b3J5X2gKICNkZWZpbmUg ZXdrX2hpc3RvcnlfaAogCi0jaW5jbHVkZSAiZXdrX2VhcGkuaCIKLQogI2luY2x1ZGUgPEVpbmEu aD4KICNpbmNsdWRlIDxFdmFzLmg+CiAjaW5jbHVkZSA8Y2Fpcm8uaD4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19tYWluLmgKaW5kZXggMjU3YmFiY2RjOTRkNzVkNWYxNjg1ZTYyYjhiYTBkZjdmZTczOGI0Yi4u ZWQ4NGFjOWU1OTQ5MjBmOGE1YzRiNjhmNWQ4MDA5NThkY2U2YjFkNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19tYWluLmgKQEAgLTI2LDcgKzI2LDcgQEAKICNpZm5kZWYgZXdrX21haW5faAogI2RlZmlu ZSBld2tfbWFpbl9oCiAKLSNpbmNsdWRlICJld2tfZWFwaS5oIgorI2luY2x1ZGUgPEVpbmEuaD4K IAogI2lmZGVmIF9fY3BsdXNwbHVzCiBleHRlcm4gIkMiIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf c2V0dGluZ3MuaAppbmRleCAwYmJkYjQ4ODhkN2ZiMGU5YmEwMjZmZWQyYzdjM2ZkNmRjNTVhZGZk Li4yZGRhMTYwYjFlOGYxYjUxNmMzM2YwZDZhNzUxMDBkNjE2YjVhMmUyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19zZXR0aW5ncy5oCkBAIC0yMSw4ICsyMSw2IEBACiAjaWZuZGVmIGV3a19zZXR0 aW5nc19oCiAjZGVmaW5lIGV3a19zZXR0aW5nc19oCiAKLSNpbmNsdWRlICJld2tfZWFwaS5oIgot CiAjaW5jbHVkZSA8RWluYS5oPgogI2luY2x1ZGUgPEV2YXMuaD4KICNpbmNsdWRlIDxjYWlyby5o PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguaCBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmgKaW5kZXggMDdiODYxMmE0 OTMxY2VlYTMwZjA5Zjk5MmRiZDJmNDU1NWE3N2RlYi4uYWNmNzkxMDY0ZGRhOThjNGM4ZjcwZDg3 NGVmODQxMzFkOTY0OTllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190 aWxlZF9tYXRyaXguaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJp eC5oCkBAIC0yMSw3ICsyMSw2IEBACiAjaWZuZGVmIGV3a190aWxlZF9tYXRyaXhfaAogI2RlZmlu ZSBld2tfdGlsZWRfbWF0cml4X2gKIAotI2luY2x1ZGUgImV3a19lYXBpLmgiCiAjaW5jbHVkZSAi ZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuaCIKIAogI2luY2x1ZGUgPEV2YXMuaD4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuaCBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuaAppbmRleCBhNTQ2Y2VlMmY0OTBkODY2MTM4ZDc0 M2Q2ZTY4MDYxYTkxYzA3MGQ4Li42NTI3NzBlYTgzYjM4MTljNDU4NDdhMDJjYTE0YTNhNzQ3MzI2 ZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5oCkBAIC0yMSw3ICsy MSw2IEBACiAjaWZuZGVmIGV3a190aWxlZF9tb2RlbF9oCiAjZGVmaW5lIGV3a190aWxlZF9tb2Rl bF9oCiAKLSNpbmNsdWRlICJld2tfZWFwaS5oIgogI2luY2x1ZGUgImV3a190aWxlZF9iYWNraW5n X3N0b3JlLmgiCiAKICNpbmNsdWRlIDxFdmFzLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3dpbmRvd19mZWF0dXJlcy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a193aW5kb3dfZmVhdHVyZXMuaAppbmRleCAwNTAxODgxZGIwM2Q1NzkzOTdiM2JkN2M0Zjc1YWM5 YmYxMWVjY2RlLi4wNGQ2ZjA0YzM1NmY5MGMwNWQyMzkwY2UwMDczMjgyYzJjMDM5M2M0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3dpbmRvd19mZWF0dXJlcy5oCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfd2luZG93X2ZlYXR1cmVzLmgKQEAgLTI2LDggKzI2 LDYgQEAKICNpZm5kZWYgZXdrX3dpbmRvd19mZWF0dXJlc19oCiAjZGVmaW5lIGV3a193aW5kb3df ZmVhdHVyZXNfaAogCi0jaW5jbHVkZSAiZXdrX2VhcGkuaCIKLQogI2luY2x1ZGUgPEVpbmEuaD4K IAogI2lmZGVmIF9fY3BsdXNwbHVzCg==