59060 2011-04-20 18:53:07 -0700 Remove redundant calls to RenderStyle::setDisplay() 2011-04-21 23:14:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 macpherson webkit-unassigned commit-queue dglazkov eric macpherson simon.fraser oldest_to_newest 389744 0 macpherson 2011-04-20 18:53:07 -0700 Remove redundant calls to RenderStyle::setDisplay() 389793 1 90482 macpherson 2011-04-20 20:25:19 -0700 Created attachment 90482 Patch 389795 2 90482 eric 2011-04-20 20:33:19 -0700 Comment on attachment 90482 Patch Why is the other setDisplay call not neccessary? 389798 3 macpherson 2011-04-20 20:41:25 -0700 (In reply to comment #2) > (From update of attachment 90482 [details]) > Why is the other setDisplay call not neccessary? The HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(display, Display) macro results in setDisplay(*primitiveValue). This is what makes the other subsequent identical calls in else cases redundant. 390631 4 90482 commit-queue 2011-04-21 23:14:04 -0700 Comment on attachment 90482 Patch Clearing flags on attachment: 90482 Committed r84603: <http://trac.webkit.org/changeset/84603> 390632 5 commit-queue 2011-04-21 23:14:08 -0700 All reviewed patches have been landed. Closing bug. 90482 2011-04-20 20:25:19 -0700 2011-04-21 23:14:04 -0700 Patch bug-59060-20110421132516.patch text/plain 2512 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NDU4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjAgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVkdW5kYW50IGNhbGxzIHRvIFJl bmRlclN0eWxlOjpzZXREaXNwbGF5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU5MDYwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gbm8gbmV3IGZ1 bmN0aW9uYWxpdHkgYWRkZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KToKKyAg ICAgICAgUmVtb3ZlIHJlZHVuZGFudCBjYWxscyB0byBSZW5kZXJTdHlsZTo6c2V0RGlzcGxheSgp CisKIDIwMTEtMDQtMjAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5 bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDg0NDU4KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NT U1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjA2LDIzICszNjA2LDE4IEBA IHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQKICAgICBjYXNlIENTU1By b3BlcnR5RGlzcGxheToKICAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUxfQU5EX1BS SU1JVElWRShkaXNwbGF5LCBEaXNwbGF5KQogI2lmIEVOQUJMRShXQ1NTKQotICAgICAgICBpZiAo cHJpbWl0aXZlVmFsdWUpIHsKLSAgICAgICAgICAgIGlmIChwcmltaXRpdmVWYWx1ZS0+Z2V0SWRl bnQoKSA9PSBDU1NWYWx1ZVdhcE1hcnF1ZWUpIHsKLSAgICAgICAgICAgICAgICAvLyBJbml0aWFs aXplIFdBUCBNYXJxdWVlIHN0eWxlCi0gICAgICAgICAgICAgICAgbV9zdHlsZS0+c2V0T3ZlcmZs b3dYKE9NQVJRVUVFKTsKLSAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRPdmVyZmxvd1koT01B UlFVRUUpOwotICAgICAgICAgICAgICAgIG1fc3R5bGUtPnNldFdoaXRlU3BhY2UoTk9XUkFQKTsK LSAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRNYXJxdWVlRGlyZWN0aW9uKE1MRUZUKTsKLSAg ICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRNYXJxdWVlU3BlZWQoODUpOyAvLyBOb3JtYWwgc3Bl ZWQKLSAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRNYXJxdWVlTG9vcENvdW50KDEpOwotICAg ICAgICAgICAgICAgIG1fc3R5bGUtPnNldE1hcnF1ZWVCZWhhdmlvcihNU0NST0xMKTsKKyAgICAg ICAgaWYgKHByaW1pdGl2ZVZhbHVlICYmIHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpID09IENT U1ZhbHVlV2FwTWFycXVlZSkgeworICAgICAgICAgICAgLy8gSW5pdGlhbGl6ZSBXQVAgTWFycXVl ZSBzdHlsZQorICAgICAgICAgICAgbV9zdHlsZS0+c2V0T3ZlcmZsb3dYKE9NQVJRVUVFKTsKKyAg ICAgICAgICAgIG1fc3R5bGUtPnNldE92ZXJmbG93WShPTUFSUVVFRSk7CisgICAgICAgICAgICBt X3N0eWxlLT5zZXRXaGl0ZVNwYWNlKE5PV1JBUCk7CisgICAgICAgICAgICBtX3N0eWxlLT5zZXRN YXJxdWVlRGlyZWN0aW9uKE1MRUZUKTsKKyAgICAgICAgICAgIG1fc3R5bGUtPnNldE1hcnF1ZWVT cGVlZCg4NSk7IC8vIE5vcm1hbCBzcGVlZAorICAgICAgICAgICAgbV9zdHlsZS0+c2V0TWFycXVl ZUxvb3BDb3VudCgxKTsKKyAgICAgICAgICAgIG1fc3R5bGUtPnNldE1hcnF1ZWVCZWhhdmlvcihN U0NST0xMKTsKIAotICAgICAgICAgICAgICAgIGlmIChtX3BhcmVudFN0eWxlKQotICAgICAgICAg ICAgICAgICAgICBtX3N0eWxlLT5zZXREaXNwbGF5KG1fcGFyZW50U3R5bGUtPmRpc3BsYXkoKSk7 Ci0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRE aXNwbGF5KCpwcmltaXRpdmVWYWx1ZSk7Ci0gICAgICAgICAgICB9IGVsc2UKLSAgICAgICAgICAg ICAgICBtX3N0eWxlLT5zZXREaXNwbGF5KCpwcmltaXRpdmVWYWx1ZSk7CisgICAgICAgICAgICBp ZiAobV9wYXJlbnRTdHlsZSkKKyAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXREaXNwbGF5KG1f cGFyZW50U3R5bGUtPmRpc3BsYXkoKSk7CiAgICAgICAgIH0KICNlbmRpZgogICAgICAgICByZXR1 cm47Cg==