59044 2011-04-20 17:16:42 -0700 [Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document. 2011-04-21 12:32:17 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 389661 0 kling 2011-04-20 17:16:42 -0700 SSIA 389666 1 90453 kling 2011-04-20 17:17:31 -0700 Created attachment 90453 Proposed patch 389667 2 webkit.review.bot 2011-04-20 17:20:15 -0700 Attachment 90453 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/ClientImpl.h:46: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/qt/ClientImpl.h:46: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/qt/ClientImpl.h:46: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 389926 3 90453 kenneth 2011-04-21 03:57:07 -0700 Comment on attachment 90453 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90453&action=review >>>> Source/WebKit2/UIProcess/API/qt/ClientImpl.h:46 >>>> +void qt_wk_didSameDocumentNavigationForFrame(WKPageRef page, WKFrameRef frame, WKSameDocumentNavigationType type, WKTypeRef userData, const void *clientInfo); >>> >>> The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] >> >> The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] > > The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] I agree with the style guide here :-) only clientInfo and userData brings value 390252 4 kling 2011-04-21 12:32:17 -0700 Committed r84539: <http://trac.webkit.org/changeset/84539> 90453 2011-04-20 17:17:31 -0700 2011-04-21 03:57:07 -0700 Proposed patch bug-59044.diff text/plain 3179 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzODhjZDdkLi4wOGMwYjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDQtMjAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdW1dL Ml0gRW1pdCBRV0tQYWdlOjp1cmxDaGFuZ2VkKCkgd2hlbiBuYXZpZ2F0aW5nIHdpdGhpbiB0aGUg c2FtZSBkb2N1bWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU5MDQ0CisKKyAgICAgICAgSG9vayB1cCB0aGUgZGlkU2FtZURvY3VtZW50TmF2aWdh dGlvbkZvckZyYW1lIGNhbGxiYWNrIHRvIFFXS1BhZ2U6OnVybENoYW5nZWQoKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChxdF93a19kaWRT YW1lRG9jdW1lbnROYXZpZ2F0aW9uRm9yRnJhbWUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6 CisgICAgICAgIChRV0tQYWdlOjpRV0tQYWdlKToKKwogMjAxMS0wNC0xOSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9u aW8gR29tZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L0Ns aWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9DbGllbnRJbXBs LmNwcAppbmRleCBiNDI3MDU4Li44MThiYWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L0NsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5jcHAKQEAgLTE3OSwzICsxNzksMTIgQEAgdm9pZCBxdF93 a19zZXRTdGF0dXNUZXh0KFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiB0ZXh0LCBjb25zdCB2 b2lkICpjbGllbnRJbmYKICAgICBRU3RyaW5nIHFUZXh0ID0gV0tTdHJpbmdDb3B5UVN0cmluZyh0 ZXh0KTsKICAgICBlbWl0IHRvUVdLUGFnZShjbGllbnRJbmZvKS0+c3RhdHVzQmFyTWVzc2FnZShx VGV4dCk7CiB9CisKK3ZvaWQgcXRfd2tfZGlkU2FtZURvY3VtZW50TmF2aWdhdGlvbkZvckZyYW1l KFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1NhbWVEb2N1bWVudE5hdmlnYXRp b25UeXBlIHR5cGUsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykK K3sKKyAgICBXZWJGcmFtZVByb3h5KiB3a2ZyYW1lID0gdG9JbXBsKGZyYW1lKTsKKyAgICBRU3Ry aW5nIHVybFN0cih3a2ZyYW1lLT51cmwoKSk7CisgICAgUVVybCBxVXJsID0gdXJsU3RyOworICAg IGVtaXQgdG9RV0tQYWdlKGNsaWVudEluZm8pLT51cmxDaGFuZ2VkKHFVcmwpOworICAgIFFXS1Bh Z2VQcml2YXRlOjpnZXQodG9RV0tQYWdlKGNsaWVudEluZm8pKS0+dXBkYXRlTmF2aWdhdGlvbkFj dGlvbnMoKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv Q2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9DbGllbnRJbXBs LmgKaW5kZXggNzk1NTE0NC4uMzA5YjAxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9DbGllbnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9DbGllbnRJbXBsLmgKQEAgLTQzLDYgKzQzLDcgQEAgdm9pZCBxdF93a19kaWRDaGFu Z2VQcm9ncmVzcyhXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pOwogdm9pZCBxdF93 a19kaWRGaW5pc2hQcm9ncmVzcyhXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pOwog dm9pZCBxdF93a19kaWRCZWNvbWVVbnJlc3BvbnNpdmUoV0tQYWdlUmVmLCBjb25zdCB2b2lkKiBj bGllbnRJbmZvKTsKIHZvaWQgcXRfd2tfZGlkQmVjb21lUmVzcG9uc2l2ZShXS1BhZ2VSZWYsIGNv bnN0IHZvaWQqIGNsaWVudEluZm8pOwordm9pZCBxdF93a19kaWRTYW1lRG9jdW1lbnROYXZpZ2F0 aW9uRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUsIFdLU2FtZURvY3Vt ZW50TmF2aWdhdGlvblR5cGUgdHlwZSwgV0tUeXBlUmVmIHVzZXJEYXRhLCBjb25zdCB2b2lkICpj bGllbnRJbmZvKTsKIAogLy8gdWkgY2xpZW50CiBXS1BhZ2VSZWYgcXRfd2tfY3JlYXRlTmV3UGFn ZShXS1BhZ2VSZWYgcGFnZSwgV0tEaWN0aW9uYXJ5UmVmIGZlYXR1cmVzLCBXS0V2ZW50TW9kaWZp ZXJzIG1vZGlmaWVycywgV0tFdmVudE1vdXNlQnV0dG9uIG1vdXNlQnV0dG9uLCBjb25zdCB2b2lk ICpjbGllbnRJbmZvKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXdrcGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2Uu Y3BwCmluZGV4IDdlYjc4ZGEuLjEwOWEwODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xd2twYWdlLmNwcApAQCAtNDMyLDcgKzQzMiw3IEBAIFFXS1BhZ2U6OlFXS1BhZ2Uo UVdLQ29udGV4dCogY29udGV4dCkKICAgICAgICAgcXRfd2tfZGlkRmluaXNoRG9jdW1lbnRMb2Fk Rm9yRnJhbWUsCiAgICAgICAgIHF0X3drX2RpZEZpbmlzaExvYWRGb3JGcmFtZSwKICAgICAgICAg cXRfd2tfZGlkRmFpbExvYWRXaXRoRXJyb3JGb3JGcmFtZSwKLSAgICAgICAgMCwgLyogZGlkU2Ft ZURvY3VtZW50TmF2aWdhdGlvbkZvckZyYW1lICovCisgICAgICAgIHF0X3drX2RpZFNhbWVEb2N1 bWVudE5hdmlnYXRpb25Gb3JGcmFtZSwKICAgICAgICAgcXRfd2tfZGlkUmVjZWl2ZVRpdGxlRm9y RnJhbWUsCiAgICAgICAgIHF0X3drX2RpZEZpcnN0TGF5b3V0Rm9yRnJhbWUsCiAgICAgICAgIHF0 X3drX2RpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lLAo=