<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>59016</bug_id>
          
          <creation_ts>2011-04-20 12:11:59 -0700</creation_ts>
          <short_desc>put unexpected passes into their own table</short_desc>
          <delta_ts>2011-04-21 11:24:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Ojan Vafai">ojan</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>389416</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-20 12:11:59 -0700</bug_when>
    <thetext>put unexpected passes into their own table</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389418</commentid>
    <comment_count>1</comment_count>
      <attachid>90382</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-20 12:14:08 -0700</bug_when>
    <thetext>Created attachment 90382
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389425</commentid>
    <comment_count>2</comment_count>
      <attachid>90382</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-20 12:17:39 -0700</bug_when>
    <thetext>Comment on attachment 90382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90382&amp;action=review

&gt; Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
&gt; +tbody tr:first-of-type:hover {

I&apos;m confused why you want to match the first tr in the table body and only on hover.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389426</commentid>
    <comment_count>3</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-20 12:20:42 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 90382 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=90382&amp;action=review
&gt; 
&gt; &gt; Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
&gt; &gt; +tbody tr:first-of-type:hover {
&gt; 
&gt; I&apos;m confused why you want to match the first tr in the table body and only on hover.

This change is actually just so that we don&apos;t change opacity when you hover over the thead.

We put each row in it&apos;s own tbody. Then we use a second tr for the expected results. We don&apos;t want to change the opacity of the expected results on hover. So the HTML looks something like the following:

&lt;table&gt;
  &lt;thead&gt;...&lt;/thead&gt;
  &lt;tbody&gt;
    &lt;tr&gt;test name + links to results&lt;/tr&gt;
    &lt;tr&gt;iframes/imgs to the inline results&lt;/tr&gt;
  &lt;/tbody&gt;
  &lt;tbody&gt;
    &lt;tr&gt;test name + links to results&lt;/tr&gt;
    &lt;tr&gt;iframes/imgs to the inline results&lt;/tr&gt;
  &lt;/tbody&gt;
&lt;/table&gt;

This way, when we sort the rows, we can sort the tbody elements and the inline results sort along with the test + result links.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389566</commentid>
    <comment_count>4</comment_count>
      <attachid>90382</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-20 15:26:08 -0700</bug_when>
    <thetext>Comment on attachment 90382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90382&amp;action=review

&gt;&gt;&gt; Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
&gt;&gt;&gt; +tbody tr:first-of-type:hover {
&gt;&gt; 
&gt;&gt; I&apos;m confused why you want to match the first tr in the table body and only on hover.
&gt; 
&gt; This change is actually just so that we don&apos;t change opacity when you hover over the thead.
&gt; 
&gt; We put each row in it&apos;s own tbody. Then we use a second tr for the expected results. We don&apos;t want to change the opacity of the expected results on hover. So the HTML looks something like the following:
&gt; 
&gt; &lt;table&gt;
&gt;   &lt;thead&gt;...&lt;/thead&gt;
&gt;   &lt;tbody&gt;
&gt;     &lt;tr&gt;test name + links to results&lt;/tr&gt;
&gt;     &lt;tr&gt;iframes/imgs to the inline results&lt;/tr&gt;
&gt;   &lt;/tbody&gt;
&gt;   &lt;tbody&gt;
&gt;     &lt;tr&gt;test name + links to results&lt;/tr&gt;
&gt;     &lt;tr&gt;iframes/imgs to the inline results&lt;/tr&gt;
&gt;   &lt;/tbody&gt;
&gt; &lt;/table&gt;
&gt; 
&gt; This way, when we sort the rows, we can sort the tbody elements and the inline results sort along with the test + result links.

I can cut this or do this in a separate patch if you need.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390104</commentid>
    <comment_count>5</comment_count>
      <attachid>90382</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-04-21 10:01:02 -0700</bug_when>
    <thetext>Comment on attachment 90382
Patch

Ojan says he has a version that is rebased with the globalState() change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390140</commentid>
    <comment_count>6</comment_count>
      <attachid>90554</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-21 10:36:17 -0700</bug_when>
    <thetext>Created attachment 90554
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390144</commentid>
    <comment_count>7</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2011-04-21 10:43:37 -0700</bug_when>
    <thetext>Committed r84518: &lt;http://trac.webkit.org/changeset/84518&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390176</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-21 11:24:30 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84518 might have broken Qt Linux ARMv7 Release and Qt Windows 32-bit Debug</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90382</attachid>
            <date>2011-04-20 12:14:08 -0700</date>
            <delta_ts>2011-04-21 10:36:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-59016-20110420121407.patch</filename>
            <type>text/plain</type>
            <size>5315</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODQzOTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NTBjYWFiNWNmYzFlZjM2NTQ5MWZmNGI4NWJjOTQ2ZmEw
NDk4N2Q1Li4wZTcxNWJmYWIyMDQxZmI3NDI2NWNjMDBkOGI3ZmFiMTBiY2Q4MDU0IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTEtMDQtMjAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwdXQgdW5leHBlY3RlZCBw
YXNzZXMgaW50byB0aGVpciBvd24gdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTU5MDE2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh
eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbDoKKwogMjAxMS0wNC0y
MCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBvbGQt
cnVuLXdlYmtpdC10ZXN0cydzIHdpbi03IHBsYXRmb3JtIHdpdGggd2luLTdzcDAKZGlmZiAtLWdp
dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pz
b25fcmVzdWx0cy5odG1sIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5
b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwKaW5kZXggMzNhYTA0YTc5M2IxMjNmOTBhMzZi
YzAwMjNmNzU1MDAzNjIyYmRkZi4uNzk2Y2IzOGRhNDI1OTFjNTY3Nzc3MWM5NGQ1MDhhMjM2NGE0
NGI0ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5
b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw
eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwKQEAgLTgsNyAr
OCw3IEBAIGJvZHkgPiBwOmZpcnN0LW9mLXR5cGUgewogICAgIG1hcmdpbi10b3A6IDA7CiB9CiAK
LXRyOmZpcnN0LW9mLXR5cGU6aG92ZXIgewordGJvZHkgdHI6Zmlyc3Qtb2YtdHlwZTpob3ZlciB7
CiAgICAgb3BhY2l0eTogMC43CiB9CiAKQEAgLTIxNyw2ICsyMTcsNyBAQCB2YXIgZ19oYXNJbWFn
ZUZhaWx1cmVzID0gZmFsc2U7CiAKIHZhciBnX3Rlc3RzV2l0aFN0ZGVyciA9IFtdOwogdmFyIGdf
bmV3VGVzdHMgPSBbXTsKK3ZhciBnX3VuZXhwZWN0ZWRQYXNzVGVzdHMgPSBbXTsKIHZhciBnX2hh
c0h0dHBUZXN0cyA9IGZhbHNlOwogCiBmdW5jdGlvbiB0YWJsZVJvd3MoKQpAQCAtMjM3LDggKzIz
OCwyMCBAQCBmdW5jdGlvbiB0YWJsZVJvd3MoKQogICAgICAgICB9CiAKICAgICAgICAgdmFyIGV4
cGVjdGVkID0gZ19yZXN1bHRzLnRlc3RzW3Rlc3RdLmV4cGVjdGVkIHx8ICdQQVNTJzsKLSAgICAg
ICAgaWYgKGFjdHVhbCA9PSAnUEFTUycgJiYgKCFnX3Jlc3VsdHMudXNlc19leHBlY3RhdGlvbnNf
ZmlsZSB8fCBleHBlY3RlZCA9PSAnUEFTUycpKQotICAgICAgICAgIGNvbnRpbnVlOworICAgICAg
ICB2YXIgaXNFeHBlY3RlZCA9IGFjdHVhbCA9PSAnU0tJUCc7CisgICAgICAgIGlmICghaXNFeHBl
Y3RlZCAmJiBnX3Jlc3VsdHMudXNlc19leHBlY3RhdGlvbnNfZmlsZSkgeworICAgICAgICAgICAg
dmFyIGV4cGVjdGVkQXJyYXkgPSBleHBlY3RlZC5zcGxpdCgnICcpOworICAgICAgICAgICAgaWYg
KGV4cGVjdGVkQXJyYXkuaW5kZXhPZihhY3R1YWwpICE9IC0xKQorICAgICAgICAgICAgICAgIGlz
RXhwZWN0ZWQgPSB0cnVlOworICAgICAgICAgICAgZWxzZSBpZiAoZXhwZWN0ZWRBcnJheS5pbmRl
eE9mKCdGQUlMJykgIT0gLTEpCisgICAgICAgICAgICAgICAgaXNFeHBlY3RlZCA9IGFjdHVhbCA9
PSAnSU1BR0UnIHx8IGFjdHVhbCA9PSAnVEVYVCcgfHwgYWN0dWFsID09ICdJTUFHRStURVhUJzsK
KyAgICAgICAgfQorCisgICAgICAgIGlmIChhY3R1YWwgPT0gJ1BBU1MnKSB7CisgICAgICAgICAg
ICBpZiAoIWlzRXhwZWN0ZWQgJiYgZXhwZWN0ZWQgIT0gJ1BBU1MnKQorICAgICAgICAgICAgICAg
IGdfdW5leHBlY3RlZFBhc3NUZXN0cy5wdXNoKHRlc3QpOyAgICAgICAgICAgIAorICAgICAgICAg
ICAgY29udGludWU7CisgICAgICAgIH0KIAogICAgICAgICAvLyBGSVhNRTogcHV0IHVuZXhwZWN0
ZWQgcGFzc2VzIGluIGEgc2VwYXJhdGUgdGFibGUuCiAKQEAgLTI4OSwxNCArMzAyLDYgQEAgZnVu
Y3Rpb24gdGFibGVSb3dzKCkKICAgICAgICAgaWYgKGdfcmVzdWx0cy51c2VzX2V4cGVjdGF0aW9u
c19maWxlKQogICAgICAgICAgIHJvdyArPSAnPHRkPicgKyBleHBlY3RlZCArICc8L3RkPic7CiAK
LSAgICAgICAgdmFyIGlzRXhwZWN0ZWQgPSBhY3R1YWwgPT0gJ1NLSVAnOwotICAgICAgICBpZiAo
IWlzRXhwZWN0ZWQgJiYgZ19yZXN1bHRzLnVzZXNfZXhwZWN0YXRpb25zX2ZpbGUpIHsKLSAgICAg
ICAgICAgIHZhciBleHBlY3RlZEFycmF5ID0gZXhwZWN0ZWQuc3BsaXQoJyAnKTsKLSAgICAgICAg
ICAgIGlmIChleHBlY3RlZEFycmF5LmluZGV4T2YoYWN0dWFsKSAhPSAtMSkKLSAgICAgICAgICAg
ICAgICBpc0V4cGVjdGVkID0gdHJ1ZTsKLSAgICAgICAgICAgIGVsc2UgaWYgKGV4cGVjdGVkQXJy
YXkuaW5kZXhPZignRkFJTCcpICE9IC0xKQotICAgICAgICAgICAgICAgIGlzRXhwZWN0ZWQgPSBh
Y3R1YWwgPT0gJ0lNQUdFJyB8fCBhY3R1YWwgPT0gJ1RFWFQnIHx8IGFjdHVhbCA9PSAnSU1BR0Ur
VEVYVCc7Ci0gICAgICAgIH0KICAgICAgICAgaHRtbCArPSAnPHRib2R5IGNsYXNzPSInICsgKGlz
RXhwZWN0ZWQgPyAnZXhwZWN0ZWQnIDogJycpICsgJyI+PHRyPicgKyByb3cgKyAnPC90cj48L3Ri
b2R5Pic7CiAgICAgfQogICAgIHJldHVybiBodG1sOwpAQCAtMzIyLDIzICszMjcsMjkgQEAgaWYg
KHRhYmxlUm93c0h0bWwpIHsKICAgICBodG1sICs9ICc8L3RyPjwvdGhlYWQ+JyArIHRhYmxlUm93
c0h0bWwgKyAnPC90YWJsZT4nOwogfQogCi1mdW5jdGlvbiBhcHBlbmRUZXN0TGlzdCh0ZXN0cywg
aGVhZGVyLCB0YWJsZUlkLCBmaWxlU3VmZml4LCBsaW5rTmFtZSkKK2Z1bmN0aW9uIGFwcGVuZFRl
c3RMaXN0KHRlc3RzLCBoZWFkZXIsIHRhYmxlSWQpCiB7CiAgICAgdGVzdHMuc29ydCgpOwogCiAg
ICAgaHRtbCArPSAnPHA+JyArIGhlYWRlciArICc8L3A+PHRhYmxlIGlkPSInICsgdGFibGVJZCAr
ICciPic7CisKKyAgICBpZiAodGFibGVJZCA9PSAncGFzc2VzLXRhYmxlJykKKyAgICAgICAgaHRt
bCArPSAnPHRoZWFkPjx0aD50ZXN0PC90aD48dGg+ZXhwZWN0ZWQgZmFpbHVyZSB0eXBlPC90aD4n
OworCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXN0cy5sZW5ndGg7IGkrKykgewogICAgICAg
ICB2YXIgdGVzdCA9IHRlc3RzW2ldOwogICAgICAgICBodG1sICs9ICc8dGJvZHk+PHRyPjx0ZD4n
ICsgdGVzdExpbmsodGVzdCkgKyAnPC90ZD48dGQ+JzsKICAgICAgICAgCi0gICAgICAgIGlmIChm
aWxlU3VmZml4LmluZGV4T2YoJ2FjdHVhbCcpID09IC0xKQotICAgICAgICAgICAgaHRtbCArPSBy
ZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCBmaWxlU3VmZml4LCBsaW5rTmFtZSk7Ci0g
ICAgICAgIGVsc2UgeworICAgICAgICBpZiAodGFibGVJZCA9PSAnc3RkZXJyLXRhYmxlJykKKyAg
ICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgJy1zdGRl
cnIudHh0JywgJ3N0ZGVycicpOworICAgICAgICBlbHNlIGlmICh0YWJsZUlkID09ICdwYXNzZXMt
dGFibGUnKQorICAgICAgICAgICAgaHRtbCArPSBnX3Jlc3VsdHMudGVzdHNbdGVzdF0uZXhwZWN0
ZWQ7CisgICAgICAgIGVsc2UgaWYgKHRhYmxlSWQgPT0gJ25ldy10ZXN0cy10YWJsZScpIHsKICAg
ICAgICAgICAgIHZhciB0ZXN0T2JqZWN0ID0gZ19yZXN1bHRzLnRlc3RzW3Rlc3RdOwogICAgICAg
ICAgICAgaWYgKHRlc3RPYmplY3QuaXNfbWlzc2luZ19hdWRpbykKICAgICAgICAgICAgICAgICBo
dG1sICs9IHJlc3VsdExpbmsoc3RyaXBFeHRlbnNpb24odGVzdCksICctYWN0dWFsLndhdicsICdh
dWRpbyByZXN1bHQnKTsKICAgICAgICAgICAgIGlmICh0ZXN0T2JqZWN0LmlzX21pc3NpbmdfdGV4
dCkKLSAgICAgICAgICAgICAgICBodG1sICs9IHJlc3VsdExpbmsoc3RyaXBFeHRlbnNpb24odGVz
dCksIGZpbGVTdWZmaXgsIGxpbmtOYW1lKTsKKyAgICAgICAgICAgICAgICBodG1sICs9IHJlc3Vs
dExpbmsoc3RyaXBFeHRlbnNpb24odGVzdCksICctYWN0dWFsLnR4dCcsICdyZXN1bHQnKTsKICAg
ICAgICAgICAgIGlmICh0ZXN0T2JqZWN0LmlzX21pc3NpbmdfaW1hZ2UpCiAgICAgICAgICAgICAg
ICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCAnLWFjdHVhbC5wbmcn
LCAncG5nIHJlc3VsdCcpOwogICAgICAgICB9IApAQCAtMzQ5LDEwICszNjAsMTMgQEAgZnVuY3Rp
b24gYXBwZW5kVGVzdExpc3QodGVzdHMsIGhlYWRlciwgdGFibGVJZCwgZmlsZVN1ZmZpeCwgbGlu
a05hbWUpCiB9CiAKIGlmIChnX25ld1Rlc3RzLmxlbmd0aCkKLSAgICBhcHBlbmRUZXN0TGlzdChn
X25ld1Rlc3RzLCAnVGVzdHMgdGhhdCBoYWQgbm8gZXhwZWN0ZWQgcmVzdWx0cyAocHJvYmFibHkg
bmV3KTonLCAnbmV3LXRlc3RzLXRhYmxlJywgJy1hY3R1YWwudHh0JywgJ3Jlc3VsdCcpOworICAg
IGFwcGVuZFRlc3RMaXN0KGdfbmV3VGVzdHMsICdUZXN0cyB0aGF0IGhhZCBubyBleHBlY3RlZCBy
ZXN1bHRzIChwcm9iYWJseSBuZXcpOicsICduZXctdGVzdHMtdGFibGUnKTsKIAogaWYgKGdfdGVz
dHNXaXRoU3RkZXJyLmxlbmd0aCkKLSAgICBhcHBlbmRUZXN0TGlzdChnX3Rlc3RzV2l0aFN0ZGVy
ciwgJ1Rlc3RzIHRoYXQgaGFkIHN0ZGVyciBvdXRwdXQ6JywgJ3N0ZGVyci10YWJsZScsICctc3Rk
ZXJyLnR4dCcsICdzdGRlcnInKTsKKyAgICBhcHBlbmRUZXN0TGlzdChnX3Rlc3RzV2l0aFN0ZGVy
ciwgJ1Rlc3RzIHRoYXQgaGFkIHN0ZGVyciBvdXRwdXQ6JywgJ3N0ZGVyci10YWJsZScpOworCitp
ZiAoZ191bmV4cGVjdGVkUGFzc1Rlc3RzLmxlbmd0aCkKKyAgICBhcHBlbmRUZXN0TGlzdChnX3Vu
ZXhwZWN0ZWRQYXNzVGVzdHMsICdUZXN0cyBleHBlY3RlZCB0byBmYWlsIGJ1dCBwYXNzZWQ6Jywg
J3Bhc3Nlcy10YWJsZScpOwogCiBpZiAoZ19oYXNIdHRwVGVzdHMpIHsKICAgICBodG1sICs9ICc8
cD5odHRwZCBhY2Nlc3MgbG9nOiA8YSBocmVmPSJhY2Nlc3NfbG9nLnR4dCI+YWNjZXNzX2xvZy50
eHQ8L2E+PC9wPicgKwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90554</attachid>
            <date>2011-04-21 10:36:17 -0700</date>
            <delta_ts>2011-04-21 10:41:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-59016-20110421103616.patch</filename>
            <type>text/plain</type>
            <size>7083</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODQ1MTYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZDRjMWJjMjc1YWQ1OTViYWJlNmVmNDY4YWJkYzUzMTdi
YTUwYzg2Li45NmE5YWYyOWQyZGE2YzkzZWVkYjZhZDA1MmVjNjM1OTExNmQ3NmY0IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg
QEAKIDIwMTEtMDQtMjAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBwdXQgdW5leHBlY3RlZCBw
YXNzZXMgaW50byB0aGVpciBvd24gdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTU5MDE2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh
eW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbDoKKworMjAxMS0wNC0y
MCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5
IFRvbnkgQ2hhbmcuCiAKICAgICAgICAgaW5pdGlhbCBzZXQgb2YgdGVzdHMgZm9yIG5ldyByZXN1
bHRzLmh0bWwgZmlsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf
dGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwgYi9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbAppbmRl
eCAwMzBhNGQ5OTY2MTVkOWRiYWJkMDI3OTdhZjg2ZjAwZDQzODM2ZGM2Li41NjdiZDMxYWYxYjI4
YjcxNzFlYTk1NjY4ZDRiN2NiOTkzZWQ1MzQ3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbAorKysg
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29u
X3Jlc3VsdHMuaHRtbApAQCAtOCw3ICs4LDcgQEAgYm9keSA+IHA6Zmlyc3Qtb2YtdHlwZSB7CiAg
ICAgbWFyZ2luLXRvcDogMDsKIH0KIAotdHI6Zmlyc3Qtb2YtdHlwZTpob3ZlciB7Cit0Ym9keSB0
cjpmaXJzdC1vZi10eXBlOmhvdmVyIHsKICAgICBvcGFjaXR5OiAwLjcKIH0KIApAQCAtMTE5LDcg
KzExOSw4IEBAIGZ1bmN0aW9uIGdsb2JhbFN0YXRlKCkKICAgICAgICAgICAgIGhhc1RleHRGYWls
dXJlczogZmFsc2UsCiAgICAgICAgICAgICBuZXdUZXN0czogW10sCiAgICAgICAgICAgICByZXN1
bHRzOiB7fSwKLSAgICAgICAgICAgIHRlc3RzV2l0aFN0ZGVycjogW10KKyAgICAgICAgICAgIHRl
c3RzV2l0aFN0ZGVycjogW10sCisgICAgICAgICAgICB1bmV4cGVjdGVkUGFzc1Rlc3RzOiBbXQog
ICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBnX3N0YXRlOwpAQCAtMjY5LDggKzI3MCwyMCBA
QCBmdW5jdGlvbiB0YWJsZVJvd3MoKQogICAgICAgICB9CiAKICAgICAgICAgdmFyIGV4cGVjdGVk
ID0gZ2xvYmFsU3RhdGUoKS5yZXN1bHRzLnRlc3RzW3Rlc3RdLmV4cGVjdGVkIHx8ICdQQVNTJzsK
LSAgICAgICAgaWYgKGFjdHVhbCA9PSAnUEFTUycgJiYgKCFnbG9iYWxTdGF0ZSgpLnJlc3VsdHMu
dXNlc19leHBlY3RhdGlvbnNfZmlsZSB8fCBleHBlY3RlZCA9PSAnUEFTUycpKQotICAgICAgICAg
IGNvbnRpbnVlOworICAgICAgICB2YXIgaXNFeHBlY3RlZCA9IGFjdHVhbCA9PSAnU0tJUCc7Cisg
ICAgICAgIGlmICghaXNFeHBlY3RlZCAmJiBnbG9iYWxTdGF0ZSgpLnJlc3VsdHMudXNlc19leHBl
Y3RhdGlvbnNfZmlsZSkgeworICAgICAgICAgICAgdmFyIGV4cGVjdGVkQXJyYXkgPSBleHBlY3Rl
ZC5zcGxpdCgnICcpOworICAgICAgICAgICAgaWYgKGV4cGVjdGVkQXJyYXkuaW5kZXhPZihhY3R1
YWwpICE9IC0xKQorICAgICAgICAgICAgICAgIGlzRXhwZWN0ZWQgPSB0cnVlOworICAgICAgICAg
ICAgZWxzZSBpZiAoZXhwZWN0ZWRBcnJheS5pbmRleE9mKCdGQUlMJykgIT0gLTEpCisgICAgICAg
ICAgICAgICAgaXNFeHBlY3RlZCA9IGFjdHVhbCA9PSAnSU1BR0UnIHx8IGFjdHVhbCA9PSAnVEVY
VCcgfHwgYWN0dWFsID09ICdJTUFHRStURVhUJzsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChh
Y3R1YWwgPT0gJ1BBU1MnKSB7CisgICAgICAgICAgICBpZiAoIWlzRXhwZWN0ZWQgJiYgZXhwZWN0
ZWQgIT0gJ1BBU1MnKQorICAgICAgICAgICAgICAgIGdsb2JhbFN0YXRlKCkudW5leHBlY3RlZFBh
c3NUZXN0cy5wdXNoKHRlc3QpOyAgICAgICAgICAgIAorICAgICAgICAgICAgY29udGludWU7Cisg
ICAgICAgIH0KIAogICAgICAgICAvLyBGSVhNRTogcHV0IHVuZXhwZWN0ZWQgcGFzc2VzIGluIGEg
c2VwYXJhdGUgdGFibGUuCiAKQEAgLTMyMSwzNiArMzM0LDM0IEBAIGZ1bmN0aW9uIHRhYmxlUm93
cygpCiAgICAgICAgIGlmIChnbG9iYWxTdGF0ZSgpLnJlc3VsdHMudXNlc19leHBlY3RhdGlvbnNf
ZmlsZSkKICAgICAgICAgICByb3cgKz0gJzx0ZD4nICsgZXhwZWN0ZWQgKyAnPC90ZD4nOwogCi0g
ICAgICAgIHZhciBpc0V4cGVjdGVkID0gYWN0dWFsID09ICdTS0lQJzsKLSAgICAgICAgaWYgKCFp
c0V4cGVjdGVkICYmIGdsb2JhbFN0YXRlKCkucmVzdWx0cy51c2VzX2V4cGVjdGF0aW9uc19maWxl
KSB7Ci0gICAgICAgICAgICB2YXIgZXhwZWN0ZWRBcnJheSA9IGV4cGVjdGVkLnNwbGl0KCcgJyk7
Ci0gICAgICAgICAgICBpZiAoZXhwZWN0ZWRBcnJheS5pbmRleE9mKGFjdHVhbCkgIT0gLTEpCi0g
ICAgICAgICAgICAgICAgaXNFeHBlY3RlZCA9IHRydWU7Ci0gICAgICAgICAgICBlbHNlIGlmIChl
eHBlY3RlZEFycmF5LmluZGV4T2YoJ0ZBSUwnKSAhPSAtMSkKLSAgICAgICAgICAgICAgICBpc0V4
cGVjdGVkID0gYWN0dWFsID09ICdJTUFHRScgfHwgYWN0dWFsID09ICdURVhUJyB8fCBhY3R1YWwg
PT0gJ0lNQUdFK1RFWFQnOwotICAgICAgICB9CiAgICAgICAgIGh0bWwgKz0gJzx0Ym9keSBjbGFz
cz0iJyArIChpc0V4cGVjdGVkID8gJ2V4cGVjdGVkJyA6ICcnKSArICciPjx0cj4nICsgcm93ICsg
JzwvdHI+PC90Ym9keT4nOwogICAgIH0KICAgICByZXR1cm4gaHRtbDsKIH0KIAotZnVuY3Rpb24g
dGVzdExpc3QodGVzdHMsIGhlYWRlciwgdGFibGVJZCwgZmlsZVN1ZmZpeCwgbGlua05hbWUpCitm
dW5jdGlvbiB0ZXN0TGlzdCh0ZXN0cywgaGVhZGVyLCB0YWJsZUlkKQogewogICAgIHRlc3RzLnNv
cnQoKTsKIAogICAgIHZhciBodG1sID0gJzxwPicgKyBoZWFkZXIgKyAnPC9wPjx0YWJsZSBpZD0i
JyArIHRhYmxlSWQgKyAnIj4nOworCisgICAgaWYgKHRhYmxlSWQgPT0gJ3Bhc3Nlcy10YWJsZScp
CisgICAgICAgIGh0bWwgKz0gJzx0aGVhZD48dGg+dGVzdDwvdGg+PHRoPmV4cGVjdGVkIGZhaWx1
cmUgdHlwZTwvdGg+JzsKKwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVuZ3RoOyBp
KyspIHsKICAgICAgICAgdmFyIHRlc3QgPSB0ZXN0c1tpXTsKICAgICAgICAgaHRtbCArPSAnPHRi
b2R5Pjx0cj48dGQ+JyArIHRlc3RMaW5rKHRlc3QpICsgJzwvdGQ+PHRkPic7CiAgICAgICAgIAot
ICAgICAgICBpZiAoZmlsZVN1ZmZpeC5pbmRleE9mKCdhY3R1YWwnKSA9PSAtMSkKLSAgICAgICAg
ICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgZmlsZVN1ZmZpeCwg
bGlua05hbWUpOwotICAgICAgICBlbHNlIHsKKyAgICAgICAgaWYgKHRhYmxlSWQgPT0gJ3N0ZGVy
ci10YWJsZScpCisgICAgICAgICAgICBodG1sICs9IHJlc3VsdExpbmsoc3RyaXBFeHRlbnNpb24o
dGVzdCksICctc3RkZXJyLnR4dCcsICdzdGRlcnInKTsKKyAgICAgICAgZWxzZSBpZiAodGFibGVJ
ZCA9PSAncGFzc2VzLXRhYmxlJykKKyAgICAgICAgICAgIGh0bWwgKz0gZ2xvYmFsU3RhdGUoKS5y
ZXN1bHRzLnRlc3RzW3Rlc3RdLmV4cGVjdGVkOworICAgICAgICBlbHNlIGlmICh0YWJsZUlkID09
ICduZXctdGVzdHMtdGFibGUnKSB7CiAgICAgICAgICAgICB2YXIgdGVzdE9iamVjdCA9IGdsb2Jh
bFN0YXRlKCkucmVzdWx0cy50ZXN0c1t0ZXN0XTsKICAgICAgICAgICAgIGlmICh0ZXN0T2JqZWN0
LmlzX21pc3NpbmdfYXVkaW8pCiAgICAgICAgICAgICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0
cmlwRXh0ZW5zaW9uKHRlc3QpLCAnLWFjdHVhbC53YXYnLCAnYXVkaW8gcmVzdWx0Jyk7CiAgICAg
ICAgICAgICBpZiAodGVzdE9iamVjdC5pc19taXNzaW5nX3RleHQpCi0gICAgICAgICAgICAgICAg
aHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCBmaWxlU3VmZml4LCBsaW5r
TmFtZSk7CisgICAgICAgICAgICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9u
KHRlc3QpLCAnLWFjdHVhbC50eHQnLCAncmVzdWx0Jyk7CiAgICAgICAgICAgICBpZiAodGVzdE9i
amVjdC5pc19taXNzaW5nX2ltYWdlKQogICAgICAgICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGlu
ayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgJy1hY3R1YWwucG5nJywgJ3BuZyByZXN1bHQnKTsKICAg
ICAgICAgfSAKQEAgLTU2MiwxMCArNTczLDEzIEBAIGZ1bmN0aW9uIGdlbmVyYXRlUGFnZSgpCiAg
ICAgfQogCiAgICAgaWYgKGdsb2JhbFN0YXRlKCkubmV3VGVzdHMubGVuZ3RoKQotICAgICAgICBo
dG1sICs9IHRlc3RMaXN0KGdsb2JhbFN0YXRlKCkubmV3VGVzdHMsICdUZXN0cyB0aGF0IGhhZCBu
byBleHBlY3RlZCByZXN1bHRzIChwcm9iYWJseSBuZXcpOicsICduZXctdGVzdHMtdGFibGUnLCAn
LWFjdHVhbC50eHQnLCAncmVzdWx0Jyk7CisgICAgICAgIGh0bWwgKz0gdGVzdExpc3QoZ2xvYmFs
U3RhdGUoKS5uZXdUZXN0cywgJ1Rlc3RzIHRoYXQgaGFkIG5vIGV4cGVjdGVkIHJlc3VsdHMgKHBy
b2JhYmx5IG5ldyk6JywgJ25ldy10ZXN0cy10YWJsZScpOwogCiAgICAgaWYgKGdsb2JhbFN0YXRl
KCkudGVzdHNXaXRoU3RkZXJyLmxlbmd0aCkKLSAgICAgICAgaHRtbCArPSB0ZXN0TGlzdChnbG9i
YWxTdGF0ZSgpLnRlc3RzV2l0aFN0ZGVyciwgJ1Rlc3RzIHRoYXQgaGFkIHN0ZGVyciBvdXRwdXQ6
JywgJ3N0ZGVyci10YWJsZScsICctc3RkZXJyLnR4dCcsICdzdGRlcnInKTsKKyAgICAgICAgaHRt
bCArPSB0ZXN0TGlzdChnbG9iYWxTdGF0ZSgpLnRlc3RzV2l0aFN0ZGVyciwgJ1Rlc3RzIHRoYXQg
aGFkIHN0ZGVyciBvdXRwdXQ6JywgJ3N0ZGVyci10YWJsZScpOworCisgICAgaWYgKGdsb2JhbFN0
YXRlKCkudW5leHBlY3RlZFBhc3NUZXN0cy5sZW5ndGgpCisgICAgICAgIGh0bWwgKz0gdGVzdExp
c3QoZ2xvYmFsU3RhdGUoKS51bmV4cGVjdGVkUGFzc1Rlc3RzLCAnVGVzdHMgZXhwZWN0ZWQgdG8g
ZmFpbCBidXQgcGFzc2VkOicsICdwYXNzZXMtdGFibGUnKTsKIAogICAgIGlmIChnbG9iYWxTdGF0
ZSgpLmhhc0h0dHBUZXN0cykgewogICAgICAgICBodG1sICs9ICc8cD5odHRwZCBhY2Nlc3MgbG9n
OiA8YSBocmVmPSJhY2Nlc3NfbG9nLnR4dCI+YWNjZXNzX2xvZy50eHQ8L2E+PC9wPicgKwpkaWZm
IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2th
Z2UvanNvbl9yZXN1bHRzX3Rlc3QuanMgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfdGVzdC5qcwppbmRleCA5ZmMwZmU0MGM4
N2NmZjkyZjIzNjYwYzJlNDM1ZmNhZWE4MzZlNTJmLi41ODAyM2Y1NTgwZGNhMTE4YTRjNTNmMzBi
ZmQ0MGM4NmY2NmIxZjhjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91
dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfdGVzdC5qcworKysgYi9Ub29scy9T
Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNf
dGVzdC5qcwpAQCAtOTksNiArOTksMjUgQEAgZnVuY3Rpb24gcnVuVGVzdHMoKQogICAgICAgICBh
c3NlcnRUcnVlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJyNzdGRlcnItdGFibGUgLnJlc3VsdC1s
aW5rJykudGV4dENvbnRlbnQgPT0gJ3N0ZGVycicpOwogICAgIH0pOwogCisgICAgcmVzdWx0cyA9
IG1vY2tSZXN1bHRzKCk7CisgICAgcmVzdWx0cy50ZXN0c1snZm9vL2Jhci5odG1sJ10gPSBtb2Nr
RXhwZWN0YXRpb24oJ1RFWFQnLCAnUEFTUycpOworICAgIHJlc3VsdHMudGVzdHNbJ2Zvby9iYXIx
Lmh0bWwnXSA9IG1vY2tFeHBlY3RhdGlvbignQ1JBU0gnLCAnUEFTUycpOworICAgIHJlc3VsdHMu
dGVzdHNbJ2Zvby9iYXIyLmh0bWwnXSA9IG1vY2tFeHBlY3RhdGlvbignSU1BR0UnLCAnUEFTUycp
OworICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7CisgICAgICAgIGFzc2VydFRydWUo
IWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzLXRhYmxlJykpOworCisgICAgICAgIHZh
ciB0ZXN0TGlua3MgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCcjcGFzc2VzLXRhYmxlIC50
ZXN0LWxpbmsnKTsKKyAgICAgICAgYXNzZXJ0VHJ1ZSh0ZXN0TGlua3NbMF0udGV4dENvbnRlbnQg
PT0gJ2Zvby9iYXIuaHRtbCcpOworICAgICAgICBhc3NlcnRUcnVlKHRlc3RMaW5rc1sxXS50ZXh0
Q29udGVudCA9PSAnZm9vL2JhcjEuaHRtbCcpOworICAgICAgICBhc3NlcnRUcnVlKHRlc3RMaW5r
c1syXS50ZXh0Q29udGVudCA9PSAnZm9vL2JhcjIuaHRtbCcpOworCisgICAgICAgIHZhciBleHBl
Y3RhdGlvblR5cGVzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnI3Bhc3Nlcy10YWJsZSB0
ZDpsYXN0LW9mLXR5cGUnKTsKKyAgICAgICAgYXNzZXJ0VHJ1ZShleHBlY3RhdGlvblR5cGVzWzBd
LnRleHRDb250ZW50ID09ICdURVhUJyk7CisgICAgICAgIGFzc2VydFRydWUoZXhwZWN0YXRpb25U
eXBlc1sxXS50ZXh0Q29udGVudCA9PSAnQ1JBU0gnKTsKKyAgICAgICAgYXNzZXJ0VHJ1ZShleHBl
Y3RhdGlvblR5cGVzWzJdLnRleHRDb250ZW50ID09ICdJTUFHRScpOworCisgICAgfSk7CisKICAg
ICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICc8cHJlPicgKyBnX2xvZy5qb2luKCdcbicpICsg
JzwvcHJlPic7CiB9CiAK
</data>
<flag name="review"
          id="83314"
          type_id="1"
          status="+"
          setter="tony"
    />
          </attachment>
      

    </bug>

</bugzilla>