59014 2011-04-20 11:56:40 -0700 Support DataView in workers 2011-04-20 14:38:50 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jianli jianli kbr oldest_to_newest 389401 0 jianli 2011-04-20 11:56:40 -0700 We need to add support for DataView in workers. 389404 1 90376 jianli 2011-04-20 11:58:24 -0700 Created attachment 90376 Proposed Patch 389485 2 90376 kbr 2011-04-20 13:37:00 -0700 Comment on attachment 90376 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90376&action=review Looks good. One minor comment about the test. > LayoutTests/fast/canvas/webgl/resources/worker-data-view-test.js:2 > + var array = new Uint8Array(4); It would be safer to write this as "new Uint32Array(1)". 389535 3 jianli 2011-04-20 14:38:50 -0700 Committed as https://trac.webkit.org/changeset/84418. 90376 2011-04-20 11:58:24 -0700 2011-04-20 13:36:59 -0700 Proposed Patch 59014 text/plain 3574 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMjJiNmJhLi5iNzM4NmU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQt MjAgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnQgRGF0YVZpZXcgaW4gd29ya2Vycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkwMTQKKwor ICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Jlc291cmNlcy93b3JrZXItZGF0YS12aWV3LXRl c3QuanM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3dvcmtlci1kYXRhLXZp ZXctdGVzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmds L3dvcmtlci1kYXRhLXZpZXctdGVzdC5odG1sOiBBZGRlZC4KKwogMjAxMS0wNC0xOSAgQ2hyaXMg Um9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9yZXNvdXJjZXMvd29ya2VyLWRh dGEtdmlldy10ZXN0LmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvcmVzb3VyY2Vz L3dvcmtlci1kYXRhLXZpZXctdGVzdC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi4xMTY0ZWNiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv d2ViZ2wvcmVzb3VyY2VzL3dvcmtlci1kYXRhLXZpZXctdGVzdC5qcwpAQCAtMCwwICsxLDYgQEAK K29ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2dCkgeworICAgIHZhciBhcnJheSA9IG5ldyBVaW50OEFy cmF5KDQpOworICAgIHZhciB2aWV3ID0gbmV3IERhdGFWaWV3KGFycmF5LmJ1ZmZlcik7CisgICAg dmlldy5zZXRVaW50MzIoMCwgMTIzNDU2NzgsIHRydWUpOworICAgIHBvc3RNZXNzYWdlKHZpZXcu Z2V0VWludDMyKDAsIHRydWUpKTsKK30KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL3dlYmdsL3dvcmtlci1kYXRhLXZpZXctdGVzdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC93b3JrZXItZGF0YS12aWV3LXRlc3QtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBlZDQ5NWEKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC93b3JrZXItZGF0YS12aWV3LXRlc3Qt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCBEYXRhVmlldyBpbiB3b3JrZXIuCisx MjM0NTY3OAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC93b3Jr ZXItZGF0YS12aWV3LXRlc3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dv cmtlci1kYXRhLXZpZXctdGVzdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLjdmZjlmZDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC93b3JrZXItZGF0YS12aWV3LXRlc3QuaHRtbApAQCAtMCwwICsxLDMxIEBACis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4 dE5vZGUobWVzc2FnZSArICJcbiIpKTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAg bG9nKCJUZXN0IERhdGFWaWV3IGluIHdvcmtlci4iKTsKKworICAgIHZhciB3b3JrZXIgPSBuZXcg V29ya2VyKCJyZXNvdXJjZXMvd29ya2VyLWRhdGEtdmlldy10ZXN0LmpzIik7CisgICAgd29ya2Vy Lm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIGxvZyhldmVudC5kYXRhKTsK KyAgICAgICAgaWYgKGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUpCisgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfTsKKyAgICB3b3JrZXIu cG9zdE1lc3NhZ2UoInN0YXJ0Iik7Cit9CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cHJlIGlkPSdjb25zb2xlJz48L3ByZT4KKzwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMTczZjdkLi4zNThjZjk2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjAgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBv cnQgRGF0YVZpZXcgaW4gd29ya2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTkwMTQKKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy93ZWJnbC93 b3JrZXItZGF0YS12aWV3LXRlc3QuaHRtbAorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXJDb250 ZXh0LmlkbDogRXhwb3NlIERhdGFWaWV3IGNvbnN0cnVjdG9yLgorCiAyMDExLTA0LTE5ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNv bnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbAppbmRl eCBlMzFmNWFkLi5kNWE5NjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dv cmtlckNvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4 dC5pZGwKQEAgLTEyNiw2ICsxMjYsNyBAQCBtb2R1bGUgdGhyZWFkcyB7CiAgICAgICAgIGF0dHJp YnV0ZSBJbnQzMkFycmF5Q29uc3RydWN0b3IgSW50MzJBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3 IG9wZXJhdG9yCiAgICAgICAgIGF0dHJpYnV0ZSBVaW50MzJBcnJheUNvbnN0cnVjdG9yIFVpbnQz MkFycmF5OyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKICAgICAgICAgYXR0cmlidXRlIEZs b2F0MzJBcnJheUNvbnN0cnVjdG9yIEZsb2F0MzJBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9w ZXJhdG9yCisgICAgICAgIGF0dHJpYnV0ZSBEYXRhVmlld0NvbnN0cnVjdG9yIERhdGFWaWV3OyAv LyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKICAgICB9OwogCiB9Cg==