59010 2011-04-20 11:14:06 -0700 [chromium] expose title text direction on WebDataSource 2011-04-20 14:05:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan fishd oldest_to_newest 389363 0 evan 2011-04-20 11:14:06 -0700 [chromium] expose text direction WebDataSource 389365 1 90368 evan 2011-04-20 11:14:51 -0700 Created attachment 90368 Patch 389368 2 90369 evan 2011-04-20 11:17:42 -0700 Created attachment 90369 Patch 389399 3 evan 2011-04-20 11:54:23 -0700 Committed r84400: <http://trac.webkit.org/changeset/84400> 389442 4 90369 fishd 2011-04-20 12:45:01 -0700 Comment on attachment 90369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review > Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 > + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too? 389478 5 90369 evan 2011-04-20 13:30:14 -0700 Comment on attachment 90369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90369&action=review >> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:90 >> + return title().direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft; > > would it make sense for the WebKit API to have a WebStringWithDirection? maybe we will want to shuttle this information across the webkit API in other places in the future too? I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future? 389507 6 fishd 2011-04-20 14:05:08 -0700 (In reply to comment #5) > I *believe* this and the didReceiveTitle are the only two, so I was hoping to keep it simple for now. Is it ok if I just keep this idea in mind for the future? Yes, that's probably OK. A quick grep of chromium/public/ suggests a couple other places where WebStringWithDirection might be useful: WebViewClient::setTooltipText WebNotification::{title,body,direction} 90368 2011-04-20 11:14:51 -0700 2011-04-20 11:17:39 -0700 Patch bug-59010-20110420111424.patch text/plain 3102 evan U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MzdkMzQyMWY5OWVhZDdkNzZlMjA5NTUyM2NlMjA1ZTcyZmI2MWYxZi4uNDg0NmU4NDhlNDhhOGQ2 OGQ3MzJiOTlhNWMyZWYwMGI3MjNmNGU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNC0yMCAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIGV4cG9zZSB0aXRsZSB0ZXh0IGRpcmVjdGlvbiBvbiBXZWJEYXRhU291cmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTAxMAorCisgICAg ICAgICogcHVibGljL1dlYkRhdGFTb3VyY2UuaDoKKyAgICAgICAgKiBzcmMvV2ViRGF0YVNvdXJj ZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEYXRhU291cmNlSW1wbDo6cGFnZVRpdGxl KToKKyAgICAgICAgKFdlYktpdDo6V2ViRGF0YVNvdXJjZUltcGw6OnBhZ2VUaXRsZURpcmVjdGlv bik6CisgICAgICAgICogc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmg6CisKIDIwMTEtMDQtMTkgIE5h b2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJEYXRhU291cmNlLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEYXRh U291cmNlLmgKaW5kZXggMWE4YzI3MGZjOTQ4ZmRkNmM5NzExMTY3N2FiYTk5NmM4OGM2ODQxMy4u ZTQzNjRlOTBkODZlMTM4MzkwYjdmZTRhNjJkYzJlZWQ4MjY4ODIxYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGF0YVNvdXJjZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGFTb3VyY2UuaApAQCAtMzMsNiArMzMsNyBAQAog CiAjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCiAjaW5jbHVkZSAiV2ViTmF2aWdhdGlvblR5cGUuaCIK KyNpbmNsdWRlICJXZWJUZXh0RGlyZWN0aW9uLmgiCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBA IC03OCw2ICs3OSw5IEBAIHB1YmxpYzoKICAgICAvLyBSZXR1cm5zIHRoZSB0aXRsZSBmb3IgdGhl IGN1cnJlbnQgcGFnZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBwYWdlVGl0bGUoKSBjb25zdCA9 IDA7CiAKKyAgICAvLyBSZXR1cm5zIHRoZSB0ZXh0IGRpcmVjdGlvbiBvZiB0aGUgdGl0bGUgZm9y IHRoZSBjdXJyZW50IHBhZ2UuCisgICAgdmlydHVhbCBXZWJUZXh0RGlyZWN0aW9uIHBhZ2VUaXRs ZURpcmVjdGlvbigpIGNvbnN0ID0gMDsKKwogICAgIC8vIFRoZSB0eXBlIG9mIG5hdmlnYXRpb24g dGhhdCB0cmlnZ2VyZWQgdGhlIGNyZWF0aW9uIG9mIHRoaXMgZGF0YXNvdXJjZS4KICAgICB2aXJ0 dWFsIFdlYk5hdmlnYXRpb25UeXBlIG5hdmlnYXRpb25UeXBlKCkgY29uc3QgPSAwOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAKaW5kZXgg MzE3MGFmZmJlNGI0YjFmODQwYzY3NTkwZTlkNmJhYWQ1Nzg1MGU3OC4uZThkNTJlNzU5YjFlODFk MmM3YmJlMjM2ZGEwYTFlOWI1MWI3MDdjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmNwcApAQCAtODIsMTAgKzgyLDE0IEBAIHZvaWQgV2Vi RGF0YVNvdXJjZUltcGw6OnJlZGlyZWN0Q2hhaW4oV2ViVmVjdG9yPFdlYlVSTD4mIHJlc3VsdCkg Y29uc3QKIAogV2ViU3RyaW5nIFdlYkRhdGFTb3VyY2VJbXBsOjpwYWdlVGl0bGUoKSBjb25zdAog ewotICAgIC8vIEZJWE1FOiB1c2UgZGlyZWN0aW9uIG9mIHRpdGxlIGFzIHdlbGwuCiAgICAgcmV0 dXJuIHRpdGxlKCkuc3RyaW5nKCk7CiB9CiAKK1dlYlN0cmluZyBXZWJEYXRhU291cmNlSW1wbDo6 cGFnZVRpdGxlRGlyZWN0aW9uKCkgY29uc3QKK3sKKyAgICByZXR1cm4gdGl0bGUoKS5kaXJlY3Rp b24oKTsKK30KKwogV2ViTmF2aWdhdGlvblR5cGUgV2ViRGF0YVNvdXJjZUltcGw6Om5hdmlnYXRp b25UeXBlKCkgY29uc3QKIHsKICAgICByZXR1cm4gdG9XZWJOYXZpZ2F0aW9uVHlwZSh0cmlnZ2Vy aW5nQWN0aW9uKCkudHlwZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYkRhdGFTb3VyY2VJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJE YXRhU291cmNlSW1wbC5oCmluZGV4IDA1MzI5ZmY1YTI2MDYwODQwNTVhMjhlNzQxY2UzZDQwY2I2 ZGU5MTYuLjc3MDVjNjE0M2M3YzM5YjM4MzhkOWNlODBiZjIzMjk2OWQyZDZiOWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmgKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuaApAQCAtNjMsNiAr NjMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJVUkwgdW5yZWFjaGFibGVVUkwoKSBjb25z dDsKICAgICB2aXJ0dWFsIHZvaWQgcmVkaXJlY3RDaGFpbihXZWJWZWN0b3I8V2ViVVJMPiYpIGNv bnN0OwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIHBhZ2VUaXRsZSgpIGNvbnN0OworICAgIHZpcnR1 YWwgV2ViVGV4dERpcmVjdGlvbiBwYWdlVGl0bGVEaXJlY3Rpb24oKSBjb25zdDsKICAgICB2aXJ0 dWFsIFdlYk5hdmlnYXRpb25UeXBlIG5hdmlnYXRpb25UeXBlKCkgY29uc3Q7CiAgICAgdmlydHVh bCBkb3VibGUgdHJpZ2dlcmluZ0V2ZW50VGltZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgRXh0cmFE YXRhKiBleHRyYURhdGEoKSBjb25zdDsK 90369 2011-04-20 11:17:42 -0700 2011-04-20 13:30:14 -0700 Patch bug-59010-20110420111715.patch text/plain 3176 evan U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MzdkMzQyMWY5OWVhZDdkNzZlMjA5NTUyM2NlMjA1ZTcyZmI2MWYxZi4uNDg0NmU4NDhlNDhhOGQ2 OGQ3MzJiOTlhNWMyZWYwMGI3MjNmNGU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNC0yMCAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hy b21pdW1dIGV4cG9zZSB0aXRsZSB0ZXh0IGRpcmVjdGlvbiBvbiBXZWJEYXRhU291cmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTAxMAorCisgICAg ICAgICogcHVibGljL1dlYkRhdGFTb3VyY2UuaDoKKyAgICAgICAgKiBzcmMvV2ViRGF0YVNvdXJj ZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEYXRhU291cmNlSW1wbDo6cGFnZVRpdGxl KToKKyAgICAgICAgKFdlYktpdDo6V2ViRGF0YVNvdXJjZUltcGw6OnBhZ2VUaXRsZURpcmVjdGlv bik6CisgICAgICAgICogc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmg6CisKIDIwMTEtMDQtMTkgIE5h b2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJEYXRhU291cmNlLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEYXRh U291cmNlLmgKaW5kZXggMWE4YzI3MGZjOTQ4ZmRkNmM5NzExMTY3N2FiYTk5NmM4OGM2ODQxMy4u ZTQzNjRlOTBkODZlMTM4MzkwYjdmZTRhNjJkYzJlZWQ4MjY4ODIxYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGF0YVNvdXJjZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGFTb3VyY2UuaApAQCAtMzMsNiArMzMsNyBAQAog CiAjaW5jbHVkZSAiV2ViQ29tbW9uLmgiCiAjaW5jbHVkZSAiV2ViTmF2aWdhdGlvblR5cGUuaCIK KyNpbmNsdWRlICJXZWJUZXh0RGlyZWN0aW9uLmgiCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBA IC03OCw2ICs3OSw5IEBAIHB1YmxpYzoKICAgICAvLyBSZXR1cm5zIHRoZSB0aXRsZSBmb3IgdGhl IGN1cnJlbnQgcGFnZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBwYWdlVGl0bGUoKSBjb25zdCA9 IDA7CiAKKyAgICAvLyBSZXR1cm5zIHRoZSB0ZXh0IGRpcmVjdGlvbiBvZiB0aGUgdGl0bGUgZm9y IHRoZSBjdXJyZW50IHBhZ2UuCisgICAgdmlydHVhbCBXZWJUZXh0RGlyZWN0aW9uIHBhZ2VUaXRs ZURpcmVjdGlvbigpIGNvbnN0ID0gMDsKKwogICAgIC8vIFRoZSB0eXBlIG9mIG5hdmlnYXRpb24g dGhhdCB0cmlnZ2VyZWQgdGhlIGNyZWF0aW9uIG9mIHRoaXMgZGF0YXNvdXJjZS4KICAgICB2aXJ0 dWFsIFdlYk5hdmlnYXRpb25UeXBlIG5hdmlnYXRpb25UeXBlKCkgY29uc3QgPSAwOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNlSW1wbC5jcHAKaW5kZXgg MzE3MGFmZmJlNGI0YjFmODQwYzY3NTkwZTlkNmJhYWQ1Nzg1MGU3OC4uNmFhYTVmNTBlMDI1ODU0 OWI4OTEzYjM3NjZhMWZjNGY4NDA5NGVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmNwcApAQCAtODIsMTAgKzgyLDE0IEBAIHZvaWQgV2Vi RGF0YVNvdXJjZUltcGw6OnJlZGlyZWN0Q2hhaW4oV2ViVmVjdG9yPFdlYlVSTD4mIHJlc3VsdCkg Y29uc3QKIAogV2ViU3RyaW5nIFdlYkRhdGFTb3VyY2VJbXBsOjpwYWdlVGl0bGUoKSBjb25zdAog ewotICAgIC8vIEZJWE1FOiB1c2UgZGlyZWN0aW9uIG9mIHRpdGxlIGFzIHdlbGwuCiAgICAgcmV0 dXJuIHRpdGxlKCkuc3RyaW5nKCk7CiB9CiAKK1dlYlRleHREaXJlY3Rpb24gV2ViRGF0YVNvdXJj ZUltcGw6OnBhZ2VUaXRsZURpcmVjdGlvbigpIGNvbnN0Cit7CisgICAgcmV0dXJuIHRpdGxlKCku ZGlyZWN0aW9uKCkgPT0gTFRSID8gV2ViVGV4dERpcmVjdGlvbkxlZnRUb1JpZ2h0IDogV2ViVGV4 dERpcmVjdGlvblJpZ2h0VG9MZWZ0OworfQorCiBXZWJOYXZpZ2F0aW9uVHlwZSBXZWJEYXRhU291 cmNlSW1wbDo6bmF2aWdhdGlvblR5cGUoKSBjb25zdAogewogICAgIHJldHVybiB0b1dlYk5hdmln YXRpb25UeXBlKHRyaWdnZXJpbmdBY3Rpb24oKS50eXBlKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGF0YVNvdXJjZUltcGwuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkRhdGFTb3VyY2VJbXBsLmgKaW5kZXggMDUzMjlmZjVhMjYwNjA4NDA1 NWEyOGU3NDFjZTNkNDBjYjZkZTkxNi4uNzcwNWM2MTQzYzdjMzliMzgzOGQ5Y2U4MGJmMjMyOTY5 ZDJkNmI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGF0YVNv dXJjZUltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEYXRhU291cmNl SW1wbC5oCkBAIC02Myw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYlVSTCB1bnJl YWNoYWJsZVVSTCgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCByZWRpcmVjdENoYWluKFdlYlZl Y3RvcjxXZWJVUkw+JikgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgcGFnZVRpdGxlKCkg Y29uc3Q7CisgICAgdmlydHVhbCBXZWJUZXh0RGlyZWN0aW9uIHBhZ2VUaXRsZURpcmVjdGlvbigp IGNvbnN0OwogICAgIHZpcnR1YWwgV2ViTmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGUoKSBj b25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSB0cmlnZ2VyaW5nRXZlbnRUaW1lKCkgY29uc3Q7CiAg ICAgdmlydHVhbCBFeHRyYURhdGEqIGV4dHJhRGF0YSgpIGNvbnN0Owo=