58990 2011-04-20 07:27:50 -0700 REGRESSION (r84306-r84311?): editing/undo/undo-iframe-location-change.html sometimes fails on SnowLeopard Intel Release (WebKit2 Tests) 2011-04-30 09:50:29 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac (Intel) OS X 10.6 NEW InRadar, LayoutTestFailure, PlatformOnly, Regression P2 Normal --- 1 jberlin webkit-unassigned abarth aroben enrica eric jamesr jberlin piman rniwa webkit.review.bot oldest_to_newest 389210 0 jberlin 2011-04-20 07:27:50 -0700 http://trac.webkit.org/changeset/84307 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r84306%20(10865)/results.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r84311%20(10866)/results.html In addition, I am not really sure why the pixel test results for compositing/iframes/invisible-iframe.html and compositing/iframes/invisible-nested-iframe-hide.html are in the cross-platform directory. I would expect those tests to be failing when run with -p on a bunch of platforms. 389259 1 rniwa 2011-04-20 08:55:17 -0700 Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally. 390777 2 jberlin 2011-04-22 08:08:03 -0700 (In reply to comment #1) > Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally. Just to be sure, you tested with WK2? I ask because it is failing pretty consistently on the SL WK2 bots. Did you get a chance to look into the compositing/iframes/invisible-nested-iframe-show.html failures? 390946 3 enrica 2011-04-22 11:58:35 -0700 I just tested one more time with r84650 on my SnowLeopard machine and I see no failures in the editing tests. 390974 4 rniwa 2011-04-22 12:36:24 -0700 (In reply to comment #2) > (In reply to comment #1) > > Enrica and I investigated the failure of editing/undo/undo-iframe-location-change.html but it passes locally. > > Just to be sure, you tested with WK2? I ask because it is failing pretty consistently on the SL WK2 bots. Yes. > Did you get a chance to look into the compositing/iframes/invisible-nested-iframe-show.html failures? No. 391789 5 jberlin 2011-04-25 09:40:42 -0700 Because these are keeping the SL WK2 bots red, I am going to commit failing expected results soon. 391815 6 webkit.review.bot 2011-04-25 10:26:31 -0700 http://trac.webkit.org/changeset/84783 might have broken Chromium Win Release 391890 7 jberlin 2011-04-25 14:19:45 -0700 Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure). Any ideas as to what happened here? 395795 8 aroben 2011-04-30 04:36:30 -0700 (In reply to comment #7) > Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure). > > Any ideas as to what happened here? I guess the bots must have gone back to their previous behavior, because they aren't red anymore. 395797 9 aroben 2011-04-30 04:41:06 -0700 These two tests seem unlikely to be failing for the same reason. I split out compositing/iframes/invisible-nested-iframe-show.html into a new bug: bug 59864. 395798 10 aroben 2011-04-30 04:42:26 -0700 (In reply to comment #8) > (In reply to comment #7) > > Now I am really confused. As soon as I committed the expected failing results in http://trac.webkit.org/changeset/84783, the editing test started passing on the bots (which is now making the bots red again because it is expecting failure). > > > > Any ideas as to what happened here? > > I guess the bots must have gone back to their previous behavior, because they aren't red anymore. My mistake, this test is indeed failing on the bots (because it's producing successful results, but we have failure results checked in). I guess we should just remove the expected failure results and see if it starts failing again. 395800 11 aroben 2011-04-30 04:48:29 -0700 Looks like this test is flaky: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11238 did fail http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11237 did not fail http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/11235 did fail 395803 12 aroben 2011-04-30 05:03:07 -0700 Added to the mac-wk2 Skipped file in r85397. 395805 13 aroben 2011-04-30 05:07:05 -0700 <rdar://problem/9363346> 395819 14 rniwa 2011-04-30 09:49:21 -0700 There might be some race condition going on here. Maybe when a page navigates in WebProcess, undo stack isn't cleared immediately in UIProcess. 395820 15 eric 2011-04-30 09:50:29 -0700 See also bug 20366.