58987 2011-04-20 07:03:24 -0700 [Qt] Clean the style of our cookie methods 2011-04-20 07:47:45 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED EasyFix, Qt, QtTriaged P5 Enhancement --- 1 benjamin benjamin oldest_to_newest 389197 0 benjamin 2011-04-20 07:03:24 -0700 There are unused variables, invalid char* conversion and useless url conversions. 389201 1 90338 benjamin 2011-04-20 07:08:42 -0700 Created attachment 90338 Patch 389212 2 90338 kling 2011-04-20 07:32:14 -0700 Comment on attachment 90338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90338&action=review Please provide SunSpider numbers. > Source/WebCore/ChangeLog:13 > + (WebCore::cookies): foreach() should use ref to const as for Qt. s/ref to const as/const references/ 389223 3 benjamin 2011-04-20 07:47:45 -0700 Committed r84373: <http://trac.webkit.org/changeset/84373> 90338 2011-04-20 07:08:42 -0700 2011-04-20 07:32:14 -0700 Patch bug-58987-20110420162020.patch text/plain 3272 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ODNkNWIzMzI3MjQ0YjMz MTBlMjc5N2Y2YTcxYTZkYjQyNTkwODM1Li5iNjMxZDAwYTdmODUyMmNmNjU4ZTE4Yzg3ODRiODdi Y2VjMDlmYmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjAgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENsZWFuIHRoZSBzdHlsZSBv ZiBvdXIgY29va2llIG1ldGhvZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU4OTg3CisKKyAgICAgICAgR290IHJpZCBvZiB0aGUgdmFyaWFibGVzIG5h bWVkICJ1IiBpbiBmYXZvciBqdXN0IGNvbnZlcnRpbmcgdGhlIHVybCB3aGVuIG5lZWRlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL3F0L0Nvb2tpZUphclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnNldENvb2tpZXMpOiBUaGUgdmFyaWFibGUgcCB3YXMgdW51c2VkLgorICAgICAgICBUaGUgOjp0 b0FzY2lpKCkgZGVwZW5kcyBvbiB0aGUgZGVmYXVsdCBjb2RlYywgdXNlIHRvTGF0aW4xKCkgaW5z dGVhZC4KKyAgICAgICAgKFdlYkNvcmU6OmNvb2tpZXMpOiBmb3JlYWNoKCkgc2hvdWxkIHVzZSBy ZWYgdG8gY29uc3QgYXMgZm9yIFF0LgorICAgICAgICAoV2ViQ29yZTo6Y29va2llUmVxdWVzdEhl YWRlckZpZWxkVmFsdWUpOgorCiAyMDExLTA0LTIwICBNYXJpdXN6IEdyemVnb3JjenlrICA8bWFy aXVzei5nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKaW5kZXggM2M0Y2Q0 MmE0YzI4ZjJlZjMwYzk4OGJmYTM3NjAxY2M5N2JhYzYxYS4uYmQxMzkwM2M5NTIzNGI1ZTdlNGNj YjY2ZmQzNTUwZGZmNTljZGQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v cXQvQ29va2llSmFyUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0Nvb2tp ZUphclF0LmNwcApAQCAtNTksMTMgKzU5LDExIEBAIHN0YXRpYyBRTmV0d29ya0Nvb2tpZUphciAq Y29va2llSmFyKGNvbnN0IERvY3VtZW50ICpkb2N1bWVudCkKIAogdm9pZCBzZXRDb29raWVzKERv Y3VtZW50KiBkb2N1bWVudCwgY29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHZhbHVlKQog ewotICAgIFFVcmwgdSh1cmwpOwotICAgIFFVcmwgcChkb2N1bWVudC0+Zmlyc3RQYXJ0eUZvckNv b2tpZXMoKSk7CiAgICAgUU5ldHdvcmtDb29raWVKYXIqIGphciA9IGNvb2tpZUphcihkb2N1bWVu dCk7CiAgICAgaWYgKCFqYXIpCiAgICAgICAgIHJldHVybjsKIAotICAgIFFMaXN0PFFOZXR3b3Jr Q29va2llPiBjb29raWVzID0gUU5ldHdvcmtDb29raWU6OnBhcnNlQ29va2llcyhRU3RyaW5nKHZh bHVlKS50b0FzY2lpKCkpOworICAgIFFMaXN0PFFOZXR3b3JrQ29va2llPiBjb29raWVzID0gUU5l dHdvcmtDb29raWU6OnBhcnNlQ29va2llcyhRU3RyaW5nKHZhbHVlKS50b0xhdGluMSgpKTsKICAg ICBRTGlzdDxRTmV0d29ya0Nvb2tpZT46Okl0ZXJhdG9yIGl0ID0gY29va2llcy5iZWdpbigpOwog ICAgIHdoaWxlIChpdCAhPSBjb29raWVzLmVuZCgpKSB7CiAgICAgICAgIGlmIChpdC0+aXNIdHRw T25seSgpKQpAQCAtNzMsMjIgKzcxLDIxIEBAIHZvaWQgc2V0Q29va2llcyhEb2N1bWVudCogZG9j dW1lbnQsIGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKICAgICAgICAgZWxz ZQogICAgICAgICAgICAgKytpdDsKICAgICB9Ci0gICAgamFyLT5zZXRDb29raWVzRnJvbVVybChj b29raWVzLCB1KTsKKyAgICBqYXItPnNldENvb2tpZXNGcm9tVXJsKGNvb2tpZXMsIFFVcmwodXJs KSk7CiB9CiAKIFN0cmluZyBjb29raWVzKGNvbnN0IERvY3VtZW50KiBkb2N1bWVudCwgY29uc3Qg S1VSTCYgdXJsKQogewotICAgIFFVcmwgdSh1cmwpOwogICAgIFFOZXR3b3JrQ29va2llSmFyKiBq YXIgPSBjb29raWVKYXIoZG9jdW1lbnQpOwogICAgIGlmICghamFyKQogICAgICAgICByZXR1cm4g U3RyaW5nKCk7CiAKLSAgICBRTGlzdDxRTmV0d29ya0Nvb2tpZT4gY29va2llcyA9IGphci0+Y29v a2llc0ZvclVybCh1KTsKKyAgICBRTGlzdDxRTmV0d29ya0Nvb2tpZT4gY29va2llcyA9IGphci0+ Y29va2llc0ZvclVybChRVXJsKHVybCkpOwogICAgIGlmIChjb29raWVzLmlzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuIFN0cmluZygpOwogCiAgICAgUVN0cmluZ0xpc3QgcmVzdWx0Q29va2llczsK LSAgICBmb3JlYWNoIChRTmV0d29ya0Nvb2tpZSBuZXR3b3JrQ29va2llLCBjb29raWVzKSB7Cisg ICAgZm9yZWFjaCAoY29uc3QgUU5ldHdvcmtDb29raWUmIG5ldHdvcmtDb29raWUsIGNvb2tpZXMp IHsKICAgICAgICAgaWYgKG5ldHdvcmtDb29raWUuaXNIdHRwT25seSgpKQogICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgIHJlc3VsdENvb2tpZXMuYXBwZW5kKFFTdHJpbmc6OmZyb21MYXRp bjEobmV0d29ya0Nvb2tpZS50b1Jhd0Zvcm0oUU5ldHdvcmtDb29raWU6Ok5hbWVBbmRWYWx1ZU9u bHkpLmNvbnN0RGF0YSgpKSk7CkBAIC05OSwxMiArOTYsMTEgQEAgU3RyaW5nIGNvb2tpZXMoY29u c3QgRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBLVVJMJiB1cmwpCiAKIFN0cmluZyBjb29raWVS ZXF1ZXN0SGVhZGVyRmllbGRWYWx1ZShjb25zdCBEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IEtV UkwgJnVybCkKIHsKLSAgICBRVXJsIHUodXJsKTsKICAgICBRTmV0d29ya0Nvb2tpZUphciogamFy ID0gY29va2llSmFyKGRvY3VtZW50KTsKICAgICBpZiAoIWphcikKICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwogCi0gICAgUUxpc3Q8UU5ldHdvcmtDb29raWU+IGNvb2tpZXMgPSBqYXItPmNvb2tp ZXNGb3JVcmwodSk7CisgICAgUUxpc3Q8UU5ldHdvcmtDb29raWU+IGNvb2tpZXMgPSBqYXItPmNv b2tpZXNGb3JVcmwoUVVybCh1cmwpKTsKICAgICBpZiAoY29va2llcy5pc0VtcHR5KCkpCiAgICAg ICAgIHJldHVybiBTdHJpbmcoKTsKIAo=