58976 2011-04-20 02:57:30 -0700 [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes 2011-04-22 17:31:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned mitz mrobinson oldest_to_newest 389133 0 pnormand 2011-04-20 02:57:30 -0700 Test added in http://trac.webkit.org/changeset/84300 (no bug associated btw) crashes on GTK: #0 0x00002b484b15d9b0 in WebCore::Node::document (this=0x0) at ../../Source/WebCore/dom/Node.h:361 361 ASSERT(this); Thread 1 (Thread 22481): #0 0x00002b484b15d9b0 in WebCore::Node::document (this=0x0) at ../../Source/WebCore/dom/Node.h:361 #1 0x00002b484b55090a in WebCore::Element::innerText (this=0x0) at ../../Source/WebCore/dom/Element.cpp:1610 #2 0x00002b484b1f4c53 in DumpRenderTreeSupportGtk::getInnerText (frame=0x1796b60) at ../../Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:191 #3 0x0000000000420029 in dumpFramesAsText (frame=0x1796b60) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:271 #4 0x0000000000420dec in dump () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:534 #5 0x00000000004218a7 in webViewLoadFinished (view=0x178c030, frame=0x1796b60) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:785 #6 0x00002b484f78333e in g_closure_invoke (closure=0x17f1190, return_value=0x0, n_param_values=2, param_values=0x8ef3cf0, invocation_hint=0x7ffff81544c0) at /tmp/buildd/glib2.0-2.27.91/./gobject/gclosure.c:767 #7 0x00002b484f79c3b9 in signal_emit_unlocked_R (node=0x1729bf0, detail=<value optimized out>, instance=<value optimized out>, emission_return=<value optimized out>, instance_and_params=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3252 #8 0x00002b484f79db36 in g_signal_emit_valist (instance=0x178c030, signal_id=<value optimized out>, detail=0, var_args=0x7ffff81546e0) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:2983 #9 0x00002b484f79de32 in g_signal_emit_by_name (instance=0x178c030, detailed_signal=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3077 #10 0x00002b484b205a96 in WebKit::FrameLoaderClient::postProgressFinishedNotification (this=0x178e3c0) at ../../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:443 #11 0x00002b484b88e6e6 in WebCore::ProgressTracker::finalProgressComplete (this=0x1795220) at ../../Source/WebCore/loader/ProgressTracker.cpp:155 #12 0x00002b484b88e593 in WebCore::ProgressTracker::progressCompleted (this=0x1795220, frame=0x179cc00) at ../../Source/WebCore/loader/ProgressTracker.cpp:134 #13 0x00002b484b8581a7 in WebCore::FrameLoader::checkLoadCompleteForThisFrame (this=0x179cca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2472 #14 0x00002b484b858842 in WebCore::FrameLoader::recursiveCheckLoadComplete (this=0x179cca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2580 #15 0x00002b484b8588f9 in WebCore::FrameLoader::checkLoadComplete (this=0x179cca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2593 #16 0x00002b484b85751e in WebCore::FrameLoader::finishedLoading (this=0x179cca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2240 #17 0x00002b484b889a0a in WebCore::MainResourceLoader::didFinishLoading (this=0x9601a40, finishTime=0) at ../../Source/WebCore/loader/MainResourceLoader.cpp:475 #18 0x00002b484b895cf9 in WebCore::ResourceLoader::didFinishLoading (this=0x9601a40, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:436 #19 0x00002b484b1c9b3c in WebCore::readCallback (source=0x2b485c1131e0, asyncResult=0x2b485c01cb00, data=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:779 #20 0x00002b484f49df65 in async_ready_callback_wrapper (source_object=0x2b485c1131e0, res=0x2b485c01cb00, user_data=0x0) at /tmp/buildd/glib2.0-2.27.91/./gio/ginputstream.c:470 #21 0x00002b484f4af628 in complete_in_idle_cb_for_thread (_data=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gio/gsimpleasyncresult.c:812 #22 0x00002b4850016362 in g_main_dispatch (context=0x1721a30) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:2440 #23 g_main_context_dispatch (context=0x1721a30) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3013 #24 0x00002b485001aa28 in g_main_context_iterate (context=0x1721a30, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3091 #25 0x00002b485001af35 in g_main_loop_run (loop=0x991f7e0) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3299 #26 0x00002b484df89657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #27 0x0000000000421560 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:702 #28 0x0000000000420bfd in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:494 #29 0x0000000000422ebf in main (argc=2, argv=0x7ffff81558a8) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1179 389134 1 pnormand 2011-04-20 03:02:57 -0700 Skipped in r84354 389467 2 mrobinson 2011-04-20 13:23:08 -0700 I think we just need to return the empty string when the documentElement is null. Uploading a patch which I've confirmed fixes the crash locally. 389469 3 90396 mrobinson 2011-04-20 13:23:34 -0700 Created attachment 90396 Patch 391265 4 90396 xan.lopez 2011-04-22 17:28:20 -0700 Comment on attachment 90396 Patch r=me 391267 5 90396 mrobinson 2011-04-22 17:31:03 -0700 Comment on attachment 90396 Patch Clearing flags on attachment: 90396 Committed r84713: <http://trac.webkit.org/changeset/84713> 391268 6 mrobinson 2011-04-22 17:31:06 -0700 All reviewed patches have been landed. Closing bug. 90396 2011-04-20 13:23:34 -0700 2011-04-22 17:31:03 -0700 Patch bug-58976-20110420132335.patch text/plain 2895 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNzgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyYzdjNjJiODcwZGMwM2Y3NDJhMjdh OWNmNTdmZTg0MzMxZTk0ODQ3Li4xODIzYjhjMjFkNDczNjdjNTY2OGQ4ZGIzYWU2NmQ5NzcwYzI2 OTE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDQtMjAgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHVEtdIGZhc3QvZXZlbnRzL292ZXJmbG93LXZpZXdwb3J0LXJlbmRl cmVyLWRlbGV0ZWQuaHRtbCBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01ODk3NgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6 IFVuc2tpcCBhIHRlc3Qgd2hpY2ggaXMgbm8gbG9uZ2VyIGNyYXNoaW5nLgorCisyMDExLTA0LTIw ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBwbGF0 Zm9ybS9ndGsvZmFzdC9kb20vZ2MtMTAtZXhwZWN0ZWQucG5nIGlzIGNvcnJ1cHQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTQwCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQKaW5kZXggMDU4ZmQ1ZGY1ZjgyOTM2ZmNmYzFlZWYyODZkZTM5Y2NiODRj YmZkNS4uYjU3MDk4YjYyZGUxZjVmYWFlNzJjZjIwNmU5ODk4Nzc2NzE5MWJjOSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKQEAgLTE4Niw5ICsxODYsNiBAQCBzdmcvdGV4dC90ZXh0LWRlY28t MDEtYi5zdmcKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4ODE4 CiBmYXN0L2Jsb2NrL2Zsb2F0L292ZXJoYW5naW5nLXRhbGwtYmxvY2suaHRtbAogCi0jIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODk3NgotZmFzdC9ldmVudHMvb3Zl cmZsb3ctdmlld3BvcnQtcmVuZGVyZXItZGVsZXRlZC5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTg4CiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0 LWVtcHR5LXZlcnNpb24uaHRtbAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNjVkZmNjODAwY2Q2NTg1 MGQwM2RmOGQwN2ZhOGExMTVlMzQ4OTIyMy4uODNmYWE3ODU4ZGIwNmNmYWMyNDkyMzNkMDdjYmVl NWY2MzdjOTUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTIw ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBmYXN0L2V2ZW50cy9vdmVy Zmxvdy12aWV3cG9ydC1yZW5kZXJlci1kZWxldGVkLmh0bWwgY3Jhc2hlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5NzYKKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHA6CisgICAgICAgIChEdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGs6OmdldElubmVyVGV4dCk6IEd1YXJkIGFnYWluc3Qgc2l0dWF0 aW9ucyB3aGVuIHRoZSBkb2N1bWVudEVsZW1lbnQKKyAgICAgICAgbWV0aG9kIG9mIHRoZSBkb2N1 bWVudCByZXR1cm5zIG51bGwuCisKIDIwMTEtMDQtMTkgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZp a0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVu ZGVyVHJlZVN1cHBvcnRHdGsuY3BwCmluZGV4IDFjZTBhZGE3MzM4Nzc5OWVjOTM0NmE3MjllNTkx YTQyYTg3NjYwOTMuLjIwOWJjMmM2NTRkYmNiZmIxMDk4Yzc0N2NlMjRmMTc5MTE0OWNmMDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydEd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcApAQCAtMTgzLDExICsxODMsMTIgQEAgQ1N0cmluZyBE dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OmdldElubmVyVGV4dChXZWJLaXRXZWJGcmFtZSogZnJh bWUpCiAgICAgICAgIHJldHVybiBDU3RyaW5nKCIiKTsKIAogICAgIEZyYW1lVmlldyogdmlldyA9 IGNvcmVGcmFtZS0+dmlldygpOwotCiAgICAgaWYgKHZpZXcgJiYgdmlldy0+bGF5b3V0UGVuZGlu ZygpKQogICAgICAgICB2aWV3LT5sYXlvdXQoKTsKIAogICAgIEVsZW1lbnQqIGRvY3VtZW50RWxl bWVudCA9IGNvcmVGcmFtZS0+ZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50KCk7CisgICAgaWYg KCFkb2N1bWVudEVsZW1lbnQpCisgICAgICAgIHJldHVybiBDU3RyaW5nKCIiKTsKICAgICByZXR1 cm4gZG9jdW1lbnRFbGVtZW50LT5pbm5lclRleHQoKS51dGY4KCk7CiB9CiAK