58968 2011-04-20 00:06:53 -0700 [GTK] Build libWebCore with the gtk sources too 2011-04-20 15:43:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 389100 0 cgarcia 2011-04-20 00:06:53 -0700 Currently webcore gtk sources are compiled as part of the libwebkitgtk sources, I think they should be moved to libWebCore, since libwebkitgtk already uses libWebCore.la. 389102 1 90319 cgarcia 2011-04-20 00:10:37 -0700 Created attachment 90319 Patch This change also improves the build time. 389247 2 90319 mrobinson 2011-04-20 08:41:39 -0700 Comment on attachment 90319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90319&action=review > Source/WebCore/ChangeLog:8 > + [GTK] Build libWebCore with the gtk sources too > + https://bugs.webkit.org/show_bug.cgi?id=58968 > + > + * GNUmakefile.am: Add webcore gtk sources to libWebCore sources. Please include in your ChangeLog the motivations for this change, so that people browsing the repository know what's up. 389278 3 cgarcia 2011-04-20 09:21:48 -0700 Committed r84381: <http://trac.webkit.org/changeset/84381> 389578 4 webkit.review.bot 2011-04-20 15:43:50 -0700 http://trac.webkit.org/changeset/84381 might have broken WinCairo Debug (Build) 90319 2011-04-20 00:10:37 -0700 2011-04-20 10:40:55 -0700 Patch webcore-gtk.diff text/plain 2104 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiY2U3N2UwLi5iM2U2ZTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEJ1aWxkIGxpYldlYkNvcmUgd2l0aCB0aGUgZ3RrIHNvdXJjZXMgdG9vCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODk2OAorCisgICAgICAgICogR05V bWFrZWZpbGUuYW06IEFkZCB3ZWJjb3JlIGd0ayBzb3VyY2VzIHRvIGxpYldlYkNvcmUgc291cmNl cy4KKwogMjAxMS0wNC0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjgzOTk2LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtl ZmlsZS5hbQppbmRleCBkNjhlYzI3Li5lMjA1OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAt NzIwLDcgKzcyMCw4IEBAIG5vZGlzdF9saWJXZWJDb3JlX2xhX1NPVVJDRVMgPSBcCiAJJCh3ZWJj b3JlX2J1aWx0X3NvdXJjZXMpCiAKIGxpYldlYkNvcmVfbGFfU09VUkNFUyA9IFwKLQkkKHdlYmNv cmVfc291cmNlcykKKwkkKHdlYmNvcmVfc291cmNlcykgXAorCSQod2ViY29yZWd0a19zb3VyY2Vz KQogCiBsaWJXZWJDb3JlX2xhX0NYWEZMQUdTID0gXAogCSQoU1lNQk9MX1ZJU0lCSUxJVFlfSU5M SU5FUykgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGE1OTNhNzQuLjBlZmVlNGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNC0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0dUS10gQnVpbGQgbGliV2ViQ29yZSB3aXRoIHRoZSBndGsgc291cmNl cyB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4 OTY4CisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogUmVtb3ZlIHdlYmNvcmUgZ3RrIHNvdXJj ZXMgZnJvbSBsaWJ3ZWJraXRndGsKKyAgICAgICAgc291cmNlcy4KKwogMjAxMS0wNC0xMiAgWGFu IExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm aXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbSBiL1NvdXJj ZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCmluZGV4IDIwNTY3Y2MuLmVlYjllZjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJL aXQvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC0xOCw3ICsxOCw2IEBAIG5vZGlzdF9saWJ3ZWJraXRn dGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkBfQFdFQktJVEdUS19BUElfTUlOT1JfVkVS U0lPTkBfCiAJJChHRU5TT1VSQ0VTX1dFQktJVCkvd2Via2l0ZW51bXR5cGVzLmgKIAogbGlid2Vi a2l0Z3RrX0BXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05AX0BXRUJLSVRHVEtfQVBJX01JTk9S X1ZFUlNJT05AX2xhX1NPVVJDRVMgPSBcCi0JJCh3ZWJjb3JlZ3RrX3NvdXJjZXMpIFwKIAkkKHdl YmtpdGd0a19zb3VyY2VzKQogCiBsaWJ3ZWJraXRndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVS U0lPTkBfQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkBfbGFfQ1hYRkxBR1MgPSBcCg==