58960 2011-04-19 20:58:10 -0700 [Chromium]Mac UI polish to add left/right padding space for autofill popup window. 2011-04-22 10:26:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 honten webkit-unassigned commit-queue dglazkov dhollowa eric honten isherman mark thakis oldest_to_newest 389034 0 honten 2011-04-19 20:58:10 -0700 [Chromium]Mac UI polish to add left/right padding space for autofill popup window. 389036 1 90299 honten 2011-04-19 21:08:22 -0700 Created attachment 90299 Patch 389037 2 thakis 2011-04-19 21:11:47 -0700 Can you please upload before and after screenshots to (e.g.) dropmocks.com and paste the link here? 389039 3 honten 2011-04-19 21:13:32 -0700 Sure, Just a moment... (In reply to comment #2) > Can you please upload before and after screenshots to (e.g.) dropmocks.com and paste the link here? 389047 4 honten 2011-04-19 21:47:07 -0700 Here it is, http://dropmocks.com/mUKYr Now I specify 4px like Linux and Win platforms. (In reply to comment #3) > Sure, > > Just a moment... > > (In reply to comment #2) > > Can you please upload before and after screenshots to (e.g.) dropmocks.com and paste the link here? 389233 5 thakis 2011-04-20 08:14:59 -0700 LGTM as far as I can tell (I think we use text popups only for autofill, not for dropdown menus, on mac). I'm not very familiar with the theme stuff – Eric is, and he's a reviewer too, so I'm ccing him. Eric, can you take a look? It's a short patch. 389243 6 90299 eric 2011-04-20 08:34:56 -0700 Comment on attachment 90299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review Seems OK to me besides the nits below. > Source/WebCore/ChangeLog:9 > + No new test because Chromium Autofill popup window doesn't have any test framework. Thank you for explaining. > Source/WebCore/ChangeLog:12 > + The code should be removed after Autofill popup window logic is separated from WebKit to Chromium. Can you provide more context? like a bug link? > Source/WebCore/rendering/RenderThemeChromiumMac.h:59 > + int popupInternalPaddingLeft(RenderStyle*) const; > + int popupInternalPaddingRight(RenderStyle*) const; Aren't these virtual calls? (we always mark virtual calls as virtual even though it's not strictly required by the spec). 389261 7 dhollowa 2011-04-20 09:01:34 -0700 The corresponding Chromium bug is: http://crbug.com/51077 This is a follow-up to WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=58505 (In reply to comment #6) > (From update of attachment 90299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review > > Seems OK to me besides the nits below. > > > Source/WebCore/ChangeLog:9 > > + No new test because Chromium Autofill popup window doesn't have any test framework. > > Thank you for explaining. > > > Source/WebCore/ChangeLog:12 > > + The code should be removed after Autofill popup window logic is separated from WebKit to Chromium. > > Can you provide more context? like a bug link? > > > Source/WebCore/rendering/RenderThemeChromiumMac.h:59 > > + int popupInternalPaddingLeft(RenderStyle*) const; > > + int popupInternalPaddingRight(RenderStyle*) const; > > Aren't these virtual calls? (we always mark virtual calls as virtual even though it's not strictly required by the spec). 389305 8 90299 isherman 2011-04-20 09:57:13 -0700 Comment on attachment 90299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review > Source/WebCore/ChangeLog:10 > + This assumes only AutofillPopupMenuClient gives TexfieldPart appearance. nit: "Texfield" -> "TextField" > Source/WebCore/rendering/RenderThemeChromiumMac.mm:83 > + nit: "autofillPopupHorizontalPadding" might be a better name for this variable -- your call > Source/WebCore/rendering/RenderThemeChromiumMac.mm:85 > +// We assume only AutofillPopupMenuClient gives TexfieldPart appearance here. nit: "Texfield" -> "TextField" 389544 9 honten 2011-04-20 14:48:24 -0700 Thank you for review, guys!! (In reply to comment #6) > (From update of attachment 90299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90299&action=review > > Source/WebCore/ChangeLog:12 > > + The code should be removed after Autofill popup window logic is separated from WebKit to Chromium. > > Can you provide more context? like a bug link? I already included the link in ChangeLog as following, + [Chromium]Mac UI polish to add left/right padding space for autofill popup window. + https://bugs.webkit.org/show_bug.cgi?id=58960 + http://code.google.com/p/chromium/issues/detail?id=51077 Do I have to add more extra info? > > > Source/WebCore/rendering/RenderThemeChromiumMac.h:59 > > + int popupInternalPaddingLeft(RenderStyle*) const; > > + int popupInternalPaddingRight(RenderStyle*) const; > > Aren't these virtual calls? (we always mark virtual calls as virtual even though it's not strictly required by the spec). Yes, you are right. I'll add them. 389739 10 90470 honten 2011-04-20 18:50:12 -0700 Created attachment 90470 Patch 390329 11 90470 honten 2011-04-21 14:19:44 -0700 Comment on attachment 90470 Patch Could you please review again? 390338 12 thakis 2011-04-21 14:27:42 -0700 Nit: const implicitly has internal linkage, so you can drop the static in front of it. 390529 13 90648 honten 2011-04-21 18:42:16 -0700 Created attachment 90648 Patch 390530 14 90648 honten 2011-04-21 18:42:46 -0700 Comment on attachment 90648 Patch Erased static. Please review again. 390621 15 90648 thakis 2011-04-21 22:44:22 -0700 Comment on attachment 90648 Patch This can land with Eric's r+. 390648 16 90648 commit-queue 2011-04-22 00:08:54 -0700 Comment on attachment 90648 Patch Rejecting attachment 90648 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1 Last 500 characters of output: pe=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 90648 from bug 58960. NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Full output: http://queues.webkit.org/results/8495324 390656 17 90648 honten 2011-04-22 00:34:25 -0700 Comment on attachment 90648 Patch Eric, could you r+? 390863 18 90648 commit-queue 2011-04-22 10:26:02 -0700 Comment on attachment 90648 Patch Clearing flags on attachment: 90648 Committed r84640: <http://trac.webkit.org/changeset/84640> 390864 19 commit-queue 2011-04-22 10:26:08 -0700 All reviewed patches have been landed. Closing bug. 90299 2011-04-19 21:08:22 -0700 2011-04-20 18:50:08 -0700 Patch bug-58960-20110419210821.patch text/plain 3730 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODQwNDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYjEyYzNkZWUyY2ZjYTUw M2FmOTZkZTQ0YmM1MWVmZDQ0M2NjNmUyLi41OGZmNTQzOTVjYThjOTA4YjhkZGQ3ZmJhM2RmNjY0 NjFkNTIyYTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMTkgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXU1hYyBVSSBwb2xpc2ggdG8gYWRk IGxlZnQvcmlnaHQgcGFkZGluZyBzcGFjZSBmb3IgYXV0b2ZpbGwgcG9wdXAgd2luZG93LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5NjAKKyAgICAg ICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NTEw NzcKKworICAgICAgICBObyBuZXcgdGVzdCBiZWNhdXNlIENocm9taXVtIEF1dG9maWxsIHBvcHVw IHdpbmRvdyBkb2Vzbid0IGhhdmUgYW55IHRlc3QgZnJhbWV3b3JrLgorICAgICAgICBUaGlzIGFz c3VtZXMgb25seSBBdXRvZmlsbFBvcHVwTWVudUNsaWVudCBnaXZlcyBUZXhmaWVsZFBhcnQgYXBw ZWFyYW5jZS4KKyAgICAgICAgT25seSBpZiBBdXRvZmlsbCBwb3B1cCB3aW5kb3cgaGFzIHJpZ2h0 L2xlZnQgcGFkZGluZy4KKyAgICAgICAgVGhlIGNvZGUgc2hvdWxkIGJlIHJlbW92ZWQgYWZ0ZXIg QXV0b2ZpbGwgcG9wdXAgd2luZG93IGxvZ2ljIGlzIHNlcGFyYXRlZCBmcm9tIFdlYktpdCB0byBD aHJvbWl1bS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmg6 IEFkZCBwb3B1cEludGVybmFsUGFkZGluZ1JpZ2h0KCkgYW5kIHBvcHVwSW50ZXJuYWxQYWRkaW5n TGVmdCgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9wdXBJbnRlcm5hbFBh ZGRpbmdMZWZ0KTogUmV0dXJuIHBhZGRpbmcgc2l6ZSBvbmx5IGlmIFRleHRmaWVsZFBhcnQgaXMg c3BlY2lmaWVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9w dXBJbnRlcm5hbFBhZGRpbmdSaWdodCk6IFJldHVybiBwYWRkaW5nIHNpemUgb25seSBpZiBUZXh0 ZmllbGRQYXJ0IGlzIHNwZWNpZmllZC4KKwogMjAxMS0wNC0xNSAgS2VubmV0aCBSdXNzZWxsICA8 a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ2hyb21pdW0gTGludXggUmVs ZWFzZSBidWlsZCBmaXggZHVlIHRvIHVudXNlZCB2YXJpYWJsZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaAppbmRleCBkY2IyM2RkZTUz YTZhYzdjYWY5ZjE5MDRiOGY4NTM2NjVkZTk1MGY4Li44Y2QwZTFlM2M2OWIxMTQwMzVlNmNmODZi M2I5Y2Q2NWU3N2U0NDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVDaHJvbWl1bU1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUNocm9taXVtTWFjLmgKQEAgLTU0LDYgKzU0LDkgQEAgcHJvdGVjdGVkOgogCiAgICAg dmlydHVhbCBib29sIHVzZXNUZXN0TW9kZUZvY3VzUmluZ0NvbG9yKCkgY29uc3Q7CiAgICAgdmly dHVhbCBOU1ZpZXcqIGRvY3VtZW50Vmlld0ZvcihSZW5kZXJPYmplY3QqKSBjb25zdDsKKworICAg IGludCBwb3B1cEludGVybmFsUGFkZGluZ0xlZnQoUmVuZGVyU3R5bGUqKSBjb25zdDsKKyAgICBp bnQgcG9wdXBJbnRlcm5hbFBhZGRpbmdSaWdodChSZW5kZXJTdHlsZSopIGNvbnN0OwogcHJpdmF0 ZToKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQWN0aXZlU3RhdGUoTlNDZWxsKiwgY29uc3QgUmVu ZGVyT2JqZWN0Kik7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bU1hYy5tbQppbmRleCBlNGExMGFlYTYzZjg5ODljMGNkNjRjYTkxYzJiNjQ1 MDJlYjUxMjBhLi44YWE5MmI5YzJiYTAzMWMyNjllZWIxOWE5ODhmYjkwODEzYjk1NDkwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5t bQpAQCAtNzksNiArNzksMjggQEAgTlNWaWV3KiBSZW5kZXJUaGVtZUNocm9taXVtTWFjOjpkb2N1 bWVudFZpZXdGb3IoUmVuZGVyT2JqZWN0KikgY29uc3QKICAgICByZXR1cm4gRmxpcHBlZFZpZXco KTsKIH0KIAorc3RhdGljIGNvbnN0IGludCBhdXRvZmlsbFBvcHVwUGFkZGluZ0xlZnRSaWdodCA9 IDQ7CisKKy8vIFRoZXNlIGZ1bmN0aW9ucyBhcmUgY2FsbGVkIHdpdGggTWVudUxpc3RQYXJ0IG9y IE1lbnVsaXN0QnV0dG9uUGFydCBhcHBlYXJhbmNlIGJ5IFJlbmRlck1lbnVMaXN0LCBvciB3aXRo IFRleHRmaWVsZFBhcnQgYXBwZWFyYW5jZSBieSBBdXRvZmlsbFBvcHVwTWVudUNsaWVudC4KKy8v IFdlIGFzc3VtZSBvbmx5IEF1dG9maWxsUG9wdXBNZW51Q2xpZW50IGdpdmVzIFRleGZpZWxkUGFy dCBhcHBlYXJhbmNlIGhlcmUuCisvLyBXZSB3YW50IHRvIGNoYW5nZSBvbmx5IEF1dG9maWxsIHBh ZGRpbmcuCisvLyBJbiB0aGUgZnV0dXJlLCB3ZSBoYXZlIHRvIHNlcGFyYXRlIEF1dG9maWxsIHBv cHVwIHdpbmRvdyBsb2dpYyBmcm9tIFdlYktpdCB0byBDaHJvbWl1bS4KK2ludCBSZW5kZXJUaGVt ZUNocm9taXVtTWFjOjpwb3B1cEludGVybmFsUGFkZGluZ0xlZnQoUmVuZGVyU3R5bGUqIHN0eWxl KSBjb25zdAoreworICAgIGlmIChzdHlsZS0+YXBwZWFyYW5jZSgpID09IFRleHRGaWVsZFBhcnQp CisgICAgICAgIHJldHVybiBhdXRvZmlsbFBvcHVwUGFkZGluZ0xlZnRSaWdodDsKKworICAgIHJl dHVybiBSZW5kZXJUaGVtZU1hYzo6cG9wdXBJbnRlcm5hbFBhZGRpbmdMZWZ0KHN0eWxlKTsKK30K KworaW50IFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnBvcHVwSW50ZXJuYWxQYWRkaW5nUmlnaHQo UmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdAoreworICAgIGlmIChzdHlsZS0+YXBwZWFyYW5jZSgp ID09IFRleHRGaWVsZFBhcnQpCisgICAgICAgIHJldHVybiBhdXRvZmlsbFBvcHVwUGFkZGluZ0xl ZnRSaWdodDsKKworICAgIHJldHVybiBSZW5kZXJUaGVtZU1hYzo6cG9wdXBJbnRlcm5hbFBhZGRp bmdSaWdodChzdHlsZSk7Cit9CisKIC8vIFVwZGF0ZXMgdGhlIGNvbnRyb2wgdGludCAoYS5rLmEu IGFjdGl2ZSBzdGF0ZSkgb2YgfGNlbGx8IChmcm9tIHxvfCkuCiAvLyBJbiB0aGUgQ2hyb21pdW0g cG9ydCwgdGhlIHJlbmRlcmVyIHJ1bnMgYXMgYSBiYWNrZ3JvdW5kIHByb2Nlc3MgYW5kIGNvbnRy b2xzJwogLy8gTlNDZWxsKHMpIGxhY2sgYSBwYXJlbnQgTlNWaWV3LiBUaGVyZWZvcmUgY29udHJv bHMgZG9uJ3QgaGF2ZSB0aGVpciB0aW50Cg== 90470 2011-04-20 18:50:12 -0700 2011-04-21 18:42:13 -0700 Patch bug-58960-20110420185010.patch text/plain 3749 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODQwNDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYjEyYzNkZWUyY2ZjYTUw M2FmOTZkZTQ0YmM1MWVmZDQ0M2NjNmUyLi5jODBlYWE2ZGVhODMxZmYyYzdjZDEzYWJjMjEwMWY5 ZTYzMTA2N2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMTkgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXU1hYyBVSSBwb2xpc2ggdG8gYWRk IGxlZnQvcmlnaHQgcGFkZGluZyBzcGFjZSBmb3IgYXV0b2ZpbGwgcG9wdXAgd2luZG93LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5NjAKKyAgICAg ICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NTEw NzcKKworICAgICAgICBObyBuZXcgdGVzdCBiZWNhdXNlIENocm9taXVtIEF1dG9maWxsIHBvcHVw IHdpbmRvdyBkb2Vzbid0IGhhdmUgYW55IHRlc3QgZnJhbWV3b3JrLgorICAgICAgICBUaGlzIGFz c3VtZXMgb25seSBBdXRvZmlsbFBvcHVwTWVudUNsaWVudCBnaXZlcyBUZXhGaWVsZFBhcnQgYXBw ZWFyYW5jZS4KKyAgICAgICAgT25seSBpZiBBdXRvZmlsbCBwb3B1cCB3aW5kb3cgaGFzIHJpZ2h0 L2xlZnQgcGFkZGluZy4KKyAgICAgICAgVGhlIGNvZGUgc2hvdWxkIGJlIHJlbW92ZWQgYWZ0ZXIg QXV0b2ZpbGwgcG9wdXAgd2luZG93IGxvZ2ljIGlzIHNlcGFyYXRlZCBmcm9tIFdlYktpdCB0byBD aHJvbWl1bS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmg6 IEFkZCBwb3B1cEludGVybmFsUGFkZGluZ1JpZ2h0KCkgYW5kIHBvcHVwSW50ZXJuYWxQYWRkaW5n TGVmdCgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9wdXBJbnRlcm5hbFBh ZGRpbmdMZWZ0KTogUmV0dXJuIHBhZGRpbmcgc2l6ZSBvbmx5IGlmIFRleHRGaWVsZFBhcnQgaXMg c3BlY2lmaWVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9w dXBJbnRlcm5hbFBhZGRpbmdSaWdodCk6IFJldHVybiBwYWRkaW5nIHNpemUgb25seSBpZiBUZXh0 RmllbGRQYXJ0IGlzIHNwZWNpZmllZC4KKwogMjAxMS0wNC0xNSAgS2VubmV0aCBSdXNzZWxsICA8 a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ2hyb21pdW0gTGludXggUmVs ZWFzZSBidWlsZCBmaXggZHVlIHRvIHVudXNlZCB2YXJpYWJsZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaAppbmRleCBkY2IyM2RkZTUz YTZhYzdjYWY5ZjE5MDRiOGY4NTM2NjVkZTk1MGY4Li44NGI0ZGJkNjNmODRjOTE5MGY1MDE3ZTRi ZjZhM2I2ZTliZmI0ZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVDaHJvbWl1bU1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUNocm9taXVtTWFjLmgKQEAgLTU0LDYgKzU0LDkgQEAgcHJvdGVjdGVkOgogCiAgICAg dmlydHVhbCBib29sIHVzZXNUZXN0TW9kZUZvY3VzUmluZ0NvbG9yKCkgY29uc3Q7CiAgICAgdmly dHVhbCBOU1ZpZXcqIGRvY3VtZW50Vmlld0ZvcihSZW5kZXJPYmplY3QqKSBjb25zdDsKKworICAg IHZpcnR1YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nTGVmdChSZW5kZXJTdHlsZSopIGNvbnN0 OworICAgIHZpcnR1YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nUmlnaHQoUmVuZGVyU3R5bGUq KSBjb25zdDsKIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUFjdGl2ZVN0YXRlKE5T Q2VsbCosIGNvbnN0IFJlbmRlck9iamVjdCopOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0KaW5kZXggZTRhMTBhZWE2M2Y4OTg5 YzBjZDY0Y2E5MWMyYjY0NTAyZWI1MTIwYS4uYmVkYjRkOTliYzczMmY3NTZlZmJhMjQ3YWEzYTJl NjUyNjVmN2Q5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1NYWMubW0KQEAgLTc5LDYgKzc5LDI4IEBAIE5TVmlldyogUmVuZGVyVGhlbWVD aHJvbWl1bU1hYzo6ZG9jdW1lbnRWaWV3Rm9yKFJlbmRlck9iamVjdCopIGNvbnN0CiAgICAgcmV0 dXJuIEZsaXBwZWRWaWV3KCk7CiB9CiAKK3N0YXRpYyBjb25zdCBpbnQgYXV0b2ZpbGxQb3B1cEhv cml6b250YWxQYWRkaW5nID0gNDsKKworLy8gVGhlc2UgZnVuY3Rpb25zIGFyZSBjYWxsZWQgd2l0 aCBNZW51TGlzdFBhcnQgb3IgTWVudWxpc3RCdXR0b25QYXJ0IGFwcGVhcmFuY2UgYnkgUmVuZGVy TWVudUxpc3QsIG9yIHdpdGggVGV4dEZpZWxkUGFydCBhcHBlYXJhbmNlIGJ5IEF1dG9maWxsUG9w dXBNZW51Q2xpZW50LgorLy8gV2UgYXNzdW1lIG9ubHkgQXV0b2ZpbGxQb3B1cE1lbnVDbGllbnQg Z2l2ZXMgVGV4ZmllbGRQYXJ0IGFwcGVhcmFuY2UgaGVyZS4KKy8vIFdlIHdhbnQgdG8gY2hhbmdl IG9ubHkgQXV0b2ZpbGwgcGFkZGluZy4KKy8vIEluIHRoZSBmdXR1cmUsIHdlIGhhdmUgdG8gc2Vw YXJhdGUgQXV0b2ZpbGwgcG9wdXAgd2luZG93IGxvZ2ljIGZyb20gV2ViS2l0IHRvIENocm9taXVt LgoraW50IFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnBvcHVwSW50ZXJuYWxQYWRkaW5nTGVmdChS ZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0Cit7CisgICAgaWYgKHN0eWxlLT5hcHBlYXJhbmNlKCkg PT0gVGV4dEZpZWxkUGFydCkKKyAgICAgICAgcmV0dXJuIGF1dG9maWxsUG9wdXBIb3Jpem9udGFs UGFkZGluZzsKKworICAgIHJldHVybiBSZW5kZXJUaGVtZU1hYzo6cG9wdXBJbnRlcm5hbFBhZGRp bmdMZWZ0KHN0eWxlKTsKK30KKworaW50IFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OnBvcHVwSW50 ZXJuYWxQYWRkaW5nUmlnaHQoUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdAoreworICAgIGlmIChz dHlsZS0+YXBwZWFyYW5jZSgpID09IFRleHRGaWVsZFBhcnQpCisgICAgICAgIHJldHVybiBhdXRv ZmlsbFBvcHVwSG9yaXpvbnRhbFBhZGRpbmc7CisKKyAgICByZXR1cm4gUmVuZGVyVGhlbWVNYWM6 OnBvcHVwSW50ZXJuYWxQYWRkaW5nUmlnaHQoc3R5bGUpOworfQorCiAvLyBVcGRhdGVzIHRoZSBj b250cm9sIHRpbnQgKGEuay5hLiBhY3RpdmUgc3RhdGUpIG9mIHxjZWxsfCAoZnJvbSB8b3wpLgog Ly8gSW4gdGhlIENocm9taXVtIHBvcnQsIHRoZSByZW5kZXJlciBydW5zIGFzIGEgYmFja2dyb3Vu ZCBwcm9jZXNzIGFuZCBjb250cm9scycKIC8vIE5TQ2VsbChzKSBsYWNrIGEgcGFyZW50IE5TVmll dy4gVGhlcmVmb3JlIGNvbnRyb2xzIGRvbid0IGhhdmUgdGhlaXIgdGludAo= 90648 2011-04-21 18:42:16 -0700 2011-04-22 10:26:02 -0700 Patch bug-58960-20110421184215.patch text/plain 3742 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODQwNDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYjEyYzNkZWUyY2ZjYTUw M2FmOTZkZTQ0YmM1MWVmZDQ0M2NjNmUyLi5jODBlYWE2ZGVhODMxZmYyYzdjZDEzYWJjMjEwMWY5 ZTYzMTA2N2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMTkgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXU1hYyBVSSBwb2xpc2ggdG8gYWRk IGxlZnQvcmlnaHQgcGFkZGluZyBzcGFjZSBmb3IgYXV0b2ZpbGwgcG9wdXAgd2luZG93LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5NjAKKyAgICAg ICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9NTEw NzcKKworICAgICAgICBObyBuZXcgdGVzdCBiZWNhdXNlIENocm9taXVtIEF1dG9maWxsIHBvcHVw IHdpbmRvdyBkb2Vzbid0IGhhdmUgYW55IHRlc3QgZnJhbWV3b3JrLgorICAgICAgICBUaGlzIGFz c3VtZXMgb25seSBBdXRvZmlsbFBvcHVwTWVudUNsaWVudCBnaXZlcyBUZXhGaWVsZFBhcnQgYXBw ZWFyYW5jZS4KKyAgICAgICAgT25seSBpZiBBdXRvZmlsbCBwb3B1cCB3aW5kb3cgaGFzIHJpZ2h0 L2xlZnQgcGFkZGluZy4KKyAgICAgICAgVGhlIGNvZGUgc2hvdWxkIGJlIHJlbW92ZWQgYWZ0ZXIg QXV0b2ZpbGwgcG9wdXAgd2luZG93IGxvZ2ljIGlzIHNlcGFyYXRlZCBmcm9tIFdlYktpdCB0byBD aHJvbWl1bS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLmg6 IEFkZCBwb3B1cEludGVybmFsUGFkZGluZ1JpZ2h0KCkgYW5kIHBvcHVwSW50ZXJuYWxQYWRkaW5n TGVmdCgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9wdXBJbnRlcm5hbFBh ZGRpbmdMZWZ0KTogUmV0dXJuIHBhZGRpbmcgc2l6ZSBvbmx5IGlmIFRleHRGaWVsZFBhcnQgaXMg c3BlY2lmaWVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9w dXBJbnRlcm5hbFBhZGRpbmdSaWdodCk6IFJldHVybiBwYWRkaW5nIHNpemUgb25seSBpZiBUZXh0 RmllbGRQYXJ0IGlzIHNwZWNpZmllZC4KKwogMjAxMS0wNC0xNSAgS2VubmV0aCBSdXNzZWxsICA8 a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ2hyb21pdW0gTGludXggUmVs ZWFzZSBidWlsZCBmaXggZHVlIHRvIHVudXNlZCB2YXJpYWJsZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMuaAppbmRleCBkY2IyM2RkZTUz YTZhYzdjYWY5ZjE5MDRiOGY4NTM2NjVkZTk1MGY4Li44NGI0ZGJkNjNmODRjOTE5MGY1MDE3ZTRi ZjZhM2I2ZTliZmI0ZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVDaHJvbWl1bU1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUNocm9taXVtTWFjLmgKQEAgLTU0LDYgKzU0LDkgQEAgcHJvdGVjdGVkOgogCiAgICAg dmlydHVhbCBib29sIHVzZXNUZXN0TW9kZUZvY3VzUmluZ0NvbG9yKCkgY29uc3Q7CiAgICAgdmly dHVhbCBOU1ZpZXcqIGRvY3VtZW50Vmlld0ZvcihSZW5kZXJPYmplY3QqKSBjb25zdDsKKworICAg IHZpcnR1YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nTGVmdChSZW5kZXJTdHlsZSopIGNvbnN0 OworICAgIHZpcnR1YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nUmlnaHQoUmVuZGVyU3R5bGUq KSBjb25zdDsKIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUFjdGl2ZVN0YXRlKE5T Q2VsbCosIGNvbnN0IFJlbmRlck9iamVjdCopOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0KaW5kZXggZTRhMTBhZWE2M2Y4OTg5 YzBjZDY0Y2E5MWMyYjY0NTAyZWI1MTIwYS4uNjA2Nzk3YTZiMjQwNDU1Njg0YzliODgxNTMzZTlh YTFjN2UwZGNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1NYWMubW0KQEAgLTc5LDYgKzc5LDI4IEBAIE5TVmlldyogUmVuZGVyVGhlbWVD aHJvbWl1bU1hYzo6ZG9jdW1lbnRWaWV3Rm9yKFJlbmRlck9iamVjdCopIGNvbnN0CiAgICAgcmV0 dXJuIEZsaXBwZWRWaWV3KCk7CiB9CiAKK2NvbnN0IGludCBhdXRvZmlsbFBvcHVwSG9yaXpvbnRh bFBhZGRpbmcgPSA0OworCisvLyBUaGVzZSBmdW5jdGlvbnMgYXJlIGNhbGxlZCB3aXRoIE1lbnVM aXN0UGFydCBvciBNZW51bGlzdEJ1dHRvblBhcnQgYXBwZWFyYW5jZSBieSBSZW5kZXJNZW51TGlz dCwgb3Igd2l0aCBUZXh0RmllbGRQYXJ0IGFwcGVhcmFuY2UgYnkgQXV0b2ZpbGxQb3B1cE1lbnVD bGllbnQuCisvLyBXZSBhc3N1bWUgb25seSBBdXRvZmlsbFBvcHVwTWVudUNsaWVudCBnaXZlcyBU ZXhmaWVsZFBhcnQgYXBwZWFyYW5jZSBoZXJlLgorLy8gV2Ugd2FudCB0byBjaGFuZ2Ugb25seSBB dXRvZmlsbCBwYWRkaW5nLgorLy8gSW4gdGhlIGZ1dHVyZSwgd2UgaGF2ZSB0byBzZXBhcmF0ZSBB dXRvZmlsbCBwb3B1cCB3aW5kb3cgbG9naWMgZnJvbSBXZWJLaXQgdG8gQ2hyb21pdW0uCitpbnQg UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9wdXBJbnRlcm5hbFBhZGRpbmdMZWZ0KFJlbmRlclN0 eWxlKiBzdHlsZSkgY29uc3QKK3sKKyAgICBpZiAoc3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBUZXh0 RmllbGRQYXJ0KQorICAgICAgICByZXR1cm4gYXV0b2ZpbGxQb3B1cEhvcml6b250YWxQYWRkaW5n OworCisgICAgcmV0dXJuIFJlbmRlclRoZW1lTWFjOjpwb3B1cEludGVybmFsUGFkZGluZ0xlZnQo c3R5bGUpOworfQorCitpbnQgUmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6cG9wdXBJbnRlcm5hbFBh ZGRpbmdSaWdodChSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0Cit7CisgICAgaWYgKHN0eWxlLT5h cHBlYXJhbmNlKCkgPT0gVGV4dEZpZWxkUGFydCkKKyAgICAgICAgcmV0dXJuIGF1dG9maWxsUG9w dXBIb3Jpem9udGFsUGFkZGluZzsKKworICAgIHJldHVybiBSZW5kZXJUaGVtZU1hYzo6cG9wdXBJ bnRlcm5hbFBhZGRpbmdSaWdodChzdHlsZSk7Cit9CisKIC8vIFVwZGF0ZXMgdGhlIGNvbnRyb2wg dGludCAoYS5rLmEuIGFjdGl2ZSBzdGF0ZSkgb2YgfGNlbGx8IChmcm9tIHxvfCkuCiAvLyBJbiB0 aGUgQ2hyb21pdW0gcG9ydCwgdGhlIHJlbmRlcmVyIHJ1bnMgYXMgYSBiYWNrZ3JvdW5kIHByb2Nl c3MgYW5kIGNvbnRyb2xzJwogLy8gTlNDZWxsKHMpIGxhY2sgYSBwYXJlbnQgTlNWaWV3LiBUaGVy ZWZvcmUgY29udHJvbHMgZG9uJ3QgaGF2ZSB0aGVpciB0aW50Cg==