58955 2011-04-19 18:16:28 -0700 The commit-queue is confused when non-layout tests fail 2011-04-19 20:17:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue dpranke ojan oldest_to_newest 388974 0 eric 2011-04-19 18:16:28 -0700 The commit-queue is confused when non-layout tests fail 388978 1 90286 eric 2011-04-19 18:17:52 -0700 Created attachment 90286 Patch 389022 2 90286 commit-queue 2011-04-19 20:17:39 -0700 Comment on attachment 90286 Patch Clearing flags on attachment: 90286 Committed r84333: <http://trac.webkit.org/changeset/84333> 389023 3 commit-queue 2011-04-19 20:17:43 -0700 All reviewed patches have been landed. Closing bug. 90286 2011-04-19 18:17:52 -0700 2011-04-19 20:17:39 -0700 Patch bug-58955-20110419181751.patch text/plain 6998 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODQzMjAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNDVkNmEwNDgyMzBkZjVkOWZlYmZjZTFjNmU0NTY2MTY3 MDFlNDAyLi43MzNjNjM2MDYyYmRkNzg1NTBmYjA5NmMzMjg1OTdhNWMyMDA2YWE4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTEtMDQtMTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb21taXQtcXVldWUg aXMgY29uZnVzZWQgd2hlbiBub24tbGF5b3V0IHRlc3RzIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTU1CisKKyAgICAgICAgQXMgc2VlbiBp biBodHRwOi8vcXVldWVzLndlYmtpdC5vcmcvcmVzdWx0cy84NDc0NDM1CisKKyAgICAgICAgSXQg ZmFpbHMgdG8gY3JlYXRlIGFuIGFyY2hpdmUgb2YgdGhlIGxheW91dCB0ZXN0IHJlc3VsdHMKKyAg ICAgICAgYW5kIHRoZW4gdGhyb3dzIGFuIGV4Y2VwdGlvbi4KKworICAgICAgICBJJ3ZlIGZpeGVk IHRoaXMgYnkgbWFraW5nIGl0IGNhdGNoIHRoZSBleGNlcHRpb24gYXMgd2VsbAorICAgICAgICBh cyBtYWRlIGl0IHNvIGl0IG5ldmVyIGNhbGxzIHRoYXQgcGF0aCBpbiB0aGUgY29tbW9uIGNhc2Uu CisKKyAgICAgICAgSSd2ZSB1cGRhdGVkIE1vY2tGaWxlU3lzdGVtIHRvIHVuZGVyc3RhbmQgcm10 cmVlJ3MgYWZmZWN0IG9uCisgICAgICAgIGRpcmVjdG9yaWVzIGFzIHdlbGwgYXMgZmlsZXMuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2Nr LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3BhY2Uu cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0 LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9tb2NrdG9vbC5weToKKwogMjAx MS0wNC0xOSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBj aGVjayBmb3Igd2hldGhlciBhIGZhaWx1cmUgaXMgZXhwZWN0ZWQgdG8gZGVhbCB3aXRoCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9t b2NrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1f bW9jay5weQppbmRleCAzYmU1ODU0MjA2NmExNDUxMGI4MjgyZWY5MTQ5N2NkYWJkOTQ4MDYxLi45 NWY1YjJiMmZhZDRjOTQ4YjZiNmVmZWRjY2E5NjE5MGM4ZWJmNTgyIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lzdGVtX21vY2sucHkK QEAgLTE0Nyw3ICsxNDcsNyBAQCBjbGFzcyBNb2NrRmlsZVN5c3RlbShvYmplY3QpOgogICAgICAg ICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIHBhdGggPSBzZWxmLm5vcm1wYXRoKHBhdGgpCiAg ICAgICAgIGlmIHBhdGggaW4gc2VsZi5kaXJzOgotICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAg ICAgICAgICAgIHJldHVybiBzZWxmLmRpcnNbcGF0aF0gaXMgbm90IE5vbmUKIAogICAgICAgICAj IFdlIG5lZWQgdG8gdXNlIGEgY29weSBvZiB0aGUga2V5cyBoZXJlIGluIG9yZGVyIHRvIGF2b2lk IHN3aXRjaGluZwogICAgICAgICAjIHRvIGEgZGlmZmVyZW50IHRocmVhZCBhbmQgcG90ZW50aWFs bHkgbW9kaWZ5aW5nIHRoZSBkaWN0IGluCkBAIC0yNjcsMTMgKzI2NywxNiBAQCBjbGFzcyBNb2Nr RmlsZVN5c3RlbShvYmplY3QpOgogICAgICAgICBzZWxmLndyaXR0ZW5fZmlsZXNbcGF0aF0gPSBO b25lCiAKICAgICBkZWYgcm10cmVlKHNlbGYsIHBhdGgpOgotICAgICAgICBpZiBub3QgcGF0aC5l bmRzd2l0aChzZWxmLnNlcCk6Ci0gICAgICAgICAgICBwYXRoICs9IHNlbGYuc2VwCisgICAgICAg IHBhdGggPSBzZWxmLm5vcm1wYXRoKHBhdGgpCiAKICAgICAgICAgZm9yIGYgaW4gc2VsZi5maWxl czoKICAgICAgICAgICAgIGlmIGYuc3RhcnRzd2l0aChwYXRoKToKICAgICAgICAgICAgICAgICBz ZWxmLmZpbGVzW2ZdID0gTm9uZQogCisgICAgICAgIGZvciBkIGluIHNlbGYuZGlyczoKKyAgICAg ICAgICAgIGlmIGQuc3RhcnRzd2l0aChwYXRoKToKKyAgICAgICAgICAgICAgICBzZWxmLmRpcnNb ZF0gPSBOb25lCisKICAgICBkZWYgc3BsaXRleHQoc2VsZiwgcGF0aCk6CiAgICAgICAgIGlkeCA9 IHBhdGgucmZpbmQoJy4nKQogICAgICAgICBpZiBpZHggPT0gLTE6CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZS5weQppbmRleCBhZmIwMDA5Yjk0 NmIyNjBiOGM5ZDZkODhmNTYxMDc0MGQyYzg5NmQ0Li41YjAxMWY3NDgwYjVmNWNhMTlhOWY3Nzhh ZTc5YjE0ZjYyY2FhYTQ0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vd29ya3NwYWNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS93b3Jrc3BhY2UucHkKQEAgLTI5LDggKzI5LDEzIEBACiAjIEEgaG9tZSBmb3IgZmls ZSBsb2dpYyB3aGljaCBzaG91bGQgc2l0IGFib3ZlIEZpbGVTeXN0ZW0sIGJ1dAogIyBiZWxvdyBt b3JlIGNvbXBsaWNhdGVkIG9iamVjdHMuCiAKK2ltcG9ydCBsb2dnaW5nCiBpbXBvcnQgemlwZmls ZQogCisKK19sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKKworCiBjbGFzcyBXb3Jr c3BhY2Uob2JqZWN0KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgZmlsZXN5c3RlbSwgZXhlY3V0 aXZlKToKICAgICAgICAgc2VsZi5fZmlsZXN5c3RlbSA9IGZpbGVzeXN0ZW0KQEAgLTU3LDUgKzYy LDEwIEBAIGNsYXNzIFdvcmtzcGFjZShvYmplY3QpOgogICAgICAgICAjICAgICAgICAgemlwX2Zp bGUud3JpdGUob3MucGF0aC5yZWxwYXRoKHBhdGgsIHNvdXJjZV9wYXRoKSkKICAgICAgICAgIyBI b3dldmVyLCBnZXR0aW5nIHRoZSBwYXRocywgZW5jb2RpbmcgYW5kIGNvbXByZXNzaW9uIGNvcnJl Y3QgY291bGQgYmUgbm9uLXRyaXZpYWwuCiAgICAgICAgICMgU28sIGZvciBub3cgd2UgZGVwZW5k IG9uIHRoZSBlbnZpcm9ubWVudCBoYXZpbmcgInppcCIgaW5zdGFsbGVkIChsaWtlbHkgZmFpbHMg b24gV2luMzIpCi0gICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3ppcCcsICct cicsIHppcF9wYXRoLCBzb3VyY2VfcGF0aF0pCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHNl bGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3ppcCcsICctcicsIHppcF9wYXRoLCBzb3VyY2Vf cGF0aF0pCisgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKKyAgICAgICAgICAgIF9sb2cu ZXJyb3IoIldvcmtzcGFjZS5jcmVhdGVfemlwIGZhaWxlZDpcbiVzIiAlIGUubWVzc2FnZV93aXRo X291dHB1dCgpKQorICAgICAgICAgICAgcmV0dXJuIE5vbmUKKwogICAgICAgICByZXR1cm4gemlw X2NsYXNzKHppcF9wYXRoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXMucHkKaW5kZXggNGVhZGIwZTVhYmZmNjk1ODY0ZmI4YzI1ZTQ3NDI1NzgxYjdlMTU3 Ny4uMWVjYzc4ZGJhMjQ5YzA2YmFlNTdmZjRkNTFjYTE5NDFkNGY3NTg0OCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CkBAIC0zNTMsNiArMzUz LDkgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQYXRjaFF1ZXVlLCBTdGVwU2VxdWVuY2VF cnJvckhhbmRsZXIsIENvbW1pdFF1ZXVlVGFza0QKICAgICAgICAgemlwX3BhdGggPSBzZWxmLl90 b29sLndvcmtzcGFjZS5maW5kX3VudXNlZF9maWxlbmFtZShzZWxmLl9sb2dfZGlyZWN0b3J5KCks ICIlcy0lcyIgJSAocGF0Y2guYnVnX2lkKCksIHJlc3VsdHNfbmFtZSksICJ6aXAiKQogICAgICAg ICBpZiBub3QgemlwX3BhdGg6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQorICAgICAgICBpZiBu b3Qgc2VsZi5fdG9vbC5maWxlc3lzdGVtLmlzZGlyKHJlc3VsdHNfZGlyZWN0b3J5KToKKyAgICAg ICAgICAgIGxvZygiJXMgZG9lcyBub3QgZXhpc3QsIG5vdCBhcmNoaXZpbmcuIiAlIHJlc3VsdHNf ZGlyZWN0b3J5KQorICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgYXJjaGl2ZSA9IHNl bGYuX3Rvb2wud29ya3NwYWNlLmNyZWF0ZV96aXAoemlwX3BhdGgsIHJlc3VsdHNfZGlyZWN0b3J5 KQogICAgICAgICAjIFJlbW92ZSB0aGUgcmVzdWx0cyBkaXJlY3RvcnkgdG8gcHJldmVudCBodHRw IGxvZ3MsIGV0Yy4gZnJvbSBnZXR0aW5nIGh1Z2UgYmV0d2VlbiBydW5zLgogICAgICAgICAjIFdl IGNvdWxkIGhhdmUgY3JlYXRlX3ppcCByZW1vdmUgdGhlIG9yaWdpbmFsLCBidXQgdGhpcyBpcyBt b3JlIGV4cGxpY2l0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL3F1ZXVlc191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkKaW5kZXggZDU3N2JhYTU1ZDVjMWI0NTkwZTdlOTA1 OTI3YjExNDNiYTU3MGZjNi4uZmMxY2UwYTU1NGE3OTE3NGU4M2M2NDcxNmIwYjRmN2I2Njg0Mzgw ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVl c191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv cXVldWVzX3VuaXR0ZXN0LnB5CkBAIC00MDMsMTAgKzQwMywyMiBAQCBUaGUgY29tbWl0LXF1ZXVl IGlzIGNvbnRpbnVpbmcgdG8gcHJvY2VzcyB5b3VyIHBhdGNoLgogCiAgICAgZGVmIHRlc3RfYXJj aGl2ZV9sYXN0X2xheW91dF90ZXN0X3Jlc3VsdHMoc2VsZik6CiAgICAgICAgIHF1ZXVlID0gQ29t bWl0UXVldWUoKQotICAgICAgICBxdWV1ZS5iaW5kX3RvX3Rvb2woTW9ja1Rvb2woKSkKKyAgICAg ICAgdG9vbCA9IE1vY2tUb29sKCkKKyAgICAgICAgcXVldWUuYmluZF90b190b29sKHRvb2wpCiAg ICAgICAgIHBhdGNoID0gcXVldWUuX3Rvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KDEyOCkKLSAg ICAgICAgIyBUaGlzIGlzIGp1c3QgdG8gdGVzdCB0aGF0IHRoZSBtZXRob2QgZG9lc24ndCByYWlz ZS4KLSAgICAgICAgcXVldWUuYXJjaGl2ZV9sYXN0X2xheW91dF90ZXN0X3Jlc3VsdHMocGF0Y2gp CisgICAgICAgICMgU2hvdWxkIGZhaWwgYmVjYXVzZSB0aGUgcmVzdWx0c19kaXJlY3RvcnkgZG9l cyBub3QgZXhpc3QuCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICIvbW9jayBkb2VzIG5vdCBl eGlzdCwgbm90IGFyY2hpdmluZy5cbiIKKyAgICAgICAgYXJjaGl2ZSA9IE91dHB1dENhcHR1cmUo KS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBxdWV1ZS5hcmNoaXZlX2xhc3RfbGF5b3V0X3Rlc3RfcmVz dWx0cywgW3BhdGNoXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChhcmNoaXZlLCBOb25lKQorCisgICAgICAgIHJlc3VsdHNfZGlyZWN0 b3J5ID0gIi9tb2NrIgorICAgICAgICAjIFNhbml0eSBjaGVjayB3aGF0IHdlIGFzc3VtZSBvdXIg bW9jayByZXN1bHRzIGRpcmVjdG9yeSBpcy4KKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChxdWV1 ZS5fcmVzdWx0c19kaXJlY3RvcnkoKSwgcmVzdWx0c19kaXJlY3RvcnkpCisgICAgICAgIHRvb2wu ZmlsZXN5c3RlbS5tYXliZV9tYWtlX2RpcmVjdG9yeShyZXN1bHRzX2RpcmVjdG9yeSkKKyAgICAg ICAgc2VsZi5hc3NlcnRUcnVlKHRvb2wuZmlsZXN5c3RlbS5leGlzdHMocmVzdWx0c19kaXJlY3Rv cnkpKQorCisgICAgICAgIHNlbGYuYXNzZXJ0Tm90RXF1YWwocXVldWUuYXJjaGl2ZV9sYXN0X2xh eW91dF90ZXN0X3Jlc3VsdHMocGF0Y2gpLCBOb25lKQorICAgICAgICBzZWxmLmFzc2VydEZhbHNl KHRvb2wuZmlsZXN5c3RlbS5leGlzdHMocmVzdWx0c19kaXJlY3RvcnkpKQogCiAgICAgZGVmIHRl c3RfdXBsb2FkX3Jlc3VsdHNfYXJjaGl2ZV9mb3JfcGF0Y2goc2VsZik6CiAgICAgICAgIHF1ZXVl ID0gQ29tbWl0UXVldWUoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L21vY2t0b29sLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5Cmlu ZGV4IGFkMDMyNDQ2YjFkNzczOWEyNTAwN2U0YTQzMmRmZDA2OGVmMTAxMjEuLjNmMmYxMTY3OWI0 NGZhNjY1M2Q1MmEyYmMwNzhjYmEyNzAyNzlkMGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9tb2NrdG9vbC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvbW9ja3Rvb2wucHkKQEAgLTcyOCw3ICs3MjgsNyBAQCBjbGFzcyBNb2NrV29ya3NwYWNlKG9i amVjdCk6CiAgICAgICAgIHJldHVybiAiJXMvJXMuJXMiICUgKGRpcmVjdG9yeSwgbmFtZSwgZXh0 ZW5zaW9uKQogCiAgICAgZGVmIGNyZWF0ZV96aXAoc2VsZiwgemlwX3BhdGgsIHNvdXJjZV9wYXRo KToKLSAgICAgICAgcGFzcworICAgICAgICByZXR1cm4gb2JqZWN0KCkgICMgU29tZXRoaW5nIHRo YXQgaXMgbm90IE5vbmUKIAogCiBjbGFzcyBNb2NrVG9vbChvYmplY3QpOgo=