58948 2011-04-19 17:27:24 -0700 [chromium] DrawingBuffer incorrectly initializes value before getBooleanv call 2011-04-19 17:51:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 enne enne enne gman kbr senorblanco oldest_to_newest 388936 0 enne 2011-04-19 17:27:24 -0700 DrawingBuffer::clearFramebuffer() initializes the depthMask to true before calling getBooleanv. In the command buffer code (gpu/command_buffer/client/gles2_c_lib_autogen.h:315), we check that the destination for all get calls has been correctly initialized, which means that it's either been initialized to 0 or -1. See the macro in gles2_c_lib.cc:33. This should probably be initialized to false instead for consistency. This asserts when loading http://www.masterofthewebgame.com on Linux (only platform tested) at ToT (chromium r82193, webkit r84319). (See also: probably would have been caught if the command buffer was tested in DRT.) 388940 1 90279 enne 2011-04-19 17:31:43 -0700 Created attachment 90279 Patch 388945 2 90279 senorblanco 2011-04-19 17:38:04 -0700 Comment on attachment 90279 Patch If a C++-style bool is the wrong type for this call, should this perhaps be 0 instead of false? Otherwise, looks good to me (unofficially). 388946 3 90279 kbr 2011-04-19 17:43:04 -0700 Comment on attachment 90279 Patch Argh. Looks fine. 388953 4 enne 2011-04-19 17:51:52 -0700 Committed r84323: <http://trac.webkit.org/changeset/84323> 90279 2011-04-19 17:31:43 -0700 2011-04-19 17:43:04 -0700 Patch bug-58948-20110419173141.patch text/plain 1593 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQzMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYzE5MGIzZGU3MjVmYmFl ZmVhNDBmYTMyNmUwY2ZmMjdlNzNkNTYxLi5kOTcyZGU1M2U1YWY0MzcxYzIwYzNlZGJiNzFmYWE2 MTMyOWJhZTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTkgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEluaXRpYWxpemUgZGVwdGggbWFzayB0 byBrbm93biB2YWx1ZSBiZWZvcmUgZ2V0Qm9vbGVhbnYgY2FsbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5NDgKKworICAgICAgICBUaGlzIHRyaXBz IGFuIGFzc2VydCBpbiB0aGUgR1BVIGNvbW1hbmQgYnVmZmVyIGNsaWVudCBjb2RlIGlmIHRoZQor ICAgICAgICBwb2ludGVkLXRvIHZhbHVlIGlzIG5vdCBpbml0aWFsaXplZCB0byAwIG9yIC0xLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RHJhd2luZ0J1ZmZlcjo6Y2xlYXJGcmFtZWJ1ZmZlcik6CisKIDIwMTEt MDQtMTkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBCZXRoIERha2luLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCmluZGV4IGEzZGVkMWVjYjRhMDVlODgzNTg5ODZi MDg3MGJjNmIxZjMyYjZkNzkuLjhlMjkzZjc3OGE5MDUyZmVhYzk2YjkzOTY2MmVkZGViMzk4NDA2 YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3 aW5nQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUv RHJhd2luZ0J1ZmZlci5jcHAKQEAgLTE1MCw3ICsxNTAsNyBAQCB2b2lkIERyYXdpbmdCdWZmZXI6 OmNsZWFyRnJhbWVidWZmZXIoKQogICAgIGNvbnN0IEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1 dGVzJiBhdHRyaWJ1dGVzID0gbV9jb250ZXh0LT5nZXRDb250ZXh0QXR0cmlidXRlcygpOwogICAg IGZsb2F0IGNsZWFyRGVwdGggPSAwOwogICAgIGludCBjbGVhclN0ZW5jaWwgPSAwOwotICAgIHVu c2lnbmVkIGNoYXIgZGVwdGhNYXNrID0gdHJ1ZTsKKyAgICB1bnNpZ25lZCBjaGFyIGRlcHRoTWFz ayA9IGZhbHNlOwogICAgIHVuc2lnbmVkIGludCBzdGVuY2lsTWFzayA9IDB4ZmZmZmZmZmY7CiAg ICAgdW5zaWduZWQgY2hhciBpc1NjaXNzb3JFbmFibGVkID0gZmFsc2U7CiAgICAgdW5zaWduZWQg bG9uZyBjbGVhck1hc2sgPSBHcmFwaGljc0NvbnRleHQzRDo6Q09MT1JfQlVGRkVSX0JJVDsK