58933 2011-04-19 15:26:58 -0700 [chromium] Clamp dirty regions on content layers to layer bounds 2011-04-21 16:08:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr senorblanco vangelis oldest_to_newest 388841 0 enne 2011-04-19 15:26:58 -0700 [chromium] Clamp dirty regions on content layers to layer bounds 388846 1 90266 enne 2011-04-19 15:30:08 -0700 Created attachment 90266 Patch 388848 2 enne 2011-04-19 15:31:26 -0700 This is the WebKit fix for http://crbug.com/79749. 388902 3 90266 vangelis 2011-04-19 16:33:10 -0700 Comment on attachment 90266 Patch unofficial r+ although it probably needs a test too... 388905 4 90266 jamesr 2011-04-19 16:36:03 -0700 Comment on attachment 90266 Patch Agree re: test. We're likely to be mucking about with this code a good bit over the next few weeks and I don't want to rewrite the same bug again without a test. 390178 5 enne 2011-04-21 11:24:41 -0700 Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case. 390192 6 senorblanco 2011-04-21 11:33:38 -0700 (In reply to comment #5) > Because this manually fixes both the original bug and another test case that Vangelis found, I'm going to commit this but leave the bug open until I write a test case. Sounds good to me (unofficially). Thanks very much for the quick fix! 390199 7 enne 2011-04-21 11:39:29 -0700 Committed r84529: <http://trac.webkit.org/changeset/84529> 390427 8 enne 2011-04-21 16:08:57 -0700 Good news, everybody! We already had three test cases that demonstrated this bug. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fcontrols-styling.html%2Cmedia%2Fvideo-volume-slider.html%2Cmedia%2Fvideo-zoom-controls.html&group=%40ToT%20GPU%20Mesa%20-%20chromium.org ...they were just all marked as IMAGE fail. 90266 2011-04-19 15:30:08 -0700 2011-04-19 16:36:03 -0700 Patch bug-58933-20110419153007.patch text/plain 1716 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQxNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYThmZDIyMWMxZmQxZjM2 NWQ2YTFlYzc2ZWI4NzRiM2Q1YzhjMjdlLi41MDQ3OTZjNWJhMTk4MGU2OTBhYTc1YmNmOGRlOTA4 ZmYwMWU4MTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTkgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIENsYW1wIGRpcnR5IHJlZ2lvbnMgb24g Y29udGVudCBsYXllcnMgdG8gbGF5ZXIgYm91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODkzMworCisgICAgICAgIFRoaXMgcHJldmVudHMgZ2Fy YmFnZSBiZWluZyByZW5kZXJlZCB3aGVuIGxheWVycyBhcmUgcmVzaXplZCBhbmQgYQorICAgICAg ICBwcmV2aW91cyBpbnZhbGlkYXRpb24gKG5vdyBvZmYtbGF5ZXIpIGlzIG5vIGxvbmdlciB2YWxp ZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRMYXllckNocm9taXVtOjpwYWlu dENvbnRlbnRzSWZEaXJ0eSk6CisKIDIwMTEtMDQtMTUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRh QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXll ckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NvbnRlbnRMYXllckNocm9taXVtLmNwcAppbmRleCBhZmYyOTgxZjYwYmRkNzU0ZjFkNWI0YTcw MjM0ZGExOTRiNzIwODlhLi5lYTk0MDk2YWJiNWZjMDNmZDQyYjljYjhhMWE5ZGRjZTc4ZTNmMDky IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9D b250ZW50TGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hyb21pdW0uY3BwCkBAIC0xMDAsNyArMTAwLDEx IEBAIHZvaWQgQ29udGVudExheWVyQ2hyb21pdW06OnBhaW50Q29udGVudHNJZkRpcnR5KGNvbnN0 IEludFJlY3QmIHRhcmdldFN1cmZhY2VSZWN0CiAgICAgSW50UmVjdCBsYXllclJlY3QgPSB2aXNp YmxlTGF5ZXJSZWN0KHRhcmdldFN1cmZhY2VSZWN0KTsKICAgICBpZiAobGF5ZXJSZWN0LmlzRW1w dHkoKSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fdGlsZXItPmludmFsaWRhdGVSZWN0KGVuY2xv c2luZ0ludFJlY3QobV9kaXJ0eVJlY3QpKTsKKworICAgIEludFJlY3QgZGlydHkgPSBlbmNsb3Np bmdJbnRSZWN0KG1fZGlydHlSZWN0KTsKKyAgICBkaXJ0eS5pbnRlcnNlY3QobGF5ZXJCb3VuZHMo KSk7CisgICAgbV90aWxlci0+aW52YWxpZGF0ZVJlY3QoZGlydHkpOworCiAgICAgbV90aWxlci0+ dXBkYXRlKHBhaW50ZXIsIGxheWVyUmVjdCk7CiAgICAgbV9kaXJ0eVJlY3QgPSBGbG9hdFJlY3Qo KTsKIH0K