58931 2011-04-19 15:16:15 -0700 don't show missing text results for tests that only dump image results 2011-04-19 16:43:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan dpranke eric tony oldest_to_newest 388837 0 ojan 2011-04-19 15:16:15 -0700 don't show missing text results for tests that only dump image results 388838 1 90263 ojan 2011-04-19 15:17:24 -0700 Created attachment 90263 Patch 388842 2 90263 eric 2011-04-19 15:28:35 -0700 Comment on attachment 90263 Patch I didn't know we had tests which only dumped images? 388850 3 dpranke 2011-04-19 15:33:06 -0700 It is possible for any given test to be missing either text, audio, or images (but it should always produce either text or audio). It should not be possible for a test to only produce image data. 388857 4 ojan 2011-04-19 15:38:40 -0700 Oh, I'm wrong. It looks like if the text result passes and the image result is missing, we'll only dump the image result. 388886 5 dpranke 2011-04-19 16:20:27 -0700 to further clarify, even though a test will always produce either text or audio, it will only save the output into the layout-test-results directory if the output didn't match the expected content. Ojan's patch is concerned with the saved output (the -actual.* files), not the produced output that lives in memory. Patch LGTM as well. 388909 6 ojan 2011-04-19 16:43:13 -0700 Committed r84313: <http://trac.webkit.org/changeset/84313> 90263 2011-04-19 15:17:24 -0700 2011-04-19 15:28:35 -0700 Patch bug-58931-20110419151723.patch text/plain 3069 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODQyOTYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YzE1MjhhZGI3ZDA2NTNmNjQ4NTUxOThlMTBlMGZiMGY4 Zjk5ZWI3Li5iOGU3NDQ1MzM1ODY2MWZjZDBiZDYwODM1OTRjN2UxOWViZDdmMjUxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBkb24n dCBzaG93IG1pc3NpbmcgdGV4dCByZXN1bHRzIGZvciB0ZXN0cyB0aGF0IG9ubHkgZHVtcCBpbWFn ZSByZXN1bHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODkzMQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0 X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWw6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9ydW5uZXIucHk6CisKKzIwMTEtMDQtMTkg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBkb24ndCBzaG93IGZhaWx1cmVzIHRhYmxlIGlmIHRo ZXJlIGFyZSBvbmx5IG5ldyB0ZXN0cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTg5MjkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMu aHRtbAppbmRleCBkMWIxN2UxNDc1NTg4Yjc5ZjgwYzBlNDY5YzJkNjI5Y2NkMDQwOGRhLi5lMjVk ZDQyZjFlMTE4NzYwNDJmOGViYmU3YjQ1NGJiMThjZThhNjdhIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMu aHRtbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFj a2FnZS9qc29uX3Jlc3VsdHMuaHRtbApAQCAtMzI1LDEzICszMjUsMTMgQEAgZnVuY3Rpb24gYXBw ZW5kVGVzdExpc3QodGVzdHMsIGhlYWRlciwgdGFibGVJZCwgZmlsZVN1ZmZpeCwgbGlua05hbWUp CiAgICAgICAgIGlmIChmaWxlU3VmZml4LmluZGV4T2YoJ2FjdHVhbCcpID09IC0xKQogICAgICAg ICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCBmaWxlU3VmZml4 LCBsaW5rTmFtZSk7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgaWYgKGdfcmVzdWx0cy50 ZXN0c1t0ZXN0XS5pc19taXNzaW5nX2F1ZGlvKQorICAgICAgICAgICAgdmFyIHRlc3RPYmplY3Qg PSBnX3Jlc3VsdHMudGVzdHNbdGVzdF07CisgICAgICAgICAgICBpZiAodGVzdE9iamVjdC5pc19t aXNzaW5nX2F1ZGlvKQogICAgICAgICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4 dGVuc2lvbih0ZXN0KSwgJy1hY3R1YWwud2F2JywgJ2F1ZGlvIHJlc3VsdCcpOwotICAgICAgICAg ICAgZWxzZSB7CisgICAgICAgICAgICBpZiAodGVzdE9iamVjdC5pc19taXNzaW5nX3RleHQpCiAg ICAgICAgICAgICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCBm aWxlU3VmZml4LCBsaW5rTmFtZSk7Ci0gICAgICAgICAgICAgICAgaWYgKGdfcmVzdWx0cy50ZXN0 c1t0ZXN0XS5pc19taXNzaW5nX2ltYWdlKQotICAgICAgICAgICAgICAgICAgICBodG1sICs9IHJl c3VsdExpbmsoc3RyaXBFeHRlbnNpb24odGVzdCksICctYWN0dWFsLnBuZycsICdwbmcgcmVzdWx0 Jyk7Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAodGVzdE9iamVjdC5pc19taXNzaW5n X2ltYWdlKQorICAgICAgICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4dGVuc2lv bih0ZXN0KSwgJy1hY3R1YWwucG5nJywgJ3BuZyByZXN1bHQnKTsKICAgICAgICAgfSAKICAgICAg ICAgCiAgICAgICAgIGh0bWwgKz0gJzwvdGQ+PC90cj48L3Rib2R5Pic7CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3J1 bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL3Rlc3RfcnVubmVyLnB5CmluZGV4IGQ1MmRlZTMwY2Y5MDBkNDI5YjBmMTc4MDNmNjEwMDIz OGY3ZTllMzEuLjhlNTM0YjE1ZjU1Y2FhYjhmNDEyODI3ODQ1YzA3ODAzMTM1ZWE1MTYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5CkBAIC0xNjEsNiArMTYxLDkgQEAgZGVmIHN1 bW1hcml6ZV9yZXN1bHRzKHBvcnRfb2JqLCBleHBlY3RhdGlvbnMsIHJlc3VsdF9zdW1tYXJ5LCBy ZXRyeV9zdW1tYXJ5LCB0ZXMKICAgICAgICAgaWYgdGVzdF9mYWlsdXJlcy5GYWlsdXJlUmVmdGVz dE1pc21hdGNoRGlkTm90T2NjdXIgaW4gZmFpbHVyZV90eXBlczoKICAgICAgICAgICAgIHRlc3Rz W3Rlc3RdWydpc19taXNtYXRjaF9yZWZ0ZXN0J10gPSBUcnVlCiAKKyAgICAgICAgaWYgdGVzdF9m YWlsdXJlcy5GYWlsdXJlTWlzc2luZ1Jlc3VsdCBpbiBmYWlsdXJlX3R5cGVzOgorICAgICAgICAg ICAgdGVzdHNbdGVzdF1bJ2lzX21pc3NpbmdfdGV4dCddID0gVHJ1ZQorCiAgICAgICAgIGlmIHRl c3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZSBpbiBmYWlsdXJlX3R5cGVzIG9yIHRlc3Rf ZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2ggaW4gZmFpbHVyZV90eXBlczoKICAgICAg ICAgICAgIHRlc3RzW3Rlc3RdWydpc19taXNzaW5nX2ltYWdlJ10gPSBUcnVlCiAK