58930 2011-04-19 15:06:04 -0700 Accessibility tree should not contain duplicate child nodes. 2011-09-12 23:10:06 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 0 ctguil webkit-unassigned cfleizach webkit.review.bot oldest_to_newest 388828 0 90262 ctguil 2011-04-19 15:06:04 -0700 Created attachment 90262 Layout Test The accessibility tree can incorrectly list the same node as a child more than once. This can lead to undefined behavior. 388832 1 90262 ctguil 2011-04-19 15:07:15 -0700 Comment on attachment 90262 Layout Test >Index: LayoutTests/accessibility/duplicate-child-nodes.html >=================================================================== >--- LayoutTests/accessibility/duplicate-child-nodes.html (revision 0) >+++ LayoutTests/accessibility/duplicate-child-nodes.html (revision 0) >@@ -0,0 +1,32 @@ >+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> >+<html> >+<head> >+<link rel="stylesheet" href="../fast/js/resources/js-test-style.css"> >+<script> >+ var successfullyParsed = false; >+</script> >+<script src="../fast/js/resources/js-test-pre.js"></script> >+</head> >+<body> >+ >+<em><code ><h4 ></em> >+ >+<p id="description"></p> >+<div id="console"></div> >+ >+<script> >+ description("Child nodes should not be duplicated in the accessibility tree."); >+ >+ if (window.accessibilityController) { >+ document.body.focus(); >+ var webArea = accessibilityController.focusedElement; >+ if (webArea.childrenCount > 1) >+ shouldBe("webArea.childAtIndex(0).isEqual(webArea.childAtIndex(1))", "false"); >+ } >+ >+ successfullyParsed = true; >+</script> >+ >+<script src="../fast/js/resources/js-test-post.js"></script> >+</body> >+</html> 388981 2 cfleizach 2011-04-19 18:20:05 -0700 <rdar://problem/9309623> 466106 3 107139 dmazzoni 2011-09-12 21:28:25 -0700 Created attachment 107139 Patch 466148 4 107139 cfleizach 2011-09-12 22:56:49 -0700 Comment on attachment 107139 Patch r=me thanks 466156 5 107139 webkit.review.bot 2011-09-12 23:10:01 -0700 Comment on attachment 107139 Patch Clearing flags on attachment: 107139 Committed r95018: <http://trac.webkit.org/changeset/95018> 466157 6 webkit.review.bot 2011-09-12 23:10:06 -0700 All reviewed patches have been landed. Closing bug. 90262 2011-04-19 15:06:04 -0700 2011-04-19 15:07:15 -0700 Layout Test MyPatch.txt text/plain 1865 ctguil SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0Mjg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMTAgIENocmlzIEd1 aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIENvdmVyaXR5IGRpc2NvdmVyZWQg Tk9fRUZGRUNUIChzZWxmLWFzc2lnbikgZGVmZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQxNDMKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dwdS9UaWxpbmdEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGluZ0RhdGE6OnNl dE1heFRleHR1cmVTaXplKToKKwogMjAxMS0wNC0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzU3ODY3PiBSZS1vcmRl ciBlbnVtIFJlc291cmNlTG9hZFByaW9yaXR5IHRvIG1ha2UgVW5yZXNvbHZlZCB2YWx1ZSBsZXNz IGltcG9ydGFudApJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9kdXBsaWNhdGUtY2hp bGQtbm9kZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2R1 cGxpY2F0ZS1jaGlsZC1ub2Rlcy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9kdXBsaWNhdGUtY2hpbGQtbm9kZXMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwzMiBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4i Pg0KKzxodG1sPg0KKzxoZWFkPg0KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPg0KKzxzY3JpcHQ+DQorICAgIHZhciBz dWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsNCis8L3NjcmlwdD4NCis8c2NyaXB0IHNyYz0iLi4v ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pg0KKzwvaGVhZD4NCis8 Ym9keT4NCisNCis8ZW0+PGNvZGUgPjxoNCA+PC9lbT4NCisNCis8cCBpZD0iZGVzY3JpcHRpb24i PjwvcD4NCis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4NCisNCis8c2NyaXB0Pg0KKyAgICBkZXNj cmlwdGlvbigiQ2hpbGQgbm9kZXMgc2hvdWxkIG5vdCBiZSBkdXBsaWNhdGVkIGluIHRoZSBhY2Nl c3NpYmlsaXR5IHRyZWUuIik7DQorDQorICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRy b2xsZXIpIHsNCisgICAgICAgIGRvY3VtZW50LmJvZHkuZm9jdXMoKTsNCisgICAgICAgIHZhciB3 ZWJBcmVhID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7DQorICAgICAg ICBpZiAod2ViQXJlYS5jaGlsZHJlbkNvdW50ID4gMSkNCisgICAgICAgICAgICBzaG91bGRCZSgi d2ViQXJlYS5jaGlsZEF0SW5kZXgoMCkuaXNFcXVhbCh3ZWJBcmVhLmNoaWxkQXRJbmRleCgxKSki LCAiZmFsc2UiKTsNCisgICAgfQ0KKw0KKyAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOw0K Kzwvc2NyaXB0Pg0KKw0KKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0Pg0KKzwvYm9keT4NCis8L2h0bWw+DQo= 107139 2011-09-12 21:28:25 -0700 2011-09-12 23:10:01 -0700 Patch bug-58930-20110912212823.patch text/plain 2552 dmazzoni SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk1MDExKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMTIgIERvbWluaWMgTWF6em9uaSAg PGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGVuc3VyZXMg dGhhdCB0aGUgYWNjZXNzaWJpbGl0eSB0cmVlCisgICAgICAgIGRvZXMgbm90IGNvbnRhaW4gZHVw bGljYXRlIGNoaWxkIG5vZGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg5MzAKKworICAgICAgICBUaGlzIHRlc3QgZmFpbGVkIHdoZW4gdGhlIGJ1 ZyB3YXMgb3JpZ2luYWxseSBmaWxlZCwgYnV0IHdhcworICAgICAgICBmaXhlZCBpbjogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODA1CisgICAgICAgIHNvIG5vIGNv ZGUgY2hhbmdlcyBhcmUgYWNjb21wYW55aW5nIHRoaXMgbmV3IGxheW91dCB0ZXN0LgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9kdXBsaWNhdGUtY2hpbGQtbm9kZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2R1cGxpY2F0ZS1jaGlsZC1ub2Rlcy5odG1sOiBBZGRlZC4KKwogMjAxMS0w OS0xMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIERvbid0IGFsbG93 IHNldHRpbmcgX19wcm90b19fIHRvIGJlIGEgZ2V0dGVyIG9yIHNldHRlcgpJbmRleDogTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9kdXBsaWNhdGUtY2hpbGQtbm9kZXMtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZHVwbGljYXRlLWNoaWxkLW5v ZGVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxp dHkvZHVwbGljYXRlLWNoaWxkLW5vZGVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw5IEBACitDaGlsZCBub2RlcyBzaG91bGQgbm90IGJlIGR1cGxpY2F0ZWQgaW4gdGhlIGFj Y2Vzc2liaWxpdHkgdHJlZS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2R1cGxpY2F0ZS1jaGlsZC1ub2Rlcy5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZHVwbGljYXRlLWNoaWxkLW5vZGVzLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2R1cGxpY2F0ZS1j aGlsZC1ub2Rlcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBACis8IURPQ1RZUEUg SFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxp bmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0 eWxlLmNzcyI+Cis8c2NyaXB0PgorICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsK Kzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorCis8ZW0+PGNvZGUgPjxoNCA+PC9lbT4K KworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKwor PHNjcmlwdD4KKyAgICBkZXNjcmlwdGlvbigiQ2hpbGQgbm9kZXMgc2hvdWxkIG5vdCBiZSBkdXBs aWNhdGVkIGluIHRoZSBhY2Nlc3NpYmlsaXR5IHRyZWUuIik7CisKKyAgICBpZiAod2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIGRvY3VtZW50LmJvZHkuZm9jdXMoKTsK KyAgICAgICAgdmFyIHdlYkFyZWEgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxl bWVudDsKKyAgICAgICAgaWYgKHdlYkFyZWEuY2hpbGRyZW5Db3VudCA+IDEpCisgICAgICAgICAg ICBzaG91bGRCZSgid2ViQXJlYS5jaGlsZEF0SW5kZXgoMCkuaXNFcXVhbCh3ZWJBcmVhLmNoaWxk QXRJbmRleCgxKSkiLCAiZmFsc2UiKTsKKyAgICB9CisKKyAgICBzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=