58926 2011-04-19 14:10:58 -0700 BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor 2011-04-21 15:36:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki abarth dpranke eric jamesr joepeck psolanki simon.fraser thestig tonyg webkit.review.bot oldest_to_newest 388779 0 psolanki 2011-04-19 14:10:58 -0700 destroyMetadataAndNotify sets m_isSolidColor flag to false but does not reset m_checkedForSolidColor. This means that a subsequent call to mayFillWithSolidColor would not call checkForSolidColor() and could end up returning false instead of true for a 1x1 image. 388782 1 psolanki 2011-04-19 14:11:54 -0700 <rdar://problem/9140052> 388789 2 90252 psolanki 2011-04-19 14:18:51 -0700 Created attachment 90252 Patch 388885 3 90272 psolanki 2011-04-19 16:17:58 -0700 Created attachment 90272 Patch 388889 4 90272 simon.fraser 2011-04-19 16:22:07 -0700 Comment on attachment 90272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90272&action=review r=me either way > Source/WebCore/platform/graphics/BitmapImage.h:167 > +#if !ASSERT_DISABLED > + void assertNotSolidColor() > + { > + ASSERT(size().width() != 1 || size().height() != 1 || frameCount() > 1); > + } > +#endif You could make this notSolidColor() const... > Source/WebCore/platform/graphics/cg/ImageCG.cpp:273 > + static_cast<BitmapImage*>(this)->assertNotSolidColor(); ... and here just ASSERT(notSolidColor()) 388928 5 psolanki 2011-04-19 17:20:28 -0700 (In reply to comment #4) > (From update of attachment 90272 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90272&action=review > > r=me either way > > > Source/WebCore/platform/graphics/BitmapImage.h:167 > > +#if !ASSERT_DISABLED > > + void assertNotSolidColor() > > + { > > + ASSERT(size().width() != 1 || size().height() != 1 || frameCount() > 1); > > + } > > +#endif > > You could make this notSolidColor() const... Couldn't make it const because we call franmeCount() that's not a const method. But I(In reply to comment #4) > (From update of attachment 90272 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90272&action=review > > r=me either way > > > Source/WebCore/platform/graphics/BitmapImage.h:167 > > +#if !ASSERT_DISABLED > > + void assertNotSolidColor() > > + { > > + ASSERT(size().width() != 1 || size().height() != 1 || frameCount() > 1); > > + } > > +#endif > > You could make this notSolidColor() const... > > > Source/WebCore/platform/graphics/cg/ImageCG.cpp:273 > > + static_cast<BitmapImage*>(this)->assertNotSolidColor(); > > ... and here just ASSERT(notSolidColor()) Thanks for the review. I made the change you suggested. I couldn't make notSolidColor() be a const method since we need to call frameCount() which isn't const. 388943 6 psolanki 2011-04-19 17:36:33 -0700 Committed r84321 - <http://trac.webkit.org/changeset/84321> 388967 7 simon.fraser 2011-04-19 18:13:36 -0700 I hit the assertion on LayoutTests/fast/backgrounds/background-fill-zero-area-crash.html with this change. 388975 8 psolanki 2011-04-19 18:17:12 -0700 Oops. I'll take a look at what's happening. 388986 9 webkit.review.bot 2011-04-19 18:29:42 -0700 http://trac.webkit.org/changeset/84321 might have broken Leopard Intel Debug (Tests) The following tests are not passing: fast/backgrounds/background-fill-zero-area-crash.html 388998 10 psolanki 2011-04-19 19:09:53 -0700 The stacktrace looks like (gdb) bt #0 0x00000001015af030 in WebCore::Image::drawPattern (this=0x1063f2650, ctxt=0x7fff5fbfc1b0, tileRect=@0x7fff5fbfac70, patternTransform=@0x7fff5fbfadc0, phase=@0x7fff5fbfae20, styleColorSpace=WebCore::ColorSpaceDeviceRGB, op=WebCore::CompositeSourceOver, destRect=@0x7fff5fbfaef0) at /Volumes/Data/psolanki/sources/external/WebKit.git/Source/WebCore/platform/graphics/cg/ImageCG.cpp:273 #1 0x00000001015acb18 in WebCore::ImageBuffer::drawPattern (this=0x1063ef2c0, destContext=0x7fff5fbfc1b0, srcRect=@0x7fff5fbfac70, patternTransform=@0x7fff5fbfadc0, phase=@0x7fff5fbfae20, styleColorSpace=WebCore::ColorSpaceDeviceRGB, op=WebCore::CompositeSourceOver, destRect=@0x7fff5fbfaef0) at /Volumes/Data/psolanki/sources/external/WebKit.git/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:229 #2 0x000000010144961f in WebCore::GeneratedImage::drawPattern (this=0x1063ee520, context=0x7fff5fbfc1b0, srcRect=@0x7fff5fbfadf0, patternTransform=@0x7fff5fbfadc0, phase=@0x7fff5fbfae20, styleColorSpace=WebCore::ColorSpaceDeviceRGB, compositeOp=WebCore::CompositeSourceOver, destRect=@0x7fff5fbfaef0) at /Volumes/Data/psolanki/sources/external/WebKit.git/Source/WebCore/platform/graphics/GeneratedImage.cpp:68 #3 0x00000001015abae6 in WebCore::Image::drawTiled (this=0x1063ee520, ctxt=0x7fff5fbfc1b0, destRect=@0x7fff5fbfaef0, srcPoint=@0x7fff5fbfaf20, scaledTileSize=@0x7fff5fbfaf10, styleColorSpace=WebCore::ColorSpaceDeviceRGB, op=WebCore::CompositeSourceOver) at /Volumes/Data/psolanki/sources/external/WebKit.git/Source/WebCore/platform/graphics/Image.cpp:142 Since its a GeneratedImage, the call to mayFillWithSolidColor() returns false in Image::drawTiled(). Then we come down to ImageBuffer::drawPattern() where we create a new BitmapImage (1x1) and call drawPattern() on it which results in this assertion being triggered. Maybe I should just move this assertion to be in Image::drawPattern() right after the call to mayFillWithSolidColor(). Or maybe ImageBuffer::drawPattern() should check for mayFillWithSolidColor() as well? 389063 11 90307 psolanki 2011-04-19 22:27:45 -0700 Created attachment 90307 Fix assertion 389065 12 psolanki 2011-04-19 22:29:25 -0700 (In reply to comment #10) > Maybe I should just move this assertion to be in Image::drawPattern() right after the call to mayFillWithSolidColor(). This is what I ended up doing in the patch attached. > Or maybe ImageBuffer::drawPattern() should check for mayFillWithSolidColor() as well? Couldn't do this in ImageBuffer because mayFillWithSolidColor() is protected, not public. 389066 13 90307 simon.fraser 2011-04-19 22:30:01 -0700 Comment on attachment 90307 Fix assertion View in context: https://bugs.webkit.org/attachment.cgi?id=90307&action=review > Source/WebCore/platform/graphics/Image.cpp:117 > + if (this->isBitmapImage()) > + ASSERT(static_cast<BitmapImage*>(this)->notSolidColor()); How about ASSERT(!isBitmapImage() || notSolidColor()) ? Then you don't need the ASSERT_DISABLED stuff. Why the this-> ? 389071 14 psolanki 2011-04-19 22:46:44 -0700 Follow on assertion fix committed as r84344 - <http://trac.webkit.org/changeset/84344> 389263 15 psolanki 2011-04-20 09:04:37 -0700 (In reply to comment #13) > (From update of attachment 90307 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90307&action=review > > > Source/WebCore/platform/graphics/Image.cpp:117 > > + if (this->isBitmapImage()) > > + ASSERT(static_cast<BitmapImage*>(this)->notSolidColor()); > > How about ASSERT(!isBitmapImage() || notSolidColor()) ? > Then you don't need the ASSERT_DISABLED stuff. Much better. Thanks. I committed with your suggested change. > Why the this-> ? Not sure why I wrote that. Maybe a habit from my java days. I removed it. 389546 16 thestig 2011-04-20 14:52:42 -0700 (In reply to comment #14) > Follow on assertion fix committed as r84344 - <http://trac.webkit.org/changeset/84344> With this commit, now I see the assertion failing on ToT Chromium for http://en.wikipedia.org/wiki/T._S._Eliot 389592 17 jamesr 2011-04-20 16:08:10 -0700 (In reply to comment #16) > (In reply to comment #14) > > Follow on assertion fix committed as r84344 - <http://trac.webkit.org/changeset/84344> > > With this commit, now I see the assertion failing on ToT Chromium for http://en.wikipedia.org/wiki/T._S._Eliot This assertion also trips in Chromium in debug mode on fast/table/stale-grid-crash.html 389635 18 psolanki 2011-04-20 16:48:16 -0700 (In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #14) > > > Follow on assertion fix committed as r84344 - <http://trac.webkit.org/changeset/84344> > > > > With this commit, now I see the assertion failing on ToT Chromium for http://en.wikipedia.org/wiki/T._S._Eliot > > This assertion also trips in Chromium in debug mode on fast/table/stale-grid-crash.html I'm not seeing the assert triggered on debug mac builds on either of the 2 pages above. The code in Image::drawTiled() is if (mayFillWithSolidColor()) { fillWithSolidColor(ctxt, destRect, solidColor(), styleColorSpace, op); return; } ASSERT(!isBitmapImage() || static_cast<BitmapImage*>(this)->notSolidColor()); The fact that this is triggered means that we had a 1x1 image which isn't getting filled by a solid color. Looking at ImageSkia.cpp, I see void BitmapImage::checkForSolidColor() { m_checkedForSolidColor = true; } No wonder its failing. That method on other ports checks if the image is 1x1 and if so it sets m_isSolidColor to true and sets m_solidColor to the color. 389645 19 psolanki 2011-04-20 16:57:24 -0700 Skia and wx are the two ports that don't have a proper implementation for checkForSolidColor(). I'll wrap the assert with proper ifdefs. 389657 20 90449 psolanki 2011-04-20 17:12:07 -0700 Created attachment 90449 Try to fix assertion failure on Chromium 389659 21 90449 rniwa 2011-04-20 17:15:07 -0700 Comment on attachment 90449 Try to fix assertion failure on Chromium View in context: https://bugs.webkit.org/attachment.cgi?id=90449&action=review > Source/WebCore/platform/graphics/Image.cpp:115 > + // See bugs 59041 and 59043. Maybe nicer to have bug URLs here. 389847 22 psolanki 2011-04-20 22:21:56 -0700 Committed Chromium fix r84468 - <http://trac.webkit.org/changeset/84468> 389952 23 90514 tonyg 2011-04-21 05:44:03 -0700 Created attachment 90514 Patch 389954 24 90514 tonyg 2011-04-21 05:45:38 -0700 Comment on attachment 90514 Patch Clearing flags on attachment: 90514 Committed r84488: <http://trac.webkit.org/changeset/84488> 389955 25 tonyg 2011-04-21 05:45:48 -0700 All reviewed patches have been landed. Closing bug. 390402 26 dpranke 2011-04-21 15:36:11 -0700 *** Bug 59148 has been marked as a duplicate of this bug. *** 90252 2011-04-19 14:18:51 -0700 2011-04-19 16:17:55 -0700 Patch bug-58926-20110419141850.patch text/plain 1353 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODQyOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZTMxNWY5ZTVkMzNjN2Vj YjVlZGY0NTYxMzg4OTkwYWYzNTgzZDQ3Li5iNGNkZjg2YThkMDU3ODQ0Mzc5ZTYwNTZhOWJjODdl NmUwZjU3OTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMTkgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEJpdG1hcEltYWdlOjpkZXN0cm95TWV0YWRhdGFBbmRO b3RpZnkgc2hvdWxkIGNsZWFyIG1fY2hlY2tlZEZvclNvbGlkQ29sb3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTI2CisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJ bWFnZTo6ZGVzdHJveU1ldGFkYXRhQW5kTm90aWZ5KTogU2V0IG1fY2hlY2tlZEZvclNvbGlkQ29s b3IgdG8gZmFsc2UuCisKIDIwMTEtMDQtMTkgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCmluZGV4IDYwMjdmMzRjMjNk ZWZjYWVlYmFlZjc0MzY2MWM5ZWY3ODRhZTZiOGMuLjdjZGI0M2Q4OTlkZmQ4YzE0NDZkZTBmODAw Y2NlOTQwZDg1ZDA4Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0JpdG1hcEltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9CaXRtYXBJbWFnZS5jcHAKQEAgLTEwMyw2ICsxMDMsNyBAQCB2b2lkIEJpdG1hcEltYWdlOjpk ZXN0cm95RGVjb2RlZERhdGFJZk5lY2Vzc2FyeShib29sIGRlc3Ryb3lBbGwpCiB2b2lkIEJpdG1h cEltYWdlOjpkZXN0cm95TWV0YWRhdGFBbmROb3RpZnkoaW50IGZyYW1lc0NsZWFyZWQpCiB7CiAg ICAgbV9pc1NvbGlkQ29sb3IgPSBmYWxzZTsKKyAgICBtX2NoZWNrZWRGb3JTb2xpZENvbG9yID0g ZmFsc2U7CiAgICAgaW52YWxpZGF0ZVBsYXRmb3JtRGF0YSgpOwogCiAgICAgaW50IGRlbHRhQnl0 ZXMgPSBmcmFtZXNDbGVhcmVkICogLWZyYW1lQnl0ZXMobV9zaXplKTsK 90272 2011-04-19 16:17:58 -0700 2011-04-21 05:43:47 -0700 Patch bug-58926-20110419161757.patch text/plain 3107 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODQzMDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYzE5MGIzZGU3MjVmYmFl ZmVhNDBmYTMyNmUwY2ZmMjdlNzNkNTYxLi42OWZjODE0MmQzY2ZjOWJkZjg1NjVmMmNlOTM0YWFm NWU2YTgxMTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTkgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEJpdG1hcEltYWdlOjpkZXN0cm95TWV0YWRhdGFBbmRO b3RpZnkgc2hvdWxkIGNsZWFyIG1fY2hlY2tlZEZvclNvbGlkQ29sb3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTI2CisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJ bWFnZTo6ZGVzdHJveU1ldGFkYXRhQW5kTm90aWZ5KTogU2V0IG1fY2hlY2tlZEZvclNvbGlkQ29s b3IgdG8gZmFsc2UuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaDoK KyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjphc3NlcnROb3RTb2xpZENvbG9yKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkltYWdlOjpkcmF3UGF0dGVybik6IEFkZCBhc3NlcnQgdG8gbWFrZSBzdXJlIHRoaXMgaXMg bm90IGNhbGxlZCBmb3IgYSAxeDEgaW1hZ2UuCisKIDIwMTEtMDQtMTkgIERhbiBCZXJuc3RlaW4g IDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERha2luLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCmluZGV4 IDYwMjdmMzRjMjNkZWZjYWVlYmFlZjc0MzY2MWM5ZWY3ODRhZTZiOGMuLjdjZGI0M2Q4OTlkZmQ4 YzE0NDZkZTBmODAwY2NlOTQwZDg1ZDA4Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKQEAgLTEwMyw2ICsxMDMsNyBAQCB2b2lkIEJp dG1hcEltYWdlOjpkZXN0cm95RGVjb2RlZERhdGFJZk5lY2Vzc2FyeShib29sIGRlc3Ryb3lBbGwp CiB2b2lkIEJpdG1hcEltYWdlOjpkZXN0cm95TWV0YWRhdGFBbmROb3RpZnkoaW50IGZyYW1lc0Ns ZWFyZWQpCiB7CiAgICAgbV9pc1NvbGlkQ29sb3IgPSBmYWxzZTsKKyAgICBtX2NoZWNrZWRGb3JT b2xpZENvbG9yID0gZmFsc2U7CiAgICAgaW52YWxpZGF0ZVBsYXRmb3JtRGF0YSgpOwogCiAgICAg aW50IGRlbHRhQnl0ZXMgPSBmcmFtZXNDbGVhcmVkICogLWZyYW1lQnl0ZXMobV9zaXplKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCmluZGV4IDM4 NjdkYjUwYzc4ZjI4NjA2M2Y4NGM0NzQwMzc0OWE4ZmFjNDczZjAuLjMyNTQ5MmNkNTgxYjA0NTgz NmI3MWRiYWVlZGM4MzI0NDA2MTZkNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvQml0bWFwSW1hZ2UuaApAQCAtMTU5LDYgKzE1OSwxMyBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCBOYXRpdmVJbWFnZVB0ciBuYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpIHsgcmV0 dXJuIGZyYW1lQXRJbmRleChjdXJyZW50RnJhbWUoKSk7IH0KICAgICBib29sIGZyYW1lSGFzQWxw aGFBdEluZGV4KHNpemVfdCk7IAogCisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgIHZvaWQgYXNz ZXJ0Tm90U29saWRDb2xvcigpCisgICAgeworICAgICAgICBBU1NFUlQoc2l6ZSgpLndpZHRoKCkg IT0gMSB8fCBzaXplKCkuaGVpZ2h0KCkgIT0gMSB8fCBmcmFtZUNvdW50KCkgPiAxKTsKKyAgICB9 CisjZW5kaWYKKwogcHJvdGVjdGVkOgogICAgIGVudW0gUmVwZXRpdGlvbkNvdW50U3RhdHVzIHsK ICAgICAgIFVua25vd24sICAgIC8vIFdlIGhhdmVuJ3QgY2hlY2tlZCB0aGUgc291cmNlJ3MgcmVw ZXRpdGlvbiBjb3VudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NnL0ltYWdlQ0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VDRy5jcHAKaW5kZXggMjRiNzI3NWY0ZTBhODE3MWYxZTgyNTFhODVjMTE0ZWJjZWM4Yzcw Zi4uYjVlNzA4OTJkZjk1ZGM1ZDEzMjU4YjU2YTFiNGQ4ZmVjODllYWRlMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VDRy5jcHAKQEAgLTI2OCw2ICsy NjgsMTEgQEAgdm9pZCBJbWFnZTo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0KiBjdHh0LCBj b25zdCBGbG9hdFJlY3QmIHRpbGVSZWN0LCBjb25zdAogICAgICAgICAvLyBBdm9pZCBhIGhhbmcg dW5kZXIgQ0dDb250ZXh0RHJhd1RpbGVkSW1hZ2Ugb24gcmVsZWFzZSBidWlsZHMuCiAgICAgICAg IHJldHVybjsKIAorI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBpZiAodGhpcy0+aXNCaXRtYXBJ bWFnZSgpKQorICAgICAgICBzdGF0aWNfY2FzdDxCaXRtYXBJbWFnZSo+KHRoaXMpLT5hc3NlcnRO b3RTb2xpZENvbG9yKCk7CisjZW5kaWYKKwogICAgIENHQ29udGV4dFJlZiBjb250ZXh0ID0gY3R4 dC0+cGxhdGZvcm1Db250ZXh0KCk7CiAgICAgY3R4dC0+c2F2ZSgpOwogICAgIENHQ29udGV4dENs aXBUb1JlY3QoY29udGV4dCwgZGVzdFJlY3QpOwo= 90307 2011-04-19 22:27:45 -0700 2011-04-21 05:43:52 -0700 Fix assertion bug-58926-20110419222744.patch text/plain 2276 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjZGY5MzE5NjFjZjczNDY5 YTI5NjZjNjMxZGIwOTlkMTU4NGEzY2Y1Li4zODM5OWY4ZmVlODVjZGQzNWU0MjI1MTk5NzE5ZjNk OWNjN2I4MDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTkgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvdyBvbiBmaXggZm9yIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODkyNgorCisgICAgICAgIE1vdmUgdGhlIGFzc2Vy dCBmcm9tIEltYWdlOjpkcmF3UGF0dGVybigpIHRvIEltYWdlOjpkcmF3VGlsZWQoKSBzbyB3ZSBk b24ndCBoaXQgaXQgd2hlbgorICAgICAgICB0cnlpbmcgdG8gcGFpbnQgR2VuZXJhdGVkSW1hZ2Vz LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW1hZ2U6OmRyYXdUaWxlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZTo6ZHJhd1BhdHRlcm4pOgorCiAy MDExLTA0LTE5ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JbWFnZS5jcHAKaW5kZXggMTFkYTBhYjgyMDE5NTY5MGE5NDAyOWI0ZDQwNDZm NmFmMjM4NGQxZi4uYWM2ZGUzODRmOWE3Zjg4ZmQ0NjY3ZGJjZjgzMzZiZTc0MDQ2ZWM1NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmNwcApAQCAtMTEyLDYgKzEx MiwxMSBAQCB2b2lkIEltYWdlOjpkcmF3VGlsZWQoR3JhcGhpY3NDb250ZXh0KiBjdHh0LCBjb25z dCBGbG9hdFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbAogICAgICAgICByZXR1cm47CiAgICAgfQog CisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgIGlmICh0aGlzLT5pc0JpdG1hcEltYWdlKCkpCisg ICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDxCaXRtYXBJbWFnZSo+KHRoaXMpLT5ub3RTb2xpZENv bG9yKCkpOworI2VuZGlmCisKICAgICBGbG9hdFNpemUgaW50cmluc2ljVGlsZVNpemUgPSBzaXpl KCk7CiAgICAgaWYgKGhhc1JlbGF0aXZlV2lkdGgoKSkKICAgICAgICAgaW50cmluc2ljVGlsZVNp emUuc2V0V2lkdGgoc2NhbGVkVGlsZVNpemUud2lkdGgoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCmluZGV4IDYzNWE4MDQ5MTQ4OThlMTI0 MjA0OTU4MWMyN2FlYWRmMTBiMjA0OTQuLjI0YjcyNzVmNGUwYTgxNzFmMWU4MjUxYTg1YzExNGVi Y2VjOGM3MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nn L0ltYWdlQ0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0lt YWdlQ0cuY3BwCkBAIC0yNjgsMTEgKzI2OCw2IEBAIHZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdy YXBoaWNzQ29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVjdCwgY29uc3QKICAg ICAgICAgLy8gQXZvaWQgYSBoYW5nIHVuZGVyIENHQ29udGV4dERyYXdUaWxlZEltYWdlIG9uIHJl bGVhc2UgYnVpbGRzLgogICAgICAgICByZXR1cm47CiAKLSNpZiAhQVNTRVJUX0RJU0FCTEVECi0g ICAgaWYgKHRoaXMtPmlzQml0bWFwSW1hZ2UoKSkKLSAgICAgICAgQVNTRVJUKHN0YXRpY19jYXN0 PEJpdG1hcEltYWdlKj4odGhpcyktPm5vdFNvbGlkQ29sb3IoKSk7Ci0jZW5kaWYKLQogICAgIENH Q29udGV4dFJlZiBjb250ZXh0ID0gY3R4dC0+cGxhdGZvcm1Db250ZXh0KCk7CiAgICAgY3R4dC0+ c2F2ZSgpOwogICAgIENHQ29udGV4dENsaXBUb1JlY3QoY29udGV4dCwgZGVzdFJlY3QpOwo= 90449 2011-04-20 17:12:07 -0700 2011-04-21 05:43:57 -0700 Try to fix assertion failure on Chromium bug-58926-20110420171206.patch text/plain 1449 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODQzOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzODg1ZWEyMGJiMjhmMzc2 NGE3ZTA5Y2MzZTFiNTRiZGJmNzNlM2MzLi5mMjBiMmMzYzE1MWJkNGJhMGYxNDcxYjEzYmFjNzE0 MmQyOTc0MjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjAgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvdyBvbiBmaXggZm9yIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODkyNgorCisgICAgICAgIEZpeCBhc3NlcnRpb25z IGluIENocm9taXVtIGJ1aWxkcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlOjpkcmF3VGlsZWQpOiBTa2lhIGFuZCBXeCBk byBub3QgaGF2ZSBwcm9wZXIgaW1wbGVtZW50YXRpb25zIG9mCisgICAgICAgIEJpdG1hcEltYWdl OjpjaGVja0ZvclNvbGlkQ29sb3IoKSBzbyB3ZSBzaG91bGRpbid0IGFzc2VydCBvbiB0aG9zZSBw bGF0Zm9ybXMuCisKIDIwMTEtMDQtMTkgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwCmluZGV4IDRhNmEyZjU5NDQw ZWIzN2U0NzQ5YzIyMTcwODZhMjRkYTVlYzBkYmMuLmViZjYzZGY3NTJiYmZjMTYyYmY1MWJhMTlh YjE2ZjU3M2UyYmM1NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFn ZS5jcHAKQEAgLTExMiw3ICsxMTIsMTAgQEAgdm9pZCBJbWFnZTo6ZHJhd1RpbGVkKEdyYXBoaWNz Q29udGV4dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmwKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIAorICAgIC8vIFNlZSBidWdzIDU5MDQxIGFuZCA1OTA0My4KKyNp ZiAhVVNFKFNLSUEpICYmICFQTEFURk9STShXWCkKICAgICBBU1NFUlQoIWlzQml0bWFwSW1hZ2Uo KSB8fCBzdGF0aWNfY2FzdDxCaXRtYXBJbWFnZSo+KHRoaXMpLT5ub3RTb2xpZENvbG9yKCkpOwor I2VuZGlmCiAKICAgICBGbG9hdFNpemUgaW50cmluc2ljVGlsZVNpemUgPSBzaXplKCk7CiAgICAg aWYgKGhhc1JlbGF0aXZlV2lkdGgoKSkK 90514 2011-04-21 05:44:03 -0700 2011-04-21 05:45:38 -0700 Patch bug-58926-20110421134401.patch text/plain 1923 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogODQ0ODcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0MGE5YjNkNmJiNmJhMDU2OTUwYzUy MTFjMjI1ZDRjOTU4NGVkNGM4Li41MjhiM2ZjYWM0M2YzMzQ4M2EzMmIzNDVhZmMzNjM2MTBjZGIz MjM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDQtMjEgIFRvbnkgR2VudGlsY29yZSAg PHRvbnlnQGNocm9taXVtLm9yZz4KIAorICAgICAgICBCaXRtYXBJbWFnZTo6ZGVzdHJveU1ldGFk YXRhQW5kTm90aWZ5IHNob3VsZCBjbGVhciBtX2NoZWNrZWRGb3JTb2xpZENvbG9yCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODkyNgorCisgICAgICAg IFJlbW92ZSBjaHJvbWl1bSdzIGNyYXNoaW5nIGV4cGVjdGF0aW9ucy4KKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKworMjAxMS0wNC0yMSAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtjaHJvbWl1bV0g Q29ycmVjdCBleHBlY2F0aW9ucyBmb3IgZWRpdGluZy9zZWxlY3Rpb24vZGVzaWdubW9kZS1uby1j YXJldC5odG1sCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01OTA4OAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKaW5kZXggOGY4NjJiMDdjYmE4ZTdlMmJmNzM1MGNhY2Q2YzNjOWEyODE2 NDY5My4uYTY2ODViNGQ3YTc0YTk1YWU5YWM2MjVlMDFjMDgzNzE3NzI4Y2FkMSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApA QCAtMzc1MCwxMyArMzc1MCw2IEBAIEJVR1RPTlkgTUFDIExFT1BBUkQgOiBmYXN0L2Nzcy92YWx1 ZS1saXN0LW91dC1vZi1ib3VuZHMtY3Jhc2guaHRtbCA9IElNQUdFCiBCVUdUT05ZIE1BQyBMRU9Q QVJEIDogc3ZnL2N1c3RvbS9ncm91cC1vcGFjaXR5LnN2ZyA9IElNQUdFCiBCVUdUT05ZIE1BQyBM RU9QQVJEIDogc3ZnL2N1c3RvbS9pbWFnZS13aXRoLXRyYW5zZm9ybS1jbGlwLWZpbHRlci5zdmcg PSBJTUFHRQogCi0vLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg5 MjYKLUJVR0NSODAwMTEgV0lOIExJTlVYIERFQlVHIDogY3NzMi4xL3QxNDAyMDEtYzUzMy1iZ2lt YWdlLTAwLWEuaHRtbCA9IENSQVNICi1CVUdDUjgwMDExIFdJTiBMSU5VWCBERUJVRyA6IGZhc3Qv YmFja2dyb3VuZHMvc29saWQtY29sb3ItY29udGV4dC1yZXN0b3JlLmh0bWwgPSBDUkFTSAotQlVH Q1I4MDAxMSBXSU4gTElOVVggREVCVUcgOiBmYXN0L2Nzcy9hY2lkMi1waXhlbC5odG1sID0gQ1JB U0gKLUJVR0NSODAwMTEgV0lOIExJTlVYIERFQlVHIDogZmFzdC9mcmFtZXMvY29udGVudC1vcGFj aXR5LTEuaHRtbCA9IENSQVNICi1CVUdDUjgwMDExIFdJTiBMSU5VWCBERUJVRyA6IGZhc3QvZnJh bWVzL2NvbnRlbnQtb3BhY2l0eS0yLmh0bWwgPSBDUkFTSAotCiAvLyB3ZWJraXQgcm9sbCA6IDg0 MzUwOjg0NDMxCiBCVUdEUFJBTktFIExJTlVYIDogZmFzdC9jYW52YXMvd2ViZ2wvY3NzLXdlYmtp dC1jYW52YXMtcmVwYWludC5odG1sID0gSU1BR0UKIEJVR0RQUkFOS0UgTElOVVggOiBmYXN0L2Nh bnZhcy93ZWJnbC9jc3Mtd2Via2l0LWNhbnZhcy5odG1sID0gSU1BR0UK