58897 2011-04-19 08:18:05 -0700 Framebuffer clearing should be pulled out of DrawingBuffer::reset(). 2011-04-19 10:42:09 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 senorblanco webkit-unassigned abarth commit-queue eric kbr mdelaney7 webkit.review.bot oldest_to_newest 388513 0 senorblanco 2011-04-19 08:18:05 -0700 Buffer clearing in DrawingBuffer::reset() should be refactored into its own function, per eseidel in https://bugs.webkit.org/show_bug.cgi?id=58706. 388516 1 90203 senorblanco 2011-04-19 08:22:37 -0700 Created attachment 90203 Patch 388519 2 eric 2011-04-19 08:30:11 -0700 Thanks for the cleanup! 388553 3 90203 commit-queue 2011-04-19 09:52:51 -0700 Comment on attachment 90203 Patch Clearing flags on attachment: 90203 Committed r84259: <http://trac.webkit.org/changeset/84259> 388554 4 commit-queue 2011-04-19 09:52:56 -0700 All reviewed patches have been landed. Closing bug. 388592 5 webkit.review.bot 2011-04-19 10:42:09 -0700 http://trac.webkit.org/changeset/84259 might have broken Windows 7 Release (Tests) 90203 2011-04-19 08:22:37 -0700 2011-04-19 09:52:51 -0700 Patch bug-58897-20110419112235.patch text/plain 6014 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MjU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTkgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHVsbCBmcmFtZWJ1ZmZlciBjbGVhcmluZyBvdXQg aW50byBpdHMgb3duIGZ1bmN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTg4OTcKKworICAgICAgICBDb3ZlcmVkIGJ5IGZhc3QvY2FudmFzIGFu ZCBjYW52YXMvcGhpbGlwIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L0RyYXdpbmdCdWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhd2luZ0J1ZmZlcjo6Y2xl YXJGcmFtZWJ1ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpEcmF3aW5nQnVmZmVyOjpyZXNldCk6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuaDoKKwogMjAx MS0wNC0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAg IFtRdF0gUkVHUkVTU0lPTig4NDE3Nik6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvZXZlbnQt bGlzdGVuZXItZ2MuaHRtbCBmYWlscwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9EcmF3aW5nQnVmZmVyLmNwcAkocmV2aXNpb24gODQyNTQp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw2ICsxNDQsNTMgQEAgdm9pZCBEcmF3aW5nQnVmZmVy OjpyZXNpemVEZXB0aFN0ZW5jaWwoaQogICAgIG1fY29udGV4dC0+YmluZFJlbmRlcmJ1ZmZlcihH cmFwaGljc0NvbnRleHQzRDo6UkVOREVSQlVGRkVSLCAwKTsKIH0KIAordm9pZCBEcmF3aW5nQnVm ZmVyOjpjbGVhckZyYW1lYnVmZmVyKCkKK3sKKyAgICBtX2NvbnRleHQtPmJpbmRGcmFtZWJ1ZmZl cihHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVIsIG1fbXVsdGlzYW1wbGVGQk8gPyBtX211 bHRpc2FtcGxlRkJPIDogbV9mYm8pOworICAgIGNvbnN0IEdyYXBoaWNzQ29udGV4dDNEOjpBdHRy aWJ1dGVzJiBhdHRyaWJ1dGVzID0gbV9jb250ZXh0LT5nZXRDb250ZXh0QXR0cmlidXRlcygpOwor ICAgIGZsb2F0IGNsZWFyRGVwdGggPSAwOworICAgIGludCBjbGVhclN0ZW5jaWwgPSAwOworICAg IHVuc2lnbmVkIGNoYXIgZGVwdGhNYXNrID0gdHJ1ZTsKKyAgICB1bnNpZ25lZCBpbnQgc3RlbmNp bE1hc2sgPSAweGZmZmZmZmZmOworICAgIHVuc2lnbmVkIGNoYXIgaXNTY2lzc29yRW5hYmxlZCA9 IGZhbHNlOworICAgIHVuc2lnbmVkIGxvbmcgY2xlYXJNYXNrID0gR3JhcGhpY3NDb250ZXh0M0Q6 OkNPTE9SX0JVRkZFUl9CSVQ7CisgICAgaWYgKGF0dHJpYnV0ZXMuZGVwdGgpIHsKKyAgICAgICAg bV9jb250ZXh0LT5nZXRGbG9hdHYoR3JhcGhpY3NDb250ZXh0M0Q6OkRFUFRIX0NMRUFSX1ZBTFVF LCAmY2xlYXJEZXB0aCk7CisgICAgICAgIG1fY29udGV4dC0+Y2xlYXJEZXB0aCgxKTsKKyAgICAg ICAgbV9jb250ZXh0LT5nZXRCb29sZWFudihHcmFwaGljc0NvbnRleHQzRDo6REVQVEhfV1JJVEVN QVNLLCAmZGVwdGhNYXNrKTsKKyAgICAgICAgbV9jb250ZXh0LT5kZXB0aE1hc2sodHJ1ZSk7Cisg ICAgICAgIGNsZWFyTWFzayB8PSBHcmFwaGljc0NvbnRleHQzRDo6REVQVEhfQlVGRkVSX0JJVDsK KyAgICB9CisgICAgaWYgKGF0dHJpYnV0ZXMuc3RlbmNpbCkgeworICAgICAgICBtX2NvbnRleHQt PmdldEludGVnZXJ2KEdyYXBoaWNzQ29udGV4dDNEOjpTVEVOQ0lMX0NMRUFSX1ZBTFVFLCAmY2xl YXJTdGVuY2lsKTsKKyAgICAgICAgbV9jb250ZXh0LT5jbGVhclN0ZW5jaWwoMCk7CisgICAgICAg IG1fY29udGV4dC0+Z2V0SW50ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6OlNURU5DSUxfV1JJVEVN QVNLLCByZWludGVycHJldF9jYXN0PGludCo+KCZzdGVuY2lsTWFzaykpOworICAgICAgICBtX2Nv bnRleHQtPnN0ZW5jaWxNYXNrU2VwYXJhdGUoR3JhcGhpY3NDb250ZXh0M0Q6OkZST05ULCAweGZm ZmZmZmZmKTsKKyAgICAgICAgY2xlYXJNYXNrIHw9IEdyYXBoaWNzQ29udGV4dDNEOjpTVEVOQ0lM X0JVRkZFUl9CSVQ7CisgICAgfQorICAgIGlzU2Npc3NvckVuYWJsZWQgPSBtX2NvbnRleHQtPmlz RW5hYmxlZChHcmFwaGljc0NvbnRleHQzRDo6U0NJU1NPUl9URVNUKTsKKyAgICBtX2NvbnRleHQt PmRpc2FibGUoR3JhcGhpY3NDb250ZXh0M0Q6OlNDSVNTT1JfVEVTVCk7CisKKyAgICBmbG9hdCBj bGVhckNvbG9yWzRdOworICAgIG1fY29udGV4dC0+Z2V0RmxvYXR2KEdyYXBoaWNzQ29udGV4dDNE OjpDT0xPUl9DTEVBUl9WQUxVRSwgY2xlYXJDb2xvcik7CisgICAgbV9jb250ZXh0LT5jbGVhckNv bG9yKDAsIDAsIDAsIDApOworICAgIG1fY29udGV4dC0+Y2xlYXIoY2xlYXJNYXNrKTsKKyAgICBt X2NvbnRleHQtPmNsZWFyQ29sb3IoY2xlYXJDb2xvclswXSwgY2xlYXJDb2xvclsxXSwgY2xlYXJD b2xvclsyXSwgY2xlYXJDb2xvclszXSk7CisKKyAgICBpZiAoYXR0cmlidXRlcy5kZXB0aCkgewor ICAgICAgICBtX2NvbnRleHQtPmNsZWFyRGVwdGgoY2xlYXJEZXB0aCk7CisgICAgICAgIG1fY29u dGV4dC0+ZGVwdGhNYXNrKGRlcHRoTWFzayk7CisgICAgfQorICAgIGlmIChhdHRyaWJ1dGVzLnN0 ZW5jaWwpIHsKKyAgICAgICAgbV9jb250ZXh0LT5jbGVhclN0ZW5jaWwoY2xlYXJTdGVuY2lsKTsK KyAgICAgICAgbV9jb250ZXh0LT5zdGVuY2lsTWFza1NlcGFyYXRlKEdyYXBoaWNzQ29udGV4dDNE OjpGUk9OVCwgc3RlbmNpbE1hc2spOworICAgIH0KKyAgICBpZiAoaXNTY2lzc29yRW5hYmxlZCkK KyAgICAgICAgbV9jb250ZXh0LT5lbmFibGUoR3JhcGhpY3NDb250ZXh0M0Q6OlNDSVNTT1JfVEVT VCk7CisgICAgZWxzZQorICAgICAgICBtX2NvbnRleHQtPmRpc2FibGUoR3JhcGhpY3NDb250ZXh0 M0Q6OlNDSVNTT1JfVEVTVCk7Cit9CisKIGJvb2wgRHJhd2luZ0J1ZmZlcjo6cmVzZXQoY29uc3Qg SW50U2l6ZSYgbmV3U2l6ZSkKIHsKICAgICBpZiAoIW1fY29udGV4dCkKQEAgLTIxNCw1MCArMjYx LDcgQEAgYm9vbCBEcmF3aW5nQnVmZmVyOjpyZXNldChjb25zdCBJbnRTaXplJgogICAgICAgICB9 CiAgICAgfQogCi0gICAgbV9jb250ZXh0LT5iaW5kRnJhbWVidWZmZXIoR3JhcGhpY3NDb250ZXh0 M0Q6OkZSQU1FQlVGRkVSLCBtX211bHRpc2FtcGxlRkJPID8gbV9tdWx0aXNhbXBsZUZCTyA6IG1f ZmJvKTsKLQotICAgIC8vIEluaXRpYWxpemUgcmVuZGVyYnVmZmVycyAoZGVwdGgvc3RlbmNpbCku Ci0gICAgZmxvYXQgY2xlYXJEZXB0aCA9IDA7Ci0gICAgaW50IGNsZWFyU3RlbmNpbCA9IDA7Ci0g ICAgdW5zaWduZWQgY2hhciBkZXB0aE1hc2sgPSB0cnVlOwotICAgIHVuc2lnbmVkIGludCBzdGVu Y2lsTWFzayA9IDB4ZmZmZmZmZmY7Ci0gICAgdW5zaWduZWQgY2hhciBpc1NjaXNzb3JFbmFibGVk ID0gZmFsc2U7Ci0gICAgdW5zaWduZWQgbG9uZyBjbGVhck1hc2sgPSBHcmFwaGljc0NvbnRleHQz RDo6Q09MT1JfQlVGRkVSX0JJVDsKLSAgICBpZiAoYXR0cmlidXRlcy5kZXB0aCkgewotICAgICAg ICBtX2NvbnRleHQtPmdldEZsb2F0dihHcmFwaGljc0NvbnRleHQzRDo6REVQVEhfQ0xFQVJfVkFM VUUsICZjbGVhckRlcHRoKTsKLSAgICAgICAgbV9jb250ZXh0LT5jbGVhckRlcHRoKDEpOwotICAg ICAgICBtX2NvbnRleHQtPmdldEJvb2xlYW52KEdyYXBoaWNzQ29udGV4dDNEOjpERVBUSF9XUklU RU1BU0ssICZkZXB0aE1hc2spOwotICAgICAgICBtX2NvbnRleHQtPmRlcHRoTWFzayh0cnVlKTsK LSAgICAgICAgY2xlYXJNYXNrIHw9IEdyYXBoaWNzQ29udGV4dDNEOjpERVBUSF9CVUZGRVJfQklU OwotICAgIH0KLSAgICBpZiAoYXR0cmlidXRlcy5zdGVuY2lsKSB7Ci0gICAgICAgIG1fY29udGV4 dC0+Z2V0SW50ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6OlNURU5DSUxfQ0xFQVJfVkFMVUUsICZj bGVhclN0ZW5jaWwpOwotICAgICAgICBtX2NvbnRleHQtPmNsZWFyU3RlbmNpbCgwKTsKLSAgICAg ICAgbV9jb250ZXh0LT5nZXRJbnRlZ2VydihHcmFwaGljc0NvbnRleHQzRDo6U1RFTkNJTF9XUklU RU1BU0ssIHJlaW50ZXJwcmV0X2Nhc3Q8aW50Kj4oJnN0ZW5jaWxNYXNrKSk7Ci0gICAgICAgIG1f Y29udGV4dC0+c3RlbmNpbE1hc2tTZXBhcmF0ZShHcmFwaGljc0NvbnRleHQzRDo6RlJPTlQsIDB4 ZmZmZmZmZmYpOwotICAgICAgICBjbGVhck1hc2sgfD0gR3JhcGhpY3NDb250ZXh0M0Q6OlNURU5D SUxfQlVGRkVSX0JJVDsKLSAgICB9Ci0gICAgaXNTY2lzc29yRW5hYmxlZCA9IG1fY29udGV4dC0+ aXNFbmFibGVkKEdyYXBoaWNzQ29udGV4dDNEOjpTQ0lTU09SX1RFU1QpOwotICAgIG1fY29udGV4 dC0+ZGlzYWJsZShHcmFwaGljc0NvbnRleHQzRDo6U0NJU1NPUl9URVNUKTsKLQotICAgIGZsb2F0 IGNsZWFyQ29sb3JbNF07Ci0gICAgbV9jb250ZXh0LT5nZXRGbG9hdHYoR3JhcGhpY3NDb250ZXh0 M0Q6OkNPTE9SX0NMRUFSX1ZBTFVFLCBjbGVhckNvbG9yKTsKLSAgICBtX2NvbnRleHQtPmNsZWFy Q29sb3IoMCwgMCwgMCwgMCk7Ci0gICAgbV9jb250ZXh0LT5jbGVhcihjbGVhck1hc2spOwotICAg IG1fY29udGV4dC0+Y2xlYXJDb2xvcihjbGVhckNvbG9yWzBdLCBjbGVhckNvbG9yWzFdLCBjbGVh ckNvbG9yWzJdLCBjbGVhckNvbG9yWzNdKTsKLQotICAgIGlmIChhdHRyaWJ1dGVzLmRlcHRoKSB7 Ci0gICAgICAgIG1fY29udGV4dC0+Y2xlYXJEZXB0aChjbGVhckRlcHRoKTsKLSAgICAgICAgbV9j b250ZXh0LT5kZXB0aE1hc2soZGVwdGhNYXNrKTsKLSAgICB9Ci0gICAgaWYgKGF0dHJpYnV0ZXMu c3RlbmNpbCkgewotICAgICAgICBtX2NvbnRleHQtPmNsZWFyU3RlbmNpbChjbGVhclN0ZW5jaWwp OwotICAgICAgICBtX2NvbnRleHQtPnN0ZW5jaWxNYXNrU2VwYXJhdGUoR3JhcGhpY3NDb250ZXh0 M0Q6OkZST05ULCBzdGVuY2lsTWFzayk7Ci0gICAgfQotICAgIGlmIChpc1NjaXNzb3JFbmFibGVk KQotICAgICAgICBtX2NvbnRleHQtPmVuYWJsZShHcmFwaGljc0NvbnRleHQzRDo6U0NJU1NPUl9U RVNUKTsKLSAgICBlbHNlCi0gICAgICAgIG1fY29udGV4dC0+ZGlzYWJsZShHcmFwaGljc0NvbnRl eHQzRDo6U0NJU1NPUl9URVNUKTsKKyAgICBjbGVhckZyYW1lYnVmZmVyKCk7CiAKICAgICBkaWRS ZXNldCgpOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJh d2luZ0J1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dwdS9EcmF3aW5nQnVmZmVyLmgJKHJldmlzaW9uIDg0MjU0KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuaAkod29ya2luZyBjb3B5KQpA QCAtNjEsNiArNjEsOCBAQCBwdWJsaWM6CiAgICAgCiAgICAgfkRyYXdpbmdCdWZmZXIoKTsKIAor ICAgIHZvaWQgY2xlYXJGcmFtZWJ1ZmZlcigpOworCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRo ZSBidWZmZXIgd2FzIHN1Y2Nlc3NmdWxseSByZXNpemVkLgogICAgIGJvb2wgcmVzZXQoY29uc3Qg SW50U2l6ZSYpOwogICAgIHZvaWQgYmluZCgpOwo=