58890 2011-04-19 06:27:20 -0700 REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output 2011-04-19 10:05:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED InRadar, LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 1 aroben jer.noble jer.noble sam oldest_to_newest 388453 0 aroben 2011-04-19 06:27:20 -0700 r84194, 1 failure: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/10828 r84210, 51 failures: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/10829 All the extra failures look like this: @@ -1,3 +1,4 @@ +supportsFullScreen() == true layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x50 388475 1 aroben 2011-04-19 06:46:19 -0700 <rdar://problem/9304546> 388550 2 jer.noble 2011-04-19 09:43:28 -0700 The 51 failures which have the extra stdout line in them look like the fault of r84206. I'll take this. 388556 3 90211 jer.noble 2011-04-19 09:53:30 -0700 Created attachment 90211 Patch 388559 4 90211 aroben 2011-04-19 09:54:17 -0700 Comment on attachment 90211 Patch Not only does it default to false, no one ever sets it to true! Is that really what we want? 388562 5 jer.noble 2011-04-19 09:56:52 -0700 Since it's in the .idl, it can be set from within a test script. I can imagine it being helpful to turn on only for the LayoutTests/fullscreen/ set of tests. 388564 6 jer.noble 2011-04-19 10:05:50 -0700 Committed r84262: <http://trac.webkit.org/changeset/84262> 90211 2011-04-19 09:53:30 -0700 2011-04-19 09:57:54 -0700 Patch bug-58890-20110419095329.patch text/plain 6116 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODQyMDYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZjJhNTkxMmU5OTY0NzVhYmQ5ZmVkMDJiZThiN2IxOGFm NDk3Y2E0Li5iYWQ4ZGVjZWM3YWUxMDM5ODc1ZjdjYzc3NWNkMWYyZjI0ZDY4ZTkzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDQtMTkgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjg0 MjA2KTogNTAgdGVzdHMgZmFpbGluZyBvbiBTbm93TGVvcGFyZCBJbnRlbCBSZWxlYXNlIChXZWJL aXQyIFRlc3RzKSBkdWUgdG8gZXh0cmEgInN1cHBvcnRzRnVsbFNjcmVlbigpID09IHRydWUiIG91 dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg4 OTAKKworICAgICAgICBBZGQgYSBsYXlvdXRUZXN0Q29udHJvbGxlciBmbGFnIHdoaWNoIGNvbnRy b2xzIHdoZW4gZnVsbCBzY3JlZW4gY2FsbGJhY2tzIGFyZSB3cml0dGVuIHRvIHN0ZG91dC4KKyAg ICAgICAgRGVmYXVsdHMgdG8gZmFsc2UuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9sbGVyLmlkbDogQWRkZWQgZHVt cEZ1bGxTY3JlZW5DYWxsYmFja3MoKS4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHA6CisgICAgICAgIChXVFI6OkluamVjdGVk QnVuZGxlUGFnZTo6c3VwcG9ydHNGdWxsU2NyZWVuKTogT25seSB3cml0ZSB0byBzdGRvdXQgaWYg c2hvdWxkRHVtcEZ1bGxTY3JlZW5DYWxsYmFja3MgaXMgc2V0LgorICAgICAgICAoV1RSOjpJbmpl Y3RlZEJ1bmRsZVBhZ2U6OmVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQpOiBEaXR0by4KKyAgICAg ICAgKFdUUjo6SW5qZWN0ZWRCdW5kbGVQYWdlOjpleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQpOiBE aXR0by4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRl c3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRyb2xsZXI6Okxh eW91dFRlc3RDb250cm9sbGVyKTogSW5pdGlhbGl6ZSBuZXcgaXZhci4KKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmg6CisgICAg ICAgIChXVFI6OkxheW91dFRlc3RDb250cm9sbGVyOjpkdW1wRnVsbFNjcmVlbkNhbGxiYWNrcyk6 IEFkZGVkLgorICAgICAgICAoV1RSOjpMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hvdWxkRHVtcEZ1 bGxTY3JlZW5DYWxsYmFja3MpOiBBZGRlZC4KKwogMjAxMS0wNC0wNSAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZm IC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9M YXlvdXRUZXN0Q29udHJvbGxlci5pZGwgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9sbGVyLmlkbAppbmRleCAyNDY0ZGJlZGJm NzY0YjNkOTIyODQ0YWZkMTczZDBkMDU0NWM1OTM0Li4wNTkzODQwNWRkM2M2MTRjMTg0YWU1ZTcz N2E1Yzg4MGZkOGYyZTBhIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9sbGVyLmlkbAorKysgYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzL0xheW91dFRlc3RDb250cm9s bGVyLmlkbApAQCAtMzksNiArMzksNyBAQCBtb2R1bGUgV1RSIHsKICAgICAgICAgdm9pZCBkdW1w U2VsZWN0aW9uUmVjdCgpOwogICAgICAgICB2b2lkIGR1bXBTdGF0dXNDYWxsYmFja3MoKTsKICAg ICAgICAgdm9pZCBkdW1wVGl0bGVDaGFuZ2VzKCk7CisgICAgICAgIHZvaWQgZHVtcEZ1bGxTY3Jl ZW5DYWxsYmFja3MoKTsKIAogICAgICAgICAvLyBTcGVjaWFsIG9wdGlvbnMuCiAgICAgICAgIHZv aWQga2VlcFdlYkhpc3RvcnkoKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcAppbmRleCA1MmVmZGM1 ZTQyNDY0MWU0MTE0ZmQ1Njk4ZGE4ZTkzOWUxZjBmNjllLi45MTFlMDhmNWIxZDA3MWNhNzVmMjFl ZGFjZGZiM2Q0YmFkMzRmNmQyIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3BwCkBAIC0xMDEyLDIw ICsxMDEyLDIzIEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24o V0tTdHJpbmdSZWYgbm90aWZpY2F0aW9uTmFtZSkKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkp CiBib29sIEluamVjdGVkQnVuZGxlUGFnZTo6c3VwcG9ydHNGdWxsU2NyZWVuKFdLQnVuZGxlUGFn ZVJlZiBwYWdlUmVmLCBXS0Z1bGxTY3JlZW5LZXlib2FyZFJlcXVlc3RUeXBlIHJlcXVlc3RUeXBl KQogewotICAgIEluamVjdGVkQnVuZGxlOjpzaGFyZWQoKS5vcygpIDw8ICJzdXBwb3J0c0Z1bGxT Y3JlZW4oKSA9PSB0cnVlXG4iOworICAgIGlmIChJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkubGF5 b3V0VGVzdENvbnRyb2xsZXIoKS0+c2hvdWxkRHVtcEZ1bGxTY3JlZW5DYWxsYmFja3MoKSkKKyAg ICAgICAgSW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLm9zKCkgPDwgInN1cHBvcnRzRnVsbFNjcmVl bigpID09IHRydWVcbiI7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgSW5qZWN0ZWRCdW5k bGVQYWdlOjplbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVm LCBXS0J1bmRsZU5vZGVIYW5kbGVSZWYgZWxlbWVudFJlZikKIHsKLSAgICBJbmplY3RlZEJ1bmRs ZTo6c2hhcmVkKCkub3MoKSA8PCAiZW50ZXJGdWxsU2NyZWVuRm9yRWxlbWVudCgpXG4iOworICAg IGlmIChJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkubGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+c2hv dWxkRHVtcEZ1bGxTY3JlZW5DYWxsYmFja3MoKSkKKyAgICAgICAgSW5qZWN0ZWRCdW5kbGU6OnNo YXJlZCgpLm9zKCkgPDwgImVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQoKVxuIjsKICAgICBXS0J1 bmRsZVBhZ2VXaWxsRW50ZXJGdWxsU2NyZWVuKHBhZ2VSZWYpOwogICAgIFdLQnVuZGxlUGFnZURp ZEVudGVyRnVsbFNjcmVlbihwYWdlUmVmKTsKIH0KIAogdm9pZCBJbmplY3RlZEJ1bmRsZVBhZ2U6 OmV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChXS0J1bmRsZVBhZ2VSZWYgcGFnZVJlZiwgV0tCdW5k bGVOb2RlSGFuZGxlUmVmIGVsZW1lbnRSZWYpCiB7Ci0gICAgSW5qZWN0ZWRCdW5kbGU6OnNoYXJl ZCgpLm9zKCkgPDwgImV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudCgpXG4iOworICAgIGlmIChJbmpl Y3RlZEJ1bmRsZTo6c2hhcmVkKCkubGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+c2hvdWxkRHVtcEZ1 bGxTY3JlZW5DYWxsYmFja3MoKSkKKyAgICAgICAgSW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLm9z KCkgPDwgImV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudCgpXG4iOwogICAgIFdLQnVuZGxlUGFnZVdp bGxFeGl0RnVsbFNjcmVlbihwYWdlUmVmKTsKICAgICBXS0J1bmRsZVBhZ2VEaWRFeGl0RnVsbFNj cmVlbihwYWdlUmVmKTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKaW5kZXggYjU3NTA3 NzIxMTJiZDM1ODcxMDU1ZjVmZmExNzA0NTg4MjIyOGQ0OC4uNDU3MjViNDk1NWMxNzRkNzY4ZGFk YjI5MTgwMjVhYjYwYmQzY2FjYiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKQEAgLTk5 LDYgKzk5LDcgQEAgTGF5b3V0VGVzdENvbnRyb2xsZXI6OkxheW91dFRlc3RDb250cm9sbGVyKCkK ICAgICAsIG1fZHVtcFN0YXR1c0NhbGxiYWNrcyhmYWxzZSkKICAgICAsIG1fZHVtcFRpdGxlQ2hh bmdlcyhmYWxzZSkKICAgICAsIG1fZHVtcFBpeGVscyh0cnVlKQorICAgICwgbV9kdW1wRnVsbFNj cmVlbkNhbGxiYWNrcyhmYWxzZSkKICAgICAsIG1fd2FpdFRvRHVtcChmYWxzZSkKICAgICAsIG1f dGVzdFJlcGFpbnQoZmFsc2UpCiAgICAgLCBtX3Rlc3RSZXBhaW50U3dlZXBIb3Jpem9udGFsbHko ZmFsc2UpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0xheW91dFRlc3RDb250cm9sbGVyLmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmgKaW5kZXggNzU2NTQ1NTExNTM5NmU1YjMxMTQx YWQ1NTEwODAyYzhjZjFjZjdjNC4uMDBkN2U1N2E0ZGFjOWMyYTI3ZWI5NDQxMDYwYjZiYjVmZjRh ODllZiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9M YXlvdXRUZXN0Q29udHJvbGxlci5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0 ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaApAQCAtNjcsNiArNjcsNyBAQCBwdWJsaWM6 CiAgICAgdm9pZCBkdW1wU2VsZWN0aW9uUmVjdCgpIHsgfSAvLyBXaWxsIG5lZWQgdG8gZG8gc29t ZXRoaW5nIHdoZW4gd2Ugc3VwcG9ydCBwaXhlbCB0ZXN0cy4KICAgICB2b2lkIGR1bXBTdGF0dXND YWxsYmFja3MoKSB7IG1fZHVtcFN0YXR1c0NhbGxiYWNrcyA9IHRydWU7IH0KICAgICB2b2lkIGR1 bXBUaXRsZUNoYW5nZXMoKSB7IG1fZHVtcFRpdGxlQ2hhbmdlcyA9IHRydWU7IH0KKyAgICB2b2lk IGR1bXBGdWxsU2NyZWVuQ2FsbGJhY2tzKCkgeyBtX2R1bXBGdWxsU2NyZWVuQ2FsbGJhY2tzID0g dHJ1ZTsgfQogCiAgICAgLy8gU3BlY2lhbCBvcHRpb25zLgogICAgIHZvaWQga2VlcFdlYkhpc3Rv cnkoKTsKQEAgLTEyOSw2ICsxMzAsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBzaG91bGREdW1wU3Rh dHVzQ2FsbGJhY2tzKCkgY29uc3QgeyByZXR1cm4gbV9kdW1wU3RhdHVzQ2FsbGJhY2tzOyB9CiAg ICAgYm9vbCBzaG91bGREdW1wVGl0bGVDaGFuZ2VzKCkgY29uc3QgeyByZXR1cm4gbV9kdW1wVGl0 bGVDaGFuZ2VzOyB9CiAgICAgYm9vbCBzaG91bGREdW1wUGl4ZWxzKCkgY29uc3QgeyByZXR1cm4g bV9kdW1wUGl4ZWxzOyB9CisgICAgYm9vbCBzaG91bGREdW1wRnVsbFNjcmVlbkNhbGxiYWNrcygp IGNvbnN0IHsgcmV0dXJuIG1fZHVtcEZ1bGxTY3JlZW5DYWxsYmFja3M7IH0KIAogICAgIGJvb2wg d2FpdFRvRHVtcCgpIGNvbnN0IHsgcmV0dXJuIG1fd2FpdFRvRHVtcDsgfQogICAgIHZvaWQgd2Fp dFRvRHVtcFdhdGNoZG9nVGltZXJGaXJlZCgpOwpAQCAtMTcwLDYgKzE3Miw3IEBAIHByaXZhdGU6 CiAgICAgYm9vbCBtX2R1bXBTdGF0dXNDYWxsYmFja3M7CiAgICAgYm9vbCBtX2R1bXBUaXRsZUNo YW5nZXM7CiAgICAgYm9vbCBtX2R1bXBQaXhlbHM7CisgICAgYm9vbCBtX2R1bXBGdWxsU2NyZWVu Q2FsbGJhY2tzOwogICAgIGJvb2wgbV93YWl0VG9EdW1wOyAvLyBUcnVlIGlmIHdhaXRVbnRpbERv bmUoKSBoYXMgYmVlbiBjYWxsZWQsIGJ1dCBub3RpZnlEb25lKCkgaGFzIG5vdCB5ZXQgYmVlbiBj YWxsZWQuCiAgICAgYm9vbCBtX3Rlc3RSZXBhaW50OwogICAgIGJvb2wgbV90ZXN0UmVwYWludFN3 ZWVwSG9yaXpvbnRhbGx5Owo=