58860 2011-04-18 19:11:13 -0700 make results file work with audio and reftests 2011-04-19 12:40:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth crogers dpranke eric tony webkit.review.bot oldest_to_newest 388228 0 ojan 2011-04-18 19:11:13 -0700 make results file work with audio and reftests 388231 1 90132 ojan 2011-04-18 19:12:16 -0700 Created attachment 90132 Patch 388232 2 90132 eric 2011-04-18 19:14:28 -0700 Comment on attachment 90132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154 > + // FIXME: use audio tags for AUDIO tests? woh, that'd be cool. > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264 > + row += resultLink(test_prefix, '-expected.wav', 'expected'); > + row += resultLink(test_prefix, '-actual.wav', 'actual'); Are they always .wav files? > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:292 > + resultLink(test_prefix, '-actual.png', 'actual') + You repeat these suffixes a lot. Maybe we should use constants? 388243 3 dpranke 2011-04-18 19:33:52 -0700 (In reply to comment #2) > (From update of attachment 90132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90132&action=review > > > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:154 > > + // FIXME: use audio tags for AUDIO tests? > > woh, that'd be cool. > Per crogers, that probably wouldn't be that useful, since you normally want to load them into an audio editor/analyzer to figure out why they're different. > > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:264 > > + row += resultLink(test_prefix, '-expected.wav', 'expected'); > > + row += resultLink(test_prefix, '-actual.wav', 'actual'); > > Are they always .wav files? Yes. 388619 4 ojan 2011-04-19 11:12:26 -0700 Committed r84267: <http://trac.webkit.org/changeset/84267> 388708 5 webkit.review.bot 2011-04-19 12:40:34 -0700 http://trac.webkit.org/changeset/84267 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: plugins/mouse-click-iframe-to-plugin.html 90132 2011-04-18 19:12:16 -0700 2011-04-18 19:14:28 -0700 Patch bug-58860-20110418191214.patch text/plain 6886 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODQxOTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YzQwODJkNGEwMWJjNjBlY2M0YmVjNTY1NmQwOWY3NTA2 NDg5ODgxLi5jZDZkMzM3Y2ZlMWRiNWE5MWNmOTRiOGY0Y2E4NzllYjFmZWFiNDc5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDQtMTggIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtYWtlIHJlc3VsdHMgZmls ZSB3b3JrIHdpdGggYXVkaW8gYW5kIHJlZnRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODg2MAorCisgICAgICAgIEFsc28gZml4IGJ1ZyB3aXRo IHRpbWVvdXQgdGVzdHMgYW5kIHN0b3JlIGEgYml0IGluIHRoZSBKU09OCisgICAgICAgIGZvciBu ZXcgaW1hZ2UgdGVzdHMgaW5zdGVhZCBvZiBsb2FkaW5nIHRoZSBpbWFnZSByZXN1bHQgdG8gY2hl Y2sgaWYgaXQncyB0aGVyZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0cy5odG1sOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5OgorCisy MDExLTA0LTE4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCiAKICAgICAgICAgaW5jbHVkZSBsaW5rcyB0byBhY3R1YWwu cG5nIGZpbGVzIGZvciBuZXcgcGl4ZWwgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0cy5odG1sIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9y ZXN1bHRzLmh0bWwKaW5kZXggNzQ0ODkyNzU3MjBiMzY2YjFiODE2MGJlYzk1MGUzYWI4YjkzNDEw Ny4uMzU0YTUxM2I3NTYyZTMwNjVhYmFkOTkyMWY5MjFmNWFjZjJhMmQ5OCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9y ZXN1bHRzLmh0bWwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwKQEAgLTE1MSw2ICsxNTEsNyBAQCBmdW5jdGlv biBwYXJlbnRPZlR5cGUobm9kZSwgc2VsZWN0b3IpCiAKIGZ1bmN0aW9uIGFwcGVuZFJlc3VsdElm cmFtZShzcmMsIHBhcmVudCkKIHsKKyAgICAvLyBGSVhNRTogdXNlIGF1ZGlvIHRhZ3MgZm9yIEFV RElPIHRlc3RzPwogICAgIHZhciBsYXlvdXRUZXN0c0luZGV4ID0gc3JjLmluZGV4T2YoJ0xheW91 dFRlc3RzJyk7CiAgICAgdmFyIG5hbWU7CiAgICAgaWYgKGxheW91dFRlc3RzSW5kZXggIT0gLTEp IHsKQEAgLTI1OCw3ICsyNTksMTAgQEAgZm9yICh2YXIgdGVzdCBpbiByZXN1bHRzLnRlc3RzKSB7 CiAgIHJvdyArPSAnPHRkPic7CiAgIGlmIChhY3R1YWwgPT0gJ0NSQVNIJykKICAgICAgIHJvdyAr PSByZXN1bHRMaW5rKHRlc3RfcHJlZml4LCAnLXN0YWNrLnR4dCcsICdzdGFjaycpOwotICBlbHNl IGlmIChhY3R1YWwuaW5kZXhPZignVEVYVCcgfHwgYWN0dWFsID09ICdUSU1FT1VUJykgIT0gLTEp IHsKKyAgZWxzZSBpZiAoYWN0dWFsID09ICdBVURJTycpIHsKKyAgICAgIHJvdyArPSByZXN1bHRM aW5rKHRlc3RfcHJlZml4LCAnLWV4cGVjdGVkLndhdicsICdleHBlY3RlZCcpOworICAgICAgcm93 ICs9IHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctYWN0dWFsLndhdicsICdhY3R1YWwnKTsKKyAg fSBlbHNlIGlmIChhY3R1YWwuaW5kZXhPZignVEVYVCcpICE9IC0xIHx8IGFjdHVhbCA9PSAnVElN RU9VVCcpIHsKICAgICAgIC8vIEZJWE1FOiBvbmx5IGluY2x1ZGUgdGltZW91dCBhY3R1YWwvZXhw ZWN0ZWQgcmVzdWx0cyBoZXJlIGlmIHdlIGFjdHVhbGx5IHNwaXQgb3V0IHJlc3VsdHMgZm9yIHRp bWVvdXQgdGVzdHMuCiAgICAgICBoYXNUZXh0RmFpbHVyZXMgPSB0cnVlOwogICAgICAgcm93ICs9 IHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctZXhwZWN0ZWQudHh0JywgJ2V4cGVjdGVkJykgKwpA QCAtMjc2LDkgKzI4MCwxOCBAQCBmb3IgKHZhciB0ZXN0IGluIHJlc3VsdHMudGVzdHMpIHsKIAog ICBpZiAoYWN0dWFsLmluZGV4T2YoJ0lNQUdFJykgIT0gLTEpIHsKICAgICAgIGhhc0ltYWdlRmFp bHVyZXMgPSB0cnVlOwotICAgICAgcm93ICs9IHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctZXhw ZWN0ZWQucG5nJywgJ2V4cGVjdGVkJykgKwotICAgICAgICAgIHJlc3VsdExpbmsodGVzdF9wcmVm aXgsICctYWN0dWFsLnBuZycsICdhY3R1YWwnKSArCi0gICAgICAgICAgcmVzdWx0TGluayh0ZXN0 X3ByZWZpeCwgJy1kaWZmLnBuZycsICdkaWZmJyk7CisKKyAgICAgIGlmIChyZXN1bHRzLnRlc3Rz W3Rlc3RdLmlzX21pc21hdGNoX3JlZnRlc3QpIHsKKyAgICAgICAgICByb3cgKz0gcmVzdWx0TGlu ayh0ZXN0X3ByZWZpeCwgJy1leHBlY3RlZC1taXNtYXRjaC5odG1sJywgJ3JlZiBtaXNtYXRjaCBo dG1sJykgKworICAgICAgICAgICAgICByZXN1bHRMaW5rKHRlc3RfcHJlZml4LCAnLWFjdHVhbC5w bmcnLCAnYWN0dWFsJyk7CisgICAgICB9IGVsc2UgeworICAgICAgICAgIGlmIChyZXN1bHRzLnRl c3RzW3Rlc3RdLmlzX3JlZnRlc3QpCisgICAgICAgICAgICAgIHJvdyArPSByZXN1bHRMaW5rKHRl c3RfcHJlZml4LCAnLWV4cGVjdGVkLmh0bWwnLCAncmVmIGh0bWwnKTsKKworICAgICAgICAgIHJv dyArPSByZXN1bHRMaW5rKHRlc3RfcHJlZml4LCAnLWV4cGVjdGVkLnBuZycsICdleHBlY3RlZCcp ICsKKyAgICAgICAgICAgICAgcmVzdWx0TGluayh0ZXN0X3ByZWZpeCwgJy1hY3R1YWwucG5nJywg J2FjdHVhbCcpICsKKyAgICAgICAgICAgICAgcmVzdWx0TGluayh0ZXN0X3ByZWZpeCwgJy1kaWZm LnBuZycsICdkaWZmJyk7CisgICAgICB9CiAgIH0KIAogICByb3cgKz0gJzwvdGQ+JzsKQEAgLTMw MCwxMyArMzEzLDIxIEBAIGZ1bmN0aW9uIGFwcGVuZFRlc3RMaXN0KHRlc3RzLCBoZWFkZXIsIHRh YmxlSWQsIGZpbGVTdWZmaXgsIGxpbmtOYW1lKQogICAgIGh0bWwgKz0gJzxwPicgKyBoZWFkZXIg KyAnPC9wPjx0YWJsZSBpZD0iJyArIHRhYmxlSWQgKyAnIj4nOwogICAgIGZvciAodmFyIGkgPSAw OyBpIDwgdGVzdHMubGVuZ3RoOyBpKyspIHsKICAgICAgICAgdmFyIHRlc3QgPSB0ZXN0c1tpXTsK LSAgICAgICAgaHRtbCArPSAnPHRib2R5Pjx0cj48dGQ+JyArIHRlc3RMaW5rKHRlc3QpICsgJzwv dGQ+JyArCi0gICAgICAgICAgICAnPHRkPicgKyByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRl c3QpLCBmaWxlU3VmZml4LCBsaW5rTmFtZSkgKyAnPC90ZD4nOworICAgICAgICBodG1sICs9ICc8 dGJvZHk+PHRyPjx0ZD4nICsgdGVzdExpbmsodGVzdCkgKyAnPC90ZD48dGQ+JzsKICAgICAgICAg Ci0gICAgICAgIGlmIChmaWxlU3VmZml4LmluZGV4T2YoJ2FjdHVhbCcpICE9IC0xKQotICAgICAg ICAgICAgaHRtbCArPSAnPHRkIGNsYXNzPSJpbWFnZS1yZXN1bHQtbGluayI+JyArIHJlc3VsdExp bmsoc3RyaXBFeHRlbnNpb24odGVzdCksICctYWN0dWFsLnBuZycsICdwbmcgcmVzdWx0JykgKyAn PC90ZD4nOworICAgICAgICBpZiAoZmlsZVN1ZmZpeC5pbmRleE9mKCdhY3R1YWwnKSA9PSAtMSkK KyAgICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgZmls ZVN1ZmZpeCwgbGlua05hbWUpOworICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIGlmIChyZXN1 bHRzLnRlc3RzW3Rlc3RdLmlzX21pc3NpbmdfYXVkaW8pCisgICAgICAgICAgICAgICAgaHRtbCAr PSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCAnLWFjdHVhbC53YXYnLCAnYXVkaW8g cmVzdWx0Jyk7CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICBodG1sICs9IHJl c3VsdExpbmsoc3RyaXBFeHRlbnNpb24odGVzdCksIGZpbGVTdWZmaXgsIGxpbmtOYW1lKTsKKyAg ICAgICAgICAgICAgICBpZiAocmVzdWx0cy50ZXN0c1t0ZXN0XS5pc19taXNzaW5nX2ltYWdlKQor ICAgICAgICAgICAgICAgICAgICBodG1sICs9IHJlc3VsdExpbmsoc3RyaXBFeHRlbnNpb24odGVz dCksICctYWN0dWFsLnBuZycsICdwbmcgcmVzdWx0Jyk7CisgICAgICAgICAgICB9CisgICAgICAg IH0gCiAgICAgICAgIAotICAgICAgICBodG1sICs9ICc8L3RyPjwvdGJvZHk+JzsKKyAgICAgICAg aHRtbCArPSAnPC90ZD48L3RyPjwvdGJvZHk+JzsKICAgICB9CiAgICAgaHRtbCArPSAnPC90YWJs ZT4nCiB9CkBAIC0zMjQsMjQgKzM0NSw2IEBAIGlmIChoYXNIdHRwVGVzdHMpIHsKIAogZG9jdW1l bnQud3JpdGUoaHRtbCk7CiAKLWZ1bmN0aW9uIHJlc3VsdExpbmtFcnJvckhhbmRsZXJGdW5jdGlv bihsaW5rKQotewotICAgIHJldHVybiBmdW5jdGlvbigpIHsgbGluay5wYXJlbnROb2RlLnJlbW92 ZUNoaWxkKGxpbmspOyB9OwotfQotCi1mdW5jdGlvbiByZW1vdmVOb25FeGlzdGFudE5ld1BpeGVs UmVzdWx0cygpCi17Ci0gICAgdmFyIGltYWdlUmVzdWx0TGlua3MgPSBkb2N1bWVudC5xdWVyeVNl bGVjdG9yQWxsKCcjbmV3LXRlc3RzLXRhYmxlIC5pbWFnZS1yZXN1bHQtbGluaycpOwotICAgIGZv ciAodmFyIGkgPSAwLCBsZW4gPSBpbWFnZVJlc3VsdExpbmtzLmxlbmd0aDsgaSA8IGxlbjsgaSsr KSB7Ci0gICAgICAgIHZhciByZXN1bHRMaW5rID0gaW1hZ2VSZXN1bHRMaW5rc1tpXTsKLSAgICAg ICAgdmFyIGltZyA9IG5ldyBJbWFnZSgpOwotICAgICAgICBpbWcub25lcnJvciA9IHJlc3VsdExp bmtFcnJvckhhbmRsZXJGdW5jdGlvbihyZXN1bHRMaW5rKTsKLSAgICAgICAgaW1nLnNyYyA9IHJl c3VsdExpbmsucXVlcnlTZWxlY3RvcignYScpLmhyZWY7Ci0gICAgfQotfQotCi1yZW1vdmVOb25F eGlzdGFudE5ld1BpeGVsUmVzdWx0cygpOwotCiBmdW5jdGlvbiB0b0FycmF5KG5vZGVMaXN0KQog ewogICAgIHJldHVybiBBcnJheS5wcm90b3R5cGUuc2xpY2UuY2FsbChub2RlTGlzdCk7CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2Fn ZS90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xh eW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5CmluZGV4IDczNDNkZGQ3ZTM1MWE4ODUxZTQ1MGMy ZDE0YTY4NWViZmUwZTYxZmYuLjAzYmIxNDk4YmIwMDQzYmZkNTFjZTk4ZjA2MmNlY2U4ZjVlYzlk YTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5CkBAIC0xNDUsOSArMTQ1LDI2 IEBAIGRlZiBzdW1tYXJpemVfcmVzdWx0cyhwb3J0X29iaiwgZXhwZWN0YXRpb25zLCByZXN1bHRf c3VtbWFyeSwgcmV0cnlfc3VtbWFyeSwgdGVzCiAgICAgICAgIHRlc3RzW3Rlc3RdID0ge30KICAg ICAgICAgdGVzdHNbdGVzdF1bJ2V4cGVjdGVkJ10gPSBleHBlY3RlZAogICAgICAgICB0ZXN0c1t0 ZXN0XVsnYWN0dWFsJ10gPSAiICIuam9pbihhY3R1YWwpCi0gICAgICAgICMgRklYTUU6IFNldCB0 aGlzIGNvcnJlY3RseSBvbmNlIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzM3NzM5IGlzIGZpeGVkLgor ICAgICAgICAjIEZJWE1FOiBTZXQgdGhpcyBjb3JyZWN0bHkgb25jZSBodHRwczovL3dlYmtpdC5v cmcvYi8zNzczOSBpcyBmaXhlZAorICAgICAgICAjIGFuZCBvbmx5IHNldCBpdCBpZiB0aGVyZSBh Y3R1YWxseSBpcyBzdGRlcnIgZGF0YS4KICAgICAgICAgdGVzdHNbdGVzdF1bJ2hhc19zdGRlcnIn XSA9IEZhbHNlCiAKKyAgICAgICAgZm9yIGYgaW4gcmVzdWx0LmZhaWx1cmVzOgorICAgICAgICAg ICAgcHJpbnQgZi5tZXNzYWdlKCkKKworICAgICAgICBmYWlsdXJlX3R5cGVzID0gW3R5cGUoZikg Zm9yIGYgaW4gcmVzdWx0LmZhaWx1cmVzXQorICAgICAgICBpZiB0ZXN0X2ZhaWx1cmVzLkZhaWx1 cmVNaXNzaW5nQXVkaW8gaW4gZmFpbHVyZV90eXBlczoKKyAgICAgICAgICAgIHRlc3RzW3Rlc3Rd Wydpc19taXNzaW5nX2F1ZGlvJ10gPSBUcnVlCisKKyAgICAgICAgaWYgdGVzdF9mYWlsdXJlcy5G YWlsdXJlUmVmdGVzdE1pc21hdGNoIGluIGZhaWx1cmVfdHlwZXM6CisgICAgICAgICAgICB0ZXN0 c1t0ZXN0XVsnaXNfcmVmdGVzdCddID0gVHJ1ZQorCisgICAgICAgIGlmIHRlc3RfZmFpbHVyZXMu RmFpbHVyZVJlZnRlc3RNaXNtYXRjaERpZE5vdE9jY3VyIGluIGZhaWx1cmVfdHlwZXM6CisgICAg ICAgICAgICB0ZXN0c1t0ZXN0XVsnaXNfbWlzbWF0Y2hfcmVmdGVzdCddID0gVHJ1ZQorCisgICAg ICAgIGlmIHRlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZSBpbiBmYWlsdXJlX3R5cGVz IG9yIHRlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2ggaW4gZmFpbHVyZV90eXBl czoKKyAgICAgICAgICAgIHRlc3RzW3Rlc3RdWydpc19taXNzaW5nX2ltYWdlJ10gPSBUcnVlCisK ICAgICAgICAgaWYgZmlsZW5hbWUgaW4gdGVzdF90aW1pbmdzX21hcDoKICAgICAgICAgICAgIHRp bWVfc2Vjb25kcyA9IHRlc3RfdGltaW5nc19tYXBbZmlsZW5hbWVdCiAgICAgICAgICAgICB0ZXN0 c1t0ZXN0XVsndGltZV9tcyddID0gaW50KDEwMDAgKiB0aW1lX3NlY29uZHMpCg==