58846 2011-04-18 15:49:32 -0700 Re-add a null check lost in r83081 2011-04-18 16:07:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 ap ap rsesek oldest_to_newest 388119 0 ap 2011-04-18 15:49:32 -0700 A null check was lost in selectedRange(), causing crashes. 388125 1 90109 ap 2011-04-18 15:51:51 -0700 Created attachment 90109 proposed patch 388128 2 rsesek 2011-04-18 15:55:38 -0700 An alternative would be to return false in TextIterator::locationAndLengthFromRange(), which is what WebPage::getLocationAndLengthFromRange used to do. Sorry that I introduced so many regressions :/ 388131 3 90109 mjs 2011-04-18 15:58:07 -0700 Comment on attachment 90109 proposed patch r=me 388142 4 ap 2011-04-18 16:07:57 -0700 Committed <http://trac.webkit.org/changeset/84202>. 90109 2011-04-18 15:51:51 -0700 2011-04-18 15:58:07 -0700 proposed patch NullCheck.txt text/plain 1377 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MTk2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMTggIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmUtYWRkIGEgbnVsbCBjaGVjayBsb3N0IGluIHI4MzA4MQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg4NDYKKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbToKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZTo6Z2V0U2VsZWN0ZWRSYW5nZSk6CisKIDIwMTEtMDQtMTggIE1hY2ll aiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9X ZWJQYWdlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkocmV2aXNpb24gODQwNTcpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0JKHdvcmtpbmcgY29weSkKQEAg LTMwNCw3ICszMDQsOCBAQCB2b2lkIFdlYlBhZ2U6OmdldFNlbGVjdGVkUmFuZ2UodWludDY0X3Qm CiAKICAgICBzaXplX3QgbG9jYXRpb25TaXplOwogICAgIHNpemVfdCBsZW5ndGhTaXplOwotICAg IGlmIChUZXh0SXRlcmF0b3I6OmxvY2F0aW9uQW5kTGVuZ3RoRnJvbVJhbmdlKGZyYW1lLT5zZWxl Y3Rpb24oKS0+dG9Ob3JtYWxpemVkUmFuZ2UoKS5nZXQoKSwgbG9jYXRpb25TaXplLCBsZW5ndGhT aXplKSkgeworICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBmcmFtZS0+c2VsZWN0aW9uKCktPnRv Tm9ybWFsaXplZFJhbmdlKCk7CisgICAgaWYgKHJhbmdlICYmIFRleHRJdGVyYXRvcjo6bG9jYXRp b25BbmRMZW5ndGhGcm9tUmFuZ2UocmFuZ2UuZ2V0KCksIGxvY2F0aW9uU2l6ZSwgbGVuZ3RoU2l6 ZSkpIHsKICAgICAgICAgbG9jYXRpb24gPSBzdGF0aWNfY2FzdDx1aW50NjRfdD4obG9jYXRpb25T aXplKTsKICAgICAgICAgbGVuZ3RoID0gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KGxlbmd0aFNpemUp OwogICAgIH0K