58844 2011-04-18 15:46:20 -0700 [Qt][WK2] Clean up tool-tip/status-bar confusion. 2011-04-18 16:06:59 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Mac (PowerPC) OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 388116 0 kling 2011-04-18 15:46:20 -0700 Tool-tip changes currently emit QWKPage::statusBarMessage() and status bar message changes emit nothing. This is obviously rather backwards. :) 388118 1 90107 kling 2011-04-18 15:48:56 -0700 Created attachment 90107 Proposed patch 388123 2 webkit.review.bot 2011-04-18 15:51:15 -0700 Attachment 90107 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/ClientImpl.h:53: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 388140 3 90107 kling 2011-04-18 16:06:52 -0700 Comment on attachment 90107 Proposed patch Clearing flags on attachment: 90107 Committed r84201: <http://trac.webkit.org/changeset/84201> 388141 4 kling 2011-04-18 16:06:59 -0700 All reviewed patches have been landed. Closing bug. 90107 2011-04-18 15:48:56 -0700 2011-04-18 16:06:52 -0700 Proposed patch bug-58844.diff text/plain 6093 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzN2NhMWE0Li4wNDQxNGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTEtMDQtMTggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBDbGVh biB1cCB0b29sLXRpcC9zdGF0dXMtYmFyIGNvbmZ1c2lvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4ODQ0CisKKyAgICAgICAgVG9vbC10aXBzIHdl cmUgaW5jb3JyZWN0bHkgaG9va2VkIHVwIHRvIHRoZSBzdGF0dXMgYmFyIHRleHQuCisgICAgICAg IENocm9tZTo6c2V0U3RhdHVzYmFyVGV4dCgpIG5vdyBjb3JyZWN0bHkgY2F1c2VzIHRoZSBRV0tQ YWdlOjpzdGF0dXNCYXJNZXNzYWdlKCkgc2lnbmFsLgorCisgICAgICAgIE5ldyBBUEk6CisgICAg ICAgIC0gUVdLUGFnZTo6dG9vbFRpcENoYW5nZWQoY29uc3QgUVN0cmluZyYgdG9vbFRpcCkgW3Np Z25hbF0KKworICAgICAgICBRR3JhcGhpY3NXS1ZpZXcgd2lsbCBhdXRvbWF0aWNhbGx5IGxpc3Rl biBmb3IgdGhpcyBhbmQgc2V0IGl0cyBvd24gdG9vbFRpcCgpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9xdC9DbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKHF0X3drX3NldFN0YXR1c1RleHQp OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmNwcDoKKyAgICAgICAgKFFHcmFwaGljc1dL Vmlldzo6UUdyYXBoaWNzV0tWaWV3KToKKyAgICAgICAgKFFHcmFwaGljc1dLVmlld1ByaXZhdGU6 Om9uVG9vbFRpcENoYW5nZWQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNz d2t2aWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcDoKKyAgICAg ICAgKFFXS1BhZ2VQcml2YXRlOjp0b29sVGlwQ2hhbmdlZCk6CisgICAgICAgIChRV0tQYWdlOjpR V0tQYWdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaDoKKwogMjAxMS0w NC0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzU4NDYzPiBTd2l0Y2ggSFRUUCBwaXBlbGluaW5nIGZyb20gdXNlciBk ZWZhdWx0IHRvIHByaXZhdGUgc2V0dGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9DbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvQ2xpZW50SW1wbC5jcHAKaW5kZXggNDc1ZDMxMC4uYjQyNzA1OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9DbGllbnRJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L0NsaWVudEltcGwuY3BwCkBAIC0xNzMsMyArMTcz LDkgQEAgdm9pZCBxdF93a190YWtlRm9jdXMoV0tQYWdlUmVmIHBhZ2UsIFdLRm9jdXNEaXJlY3Rp b24gZGlyZWN0aW9uLCBjb25zdCB2b2lkICpjbGkKIHZvaWQgcXRfd2tfcnVuSmF2YVNjcmlwdEFs ZXJ0KFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiBhbGVydFRleHQsIFdLRnJhbWVSZWYgZnJh bWUsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CiB9CisKK3ZvaWQgcXRfd2tfc2V0U3RhdHVz VGV4dChXS1BhZ2VSZWYgcGFnZSwgV0tTdHJpbmdSZWYgdGV4dCwgY29uc3Qgdm9pZCAqY2xpZW50 SW5mbykKK3sKKyAgICBRU3RyaW5nIHFUZXh0ID0gV0tTdHJpbmdDb3B5UVN0cmluZyh0ZXh0KTsK KyAgICBlbWl0IHRvUVdLUGFnZShjbGllbnRJbmZvKS0+c3RhdHVzQmFyTWVzc2FnZShxVGV4dCk7 Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L0NsaWVudElt cGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5oCmluZGV4 IDZmNDEyOGUuLjc5NTUxNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv Q2xpZW50SW1wbC5oCkBAIC01MCw2ICs1MCw3IEBAIHZvaWQgcXRfd2tfc2hvd1BhZ2UoV0tQYWdl UmVmIHBhZ2UsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogdm9pZCBxdF93a19jbG9zZShXS1Bh Z2VSZWYgcGFnZSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB2b2lkIHF0X3drX3Rha2VGb2N1 cyhXS1BhZ2VSZWYgcGFnZSwgV0tGb2N1c0RpcmVjdGlvbiBkaXJlY3Rpb24sIGNvbnN0IHZvaWQg KmNsaWVudEluZm8pOwogdm9pZCBxdF93a19ydW5KYXZhU2NyaXB0QWxlcnQoV0tQYWdlUmVmIHBh Z2UsIFdLU3RyaW5nUmVmIGFsZXJ0VGV4dCwgV0tGcmFtZVJlZiBmcmFtZSwgY29uc3Qgdm9pZCog Y2xpZW50SW5mbyk7Cit2b2lkIHF0X3drX3NldFN0YXR1c1RleHQoV0tQYWdlUmVmIHBhZ2UsIFdL U3RyaW5nUmVmIHRleHQsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogCiAjaWZkZWYgX19jcGx1 c3BsdXMKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdy YXBoaWNzd2t2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBo aWNzd2t2aWV3LmNwcAppbmRleCAwMzgxZDczLi5kODVhZGUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCkBAIC01MCw2ICs1 MCw3IEBAIHN0cnVjdCBRR3JhcGhpY3NXS1ZpZXdQcml2YXRlIHsKICAgICBRR3JhcGhpY3NXS1Zp ZXdQcml2YXRlKFFHcmFwaGljc1dLVmlldyogdmlldyk7CiAgICAgV0tQYWdlUmVmIHBhZ2VSZWYo KSBjb25zdCB7IHJldHVybiBwYWdlLT5wYWdlUmVmKCk7IH0KIAorICAgIHZvaWQgb25Ub29sVGlw Q2hhbmdlZChjb25zdCBRU3RyaW5nJik7CiAgICAgdm9pZCBvblNjYWxlQ2hhbmdlZCgpOwogICAg IHZvaWQgY29tbWl0U2NhbGUoKTsKIApAQCAtODQsNiArODUsNyBAQCBRR3JhcGhpY3NXS1ZpZXc6 OlFHcmFwaGljc1dLVmlldyhRV0tDb250ZXh0KiBjb250ZXh0LCBCYWNraW5nU3RvcmVUeXBlIGJh Y2tpbmdTdAogICAgIGNvbm5lY3QoZC0+cGFnZSwgU0lHTkFMKGN1cnNvckNoYW5nZWQoY29uc3Qg UUN1cnNvciYpKSwgdGhpcywgU0xPVCh1cGRhdGVDdXJzb3IoY29uc3QgUUN1cnNvciYpKSk7CiAg ICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoZm9jdXNOZXh0UHJldkNoaWxkKGJvb2wpKSwgdGhp cywgU0xPVChmb2N1c05leHRQcmV2Q2hpbGRDYWxsYmFjayhib29sKSkpOwogICAgIGNvbm5lY3Qo ZC0+cGFnZSwgU0lHTkFMKHNob3dDb250ZXh0TWVudShRU2hhcmVkUG9pbnRlcjxRTWVudT4pKSwg dGhpcywgU0xPVChzaG93Q29udGV4dE1lbnUoUVNoYXJlZFBvaW50ZXI8UU1lbnU+KSkpOworICAg IGNvbm5lY3QoZC0+cGFnZSwgU0lHTkFMKHRvb2xUaXBDaGFuZ2VkKFFTdHJpbmcpKSwgdGhpcywg U0xPVChvblRvb2xUaXBDaGFuZ2VkKFFTdHJpbmcpKSk7CiB9CiAKIFFHcmFwaGljc1dLVmlldzo6 flFHcmFwaGljc1dLVmlldygpCkBAIC00MjQsNiArNDI2LDExIEBAIHZvaWQgUUdyYXBoaWNzV0tW aWV3UHJpdmF0ZTo6b25TY2FsZUNoYW5nZWQoKQogI2VuZGlmCiB9CiAKK3ZvaWQgUUdyYXBoaWNz V0tWaWV3UHJpdmF0ZTo6b25Ub29sVGlwQ2hhbmdlZChjb25zdCBRU3RyaW5nJiB0b29sVGlwKQor eworICAgIHEtPnNldFRvb2xUaXAodG9vbFRpcCk7Cit9CisKIHZvaWQgUUdyYXBoaWNzV0tWaWV3 UHJpdmF0ZTo6Y29tbWl0U2NhbGUoKQogewogI2lmIEVOQUJMRShUSUxFRF9CQUNLSU5HX1NUT1JF KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3 a3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3 LmgKaW5kZXggMDNmYzcyMi4uZTRhZWNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5oCkBAIC05MCw3ICs5MCw4IEBAIHByb3RlY3Rl ZDoKICAgICB2aXJ0dWFsIHZvaWQgZm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCopOwogCiBwcml2 YXRlOgotICAgIFFfUFJJVkFURV9TTE9UKGQsIHZvaWQgb25TY2FsZUNoYW5nZWQoKSk7CisgICAg UV9QUklWQVRFX1NMT1QoZCwgdm9pZCBvblNjYWxlQ2hhbmdlZCgpKQorICAgIFFfUFJJVkFURV9T TE9UKGQsIHZvaWQgb25Ub29sVGlwQ2hhbmdlZChjb25zdCBRU3RyaW5nJikpCiAKICAgICBRR3Jh cGhpY3NXS1ZpZXdQcml2YXRlKiBkOwogICAgIGZyaWVuZCBjbGFzcyBRR3JhcGhpY3NXS1ZpZXdQ cml2YXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2tw YWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5k ZXggMGM3ZjUyNi4uN2ViNzhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xd2twYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2UuY3BwCkBAIC0yMDIsNyArMjAyLDcgQEAgdm9pZCBRV0tQYWdlUHJpdmF0ZTo6ZGlk Q2hhbmdlQ29udGVudHNTaXplKGNvbnN0IEludFNpemUmIG5ld1NpemUpCiAKIHZvaWQgUVdLUGFn ZVByaXZhdGU6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYgbmV3 VG9vbHRpcCkKIHsKLSAgICBlbWl0IHEtPnN0YXR1c0Jhck1lc3NhZ2UoUVN0cmluZyhuZXdUb29s dGlwKSk7CisgICAgZW1pdCBxLT50b29sVGlwQ2hhbmdlZChRU3RyaW5nKG5ld1Rvb2x0aXApKTsK IH0KIAogdm9pZCBRV0tQYWdlUHJpdmF0ZTo6cmVnaXN0ZXJFZGl0Q29tbWFuZChQYXNzUmVmUHRy PFdlYkVkaXRDb21tYW5kUHJveHk+LCBXZWJQYWdlUHJveHk6OlVuZG9PclJlZG8pCkBAIC00NjQs NyArNDY0LDcgQEAgUVdLUGFnZTo6UVdLUGFnZShRV0tDb250ZXh0KiBjb250ZXh0KQogICAgICAg ICBxdF93a19ydW5KYXZhU2NyaXB0QWxlcnQsCiAgICAgICAgIDAsICAvKiBydW5KYXZhU2NyaXB0 Q29uZmlybSAqLwogICAgICAgICAwLCAgLyogcnVuSmF2YVNjcmlwdFByb21wdCAqLwotICAgICAg ICAwLCAgLyogc2V0U3RhdHVzVGV4dCAqLworICAgICAgICBxdF93a19zZXRTdGF0dXNUZXh0LAog ICAgICAgICAwLCAgLyogbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQgKi8KICAgICAgICAgMCwgIC8q IG1pc3NpbmdQbHVnaW5CdXR0b25DbGlja2VkICovCiAgICAgICAgIDAsICAvKiBkaWROb3RIYW5k bGVLZXlFdmVudCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xd2twYWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaApp bmRleCAzM2RjYTAyLi41ZGNmYWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F3a3BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2UuaApAQCAtMTIyLDYgKzEyMiw3IEBAIHB1YmxpYzoKIAogcHVibGljOgogICAgIFFf U0lHTkFMIHZvaWQgc3RhdHVzQmFyTWVzc2FnZShjb25zdCBRU3RyaW5nJik7CisgICAgUV9TSUdO QUwgdm9pZCB0b29sVGlwQ2hhbmdlZChjb25zdCBRU3RyaW5nJik7CiAgICAgUV9TSUdOQUwgdm9p ZCB0aXRsZUNoYW5nZWQoY29uc3QgUVN0cmluZyYpOwogICAgIFFfU0lHTkFMIHZvaWQgbG9hZFN0 YXJ0ZWQoKTsKICAgICBRX1NJR05BTCB2b2lkIGxvYWRGaW5pc2hlZChib29sIG9rKTsK