58842 2011-04-18 15:30:16 -0700 Dropping a file in a WKView (WebKit2) doesn't load the file 2011-04-18 16:09:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica jeffm oldest_to_newest 388104 0 enrica 2011-04-18 15:30:16 -0700 Dragging a local .html into the current page doesn't show a "+" green circle nor does it allow dragging and dropping the site. This does work however when dragged and dropped to the toolbar. Repro steps: 1. Launch Safari on Windows 2. Drag and drop a local .html file into into current page. --Result: Local .html file is not displayed. Blue '+ Copy' displayed when hovering local .html file over current page instead of expected green '+'. --Note: Drag and drop of local .html files into bookmarks toolbar functions as expected. <rdar://problem/8514409> 388110 1 90104 enrica 2011-04-18 15:39:50 -0700 Created attachment 90104 Patch 388120 2 90104 jeffm 2011-04-18 15:49:49 -0700 Comment on attachment 90104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90104&action=review > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:447 > + RetainPtr<CFStringRef> pathAsCFString(AdoptCF, CFStringCreateWithCharacters(kCFAllocatorDefault, (const UniChar *)stringData.charactersWithNullTermination(), wcslen(stringData.charactersWithNullTermination()))); Can't you just do: RetainPtr<CFStringRef> pathAsCFString(AdoptCF, stringData.createCFString()); 388129 3 jeffm 2011-04-18 15:56:33 -0700 (In reply to comment #2) > (From update of attachment 90104 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90104&action=review > > > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:447 > > + RetainPtr<CFStringRef> pathAsCFString(AdoptCF, CFStringCreateWithCharacters(kCFAllocatorDefault, (const UniChar *)stringData.charactersWithNullTermination(), wcslen(stringData.charactersWithNullTermination()))); > > Can't you just do: RetainPtr<CFStringRef> pathAsCFString(AdoptCF, stringData.createCFString()); Ignore that comment, I see that the problem you're addressing is that there is an extra null at the end, and createCFString() is using String::length(), which would be wrong. 388130 4 90104 mjs 2011-04-18 15:57:02 -0700 Comment on attachment 90104 Patch r=me but please consider Jeff's suggestion when landing. 388139 5 enrica 2011-04-18 16:06:46 -0700 In his last comment, Jeff told me to ignore his previous comment. In fact what I'm removing is the use of String.length() to get rid of the extra 0 at the end. Thanks for the review. 388144 6 enrica 2011-04-18 16:09:44 -0700 http://trac.webkit.org/changeset/84203 90104 2011-04-18 15:39:50 -0700 2011-04-18 15:57:02 -0700 Patch urlwithextra0.txt text/plain 1787 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MTkxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTggIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBEcm9wcGluZyBhIGZpbGUgaW4gYSBXS1ZpZXcgKFdlYktpdDIp IGRvZXNuJ3QgbG9hZCB0aGUgZmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4ODQyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NTE0NDA5Pgor ICAgICAgICAKKyAgICAgICAgVGhlIFVSTCBzdHJpbmcgZm9yIHRoZSBmaWxlIGNvbnRhaW5zIGFu IGV4dHJhICUwMCBhdCB0aGUgZW5kCisgICAgICAgIHRoYXQgY2F1c2VzIHRoZSBuZXR3b3JrIGZy YW1ld29yayB0byBmYWlsIHRvIGxvYWQgdGhlIGZpbGUuCisgICAgICAgIAorICAgICAgICAqIHBs YXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0VVJMKToKKwogMjAxMS0wNC0xOCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwCShy ZXZpc2lvbiA4NDA0NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRV dGlsaXRpZXNXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDQsNyArNDQ0LDcgQEAgU3RyaW5n IGdldFVSTChjb25zdCBEcmFnRGF0YU1hcCogZGF0YSwgRAogCiAgICAgaWYgKHN0cmluZ0RhdGEu aXNFbXB0eSgpIHx8ICghUGF0aEZpbGVFeGlzdHMoc3RyaW5nRGF0YS5jaGFyYWN0ZXJzV2l0aE51 bGxUZXJtaW5hdGlvbigpKSAmJiAhUGF0aElzVU5DKHN0cmluZ0RhdGEuY2hhcmFjdGVyc1dpdGhO dWxsVGVybWluYXRpb24oKSkpKQogICAgICAgICByZXR1cm4gdXJsOwotICAgIFJldGFpblB0cjxD RlN0cmluZ1JlZj4gcGF0aEFzQ0ZTdHJpbmcoQWRvcHRDRiwgQ0ZTdHJpbmdDcmVhdGVXaXRoQ2hh cmFjdGVycyhrQ0ZBbGxvY2F0b3JEZWZhdWx0LCAoY29uc3QgVW5pQ2hhciAqKXN0cmluZ0RhdGEu Y2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSwgc3RyaW5nRGF0YS5sZW5ndGgoKSkpOwor ICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gcGF0aEFzQ0ZTdHJpbmcoQWRvcHRDRiwgQ0ZTdHJp bmdDcmVhdGVXaXRoQ2hhcmFjdGVycyhrQ0ZBbGxvY2F0b3JEZWZhdWx0LCAoY29uc3QgVW5pQ2hh ciAqKXN0cmluZ0RhdGEuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSwgd2NzbGVuKHN0 cmluZ0RhdGEuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSkpKTsKICAgICBpZiAodXJs RnJvbVBhdGgocGF0aEFzQ0ZTdHJpbmcuZ2V0KCksIHVybCkgJiYgdGl0bGUpCiAgICAgICAgICp0 aXRsZSA9IHVybDsKICNlbmRpZgo=