58821 2011-04-18 13:35:28 -0700 Don't cast BitmapImageSingleFrameSkia to BitmapImage 2011-08-03 10:15:35 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jbauman jbauman commit-queue kbr scroggo tomhudson webkit.review.bot zmo oldest_to_newest 388000 0 jbauman 2011-04-18 13:35:28 -0700 Don't cast BitmapImageSingleFrameSkia to BitmapImage 388008 1 90084 jbauman 2011-04-18 13:50:49 -0700 Created attachment 90084 Patch 388009 2 jbauman 2011-04-18 13:52:40 -0700 See http://code.google.com/p/chromium/issues/detail?id=79739 388012 3 webkit.review.bot 2011-04-18 13:55:35 -0700 Attachment 90084 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 388024 4 90090 jbauman 2011-04-18 14:01:34 -0700 Created attachment 90090 Patch 388092 5 90090 kbr 2011-04-18 15:18:15 -0700 Comment on attachment 90090 Patch How was the logic error discovered? Would it be possible to add a WebGL layout test to cover this case? 388101 6 jbauman 2011-04-18 15:27:11 -0700 Some of the webgl layout tests started crashing due to this bug, after an unrelated change to BitmapImageSingleFrameSkia caused the problem to become visible. I can't really think of a type of test that would deterministically catch this bug. 388111 7 90090 kbr 2011-04-18 15:40:43 -0700 Comment on attachment 90090 Patch OK. Let's get this fix in ASAP. 388196 8 90090 commit-queue 2011-04-18 18:35:31 -0700 Comment on attachment 90090 Patch Clearing flags on attachment: 90090 Committed r84213: <http://trac.webkit.org/changeset/84213> 388197 9 commit-queue 2011-04-18 18:35:36 -0700 All reviewed patches have been landed. Closing bug. 445927 10 tomhudson 2011-08-03 10:15:35 -0700 Similar problems cropping up in https://bugs.webkit.org/show_bug.cgi?id=65063 because the underlying issue - casting to BitmapImage - isn't limited to this one case. 90084 2011-04-18 13:50:49 -0700 2011-04-18 14:01:31 -0700 Patch bug-58821-20110418135048.patch text/plain 2761 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogODM4MDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMWVjYjNmMDJhNGZlOWE5 ZmJlZWU2ZDUyNTcyNzE5MmZkMjNmM2ZhLi41NjhkMTZhZTJmYzc2YTkwNGUyYjA0OWQwZDBmZWIw OTM5NzIwMGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMTggIEpvaG4g QmF1bWFuICA8amJhdW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgY2FzdCBCaXRtYXBJbWFnZVNpbmdsZUZyYW1l U2tpYSB0byBCaXRtYXBJbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg4MjEKKworCUJpdG1hcEltYWdlU2luZ2xlRnJhbWVTa2lhIGhhcyBpc0Jp dG1hcCByZXR1cm4gdHJ1ZSwgYnV0CisJY2FuJ3QgYmUgY2FzdCB0byBhIEJpdG1hcEltYWdlLiBJ bnN0ZWFkIG9mIHVzaW5nIEJpdG1hcEltYWdlLAorCXVzZSBpc09wYXF1ZSBmcm9tIFNrQml0bWFw IHRvIGRldGVybWluZSBpZiB0aGUgaW1hZ2UgaGFzIGFscGhhLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0 M0RTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbWFn ZURhdGEpOgorCiAyMDExLTA0LTEzICBDYXJ5IENsYXJrICA8Y2FyeWNsYXJrQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dDNEU2tpYS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dDNE U2tpYS5jcHAKaW5kZXggZDMyYTQwMjAzNDgzZjEyMzZjYWE3Njg4ZjAzOWYzZWU4ZThjMDBlZS4u MGZiNDRlNzdkMzkwYTUyOWE3OGMwMGVhOGFiMDhiMWRiMjMwNjg1NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNraWEu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3ND b250ZXh0M0RTa2lhLmNwcApAQCAtNTEsMTAgKzUxLDEwIEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0 M0Q6OmdldEltYWdlRGF0YShJbWFnZSogaW1hZ2UsCiAgICAgaWYgKCFpbWFnZSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIE93blB0cjxOYXRpdmVJbWFnZVNraWE+IHBpeGVsczsKLSAgICBO YXRpdmVJbWFnZVNraWEqIHNraWFJbWFnZSA9IDA7CisgICAgTmF0aXZlSW1hZ2VTa2lhKiBza2lh SW1hZ2UgPSBpbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKICAgICBBbHBoYU9w IG5lZWRlZEFscGhhT3AgPSBBbHBoYURvTm90aGluZzsKLSAgICBib29sIGhhc0FscGhhID0gaW1h Z2UtPmlzQml0bWFwSW1hZ2UoKSA/IHN0YXRpY19jYXN0PEJpdG1hcEltYWdlKj4oaW1hZ2UpLT5m cmFtZUhhc0FscGhhQXRJbmRleCgwKSA6IHRydWU7Ci0gICAgaWYgKChpZ25vcmVHYW1tYUFuZENv bG9yUHJvZmlsZSB8fCAoaGFzQWxwaGEgJiYgIXByZW11bHRpcGx5QWxwaGEpKSAmJiBpbWFnZS0+ ZGF0YSgpKSB7CisgICAgYm9vbCBoYXNBbHBoYSA9IHNraWFJbWFnZSA/ICFza2lhSW1hZ2UtPmlz T3BhcXVlKCkgOiB0cnVlOworICAgIGlmICgoIXNraWFJbWFnZSB8fCBpZ25vcmVHYW1tYUFuZENv bG9yUHJvZmlsZSB8fCAoaGFzQWxwaGEgJiYgIXByZW11bHRpcGx5QWxwaGEpKSAmJiBpbWFnZS0+ ZGF0YSgpKSB7CiAgICAgICAgIEltYWdlU291cmNlIGRlY29kZXIoSW1hZ2VTb3VyY2U6OkFscGhh Tm90UHJlbXVsdGlwbGllZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZ25vcmVHYW1t YUFuZENvbG9yUHJvZmlsZSA/IEltYWdlU291cmNlOjpHYW1tYUFuZENvbG9yUHJvZmlsZUlnbm9y ZWQgOiBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclByb2ZpbGVBcHBsaWVkKTsKICAgICAgICAg Ly8gQXR0ZW1wdCB0byBnZXQgcmF3IHVucHJlbXVsdGlwbGllZCBpbWFnZSBkYXRhIApAQCAtNzEs MTEgKzcxLDggQEAgYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKEltYWdlKiBp bWFnZSwKICAgICAgICAgc2tpYUltYWdlID0gcGl4ZWxzLmdldCgpOwogICAgICAgICBpZiAoaGFz QWxwaGEgJiYgcHJlbXVsdGlwbHlBbHBoYSkKICAgICAgICAgICAgIG5lZWRlZEFscGhhT3AgPSBB bHBoYURvUHJlbXVsdGlwbHk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgc2tpYUltYWdlID0gaW1h Z2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7Ci0gICAgICAgIGlmICghcHJlbXVsdGlw bHlBbHBoYSAmJiBoYXNBbHBoYSkKLSAgICAgICAgICAgIG5lZWRlZEFscGhhT3AgPSBBbHBoYURv VW5tdWx0aXBseTsKLSAgICB9CisgICAgfSBlbHNlIGlmICghcHJlbXVsdGlwbHlBbHBoYSAmJiBo YXNBbHBoYSkKKyAgICAgICAgbmVlZGVkQWxwaGFPcCA9IEFscGhhRG9Vbm11bHRpcGx5OwogICAg IGlmICghc2tpYUltYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgU2tCaXRtYXAmIHNr aWFJbWFnZVJlZiA9ICpza2lhSW1hZ2U7Cg== 90090 2011-04-18 14:01:34 -0700 2011-04-18 18:35:31 -0700 Patch bug-58821-20110418140133.patch text/plain 2782 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogODM4MDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMWVjYjNmMDJhNGZlOWE5 ZmJlZWU2ZDUyNTcyNzE5MmZkMjNmM2ZhLi5jNzYzYzQ2YzQyYTc3ZWY3YWE2OWU1YmNiYmM3ZWUy NDkzMDMxMDg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMTggIEpvaG4g QmF1bWFuICA8amJhdW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgY2FzdCBCaXRtYXBJbWFnZVNpbmdsZUZyYW1l U2tpYSB0byBCaXRtYXBJbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg4MjEKKworICAgICAgICBCaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tpYSBo YXMgaXNCaXRtYXAgcmV0dXJuIHRydWUsIGJ1dAorICAgICAgICBjYW4ndCBiZSBjYXN0IHRvIGEg Qml0bWFwSW1hZ2UuIEluc3RlYWQgb2YgdXNpbmcgQml0bWFwSW1hZ2UsCisgICAgICAgIHVzZSBp c09wYXF1ZSBmcm9tIFNrQml0bWFwIHRvIGRldGVybWluZSBpZiB0aGUgaW1hZ2UgaGFzIGFscGhh LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3NraWEvR3JhcGhpY3NDb250ZXh0M0RTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dDNEOjpnZXRJbWFnZURhdGEpOgorCiAyMDExLTA0LTEzICBDYXJ5IENsYXJrICA8 Y2FyeWNsYXJrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBo aWNzQ29udGV4dDNEU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0dyYXBoaWNzQ29udGV4dDNEU2tpYS5jcHAKaW5kZXggZDMyYTQwMjAzNDgzZjEyMzZjYWE3 Njg4ZjAzOWYzZWU4ZThjMDBlZS4uMGZiNDRlNzdkMzkwYTUyOWE3OGMwMGVhOGFiMDhiMWRiMjMw Njg1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9H cmFwaGljc0NvbnRleHQzRFNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0M0RTa2lhLmNwcApAQCAtNTEsMTAgKzUxLDEwIEBA IGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0YShJbWFnZSogaW1hZ2UsCiAgICAg aWYgKCFpbWFnZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIE93blB0cjxOYXRpdmVJbWFn ZVNraWE+IHBpeGVsczsKLSAgICBOYXRpdmVJbWFnZVNraWEqIHNraWFJbWFnZSA9IDA7CisgICAg TmF0aXZlSW1hZ2VTa2lhKiBza2lhSW1hZ2UgPSBpbWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50 RnJhbWUoKTsKICAgICBBbHBoYU9wIG5lZWRlZEFscGhhT3AgPSBBbHBoYURvTm90aGluZzsKLSAg ICBib29sIGhhc0FscGhhID0gaW1hZ2UtPmlzQml0bWFwSW1hZ2UoKSA/IHN0YXRpY19jYXN0PEJp dG1hcEltYWdlKj4oaW1hZ2UpLT5mcmFtZUhhc0FscGhhQXRJbmRleCgwKSA6IHRydWU7Ci0gICAg aWYgKChpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSB8fCAoaGFzQWxwaGEgJiYgIXByZW11bHRp cGx5QWxwaGEpKSAmJiBpbWFnZS0+ZGF0YSgpKSB7CisgICAgYm9vbCBoYXNBbHBoYSA9IHNraWFJ bWFnZSA/ICFza2lhSW1hZ2UtPmlzT3BhcXVlKCkgOiB0cnVlOworICAgIGlmICgoIXNraWFJbWFn ZSB8fCBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSB8fCAoaGFzQWxwaGEgJiYgIXByZW11bHRp cGx5QWxwaGEpKSAmJiBpbWFnZS0+ZGF0YSgpKSB7CiAgICAgICAgIEltYWdlU291cmNlIGRlY29k ZXIoSW1hZ2VTb3VyY2U6OkFscGhhTm90UHJlbXVsdGlwbGllZCwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpZ25vcmVHYW1tYUFuZENvbG9yUHJvZmlsZSA/IEltYWdlU291cmNlOjpHYW1t YUFuZENvbG9yUHJvZmlsZUlnbm9yZWQgOiBJbWFnZVNvdXJjZTo6R2FtbWFBbmRDb2xvclByb2Zp bGVBcHBsaWVkKTsKICAgICAgICAgLy8gQXR0ZW1wdCB0byBnZXQgcmF3IHVucHJlbXVsdGlwbGll ZCBpbWFnZSBkYXRhIApAQCAtNzEsMTEgKzcxLDggQEAgYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6 Z2V0SW1hZ2VEYXRhKEltYWdlKiBpbWFnZSwKICAgICAgICAgc2tpYUltYWdlID0gcGl4ZWxzLmdl dCgpOwogICAgICAgICBpZiAoaGFzQWxwaGEgJiYgcHJlbXVsdGlwbHlBbHBoYSkKICAgICAgICAg ICAgIG5lZWRlZEFscGhhT3AgPSBBbHBoYURvUHJlbXVsdGlwbHk7Ci0gICAgfSBlbHNlIHsKLSAg ICAgICAgc2tpYUltYWdlID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7Ci0g ICAgICAgIGlmICghcHJlbXVsdGlwbHlBbHBoYSAmJiBoYXNBbHBoYSkKLSAgICAgICAgICAgIG5l ZWRlZEFscGhhT3AgPSBBbHBoYURvVW5tdWx0aXBseTsKLSAgICB9CisgICAgfSBlbHNlIGlmICgh cHJlbXVsdGlwbHlBbHBoYSAmJiBoYXNBbHBoYSkKKyAgICAgICAgbmVlZGVkQWxwaGFPcCA9IEFs cGhhRG9Vbm11bHRpcGx5OwogICAgIGlmICghc2tpYUltYWdlKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgU2tCaXRtYXAmIHNraWFJbWFnZVJlZiA9ICpza2lhSW1hZ2U7Cg==