<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58801</bug_id>
          
          <creation_ts>2011-04-18 11:20:55 -0700</creation_ts>
          <short_desc>[WinCairo] &quot;build-webkit --wincairo&quot; thinks you need WebKitSupportLibraries.zip</short_desc>
          <delta_ts>2011-04-21 22:51:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>387882</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-18 11:20:55 -0700</bug_when>
    <thetext>If you run &quot;build-webkit --wincairo&quot;, you should be building a release that does not use any of the proprietary Apple libraries.  Unfortunately, the &quot;build-webkit&quot; script thinks that you need this zip file and will not continue without it.

This issue modifies the &quot;build-webkit&quot; script to ignore the missing zip file if you are building with &quot;--wincairo&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389842</commentid>
    <comment_count>1</comment_count>
      <attachid>90492</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-20 21:56:56 -0700</bug_when>
    <thetext>Created attachment 90492
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389846</commentid>
    <comment_count>2</comment_count>
      <attachid>90493</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-20 22:19:31 -0700</bug_when>
    <thetext>Created attachment 90493
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390083</commentid>
    <comment_count>3</comment_count>
      <attachid>90493</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-04-21 09:31:01 -0700</bug_when>
    <thetext>Comment on attachment 90493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90493&amp;action=review

&gt; Tools/Scripts/build-webkit:-514
&gt;  } elsif (isAppleWinWebKit()) {
&gt;      # Copy WebKitSupportLibrary to the correct location in WebKitLibraries so it can be found.
&gt;      # Will fail if WebKitSupportLibrary.zip is not in source root.
&gt; -    (system(&quot;perl Tools/Scripts/update-webkit-support-libs&quot;) == 0) or die;

It&apos;s odd that isAppleWinWebKit returns true for WinCairo. It probably shouldn&apos;t.

&gt; Tools/Scripts/update-webkit:101
&gt;  } elsif (isAppleWinWebKit()) {

Ditto. :)

&gt; Tools/Scripts/webkitdirs.pm:212
&gt; +        $configuration .= &quot;_Cairo_CFLite&quot; if (isWinCairo() &amp;&amp; isCygwin());

Perhaps you should move this out of the block. You never want to build the Release or Debug configurations if you&apos;ve specified the WinCairo flag. Why is isCygwin important here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390088</commentid>
    <comment_count>4</comment_count>
      <attachid>90493</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-21 09:38:35 -0700</bug_when>
    <thetext>Comment on attachment 90493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90493&amp;action=review

&gt;&gt; Tools/Scripts/build-webkit:-514
&gt;&gt; -    (system(&quot;perl Tools/Scripts/update-webkit-support-libs&quot;) == 0) or die;
&gt; 
&gt; It&apos;s odd that isAppleWinWebKit returns true for WinCairo. It probably shouldn&apos;t.

Yes, that&apos;s probably true.  WinCairo piggybacks off of the isAppleWinWebKit for most of its functionality.  Changing all of these places would expand the scope of this change considerably.

&gt;&gt; Tools/Scripts/update-webkit:101
&gt;&gt;  } elsif (isAppleWinWebKit()) {
&gt; 
&gt; Ditto. :)

Ditto! :-)

&gt;&gt; Tools/Scripts/webkitdirs.pm:212
&gt;&gt; +        $configuration .= &quot;_Cairo_CFLite&quot; if (isWinCairo() &amp;&amp; isCygwin());
&gt; 
&gt; Perhaps you should move this out of the block. You never want to build the Release or Debug configurations if you&apos;ve specified the WinCairo flag. Why is isCygwin important here?

That&apos;s a good point.  I was only thinking about the default case, which is where I ran into the problem.  I&apos;ll change that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390602</commentid>
    <comment_count>5</comment_count>
      <attachid>90668</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-21 21:50:12 -0700</bug_when>
    <thetext>Created attachment 90668
Revised per mrobinson&apos;s comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390618</commentid>
    <comment_count>6</comment_count>
      <attachid>90668</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-04-21 22:34:41 -0700</bug_when>
    <thetext>Comment on attachment 90668
Revised per mrobinson&apos;s comments

Great!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390622</commentid>
    <comment_count>7</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2011-04-21 22:51:26 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/84601</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90492</attachid>
            <date>2011-04-20 21:56:56 -0700</date>
            <delta_ts>2011-04-20 22:19:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58801-20110420215654.patch</filename>
            <type>text/plain</type>
            <size>2237</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0NDY2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTYgQEAKKzIwMTEtMDQtMjAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNo
IGJ1aWxkLXdlYmtpdCBhbmQgdXBkYXRlLXdlYmtpdCB0aGF0IHRoZSBXaW5DYWlybyBwb3J0IGRv
ZXMKKyAgICAgICAgbm90IG5lZWQgdGhlIG5vbi1yZWRpc3RyaWJ1dGFibGUgV2ViS2l0U3VwcG9y
dExpYnJhcmllcy56aXAgZmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTU4ODAxCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogRG9u
J3QgZGllIGlmIFdlYktpdFN1cHBvcnRMaWJyYXJpZXMuemlwCisgICAgICAgICAgZG9lc24ndCBl
eGlzdC4KKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQ6IERvbid0IGRpZSBpZiBXZWJL
aXRTdXBwb3J0TGlicmFyaWVzLnppcAorICAgICAgICAgIGRvZXNuJ3QgZXhpc3QuCisKIDIwMTEt
MDQtMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg
ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4NDQzMS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMv
YnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShy
ZXZpc2lvbiA4NDQ2NikKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CSh3b3JraW5nIGNv
cHkpCkBAIC01MTEsOSArNTExLDkgQEAgaWYgKGlzR3RrKCkpIHsKIH0gZWxzaWYgKGlzQXBwbGVX
aW5XZWJLaXQoKSkgewogICAgICMgQ29weSBXZWJLaXRTdXBwb3J0TGlicmFyeSB0byB0aGUgY29y
cmVjdCBsb2NhdGlvbiBpbiBXZWJLaXRMaWJyYXJpZXMgc28gaXQgY2FuIGJlIGZvdW5kLgogICAg
ICMgV2lsbCBmYWlsIGlmIFdlYktpdFN1cHBvcnRMaWJyYXJ5LnppcCBpcyBub3QgaW4gc291cmNl
IHJvb3QuCi0gICAgKHN5c3RlbSgicGVybCBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtc3Vw
cG9ydC1saWJzIikgPT0gMCkgb3IgZGllOwotICAgICMgVXBkYXRlIENhaXJvIERlcGVuZGFuY2ll
cy4KLSAgICBpZiAoaXNXaW5DYWlybygpKSB7CisgICAgaWYgKCFpc1dpbkNhaXJvKCkpIHsKKyAg
ICAgICAgKHN5c3RlbSgicGVybCBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtc3VwcG9ydC1s
aWJzIikgPT0gMCkgb3IgZGllOworICAgIH0gZWxzZSB7CiAgICAgICAgIChzeXN0ZW0oInBlcmwg
VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LXdpbmNhaXJvLWxpYnMiKSA9PSAwKSBvciBkaWU7
CiAgICAgfQogfSBlbHNpZiAoaXNRdCgpKSB7CkluZGV4OiBUb29scy9TY3JpcHRzL3VwZGF0ZS13
ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CShyZXZpc2lv
biA4NDQ2NikKKysrIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAkod29ya2luZyBjb3B5KQpA
QCAtOTksOCArOTksOSBAQCBpZiAoLWQgIi4uL0ludGVybmFsIikgewogCiAgICAgc3lzdGVtKCJw
ZXJsIiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSIpID09IDAgb3IgZGll
ICQhOwogfSBlbHNpZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7Ci0gICAgc3lzdGVtKCJwZXJsIiwg
IlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGlicyIpID09IDAgb3IgZGll
OwotICAgIGlmIChpc1dpbkNhaXJvKCkpIHsKKyAgICBpZiAoIWlzV2luQ2Fpcm8oKSkgeworICAg
ICAgICBzeXN0ZW0oInBlcmwiLCAiVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWF1eGlsaWFy
eS1saWJzIikgPT0gMCBvciBkaWU7CisgICAgfSBlbHNlIHsKICAgICAgICAgc3lzdGVtKCJwZXJs
IiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWlyby1saWJzIikgPT0gMCBvciBk
aWU7CiAgICAgfQogfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90493</attachid>
            <date>2011-04-20 22:19:31 -0700</date>
            <delta_ts>2011-04-21 21:50:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58801-20110420221929.patch</filename>
            <type>text/plain</type>
            <size>2980</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0NDY2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMjEgQEAKKzIwMTEtMDQtMjAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNo
IGJ1aWxkLXdlYmtpdCBhbmQgdXBkYXRlLXdlYmtpdCB0aGF0IHRoZSBXaW5DYWlybyBwb3J0IGRv
ZXMKKyAgICAgICAgbm90IG5lZWQgdGhlIG5vbi1yZWRpc3RyaWJ1dGFibGUgV2ViS2l0U3VwcG9y
dExpYnJhcmllcy56aXAgZmlsZS4KKyAgICAgICAgQWxzbyBhcHBlbmQgdGhlIF9DYWlyb19DRkxp
dGUgbGFiZWwgdG8gdGhlIGJ1aWxkIHRhcmdldCBmb3IgdGhlCisgICAgICAgIGRlZmF1bHQgKG5v
IGFyZ3VtZW50KSBjYXNlIHdoZW4gYnVpbGRpbmcgd2l0aCAnLS13aW5jYWlybycKKyAgICAKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4ODAxCisKKyAg
ICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogRG9uJ3QgZGllIGlmIFdlYktpdFN1cHBvcnRM
aWJyYXJpZXMuemlwCisgICAgICAgICAgZG9lc24ndCBleGlzdC4KKyAgICAgICAgKiBTY3JpcHRz
L3dlYmtpdGRpcnMucG06IEFwcGVuZCAnX0NhaXJvX0NGTGl0ZScgdG8gdGhlIGRlZmF1bHQKKyAg
ICAgICAgICAnUmVsZWFzZScgYnVpbGQgdGFyZ2V0IHdoZW4gcGFzc2VkIHRoZSAnLS13aW5jYWly
bycgZmxhZy4KKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQ6IERvbid0IGRpZSBpZiBX
ZWJLaXRTdXBwb3J0TGlicmFyaWVzLnppcAorICAgICAgICAgIGRvZXNuJ3QgZXhpc3QuCisKIDIw
MTEtMDQtMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg
ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4NDQzMS4KSW5kZXg6IFRvb2xzL1Njcmlw
dHMvYnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0
CShyZXZpc2lvbiA4NDQ2NikKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CSh3b3JraW5n
IGNvcHkpCkBAIC01MTEsOSArNTExLDkgQEAgaWYgKGlzR3RrKCkpIHsKIH0gZWxzaWYgKGlzQXBw
bGVXaW5XZWJLaXQoKSkgewogICAgICMgQ29weSBXZWJLaXRTdXBwb3J0TGlicmFyeSB0byB0aGUg
Y29ycmVjdCBsb2NhdGlvbiBpbiBXZWJLaXRMaWJyYXJpZXMgc28gaXQgY2FuIGJlIGZvdW5kLgog
ICAgICMgV2lsbCBmYWlsIGlmIFdlYktpdFN1cHBvcnRMaWJyYXJ5LnppcCBpcyBub3QgaW4gc291
cmNlIHJvb3QuCi0gICAgKHN5c3RlbSgicGVybCBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQt
c3VwcG9ydC1saWJzIikgPT0gMCkgb3IgZGllOwotICAgICMgVXBkYXRlIENhaXJvIERlcGVuZGFu
Y2llcy4KLSAgICBpZiAoaXNXaW5DYWlybygpKSB7CisgICAgaWYgKCFpc1dpbkNhaXJvKCkpIHsK
KyAgICAgICAgKHN5c3RlbSgicGVybCBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtc3VwcG9y
dC1saWJzIikgPT0gMCkgb3IgZGllOworICAgIH0gZWxzZSB7CiAgICAgICAgIChzeXN0ZW0oInBl
cmwgVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LXdpbmNhaXJvLWxpYnMiKSA9PSAwKSBvciBk
aWU7CiAgICAgfQogfSBlbHNpZiAoaXNRdCgpKSB7CkluZGV4OiBUb29scy9TY3JpcHRzL3VwZGF0
ZS13ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CShyZXZp
c2lvbiA4NDQ2NikKKysrIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAkod29ya2luZyBjb3B5
KQpAQCAtOTksOCArOTksOSBAQCBpZiAoLWQgIi4uL0ludGVybmFsIikgewogCiAgICAgc3lzdGVt
KCJwZXJsIiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSIpID09IDAgb3Ig
ZGllICQhOwogfSBlbHNpZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7Ci0gICAgc3lzdGVtKCJwZXJs
IiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1hdXhpbGlhcnktbGlicyIpID09IDAgb3Ig
ZGllOwotICAgIGlmIChpc1dpbkNhaXJvKCkpIHsKKyAgICBpZiAoIWlzV2luQ2Fpcm8oKSkgewor
ICAgICAgICBzeXN0ZW0oInBlcmwiLCAiVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWF1eGls
aWFyeS1saWJzIikgPT0gMCBvciBkaWU7CisgICAgfSBlbHNlIHsKICAgICAgICAgc3lzdGVtKCJw
ZXJsIiwgIlRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWlyby1saWJzIikgPT0gMCBv
ciBkaWU7CiAgICAgfQogfQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gODQ0NjYpCisr
KyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTIwOSw2ICsy
MDksNyBAQCBzdWIgZGV0ZXJtaW5lQ29uZmlndXJhdGlvbgogICAgICAgICAkY29uZmlndXJhdGlv
biA9ICJEZWJ1ZyIgaWYgJGNvbmZpZ3VyYXRpb24gZXEgIkRldmVsb3BtZW50IjsKICAgICB9IGVs
c2UgewogICAgICAgICAkY29uZmlndXJhdGlvbiA9ICJSZWxlYXNlIjsKKyAgICAgICAgJGNvbmZp
Z3VyYXRpb24gLj0gIl9DYWlyb19DRkxpdGUiIGlmIChpc1dpbkNhaXJvKCkgJiYgaXNDeWd3aW4o
KSk7CiAgICAgfQogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90668</attachid>
            <date>2011-04-21 21:50:12 -0700</date>
            <delta_ts>2011-04-21 22:34:40 -0700</delta_ts>
            <desc>Revised per mrobinson&apos;s comments</desc>
            <filename>build_cairo.patch</filename>
            <type>text/plain</type>
            <size>3063</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDg0NTk4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMjEgQEAKKzIwMTEtMDQtMjEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNo
IGJ1aWxkLXdlYmtpdCBhbmQgdXBkYXRlLXdlYmtpdCB0aGF0IHRoZSBXaW5DYWlybyBwb3J0IGRv
ZXMKKyAgICAgICAgbm90IG5lZWQgdGhlIG5vbi1yZWRpc3RyaWJ1dGFibGUgV2ViS2l0U3VwcG9y
dExpYnJhcmllcy56aXAgZmlsZS4KKyAgICAgICAgQWxzbyBhcHBlbmQgdGhlIF9DYWlyb19DRkxp
dGUgbGFiZWwgdG8gdGhlIGJ1aWxkIHRhcmdldCBmb3IgdGhlCisgICAgICAgIGRlZmF1bHQgKG5v
IGFyZ3VtZW50KSBjYXNlIHdoZW4gYnVpbGRpbmcgd2l0aCAnLS13aW5jYWlybycKKyAgICAKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4ODAxCisKKyAg
ICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogRG9uJ3QgZGllIGlmIFdlYktpdFN1cHBvcnRM
aWJyYXJpZXMuemlwCisgICAgICAgICAgZG9lc24ndCBleGlzdC4KKyAgICAgICAgKiBTY3JpcHRz
L3dlYmtpdGRpcnMucG06IEFwcGVuZCAnX0NhaXJvX0NGTGl0ZScgdG8gdGhlIGRlZmF1bHQKKyAg
ICAgICAgICAnUmVsZWFzZScgYnVpbGQgdGFyZ2V0IHdoZW4gcGFzc2VkIHRoZSAnLS13aW5jYWly
bycgZmxhZy4KKyAgICAgICAgKiBTY3JpcHRzL3VwZGF0ZS13ZWJraXQ6IERvbid0IGRpZSBpZiBX
ZWJLaXRTdXBwb3J0TGlicmFyaWVzLnppcAorICAgICAgICAgIGRvZXNuJ3QgZXhpc3QuCisKIDIw
MTEtMDQtMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtp
dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2aXNpb24gODQ1
OTgpCisrKyBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkod29ya2luZyBjb3B5KQpAQCAtNTEy
LDE0ICs1MTIsMTIgQEAgaWYgKGlzR3RrKCkpIHsKICAgICAgICAgcHJpbnQgIlVwZGF0aW5nICRo
ZWFkZXJEaXJcbiI7CiAgICAgICAgIHN5c3RlbSAiZGl0dG8iLCAkc3JjSGVhZGVyRGlyLCAkaGVh
ZGVyRGlyOwogICAgIH0KK30gZWxzaWYgKGlzV2luQ2Fpcm8oKSkgeworICAgIChzeXN0ZW0oInBl
cmwgVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LXdpbmNhaXJvLWxpYnMiKSA9PSAwKSBvciBk
aWU7CiB9IGVsc2lmIChpc0FwcGxlV2luV2ViS2l0KCkpIHsKICAgICAjIENvcHkgV2ViS2l0U3Vw
cG9ydExpYnJhcnkgdG8gdGhlIGNvcnJlY3QgbG9jYXRpb24gaW4gV2ViS2l0TGlicmFyaWVzIHNv
IGl0IGNhbiBiZSBmb3VuZC4KICAgICAjIFdpbGwgZmFpbCBpZiBXZWJLaXRTdXBwb3J0TGlicmFy
eS56aXAgaXMgbm90IGluIHNvdXJjZSByb290LgogICAgIChzeXN0ZW0oInBlcmwgVG9vbHMvU2Ny
aXB0cy91cGRhdGUtd2Via2l0LXN1cHBvcnQtbGlicyIpID09IDApIG9yIGRpZTsKLSAgICAjIFVw
ZGF0ZSBDYWlybyBEZXBlbmRhbmNpZXMuCi0gICAgaWYgKGlzV2luQ2Fpcm8oKSkgewotICAgICAg
ICAoc3lzdGVtKCJwZXJsIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWlyby1saWJz
IikgPT0gMCkgb3IgZGllOwotICAgIH0KIH0gZWxzaWYgKGlzUXQoKSkgewogICAgIHB1c2ggQG9w
dGlvbnMsICItLWluc3RhbGwtaGVhZGVycz0iIC4gJGluc3RhbGxIZWFkZXJzIGlmIGRlZmluZWQo
JGluc3RhbGxIZWFkZXJzKTsKICAgICBwdXNoIEBvcHRpb25zLCAiLS1pbnN0YWxsLWxpYnM9IiAu
ICRpbnN0YWxsTGlicyBpZiBkZWZpbmVkKCRpbnN0YWxsTGlicyk7CkluZGV4OiBUb29scy9TY3Jp
cHRzL3VwZGF0ZS13ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Vi
a2l0CShyZXZpc2lvbiA4NDU5OCkKKysrIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAkod29y
a2luZyBjb3B5KQpAQCAtMTAxLDYgKzEwMSw3IEBAIGlmICgtZCAiLi4vSW50ZXJuYWwiKSB7CiB9
IGVsc2lmIChpc0FwcGxlV2luV2ViS2l0KCkpIHsKICAgICBzeXN0ZW0oInBlcmwiLCAiVG9vbHMv
U2NyaXB0cy91cGRhdGUtd2Via2l0LWF1eGlsaWFyeS1saWJzIikgPT0gMCBvciBkaWU7CiAgICAg
aWYgKGlzV2luQ2Fpcm8oKSkgeworICAgICAgICAjIFdpbkNhaXJvIHNoYXJlcyB0aGUgYXV4aWxp
YXJ5IGxpYnMgZnJvbSB0aGUgQXBwbGUgcG9ydC4KICAgICAgICAgc3lzdGVtKCJwZXJsIiwgIlRv
b2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWlyby1saWJzIikgPT0gMCBvciBkaWU7CiAg
ICAgfQogfQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gODQ1OTgpCisrKyBUb29scy9T
Y3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTIxMCw2ICsyMTAsMTAgQEAg
c3ViIGRldGVybWluZUNvbmZpZ3VyYXRpb24KICAgICB9IGVsc2UgewogICAgICAgICAkY29uZmln
dXJhdGlvbiA9ICJSZWxlYXNlIjsKICAgICB9CisKKyAgICBpZiAoJGNvbmZpZ3VyYXRpb24gJiYg
aXNXaW5DYWlybygpKSB7CisgICAgICAgICRjb25maWd1cmF0aW9uIC49ICJfQ2Fpcm9fQ0ZMaXRl
IjsKKyAgICB9CiB9CiAKIHN1YiBkZXRlcm1pbmVBcmNoaXRlY3R1cmUK
</data>
<flag name="review"
          id="83426"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>