58791 2011-04-18 09:05:52 -0700 REGRESSION: [Chromium Win] details-add-summary-1.html start crashing after r84039 2011-04-18 12:20:55 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 morrita morrita abarth dglazkov eric jknotten webkit.review.bot oldest_to_newest 387761 0 morrita 2011-04-18 09:05:52 -0700 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fhtml%2Fdetails-add-summary-1.html&showExpectations=true&group=%40ToT%20-%20chromium.org 387793 1 90044 morrita 2011-04-18 09:29:29 -0700 Created attachment 90044 Patch 387794 2 jknotten 2011-04-18 09:32:59 -0700 LGTM 387801 3 90044 eric 2011-04-18 09:39:02 -0700 Comment on attachment 90044 Patch I take it the chromium is the only port with <details> enabled? 387809 4 morrita 2011-04-18 09:46:47 -0700 > (From update of attachment 90044 [details]) > I take it the chromium is the only port with <details> enabled? No, there is no ifdefs for <details>. But the crash is reproduced only there. 387810 5 morrita 2011-04-18 09:47:40 -0700 Anyway, thank you for reviewing Eric! I'm landing this. 387811 6 morrita 2011-04-18 09:49:11 -0700 Committed r84152: <http://trac.webkit.org/changeset/84152> 387929 7 webkit.review.bot 2011-04-18 12:20:55 -0700 http://trac.webkit.org/changeset/84152 might have broken GTK Linux 32-bit Debug 90044 2011-04-18 09:29:29 -0700 2011-04-18 09:39:02 -0700 Patch bug-58791-20110418092928.patch text/plain 1452 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODQxNDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNzkzY2FlY2I5YzQ2YTFm NWYxNTBjNmZlYjZhNjlmY2MzNjE0ZDYzLi5jZTUwMWEyMTdjMDhkMTNkMzJmMjM1MTcyZDdhYmYw OWY0Njc5NDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTggIE1PUklU QSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogW0Nocm9taXVtIFdpbl0gZGV0YWls cy1hZGQtc3VtbWFyeS0xLmh0bWwgc3RhcnQgY3Jhc2hpbmcgYWZ0ZXIgcjg0MDM5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODc5MQorICAgICAgICAK KyAgICAgICAgT24gcmVmcmVzaE1haW5TdW1tYXJ5KCksIGZpbmRNYWluU3VtbWFyeSgpIHBvc3Np Ymx5IHJlbGVhc2VzIG9sZFN1bW1hcnkuCisgICAgICAgIFdlIHNob3VsZCBndWFyZCBpdCBhZ2Fp biBSZWZQdHIuCisKKyAgICAgICAgKiBodG1sL0hUTUxEZXRhaWxzRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRGV0YWlsc0VsZW1lbnQ6OnJlZnJlc2hNYWluU3VtbWFyeSk6CisK IDIwMTEtMDQtMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEZXRhaWxzRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxEZXRhaWxzRWxlbWVudC5jcHAKaW5kZXggYzk4YjY2ZTEyMzY0OWE2MDBjMDFhM2M4ZWQ5MTUz NjBhZGIyOGZmYi4uYjQxZjVkZGMxNjUxMjJiODRlN2ZjMDM5NDI0NDNiNzc5NjZhY2U1OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGV0YWlsc0VsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERldGFpbHNFbGVtZW50LmNwcApAQCAtNzYsNyArNzYs NyBAQCBOb2RlKiBIVE1MRGV0YWlsc0VsZW1lbnQ6OmZpbmRNYWluU3VtbWFyeSgpCiAKIHZvaWQg SFRNTERldGFpbHNFbGVtZW50OjpyZWZyZXNoTWFpblN1bW1hcnkoUmVmcmVzaFJlbmRlcmVyIHJl ZnJlc2hSZW5kZXJlcikKIHsKLSAgICBOb2RlKiBvbGRTdW1tYXJ5ID0gbV9tYWluU3VtbWFyeTsK KyAgICBSZWZQdHI8Tm9kZT4gb2xkU3VtbWFyeSA9IG1fbWFpblN1bW1hcnk7CiAgICAgbV9tYWlu U3VtbWFyeSA9IGZpbmRNYWluU3VtbWFyeSgpOwogCiAgICAgaWYgKG9sZFN1bW1hcnkgPT0gbV9t YWluU3VtbWFyeSB8fCAhYXR0YWNoZWQoKSkK