5879 2005-11-29 13:23:04 -0800 REGRESSION: Buttons go into pushed state when moused over when text field has focus 2005-11-29 17:50:21 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED http://www.unsanity.org/archives/000439.php P1 Normal --- 1 webkit-bugs hyatt mitz oldest_to_newest 24885 0 webkit-bugs 2005-11-29 13:23:04 -0800 Go to http://www.unsanity.org/archives/000439.php and click inside the comments text field. While the view has keyboard focus, mouse over the preview or post buttons. They will go into the pushed state. This is not 100% reproducible which makes it even more annoying. 24886 1 4854 webkit-bugs 2005-11-29 13:23:57 -0800 Created attachment 4854 testcase: click in the textview 24887 2 mitz 2005-11-29 13:30:01 -0800 Confirmed on TOT. Due to randomness of the phenomenon, I couldn't reproduce it with the attached testcase, but I'm actually seeing it right now as I'm typing in the comments text area if I move the mouse over the Commit button. This regression is as old as the customizable buttons, IIRC. 24893 3 mitz 2005-11-29 15:29:56 -0800 I don't know this code, but from looking around with gdb, the problem might be that the KHTMLView's d- >mousePressed stays at true after you click in an AppKit widget such as a text area. If a few other parameters are lined up, an :active chain gets frozen, consisting of a bunch of objects, which may include buttons and also normal text links. Those objects will change to/from their :active state as the mouse passes over them, like what happens when you mousedown in an object and start dragging around. 24895 4 mitz 2005-11-29 15:44:30 -0800 More likely, the fact that (d->mousePressed == true) throughout is normal, and the problem is those stray objects which thing that think that they are in the active chain. I don't see NodeImpl's m_hovered being initialized to false, and that's a bad sign. 24896 5 mitz 2005-11-29 15:45:25 -0800 s/m_hovered/m_inActiveChain/ Sorry for the spam. 25161 6 4856 mitz 2005-11-29 16:13:01 -0800 Created attachment 4856 Initialize m_inActiveChain to false Should have noticed this when bug 4221 was fixed :-) 25162 7 4856 eric 2005-11-29 16:23:26 -0800 Comment on attachment 4856 Initialize m_inActiveChain to false I've seen this happen too. It would be even better if we could have a dom test to prevent this from regressing again. 25170 8 darin 2005-11-29 17:50:21 -0800 I can't believe this! Beth and I spotted this uninitialized variable *today* while fixing another bug. 4854 2005-11-29 13:23:57 -0800 2005-11-29 13:25:32 -0800 testcase: click in the textview focustest.html text/html 334 webkit-bugs PGh0bWw+PGhlYWQ+PHRpdGxlPkZvY3VzIFZpZXcgVGVzdDwvdGl0bGU+PC9oZWFkPjxib2R5Pjxm b3JtPjx0ZXh0YXJlYSB0YWJpbmRleD0iNCIgaWQ9InRleHQiIG5hbWU9InRleHQiIHJvd3M9IjEw IiBjb2xzPSI1MCI+PC90ZXh0YXJlYT4KPGlucHV0IHR5cGU9InN1Ym1pdCIgbmFtZT0icHJldmll dyIgdGFiaW5kZXg9IjUiIAogICAgdmFsdWU9IlByZXZpZXciIC8+CjxpbnB1dCBzdHlsZT0iZm9u dC13ZWlnaHQ6IGJvbGQ7IiB0eXBlPSJzdWJtaXQiIG5hbWU9InBvc3QiIAogICAgdGFiaW5kZXg9 IjYiIHZhbHVlPSJQb3N0IiAvPgo8L2Rpdj4KPC9mb3JtPgo8L2JvZHk+PC9odG1sPg== 4856 2005-11-29 16:13:01 -0800 2005-11-29 16:23:26 -0800 Initialize m_inActiveChain to false 5879_r1.patch text/plain 1398 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJDb3JlL0NoYW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40MzEKZGlmZiAtcCAtdSAt cjEuNDMxIFdlYkNvcmUvQ2hhbmdlTG9nCi0tLSBXZWJDb3JlL0NoYW5nZUxvZwkyOSBOb3YgMjAw NSAyMjoxNDowNSAtMDAwMAkxLjQzMQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJMzAgTm92IDIwMDUg MDA6MTM6MDkgLTAwMDAKQEAgLTEsMyArMSwxMyBAQAorMjAwNS0xMS0zMCAgTWl0eiBQZXR0ZWwg IDxvcGVuZGFyd2luLm9yZ0BtaXR6cGV0dGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeGVkIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFy d2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg3OQorICAgICAgICAgIFJFR1JFU1NJT046IEJ1dHRv bnMgZ28gaW50byBwdXNoZWQgc3RhdGUgd2hlbiBtb3VzZWQgb3ZlciB3aGVuIHRleHQgZmllbGQg aGFzIGZvY3VzCisKKyAgICAgICAgKiBraHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcDoKKyAgICAg ICAgKERPTTo6Tm9kZUltcGw6Ok5vZGVJbXBsKTogSW5pdGlhbGl6ZSBtX2luQWN0aXZlQ2hhaW4g dG8gZmFsc2UuCisKIDIwMDUtMTEtMjkgIERhdmlkIEhhcnJpc29uICA8aGFycmlzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBXZWJDb3Jl L2todG1sL3htbC9kb21fbm9kZWltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9v dC9XZWJDb3JlL2todG1sL3htbC9kb21fbm9kZWltcGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjIxNgpkaWZmIC1wIC11IC1yMS4yMTYgV2ViQ29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBs LmNwcAotLS0gV2ViQ29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcAkyNiBOb3YgMjAwNSAy MjozNTo0NCAtMDAwMAkxLjIxNgorKysgV2ViQ29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmNw cAkzMCBOb3YgMjAwNSAwMDoxMzoyMiAtMDAwMApAQCAtMTI4LDYgKzEyOCw3IEBAIE5vZGVJbXBs OjpOb2RlSW1wbChEb2N1bWVudEltcGwgKmRvYykKICAgICAgIG1fZm9jdXNlZCggZmFsc2UgKSwK ICAgICAgIG1fYWN0aXZlKCBmYWxzZSApLAogICAgICAgbV9ob3ZlcmVkKGZhbHNlKSwKKyAgICAg IG1faW5BY3RpdmVDaGFpbihmYWxzZSksCiAgICAgICBtX3N0eWxlRWxlbWVudCggZmFsc2UgKSwK ICAgICAgIG1faW1wbGljaXQoIGZhbHNlICkKIHsK