58784 2011-04-18 07:25:16 -0700 [Chromium] Enable QUOTA API at runtime if enable-quota flag is given 2011-05-06 01:28:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 60355 1 kinuko webkit-unassigned abarth eric fishd levin webkit.review.bot oldest_to_newest 387697 0 kinuko 2011-04-18 07:25:16 -0700 Enable QUOTA API (added in http://trac.webkit.org/changeset/84053) at runtime if enable-quota flag is given. For now the feature is enabled only if the quota compile-time flag is given. 387702 1 90031 kinuko 2011-04-18 07:30:35 -0700 Created attachment 90031 Patch 387788 2 90031 levin 2011-04-18 09:24:26 -0700 Comment on attachment 90031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review Please wait for Darin's ok since you did a chromium public api change. > Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:323 > +void WebRuntimeFeatures::enableQuota(bool enable) I suspect you'll trigger a warning and thus a compile error due to unused enable when QUOTA isn't enabled. 388429 3 kinuko 2011-04-19 05:38:36 -0700 Committed r84247: <http://trac.webkit.org/changeset/84247> 388433 4 webkit.review.bot 2011-04-19 05:52:06 -0700 http://trac.webkit.org/changeset/84247 might have broken Chromium Win Release 388454 5 levin 2011-04-19 06:29:29 -0700 (In reply to comment #2) > (From update of attachment 90031 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review > > Please wait for Darin's ok since you did a chromium public api change. I didn't see Darin's ok in here. > > > Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:323 > > +void WebRuntimeFeatures::enableQuota(bool enable) > > I suspect you'll trigger a warning and thus a compile error due to unused enable when QUOTA isn't enabled. It doesn't look like this was handled. 388464 6 kinuko 2011-04-19 06:41:59 -0700 (In reply to comment #5) > (In reply to comment #2) > > (From update of attachment 90031 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review > > > > Please wait for Darin's ok since you did a chromium public api change. > > I didn't see Darin's ok in here. Oops, sorry I overlooked the commend... ok I will revert the change. > > > Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:323 > > > +void WebRuntimeFeatures::enableQuota(bool enable) > > > > I suspect you'll trigger a warning and thus a compile error due to unused enable when QUOTA isn't enabled. > > It doesn't look like this was handled. Sorry I didn't reply. I thought it would be ok (and seems to be ok) as the file have a lot of similar lines (i.e.g void WebRuntimeFeatures::enableXxx(bool enable) with #if ENABLE(XXX) in body). 388470 7 levin 2011-04-19 06:44:23 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > (From update of attachment 90031 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review > > > > > > Please wait for Darin's ok since you did a chromium public api change. > > > > I didn't see Darin's ok in here. > > Oops, sorry I overlooked the commend... ok I will revert the change. At this point, I wouldn't revert. Just get an ok from Darin or do any changes that he suggests. > I thought it would be ok as the file have a lot of similar lines . Ah. Thanks! 388481 8 kinuko 2011-04-19 06:50:23 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #2) > > > > (From update of attachment 90031 [details] [details] [details] [details]) > > > > View in context: https://bugs.webkit.org/attachment.cgi?id=90031&action=review > > > > > > > > Please wait for Darin's ok since you did a chromium public api change. > > > > > > I didn't see Darin's ok in here. > > > > Oops, sorry I overlooked the commend... ok I will revert the change. > > At this point, I wouldn't revert. Just get an ok from Darin or do any changes that he suggests. Ok, will do. Darin, please let me know if anything need to be changed/reverted. Thanks! > > I thought it would be ok as the file have a lot of similar lines . > Ah. Thanks! 388573 9 90031 fishd 2011-04-19 10:16:25 -0700 Comment on attachment 90031 Patch API changes LGTM 90031 2011-04-18 07:30:35 -0700 2011-04-19 10:16:24 -0700 Patch bug-58784-20110418233033.patch text/plain 5722 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOTIzNmM3N2UwMjFhM2Jl YWQ1NWQxZDI3MDVkZjAwYjk4MTRkYTcwLi41ZTJmMTAxZmI2NDljMmRmZjU0NzU0OTJjMzM5YjJk NDQzNTQxZGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTggIEtpbnVr byBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIFFVT1RBIEFQSSBhdCBy dW50aW1lIGlmIGVuYWJsZS1xdW90YSBmbGFnIGlzIGdpdmVuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODc4NAorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBhcyB0aGlzIGRvZXMgbm90IGNoYW5nZSBhbnkgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAq IGJpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHA6CisgICAgICAgICog YmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisgICAgICAgIChXZWJD b3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpxdW90YUVuYWJsZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0UXVvdGFFbmFibGVkKToKKyAgICAgICAg KiBwYWdlL0RPTVdpbmRvdy5pZGw6CisKIDIwMTEtMDQtMTcgIERhbiBCZXJuc3RlaW4gIDxtaXR6 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRG ZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFi bGVkRmVhdHVyZXMuY3BwCmluZGV4IGU5NTkxZmRmMzYxYzQ3YmQyYWYzZDFlMTJlZWZkZDg2MzBh OTcxZDguLmRkNDcxODRhYjVmMWZlMmZlOWYxYTM0ZTdhYTQxMDYxZjExYWQ0MTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJl cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxl ZEZlYXR1cmVzLmNwcApAQCAtMTQyLDQgKzE0Miw4IEBAIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6b3BlbkRhdGFiYXNlU3luY0VuYWJsZWQoKQogfQogI2VuZGlmCiAKKyNpZiBFTkFCTEUo UVVPVEEpCitib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzUXVvdGFFbmFibGVkID0gZmFs c2U7CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmggYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAppbmRl eCAxMDA0ZWE0YTdhOGE4ZDQyNzVlZmVkODIwNTFmMmY0MTRjMDliNTdkLi4zNDMyZDc0NGYyYmZm ODk1Y2M0MTExMmJkMzczNWUwMzBkYzZiZTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaApAQCAtMTUwLDYg KzE1MCwxMSBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgd2Via2l0R2V0VXNlck1lZGlhRW5h YmxlZCgpIHsgcmV0dXJuIGlzTWVkaWFTdHJlYW1FbmFibGVkOyB9CiAjZW5kaWYKIAorI2lmIEVO QUJMRShRVU9UQSkKKyAgICBzdGF0aWMgYm9vbCBxdW90YUVuYWJsZWQoKSB7IHJldHVybiBpc1F1 b3RhRW5hYmxlZDsgfQorICAgIHN0YXRpYyB2b2lkIHNldFF1b3RhRW5hYmxlZChib29sIGlzRW5h YmxlZCkgeyBpc1F1b3RhRW5hYmxlZCA9IGlzRW5hYmxlZDsgfQorI2VuZGlmCisKIHByaXZhdGU6 CiAgICAgLy8gTmV2ZXIgaW5zdGFudGlhdGUuCiAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlcygp IHsgfQpAQCAtMTgyLDYgKzE4NywxMCBAQCBwcml2YXRlOgogI2lmIEVOQUJMRShNRURJQV9TVFJF QU0pCiAgICAgc3RhdGljIGJvb2wgaXNNZWRpYVN0cmVhbUVuYWJsZWQ7CiAjZW5kaWYKKworI2lm IEVOQUJMRShRVU9UQSkKKyAgICBzdGF0aWMgYm9vbCBpc1F1b3RhRW5hYmxlZDsKKyNlbmRpZgog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9ET01XaW5kb3cuaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCmlu ZGV4IDRiMmQyYzQ3NTRiMGFiOTA5ZThjZDJkMDMyNzQ4OThjODM3YTI1OTcuLmYyN2ZlNTM5MzJj Yzc4YmZiYzE1YTVkOWI1YTU0OWY1MWUzMzgwYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5p ZGwKQEAgLTc4Niw3ICs3ODYsOSBAQCBtb2R1bGUgd2luZG93IHsKIAogICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPUJMT0JdIERPTVVSTCB3ZWJraXRVUkw7CiAKLSAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDb25kaXRpb25hbD1RVU9UQV0gU3RvcmFnZUluZm8gd2Vi a2l0U3RvcmFnZUluZm87CisjaWYgZGVmaW5lZChFTkFCTEVfUVVPVEEpICYmIEVOQUJMRV9RVU9U QQorICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0VuYWJsZWRBdFJ1bnRpbWU9UXVvdGFdIFN0 b3JhZ2VJbmZvIHdlYmtpdFN0b3JhZ2VJbmZvOworI2VuZGlmCiAKICNlbmRpZiAvLyBkZWZpbmVk KExBTkdVQUdFX0pBVkFTQ1JJUFQpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMmUy MzNkMGY2MTY2YmI0YjhhOWVhYzM1YzMwZjdlZTI4ZWQwZmI0OC4uN2VkZTg2ZDE0YmY0MzhmYWUw ZDBiN2FjYWExYzVkZjRhYWUzNmFlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMS0wNC0xOCAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBFbmFibGUgUVVPVEEgQVBJIGF0IHJ1bnRpbWUgaWYgZW5hYmxlLXF1b3RhIGZsYWcg aXMgZ2l2ZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU4Nzg0CisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOiBBZGRlZCBFTkFCTEVfUVVPVEE9MS4K KyAgICAgICAgKiBwdWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmg6CisgICAgICAgICogc3JjL1dl YlJ1bnRpbWVGZWF0dXJlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlJ1bnRpbWVGZWF0dXJl czo6ZW5hYmxlUXVvdGEpOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdDo6V2ViUnVudGltZUZlYXR1 cmVzOjppc1F1b3RhRW5hYmxlZCk6IEFkZGVkLgorCiAyMDExLTA0LTE3ICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggMjAwOGE3YTJhYjZhMjcy OGZkMTU5OTExMDA2MTY5ZGQyNjdjNWE4My4uMDFmNWM3ODZmZTAwMDY5YWEwZTZiZjI1N2EzYjVl OWQ1ZmMzOTBkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAtNzcsNiAr NzcsNyBAQAogICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKICAgICAgICAg J0VOQUJMRV9QQUdFX1ZJU0lCSUxJVFlfQVBJPTAnLAogICAgICAgICAnRU5BQkxFX1BST0dSRVNT X1RBRz0xJywKKyAgICAgICAgJ0VOQUJMRV9RVU9UQT0xJywKICAgICAgICAgJ0VOQUJMRV9SRUdJ U1RFUl9QUk9UT0NPTF9IQU5ETEVSPTAnLAogICAgICAgICAnRU5BQkxFX1JFUVVFU1RfQU5JTUFU SU9OX0ZSQU1FPTEnLAogICAgICAgICAnRU5BQkxFX1NIQVJFRF9XT1JLRVJTPTEnLApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUnVudGltZUZlYXR1cmVzLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSdW50aW1lRmVhdHVyZXMuaAppbmRl eCBkZmFhZTVlYmQ1YTUzNTVjYjFiODI0OTg2ZmZiY2Q5MmFiZWEwMWJiLi4yNzZhMTY2OWYxYmIw NWQwYzM1ZWIzYmE4N2IwZTc3NWM3OTY1NTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJSdW50aW1lRmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJSdW50aW1lRmVhdHVyZXMuaApAQCAtMTAwLDYgKzEwMCw5IEBAIHB1 YmxpYzoKICAgICBXRUJLSVRfQVBJIHN0YXRpYyB2b2lkIGVuYWJsZUphdmFTY3JpcHRJMThOQVBJ KGJvb2wpOwogICAgIFdFQktJVF9BUEkgc3RhdGljIGJvb2wgaXNKYXZhU2NyaXB0STE4TkFQSUVu YWJsZWQoKTsKIAorICAgIFdFQktJVF9BUEkgc3RhdGljIHZvaWQgZW5hYmxlUXVvdGEoYm9vbCk7 CisgICAgV0VCS0lUX0FQSSBzdGF0aWMgYm9vbCBpc1F1b3RhRW5hYmxlZCgpOworCiBwcml2YXRl OgogICAgIFdlYlJ1bnRpbWVGZWF0dXJlcygpOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlJ1bnRpbWVGZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJSdW50aW1lRmVhdHVyZXMuY3BwCmluZGV4IDI1NmJmNTY4ZjBhMTNhZmJi NzkxM2JhZmZlZGU2ZWJiOGU2YWU5ZWEuLjVkNjRjYzgzNjMzY2FiMDM5NmQ0OTQyNWNjMWIzZTE2 YjgxOTdhOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJ1bnRp bWVGZWF0dXJlcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUnVudGlt ZUZlYXR1cmVzLmNwcApAQCAtMzIwLDQgKzMyMCwyMCBAQCBib29sIFdlYlJ1bnRpbWVGZWF0dXJl czo6aXNKYXZhU2NyaXB0STE4TkFQSUVuYWJsZWQoKQogI2VuZGlmCiB9CiAKK3ZvaWQgV2ViUnVu dGltZUZlYXR1cmVzOjplbmFibGVRdW90YShib29sIGVuYWJsZSkKK3sKKyNpZiBFTkFCTEUoUVVP VEEpCisgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0UXVvdGFFbmFibGVkKGVuYWJsZSk7 CisjZW5kaWYKK30KKworYm9vbCBXZWJSdW50aW1lRmVhdHVyZXM6OmlzUXVvdGFFbmFibGVkKCkK K3sKKyNpZiBFTkFCTEUoUVVPVEEpCisgICAgcmV0dXJuIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6 OnF1b3RhRW5hYmxlZCgpOworI2Vsc2UKKyAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKK30KKwog fSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==