58779 2011-04-18 06:19:17 -0700 REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs. 2011-04-18 13:26:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling abarth commit-queue eric ossy webkit.review.bot yael oldest_to_newest 387668 0 kling 2011-04-18 06:19:17 -0700 r84010 broke redirection of [broken] http:/ URLs because KURL cannot extract the host part of such URLs. 387672 1 90026 kling 2011-04-18 06:36:11 -0700 Created attachment 90026 Proposed patch 387767 2 90026 eric 2011-04-18 09:11:26 -0700 Comment on attachment 90026 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90026&action=review > Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1029 > + QUrl url = newRequest.url(); Why use a QUrl instead of a KURL? 387781 3 kling 2011-04-18 09:18:01 -0700 (In reply to comment #2) > (From update of attachment 90026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90026&action=review > > > Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1029 > > + QUrl url = newRequest.url(); > > Why use a QUrl instead of a KURL? See ChangeLog: "KURL::host() doesn't return the host part of [broken] http:/ URLs, so use QUrl instead to match the behavior of other ports." I could also fix the test to use http:// instead of http:/ but it seemed more appropriate to have consistent behavior across ports. 387897 4 90026 abarth 2011-04-18 11:42:59 -0700 Comment on attachment 90026 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=90026&action=review >>> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1029 >>> - KURL url = newRequest.url(); >>> + QUrl url = newRequest.url(); >> >> Why use a QUrl instead of a KURL? > > See ChangeLog: > > "KURL::host() doesn't return the host part of [broken] http:/ URLs, so use QUrl instead to match the behavior of other ports." > > I could also fix the test to use http:// instead of http:/ but it seemed more appropriate to have consistent behavior across ports. How do other port solve this problem with KURL? 387903 5 kling 2011-04-18 11:47:31 -0700 (In reply to comment #4) > (From update of attachment 90026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90026&action=review > > >>> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1029 > >>> - KURL url = newRequest.url(); > >>> + QUrl url = newRequest.url(); > >> > >> Why use a QUrl instead of a KURL? > > > > See ChangeLog: > > > > "KURL::host() doesn't return the host part of [broken] http:/ URLs, so use QUrl instead to match the behavior of other ports." > > > > I could also fix the test to use http:// instead of http:/ but it seemed more appropriate to have consistent behavior across ports. > > How do other port solve this problem with KURL? Apple is using NSURL, Chromium GURL and Gtk is using SoupURI. In other words, everyone is using their platform URL class. 387906 6 90026 abarth 2011-04-18 11:54:29 -0700 Comment on attachment 90026 Proposed patch I think a better solution would be to fix KURL, but this is probably ok for now. 387935 7 90026 commit-queue 2011-04-18 12:23:41 -0700 Comment on attachment 90026 Proposed patch Clearing flags on attachment: 90026 Committed r84168: <http://trac.webkit.org/changeset/84168> 387936 8 commit-queue 2011-04-18 12:23:46 -0700 All reviewed patches have been landed. Closing bug. 387987 9 webkit.review.bot 2011-04-18 13:26:19 -0700 http://trac.webkit.org/changeset/84168 might have broken Qt Linux Release The following tests are not passing: fast/ruby/after-block-doesnt-crash.html fast/ruby/after-table-doesnt-crash.html fast/ruby/before-block-doesnt-crash.html fast/ruby/before-table-doesnt-crash.html 90026 2011-04-18 06:36:11 -0700 2011-04-18 12:23:41 -0700 Proposed patch bug-58779.diff text/plain 4013 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNTgzOTE4Li5jNjFkMmViIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQt MTggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRFJUOiBVbmJyZWFrIHJlZGlyZWN0 aW9uIG9mIGh0dHA6LyBVUkxzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg3NzkKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6IFVuc2tp cCBodHRwL3Rlc3RzL2xvYWRpbmcvY3Jvc3Mtb3JpZ2luLVhIUi13aWxsTG9hZFJlcXVlc3QuaHRt bAorCiAyMDExLTA0LTE2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgVXBkYXRlZCByZXN1bHRzIGZvciBmYXN0L2Jsb2NrL2Zsb2F0LzAzMi5odG1sIGFmdGVyIHI4 NDA5Ni4gRmlsZWQgaHR0cDovL3dlYmtpdC5vcmcvYi81ODczNiB0bwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKaW5kZXggODMxNmI3My4uNWRkOTQ4ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBA IC0zNDkxLDcgKzM0OTEsNiBAQCBmYXN0L3RyYW5zZm9ybXMvc2Nyb2xsSW50b1ZpZXctdHJhbnNm b3JtZWQuaHRtbAogZmFzdC9jc3MvZm9udC1mYWNlLXJlcGVhdGVkLXVybC5odG1sCiBodHRwL3Rl c3RzL2luc3BlY3Rvci9uZXR3b3JrL2Rvd25sb2FkLmh0bWwKIGh0dHAvdGVzdHMvaW5zcGVjdG9y L25ldHdvcmsveC1mcmFtZS1vcHRpb25zLWRlbnkuaHRtbAotaHR0cC90ZXN0cy9sb2FkaW5nL2Ny b3NzLW9yaWdpbi1YSFItd2lsbExvYWRSZXF1ZXN0Lmh0bWwKIGh0dHAvdGVzdHMvbWlzYy9yZWRp cmVjdC10by1leHRlcm5hbC11cmwuaHRtbAogCiAjIFF1b3RhIEFQSSBpcyBub3QgeWV0IHN1cHBv cnRlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggOTkxM2U3MS4uYTE3ZmM0OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxMS0wNC0xOCAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UkVHUkVTU0lPTiAocjg0MDEwKTogW1F0XSBEUlQ6IFVuYnJlYWsgcmVkaXJlY3Rpb24gb2YgaHR0 cDovIFVSTHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODc3OQorCisgICAgICAgIEtVUkw6Omhvc3QoKSBkb2Vzbid0IHJldHVybiB0aGUgaG9zdCBw YXJ0IG9mIFticm9rZW5dIGh0dHA6LyBVUkxzLCBzbyB1c2UKKyAgICAgICAgUVVybCBpbnN0ZWFk IHRvIG1hdGNoIHRoZSBiZWhhdmlvciBvZiBvdGhlciBwb3J0cy4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QpOgorCiAyMDExLTA0LTE2 ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3Bw CmluZGV4IGIxY2JkNTUuLjM0N2EzZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcApAQCAtMTAyNiw3ICsxMDI2 LDcgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudFF0Ojphc3NpZ25JZGVudGlmaWVyVG9Jbml0aWFs UmVxdWVzdCh1bnNpZ25lZCBsb25nIGlkZW50aWYKIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudFF0 OjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChXZWJDb3JlOjpEb2N1bWVudExvYWRlciosIHVuc2ln bmVkIGxvbmcgaWRlbnRpZmllciwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiBuZXdSZXF1ZXN0 LCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiByZWRpcmVjdFJlc3BvbnNlKQogewot ICAgIEtVUkwgdXJsID0gbmV3UmVxdWVzdC51cmwoKTsKKyAgICBRVXJsIHVybCA9IG5ld1JlcXVl c3QudXJsKCk7CiAKICAgICBpZiAoZHVtcFJlc291cmNlTG9hZENhbGxiYWNrcykKICAgICAgICAg cHJpbnRmKCIlcyAtIHdpbGxTZW5kUmVxdWVzdCAlcyByZWRpcmVjdFJlc3BvbnNlICVzXG4iLApA QCAtMTA0NiwxMCArMTA0NiwxMSBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNo V2lsbFNlbmRSZXF1ZXN0KFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyKiwgdW5zaQogICAgIH0KIAog ICAgIGlmIChRV2ViUGFnZVByaXZhdGU6OmRydFJ1bgotICAgICAgICAmJiB1cmwucHJvdG9jb2xJ bkhUVFBGYW1pbHkoKQotICAgICAgICAmJiB1cmwuaG9zdCgpICE9ICIxMjcuMC4wLjEiCi0gICAg ICAgICYmIHVybC5ob3N0KCkgIT0gIjI1NS4yNTUuMjU1LjI1NSIKLSAgICAgICAgJiYgIWVxdWFs SWdub3JpbmdDYXNlKHVybC5ob3N0KCksICJsb2NhbGhvc3QiKSkgeworICAgICAgICAmJiB1cmwu aXNWYWxpZCgpCisgICAgICAgICYmICh1cmwuc2NoZW1lKCkudG9Mb3dlcigpID09IFFMYXRpbjFT dHJpbmcoImh0dHAiKSB8fCB1cmwuc2NoZW1lKCkudG9Mb3dlcigpID09IFFMYXRpbjFTdHJpbmco Imh0dHBzIikpCisgICAgICAgICYmIHVybC5ob3N0KCkgIT0gUUxhdGluMVN0cmluZygiMTI3LjAu MC4xIikKKyAgICAgICAgJiYgdXJsLmhvc3QoKSAhPSBRTGF0aW4xU3RyaW5nKCIyNTUuMjU1LjI1 NS4yNTUiKQorICAgICAgICAmJiB1cmwuaG9zdCgpLnRvTG93ZXIoKSAhPSBRTGF0aW4xU3RyaW5n KCJsb2NhbGhvc3QiKSkgewogCiAgICAgICAgIHByaW50ZigiQmxvY2tlZCBhY2Nlc3MgdG8gZXh0 ZXJuYWwgVVJMICVzXG4iLCBxUHJpbnRhYmxlKGRydERlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0 UmVzdWx0KHVybCkpKTsKICAgICAgICAgbmV3UmVxdWVzdC5zZXRVUkwoUVVybCgpKTsKQEAgLTEw NjAsNyArMTA2MSw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hXaWxsU2Vu ZFJlcXVlc3QoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXIqLCB1bnNpCiAgICAgICAgICAgbmV3UmVx dWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoc2VuZFJlcXVlc3RDbGVhckhlYWRlcnMuYXQoaSkudG9M b2NhbDhCaXQoKS5jb25zdERhdGEoKSwgUVN0cmluZygpKTsKIAogICAgIGlmIChRV2ViUGFnZVBy aXZhdGU6OmRydFJ1bikgewotICAgICAgICBRTWFwPFFTdHJpbmcsIFFTdHJpbmc+Ojpjb25zdF9p dGVyYXRvciBpdCA9IFVSTHNUb1JlZGlyZWN0LmNvbnN0RmluZCh1cmwuc3RyaW5nKCkpOworICAg ICAgICBRTWFwPFFTdHJpbmcsIFFTdHJpbmc+Ojpjb25zdF9pdGVyYXRvciBpdCA9IFVSTHNUb1Jl ZGlyZWN0LmNvbnN0RmluZCh1cmwudG9TdHJpbmcoKSk7CiAgICAgICAgIGlmIChpdCAhPSBVUkxz VG9SZWRpcmVjdC5jb25zdEVuZCgpKQogICAgICAgICAgICAgbmV3UmVxdWVzdC5zZXRVUkwoUVVy bChpdC52YWx1ZSgpKSk7CiAgICAgfQo=