58773 2011-04-18 03:08:43 -0700 [GTK] Release builds should have debug symbols 2011-06-27 01:55:05 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 63318 P2 Normal --- 1 pnormand webkit-unassigned gustavo xan.lopez oldest_to_newest 387612 0 pnormand 2011-04-18 03:08:43 -0700 To match Mac port nomenclature: --release: build with -O2 -g --production: build with -O2 --debug: build with -O0 -g 387615 1 pnormand 2011-04-18 03:41:24 -0700 Production in our case would simply be not Debug and not Release. eg: ./configure --disable-debug --disable-release (both are disabled by default anyway). 387616 2 90011 pnormand 2011-04-18 03:42:05 -0700 Created attachment 90011 proposed patch 387661 3 gustavo 2011-04-18 05:50:37 -0700 Two points here: * this will make the build take a lot more time, it will possibly be close to a debug build * in Debian we always build with -g anyways, and then split the symbols off to their own package I'm OK with this in principle. I think we should keep the EWS building without -g, though, otherwise it's going to lag heavily. 387663 4 pnormand 2011-04-18 05:57:02 -0700 For the EWS doing a simple build-webkit --gtk will do a Production build. 387730 5 90011 mrobinson 2011-04-18 08:14:27 -0700 Comment on attachment 90011 proposed patch I think the debug, release, production terminology might be unusual to people familiar with configure, make, make install. Maybe it would make sense to have the configure flag something like --enable-debug-symbols or even just override the CPPFLAGS manually. What do you think? 387743 6 pnormand 2011-04-18 08:35:08 -0700 (In reply to comment #5) > (From update of attachment 90011 [details]) > I think the debug, release, production terminology might be unusual to people familiar with configure, make, make install. Maybe it would make sense to have the configure flag something like --enable-debug-symbols hum yes make sense indeed! I'll upload a new patch > or even just override the CPPFLAGS manually. What do you think? Not sure that would integrate well with build-webkit... 388551 7 pnormand 2011-04-19 09:47:27 -0700 (In reply to comment #1) > Production in our case would simply be not Debug and not Release. eg: ./configure --disable-debug --disable-release (both are disabled by default anyway). That was a wrong assumption, the default build configuration is Release. Meaning that by default dbg symbols would be included. So not sure what to do to have a build without dbg symbols using build-webkit. I don't think setting CXXFLAGS manually would work because build-webkit when calling configure would anyway insert the -g switch there. On mac the build configuration can be changed by a Configuration file the product directory. But that doesn't feel very intuitive (IMHO). I think that leaves us with a new build-webkit option, --production maybe? That would enable build with optimizations and without dbg symbols. Opinions? 427785 8 pnormand 2011-06-27 01:55:05 -0700 *** This bug has been marked as a duplicate of bug 63318 *** 90011 2011-04-18 03:42:05 -0700 2011-04-18 09:34:54 -0700 proposed patch proposed-patch.patch text/plain 3753 pnormand RnJvbSAzMThkMTRlZGRmMTMxMDljNTY5YmY0NDRlYWM3ZmNhMGY0ZGZiMmJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDE4IEFwciAyMDExIDEyOjQyOjEzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgIHwgICAxMSAr KysrKysrKysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysr CiBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gfCAgICA0ICsrKy0KIGNvbmZpZ3VyZS5hYyAg ICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrLS0tCiA0IGZpbGVzIGNoYW5nZWQsIDM2 IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIv Q2hhbmdlTG9nCmluZGV4IDgwZDA0M2IuLjVmMzk4YWQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZwor KysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNC0xOCAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0dUS10gUmVsZWFzZSBidWlsZHMgc2hvdWxkIGhhdmUgZGVi dWcgc3ltYm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTg3NzMKKworICAgICAgICAqIGNvbmZpZ3VyZS5hYzogTmV3IGNvbmZpZ3VyZSBzd2l0Y2gg dG8gaGFuZGxlIFJlbGVhc2UgYnVpbGRzLiBJZgorICAgICAgICB0aGlzIGlzIGVuYWJsZWQgLWcg aXMgYWRkZWQgdG8gQ0ZMQUdTIGFuZCBDWFhGTEFHUy4gVGhlIG9wdGlvbiBpcworICAgICAgICBk aXNhYmxlZCBieSBkZWZhdWx0LgorCiAyMDExLTA0LTE2ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNjOGJlZjQu LmY4OWI2MDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNC0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW0dUS10gUmVsZWFzZSBidWlsZHMgc2hvdWxkIGhhdmUgZGVidWcgc3ltYm9scwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg3NzMKKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTogSG9vayAtLXJlbGVhc2UgdG8gdGhlIG5l dworICAgICAgICAtLWVuYWJsZS1yZWxlYXNlIGNvbmZpZ3VyZSBvcHRpb24uCisKIDIwMTEtMDQt MTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4NDExMS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBlN2Fm YmVhLi42MjlhYjNiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xNDU3LDcgKzE0NTcsOSBAQCBzdWIg YnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRAKQogICAgIGlmICgkY29uZmlnID1+IG0vZGVidWcvaSkg ewogICAgICAgICBwdXNoIEBidWlsZEFyZ3MsICItLWVuYWJsZS1kZWJ1ZyI7CiAgICAgfSBlbHNl IHsKLSAgICAgICAgcHVzaCBAYnVpbGRBcmdzLCAiLS1kaXNhYmxlLWRlYnVnIjsKKyAgICAgICAg aWYgKCRjb25maWcgPX4gbS9yZWxlYXNlL2kpIHsKKyAgICAgICAgICAgIHB1c2ggQGJ1aWxkQXJn cywgIi0tZW5hYmxlLXJlbGVhc2UiOworICAgICAgICB9CiAgICAgfQogCiAgICAgIyBVc2Ugcm0g dG8gY2xlYW4gdGhlIGJ1aWxkIGRpcmVjdG9yeSBzaW5jZSBkaXN0Y2xlYW4gbWF5IG1pc3MgZmls ZXMKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBmNDdiZjVi Li4wNDI2ZWU2IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBA IC0zNDUsNiArMzQ1LDE0IEBAIEFDX0FSR19FTkFCTEUoZGVidWcsCiAgICAgICAgICAgICAgIFtd LFtlbmFibGVfZGVidWc9Im5vIl0pCiBBQ19NU0dfUkVTVUxUKFskZW5hYmxlX2RlYnVnXSkKIAor IyBjaGVjayB3aGV0aGVyIHRvIGJ1aWxkIHdpdGggbWluaW1hbCBkZWJ1Z2dpbmcgc3VwcG9ydCBl bmFibGVkCitBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZG8gYSByZWxlYXNlIGJ1aWxkXSkK K0FDX0FSR19FTkFCTEUocmVsZWFzZSwKKyAgICAgICAgICAgICAgQUNfSEVMUF9TVFJJTkcoWy0t ZW5hYmxlLXJlbGVhc2VdLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbdHVybiBvbiBt aW5pbWFsIGRlYnVnZ2luZyBzdXBwb3J0IFtkZWZhdWx0PW5vXV0pLAorICAgICAgICAgICAgICBb XSxbZW5hYmxlX3JlbGVhc2U9Im5vIl0pCitBQ19NU0dfUkVTVUxUKFskZW5hYmxlX3JlbGVhc2Vd KQorCiAjIGNoZWNrIHdoZXRoZXIgdG8gZW5hYmxlIG9wdGltaXplZCBidWlsZHMKIEFDX01TR19D SEVDS0lORyhbd2hldGhlciB0byBlbmFibGUgb3B0aW1pemVkIGJ1aWxkc10pCiBBQ19BUkdfRU5B QkxFKG9wdGltaXphdGlvbnMsCkBAIC05MDYsOCArOTE0LDggQEAgaWYgdGVzdCAiJGhvc3RfY3B1 IiA9ICJzaDQiOyB0aGVuCiAgICBDRkxBR1M9IiRDRkxBR1MgLW1pZWVlIC13IgogZmkKIAotIyBB ZGQgJy1nJyBmbGFnIHRvIGdjYyBpZiBpdCdzIGRlYnVnIGJ1aWxkCi1pZiB0ZXN0ICIkZW5hYmxl X2RlYnVnIiA9ICJ5ZXMiOyB0aGVuCisjIEFkZCAnLWcnIGZsYWcgdG8gZ2NjIGlmIGl0J3MgZGVi dWcgb3IgcmVsZWFzZSBidWlsZAoraWYgdGVzdCAiJGVuYWJsZV9kZWJ1ZyIgPSAieWVzIiAtbyAi JGVuYWJsZV9yZWxlYXNlIiA9ICJ5ZXMiOyB0aGVuCiAgICBDWFhGTEFHUz0iJENYWEZMQUdTIC1n IgogICAgQ0ZMQUdTPSIkQ0ZMQUdTIC1nIgogZWxzZQpAQCAtMTE1MCw3ICsxMTU4LDggQEAgZWNo byAiCiBXZWJLaXQgd2FzIGNvbmZpZ3VyZWQgd2l0aCB0aGUgZm9sbG93aW5nIG9wdGlvbnM6CiAK IEJ1aWxkIGNvbmZpZ3VyYXRpb246Ci0gRW5hYmxlIGRlYnVnZ2luZyAoc2xvdykgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2RlYnVnCisgRW5hYmxlIGRlYnVnZ2lu ZyAodmVyeSBzbG93KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlX2RlYnVn CisgRW5hYmxlIG1pbmltYWwgZGVidWdnaW5nIChzbG93KSAgICAgICAgICAgICAgICAgICAgICAg ICAgOiAkZW5hYmxlX3JlbGVhc2UKICBFbmFibGUgR0NDIGJ1aWxkIG9wdGltaXphdGlvbiAgICAg ICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfb3B0aW1pemF0aW9ucwogIENvZGUgY292 ZXJhZ2Ugc3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJs ZV9jb3ZlcmFnZQogIFVuaWNvZGUgYmFja2VuZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDogJHdpdGhfdW5pY29kZV9iYWNrZW5kCi0tIAoxLjcuNC40