58770 2011-04-18 02:41:59 -0700 REGRESSION(r84112): Chromium linux layout tests are broken. (Requested by loislo2 on #webkit). 2011-04-18 12:03:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 58690 1 webkit.review.bot webkit.review.bot abarth dpranke eric loislo ojan oldest_to_newest 387600 0 webkit.review.bot 2011-04-18 02:41:59 -0700 http://trac.webkit.org/changeset/84112 broke the build: Chromium linux layout tests are broken. (Requested by loislo2 on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 387601 1 90008 webkit.review.bot 2011-04-18 02:42:21 -0700 Created attachment 90008 ROLLOUT of r84112 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 387602 2 90008 loislo 2011-04-18 02:45:41 -0700 Comment on attachment 90008 ROLLOUT of r84112 Clearing flags on attachment: 90008 Committed r84127: <http://trac.webkit.org/changeset/84127> 387603 3 loislo 2011-04-18 02:45:50 -0700 All reviewed patches have been landed. Closing bug. 387639 4 webkit.review.bot 2011-04-18 04:45:35 -0700 http://trac.webkit.org/changeset/84127 might have broken GTK Linux 64-bit Debug 387910 5 dpranke 2011-04-18 12:03:18 -0700 Okay, there's an actual bug here as well. Doing a read on a non-blocking socket may raise EAGAIN / EWOULDBLOCK if there is no data available, and we weren't catching that case. I'm not sure why I didn't see this when I tested this the first time, since it's a pretty pervasive failure. It's easy to patch this, but I wonder what the performance cost will be of catching errors vs. doing a select first to see if data is available, since raising an error is the common case. 90008 2011-04-18 02:42:21 -0700 2011-04-18 02:45:41 -0700 ROLLOUT of r84112 bug-58770-20110418093914.patch text/plain 3160 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMjYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNGI1MWMzNTRlOWJhY2IxOTNjZmE3Mzc4YzJlYzQ0MjAw ZWYyNWI0Li42NjdmZGYxZjZkNmU3NTEzMmIxZTYxZjZmNjQyNTRhNWNlYWZhZTRmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4NDExMi4KKyAgICAgICAgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvODQxMTIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NzcwCisKKyAgICAgICAgQ2hyb21pdW0gbGlu dXggbGF5b3V0IHRlc3RzIGFyZSBicm9rZW4uIChSZXF1ZXN0ZWQgYnkgbG9pc2xvMgorICAgICAg ICBvbiAjd2Via2l0KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5OgorCiAy MDExLTA0LTE3ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIFNlaWRlbCBhbmQgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0 X3dyaXRlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9w YWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weQppbmRleCBiYzgzMDEwODNjNDVhZjgyYWI0ZWU0 MDdkM2QxYzJmNGEwY2FiZWJlLi5lZWI5ODkwNWQyNmM4ZTA1NzMxYTE0NGYyMzQ1NDNhMjM1MjVh ZmVmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlv dXRfcGFja2FnZS90ZXN0X3Jlc3VsdF93cml0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CkBA IC00Myw5ICs0Myw2IEBAIGRlZiB3cml0ZV90ZXN0X3Jlc3VsdChwb3J0LCBmaWxlbmFtZSwgZHJp dmVyX291dHB1dCwKICAgICBjaGVja3N1bXNfbWlzbWF0Y2hfYnV0X2ltYWdlc19hcmVfc2FtZSA9 IEZhbHNlCiAgICAgaW1hZ2VoYXNoX21pc21hdGNoX2ZhaWx1cmUgPSBOb25lCiAgICAgd3JpdGVy ID0gVGVzdFJlc3VsdFdyaXRlcihwb3J0LCByb290X291dHB1dF9kaXIsIGZpbGVuYW1lKQotICAg IGlmIGRyaXZlcl9vdXRwdXQuZXJyb3I6Ci0gICAgICAgIHdyaXRlci53cml0ZV9zdGRlcnIoZHJp dmVyX291dHB1dC5lcnJvcikKLQogICAgIGZvciBmYWlsdXJlIGluIGZhaWx1cmVzOgogICAgICAg ICAjIEZJWE1FOiBJbnN0ZWFkIG9mIHRoaXMgbG9uZyAnaWYnIGJsb2NrLCBlYWNoIGZhaWx1cmUg Y2xhc3MgbWlnaHQKICAgICAgICAgIyBoYXZlIGEgcmVzcG9uc2liaWxpdHkgZm9yIHdyaXRpbmcg YSB0ZXN0IHJlc3VsdC4KQEAgLTE1NywxMiArMTU0LDYgQEAgY2xhc3MgVGVzdFJlc3VsdFdyaXRl cihvYmplY3QpOgogICAgICAgICBpZiBleHBlY3RlZCBpcyBub3QgTm9uZToKICAgICAgICAgICAg IGZzLndyaXRlX2JpbmFyeV9maWxlKGV4cGVjdGVkX2ZpbGVuYW1lLCBleHBlY3RlZCkKIAotICAg IGRlZiB3cml0ZV9zdGRlcnIoc2VsZiwgZXJyb3IpOgotICAgICAgICBmcyA9IHNlbGYuX3BvcnQu X2ZpbGVzeXN0ZW0KLSAgICAgICAgZmlsZW5hbWUgPSBzZWxmLm91dHB1dF9maWxlbmFtZSgiLXN0 ZGVyci50eHQiKQotICAgICAgICBmcy5tYXliZV9tYWtlX2RpcmVjdG9yeShmcy5kaXJuYW1lKGZp bGVuYW1lKSkKLSAgICAgICAgZnMud3JpdGVfdGV4dF9maWxlKGZpbGVuYW1lLCBlcnJvcikKLQog ICAgIGRlZiB3cml0ZV9jcmFzaF9yZXBvcnQoc2VsZiwgZXJyb3IpOgogICAgICAgICAiIiJXcml0 ZSBjcmFzaCBpbmZvcm1hdGlvbi4iIiIKICAgICAgICAgZnMgPSBzZWxmLl9wb3J0Ll9maWxlc3lz dGVtCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5f d2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQppbmRleCA5NzA1ZmZiYjQ3NjJhMjA0 ZDEwY2U4MTJkODI5NDBiOGE4MTJlMjkzLi42ZjM5YTkyMDcwODUzNjU3ZTIzZjEyNGU2ZDBkYjFi ZjI1ZDA4NWIzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkKQEAgLTM0MSwxMiAr MzQxLDYgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICB0ZXN0 c19ydW4gPSBnZXRfdGVzdHNfcnVuKFsnZmFpbHVyZXMvZXhwZWN0ZWQva2V5YmFvcmQuaHRtbCdd LCB0ZXN0c19pbmNsdWRlZD1UcnVlLCBmbGF0dGVuX2JhdGNoZXM9VHJ1ZSkKICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbHMoW10sIHRlc3RzX3J1bikKIAotICAgIGRlZiB0ZXN0X3N0ZGVycl9pc19z YXZlZChzZWxmKToKLSAgICAgICAgZnMgPSBwb3J0LnVuaXRfdGVzdF9maWxlc3lzdGVtKCkKLSAg ICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVuKGZpbGVzeXN0ZW09ZnMpKQotICAgICAg ICBzZWxmLmFzc2VydEVxdWFscyhmcy5yZWFkX3RleHRfZmlsZSgnL3RtcC9sYXlvdXQtdGVzdC1y ZXN1bHRzL3Bhc3Nlcy9lcnJvci1zdGRlcnIudHh0JyksCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICdzdHVmZiBnb2luZyB0byBzdGRlcnInKQotCiAgICAgZGVmIHRlc3RfdGVzdF9saXN0KHNl bGYpOgogICAgICAgICBmcyA9IHBvcnQudW5pdF90ZXN0X2ZpbGVzeXN0ZW0oKQogICAgICAgICBm aWxlbmFtZSA9ICcvdG1wL2Zvby50eHQnCg==