58764 2011-04-18 00:12:55 -0700 Web Inspector: Backspace in the Console is broken 2011-04-19 03:01:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 58875 1 apavlov apavlov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 387567 0 apavlov 2011-04-18 00:12:55 -0700 This is a regression from http://trac.webkit.org/changeset/83968 387576 1 90002 apavlov 2011-04-18 01:16:43 -0700 Created attachment 90002 [PATCH] Suggested fix 387586 2 90002 yurys 2011-04-18 02:04:53 -0700 Comment on attachment 90002 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=90002&action=review > Source/WebCore/inspector/front-end/inspector.js:797 > + if (!selection.rangeCount || !selection.isCollapsed) This will break backspace on non-empty selection. r- for this. 387775 3 90043 apavlov 2011-04-18 09:15:22 -0700 Created attachment 90043 [PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements 387780 4 90043 yurys 2011-04-18 09:17:34 -0700 Comment on attachment 90043 [PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements View in context: https://bugs.webkit.org/attachment.cgi?id=90043&action=review > Source/WebCore/inspector/front-end/inspector.js:797 > + var computedStyle = document.defaultView.getComputedStyle(this.currentFocusElement, null, ""); Could you provide a comment explaining this logic? 387789 5 apavlov 2011-04-18 09:24:31 -0700 Committed r84150: <http://trac.webkit.org/changeset/84150> 387927 6 webkit.review.bot 2011-04-18 12:20:45 -0700 http://trac.webkit.org/changeset/84150 might have broken GTK Linux 32-bit Debug 388385 7 apavlov 2011-04-19 03:01:05 -0700 Rolled out in r84236. 90002 2011-04-18 01:16:43 -0700 2011-04-18 09:15:22 -0700 [PATCH] Suggested fix fixback.patch text/plain 1429 apavlov Y29tbWl0IDFmZThjM2M0OTJmNmU3ZjVjNTA1YzI4YjJkZGQwMDdkNjdlZDk3YzkKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gQXByIDE4 IDEyOjEwOjQ5IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRkMjUxZC4uZmFm MzVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA0LTE4ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQmFja3NwYWNlIGluIHRoZSBD b25zb2xlIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTg3NjQKKworICAgICAgICBBIHJlZ3Jlc3Npb24gZml4IGZyb20gcjgzOTY4Lgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duKToKKwogMjAxMS0wNC0xNyAgVGhpZXJyeSBSZWRp bmcgIDx0aGllcnJ5LnJlZGluZ0BhdmlvbmljLWRlc2lnbi5kZT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L2luc3BlY3Rvci5qcwppbmRleCBjNTk5ZTQ2Li5jY2IwOTU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNzkzLDcgKzc5Myw5IEBA IFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlvbihldmVudCkKICAgICAgICAg ICAgICAgICBQYWdlQWdlbnQucmVsb2FkUGFnZShldmVudC5jdHJsS2V5IHx8IGV2ZW50LnNoaWZ0 S2V5KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlICJVKzAwMDgiOiAvLyBCYWNr c3BhY2UKLSAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgICAgICB2 YXIgc2VsZWN0aW9uID0gd2luZG93LmdldFNlbGVjdGlvbigpOworICAgICAgICAgICAgaWYgKCFz ZWxlY3Rpb24ucmFuZ2VDb3VudCB8fCAhc2VsZWN0aW9uLmlzQ29sbGFwc2VkKQorICAgICAgICAg ICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICBicmVhazsKICAgICB9 CiB9Cg== 90043 2011-04-18 09:15:22 -0700 2011-04-18 09:18:16 -0700 [PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements fixback.patch text/plain 1665 apavlov Y29tbWl0IGZiMDg4ZGUyNDM2OTRhYTBjOWVkMmMzMmVjYzRlMWI0OWExNmUxMWMKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gQXByIDE4 IDIwOjEyOjM4IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY2MDg2Yi4uMGQ2 MGJmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTA0LTE4ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQmFja3NwYWNlIGluIHRoZSBD b25zb2xlIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTg3NjQKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9y LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93bik6CisKKzIwMTEtMDQt MTggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwogICAgICAgICBS ZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5lZWQg YSB3b3JrYXJvdW5kIGZvciBidWcgNTg0MjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9pbnNwZWN0b3IuanMKaW5kZXggYjEyNWU3ZS4uNWFjOGU4ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTc5Miw2 ICs3OTIsMTQgQEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKGV2ZW50 KQogICAgICAgICAgICAgaWYgKCFpc01hYykKICAgICAgICAgICAgICAgICBQYWdlQWdlbnQucmVs b2FkUGFnZShldmVudC5jdHJsS2V5IHx8IGV2ZW50LnNoaWZ0S2V5KTsKICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICBjYXNlICJVKzAwMDgiOiAvLyBCYWNrc3BhY2UKKyAgICAgICAgICAgIGlm ICh0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQgJiYgZG9jdW1lbnQuZGVmYXVsdFZpZXcpIHsKKyAg ICAgICAgICAgICAgICB2YXIgY29tcHV0ZWRTdHlsZSA9IGRvY3VtZW50LmRlZmF1bHRWaWV3Lmdl dENvbXB1dGVkU3R5bGUodGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50LCBudWxsLCAiIik7CisgICAg ICAgICAgICAgICAgdmFyIHVzZXJNb2RpZnkgPSBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFs dWUoIi13ZWJraXQtdXNlci1tb2RpZnkiKTsKKyAgICAgICAgICAgICAgICBpZiAoIXVzZXJNb2Rp ZnkgfHwgdXNlck1vZGlmeSA9PT0gInJlYWQtb25seSIpCisgICAgICAgICAgICAgICAgICAgIGV2 ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBicmVhazsK ICAgICB9CiB9CiAK