58763 2011-04-17 23:07:37 -0700 Stop using -[NSString initWithContentsOfFile:] 2011-04-18 15:23:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 387558 0 zwarich 2011-04-17 23:07:37 -0700 We should stop using -[NSString initWithContentsOfFile:], which was deprecated in Tiger. Clang gives a deprecation warning for using it. 387559 1 89998 zwarich 2011-04-17 23:09:06 -0700 Created attachment 89998 Proposed patch 388099 2 zwarich 2011-04-18 15:23:39 -0700 Fixed in r84191. 89998 2011-04-17 23:09:06 -0700 2011-04-18 07:11:40 -0700 Proposed patch NSString.patch text/plain 1854 zwarich SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA4NDEyMikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTcgIENhbWVyb24gWndhcmljaCAgPHp3 YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFN0b3AgdXNpbmcgLVtOU1N0cmluZyBpbml0V2l0aENvbnRlbnRzT2ZGaWxlOl0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NzYzCisK KyAgICAgICAgLVtOU1N0cmluZyBpbml0V2l0aENvbnRlbnRzT2ZGaWxlOl0gd2FzIGRlcHJlY2F0 ZWQgaW4gMTAuNCwgc28gd2Ugc2hvdWxkIHN0b3AgdXNpbmcgaXQuCisKKyAgICAgICAgKiBXZWJW aWV3L1dlYlZpZXcubW06CisgICAgICAgIChsZWFrTWFpbFF1aXJrc1VzZXJTY3JpcHRDb250ZW50 cyk6CisgICAgICAgIChsZWFrT3V0bG9va1F1aXJrc1VzZXJTY3JpcHRDb250ZW50cyk6CisKIDIw MTEtMDQtMTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICA8 aHR0cDovL3dlYmtpdC5vcmcvYi81ODQ2Mz4gU3dpdGNoIEhUVFAgcGlwZWxpbmluZyBmcm9tIHVz ZXIgZGVmYXVsdCB0byBwcml2YXRlIHNldHRpbmcKSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9X ZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShy ZXZpc2lvbiA4NDExOSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5n IGNvcHkpCkBAIC02NDIsNyArNjQyLDggQEAKIHN0YXRpYyBOU1N0cmluZyAqbGVha01haWxRdWly a3NVc2VyU2NyaXB0Q29udGVudHMoKQogewogICAgIE5TU3RyaW5nICpzY3JpcHRQYXRoID0gW1tO U0J1bmRsZSBidW5kbGVGb3JDbGFzczpbV2ViVmlldyBjbGFzc11dIHBhdGhGb3JSZXNvdXJjZTpA Ik1haWxRdWlya3NVc2VyU2NyaXB0IiBvZlR5cGU6QCJqcyJdOwotICAgIHJldHVybiBbW05TU3Ry aW5nIGFsbG9jXSBpbml0V2l0aENvbnRlbnRzT2ZGaWxlOnNjcmlwdFBhdGhdOworICAgIE5TU3Ry aW5nRW5jb2RpbmcgZW5jb2Rpbmc7CisgICAgcmV0dXJuIFtbTlNTdHJpbmcgYWxsb2NdIGluaXRX aXRoQ29udGVudHNPZkZpbGU6c2NyaXB0UGF0aCB1c2VkRW5jb2Rpbmc6JmVuY29kaW5nIGVycm9y OjBdOwogfQogCiAtICh2b2lkKV9pbmplY3RNYWlsUXVpcmtzU2NyaXB0CkBAIC02NjIsNyArNjYz LDggQEAKIHN0YXRpYyBOU1N0cmluZyAqbGVha091dGxvb2tRdWlya3NVc2VyU2NyaXB0Q29udGVu dHMoKQogewogICAgIE5TU3RyaW5nICpzY3JpcHRQYXRoID0gW1tOU0J1bmRsZSBidW5kbGVGb3JD bGFzczpbV2ViVmlldyBjbGFzc11dIHBhdGhGb3JSZXNvdXJjZTpAIk91dGxvb2tRdWlya3NVc2Vy U2NyaXB0IiBvZlR5cGU6QCJqcyJdOwotICAgIHJldHVybiBbW05TU3RyaW5nIGFsbG9jXSBpbml0 V2l0aENvbnRlbnRzT2ZGaWxlOnNjcmlwdFBhdGhdOworICAgIE5TU3RyaW5nRW5jb2RpbmcgZW5j b2Rpbmc7CisgICAgcmV0dXJuIFtbTlNTdHJpbmcgYWxsb2NdIGluaXRXaXRoQ29udGVudHNPZkZp bGU6c2NyaXB0UGF0aCB1c2VkRW5jb2Rpbmc6JmVuY29kaW5nIGVycm9yOjBdOwogfQogCiAtKHZv aWQpX2luamVjdE91dGxvb2tRdWlya3NTY3JpcHQK