58760 2011-04-17 21:04:41 -0700 JSC no longer builds with Clang due to -Woverloaded-virtual warning 2011-04-18 01:38:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich abarth eric webkit.review.bot oldest_to_newest 387512 0 zwarich 2011-04-17 21:04:41 -0700 JSC no longer builds with clang because of a -Woverloaded-virtual warning from an overload of JSValue::put(). 387515 1 89986 zwarich 2011-04-17 21:07:20 -0700 Created attachment 89986 Proposed patch 387517 2 89986 mitz 2011-04-17 21:12:42 -0700 Comment on attachment 89986 Proposed patch Thank you! 387540 3 zwarich 2011-04-17 22:19:56 -0700 Fixed in r84121. 387583 4 webkit.review.bot 2011-04-18 01:38:08 -0700 http://trac.webkit.org/changeset/84121 might have broken GTK Linux 32-bit Debug 89986 2011-04-17 21:07:20 -0700 2011-04-17 21:12:42 -0700 Proposed patch putSpecificValue.patch text/plain 3808 zwarich SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCShyZXZpc2lv biA4NDExOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xNzYsNyArMTc2LDcgQEAKICAgICAgICAgfSBEaWN0aW9uYXJ5S2lu ZDsKICAgICAgICAgc3RhdGljIFN0cnVjdHVyZSogdG9EaWN0aW9uYXJ5VHJhbnNpdGlvbihKU0ds b2JhbERhdGEmLCBTdHJ1Y3R1cmUqLCBEaWN0aW9uYXJ5S2luZCk7CiAKLSAgICAgICAgc2l6ZV90 IHB1dChKU0dsb2JhbERhdGEmLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIHVuc2ln bmVkIGF0dHJpYnV0ZXMsIEpTQ2VsbCogc3BlY2lmaWNWYWx1ZSk7CisgICAgICAgIHNpemVfdCBw dXRTcGVjaWZpY1ZhbHVlKEpTR2xvYmFsRGF0YSYsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5 TmFtZSwgdW5zaWduZWQgYXR0cmlidXRlcywgSlNDZWxsKiBzcGVjaWZpY1ZhbHVlKTsKICAgICAg ICAgc2l6ZV90IHJlbW92ZShjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpOwogCiAgICAg ICAgIHZvaWQgY3JlYXRlUHJvcGVydHlNYXAodW5zaWduZWQga2V5Q291bnQgPSAwKTsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAkocmV2aXNpb24g ODQxMTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMzYsNyArMzM2LDcgQEAKICAgICBpZiAoc3RydWN0dXJlLT50cmFu c2l0aW9uQ291bnQoKSA+IHNfbWF4VHJhbnNpdGlvbkxlbmd0aCkgewogICAgICAgICBTdHJ1Y3R1 cmUqIHRyYW5zaXRpb24gPSB0b0NhY2hlYWJsZURpY3Rpb25hcnlUcmFuc2l0aW9uKGdsb2JhbERh dGEsIHN0cnVjdHVyZSk7CiAgICAgICAgIEFTU0VSVChzdHJ1Y3R1cmUgIT0gdHJhbnNpdGlvbik7 Ci0gICAgICAgIG9mZnNldCA9IHRyYW5zaXRpb24tPnB1dChnbG9iYWxEYXRhLCBwcm9wZXJ0eU5h bWUsIGF0dHJpYnV0ZXMsIHNwZWNpZmljVmFsdWUpOworICAgICAgICBvZmZzZXQgPSB0cmFuc2l0 aW9uLT5wdXRTcGVjaWZpY1ZhbHVlKGdsb2JhbERhdGEsIHByb3BlcnR5TmFtZSwgYXR0cmlidXRl cywgc3BlY2lmaWNWYWx1ZSk7CiAgICAgICAgIEFTU0VSVChvZmZzZXQgPj0gc3RydWN0dXJlLT5t X2Fub255bW91c1Nsb3RDb3VudCk7CiAgICAgICAgIEFTU0VSVChzdHJ1Y3R1cmUtPm1fYW5vbnlt b3VzU2xvdENvdW50ID09IHRyYW5zaXRpb24tPm1fYW5vbnltb3VzU2xvdENvdW50KTsKICAgICAg ICAgaWYgKHRyYW5zaXRpb24tPnByb3BlcnR5U3RvcmFnZVNpemUoKSA+IHRyYW5zaXRpb24tPnBy b3BlcnR5U3RvcmFnZUNhcGFjaXR5KCkpCkBAIC0zNjQsNyArMzY0LDcgQEAKICAgICAgICAgICAg IHRyYW5zaXRpb24tPmNyZWF0ZVByb3BlcnR5TWFwKCk7CiAgICAgfQogCi0gICAgb2Zmc2V0ID0g dHJhbnNpdGlvbi0+cHV0KGdsb2JhbERhdGEsIHByb3BlcnR5TmFtZSwgYXR0cmlidXRlcywgc3Bl Y2lmaWNWYWx1ZSk7CisgICAgb2Zmc2V0ID0gdHJhbnNpdGlvbi0+cHV0U3BlY2lmaWNWYWx1ZShn bG9iYWxEYXRhLCBwcm9wZXJ0eU5hbWUsIGF0dHJpYnV0ZXMsIHNwZWNpZmljVmFsdWUpOwogICAg IEFTU0VSVChvZmZzZXQgPj0gc3RydWN0dXJlLT5tX2Fub255bW91c1Nsb3RDb3VudCk7CiAgICAg QVNTRVJUKHN0cnVjdHVyZS0+bV9hbm9ueW1vdXNTbG90Q291bnQgPT0gdHJhbnNpdGlvbi0+bV9h bm9ueW1vdXNTbG90Q291bnQpOwogICAgIGlmICh0cmFuc2l0aW9uLT5wcm9wZXJ0eVN0b3JhZ2VT aXplKCkgPiB0cmFuc2l0aW9uLT5wcm9wZXJ0eVN0b3JhZ2VDYXBhY2l0eSgpKQpAQCAtNTg4LDcg KzU4OCw3IEBACiAKICAgICBtX2lzUGlubmVkUHJvcGVydHlUYWJsZSA9IHRydWU7CiAKLSAgICBz aXplX3Qgb2Zmc2V0ID0gcHV0KGdsb2JhbERhdGEsIHByb3BlcnR5TmFtZSwgYXR0cmlidXRlcywg c3BlY2lmaWNWYWx1ZSk7CisgICAgc2l6ZV90IG9mZnNldCA9IHB1dFNwZWNpZmljVmFsdWUoZ2xv YmFsRGF0YSwgcHJvcGVydHlOYW1lLCBhdHRyaWJ1dGVzLCBzcGVjaWZpY1ZhbHVlKTsKICAgICBB U1NFUlQob2Zmc2V0ID49IG1fYW5vbnltb3VzU2xvdENvdW50KTsKICAgICBpZiAocHJvcGVydHlT dG9yYWdlU2l6ZSgpID4gcHJvcGVydHlTdG9yYWdlQ2FwYWNpdHkoKSkKICAgICAgICAgZ3Jvd1By b3BlcnR5U3RvcmFnZUNhcGFjaXR5KCk7CkBAIC02ODMsNyArNjgzLDcgQEAKICAgICAgICAgaXRl ci0+c3BlY2lmaWNWYWx1ZS5jbGVhcigpOwogfQogCi1zaXplX3QgU3RydWN0dXJlOjpwdXQoSlNH bG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIHVu c2lnbmVkIGF0dHJpYnV0ZXMsIEpTQ2VsbCogc3BlY2lmaWNWYWx1ZSkKK3NpemVfdCBTdHJ1Y3R1 cmU6OnB1dFNwZWNpZmljVmFsdWUoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBjb25zdCBJZGVu dGlmaWVyJiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMsIEpTQ2VsbCogc3BlY2lm aWNWYWx1ZSkKIHsKICAgICBBU1NFUlQoIXByb3BlcnR5TmFtZS5pc051bGwoKSk7CiAgICAgQVNT RVJUKGdldChnbG9iYWxEYXRhLCBwcm9wZXJ0eU5hbWUpID09IG5vdEZvdW5kKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODQxMTkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQt MTcgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTQyBubyBsb25nZXIgYnVpbGRzIHdp dGggQ2xhbmcgZHVlIHRvIC1Xb3ZlcmxvYWRlZC12aXJ0dWFsIHdhcm5pbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NzYwCisKKyAgICAgICAgUmVu YW1lIFN0cnVjdHVyZSdzIHNwZWNpZmljVmFsdWUgb3ZlcmxvYWQgb2YgcHV0IHRvIHB1dFNwZWNp ZmljVmFsdWUgdG8gYXZvaWQKKyAgICAgICAgQ2xhbmcncyB3YXJuaW5nIGZvciBvdmVybG9hZGlu ZyBhIHZpcnR1YWwgZnVuY3Rpb24uCisKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5jcHA6 CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6YWRkUHJvcGVydHlUcmFuc2l0aW9uKToKKyAgICAg ICAgKEpTQzo6U3RydWN0dXJlOjphZGRQcm9wZXJ0eVdpdGhvdXRUcmFuc2l0aW9uKToKKyAgICAg ICAgKEpTQzo6U3RydWN0dXJlOjpwdXRTcGVjaWZpY1ZhbHVlKToKKyAgICAgICAgKiBydW50aW1l L1N0cnVjdHVyZS5oOgorCiAyMDExLTA0LTE3ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCg==