58755 2011-04-17 16:42:07 -0700 [WIN] Use WCHAR instead of TCHAR 2011-04-18 12:21:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 paroga paroga abarth aroben commit-queue eric webkit.review.bot oldest_to_newest 387460 0 paroga 2011-04-17 16:42:07 -0700 [WIN] Use WCHAR instead of TCHAR 387463 1 89972 paroga 2011-04-17 16:48:18 -0700 Created attachment 89972 Patch 387827 2 89972 commit-queue 2011-04-18 10:09:03 -0700 Comment on attachment 89972 Patch Clearing flags on attachment: 89972 Committed r84154: <http://trac.webkit.org/changeset/84154> 387828 3 commit-queue 2011-04-18 10:09:08 -0700 All reviewed patches have been landed. Closing bug. 387931 4 webkit.review.bot 2011-04-18 12:21:03 -0700 http://trac.webkit.org/changeset/84154 might have broken GTK Linux 32-bit Debug 89972 2011-04-17 16:48:18 -0700 2011-04-18 10:09:03 -0700 Patch bug-58755-20110418014815.patch text/plain 7752 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwZjA5ZjE0NTJhN2RjOWIzZjk5OTUxMmQ1ZTNhZWFlZGNm ZjY3NDIwLi5mNTU4MjM4YTA3Njk2NDM5YWFkOGI1N2RlZWRmNzVlMTEwZTI5NGM3IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDQtMTcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTl0gVXNl IFdDSEFSIGluc3RlYWQgb2YgVENIQVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4NzU1CisKKyAgICAgICAgV2UgYWx3YXlzIHVzZSB0aGUgVU5JQ09E RSB2ZXJzaW9ucyBvZiB3aW5kb3dzIGZ1bmN0aW9ucywgc28KKyAgICAgICAgdGhlIHVzYWdlIG9m IFRDSEFSIG1ha2VzIG5vIHNlbnNlIGFuZCBtaXhpbmcgdGhlbSBpcyBiYWQgc3R5bGUuCisKKyAg ICAgICAgKiBXaW5MYXVuY2hlci9QcmludFdlYlVJRGVsZWdhdGUuY3BwOgorICAgICAgICAgIEFs c28gZml4IHZhcmlvdXMgc3R5bGUgaXNzdWVzIChpbmNsdWRpbmcgaW5kZW50YXRpb24gYW5kIHJl bW92YWwgb2YgdWdseSBDLWNhc3RzKS4KKyAgICAgICAgKiBXaW5MYXVuY2hlci9XaW5MYXVuY2hl ci5jcHA6CisKIDIwMTEtMDQtMTcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2lu TGF1bmNoZXIvUHJpbnRXZWJVSURlbGVnYXRlLmNwcCBiL1Rvb2xzL1dpbkxhdW5jaGVyL1ByaW50 V2ViVUlEZWxlZ2F0ZS5jcHAKaW5kZXggY2NjMjY3YmM1YjAwY2E5ZDJmZTBmNGZmOWU5M2EwN2M4 NjIyYjI5MS4uM2U5MjE0NDE4MDM3YTA5N2NlZjBjNzIzMzRjNDFkZWIwMjgxNjk2MSAxMDA2NDQK LS0tIGEvVG9vbHMvV2luTGF1bmNoZXIvUHJpbnRXZWJVSURlbGVnYXRlLmNwcAorKysgYi9Ub29s cy9XaW5MYXVuY2hlci9QcmludFdlYlVJRGVsZWdhdGUuY3BwCkBAIC0yNywxNCArMjcsMTMgQEAK ICNpbmNsdWRlICJzdGRhZnguaCIKICNpbmNsdWRlICJQcmludFdlYlVJRGVsZWdhdGUuaCIKIAor I2luY2x1ZGUgPFdlYktpdC9XZWJLaXRDT01BUEkuaD4KICNpbmNsdWRlIDxjb21tY3RybC5oPgog I2luY2x1ZGUgPGNvbW1kbGcuaD4KICNpbmNsdWRlIDxvYmpiYXNlLmg+CiAjaW5jbHVkZSA8c2hs d2FwaS5oPgogI2luY2x1ZGUgPHdpbmluZXQuaD4KIAotI2luY2x1ZGUgPFdlYktpdC9XZWJLaXRD T01BUEkuaD4KLQogc3RhdGljIGNvbnN0IGludCBNQVJHSU4gPSAyMDsKIAogSFJFU1VMVCBQcmlu dFdlYlVJRGVsZWdhdGU6OlF1ZXJ5SW50ZXJmYWNlKFJFRklJRCByaWlkLCB2b2lkKiogcHB2T2Jq ZWN0KQpAQCAtOTcsOTggKzk2LDk4IEBAIEhSRVNVTFQgUHJpbnRXZWJVSURlbGVnYXRlOjp3ZWJW aWV3UHJpbnRpbmdNYXJnaW5SZWN0KElXZWJWaWV3KiB2aWV3LCBSRUNUKiByZWN0CiAKIEhSRVNV TFQgUHJpbnRXZWJVSURlbGVnYXRlOjp3ZWJWaWV3SGVhZGVySGVpZ2h0KElXZWJWaWV3KiB3ZWJW aWV3LCBmbG9hdCogaGVpZ2h0KQogewotICAgaWYgKCF3ZWJWaWV3IHx8ICFoZWlnaHQpCi0gICAg ICByZXR1cm4gRV9QT0lOVEVSOwotICAgCi0gICBIREMgZGMgPSA6OkdldERDKDApOworICAgIGlm ICghd2ViVmlldyB8fCAhaGVpZ2h0KQorICAgICAgICByZXR1cm4gRV9QT0lOVEVSOwogCi0gICBU RVhUTUVUUklDIHRleHRNZXRyaWM7Ci0gICA6OkdldFRleHRNZXRyaWNzKGRjLCAmdGV4dE1ldHJp Yyk7Ci0gICA6OlJlbGVhc2VEQygwLCBkYyk7CisgICAgSERDIGRjID0gOjpHZXREQygwKTsKIAot ICAgKmhlaWdodCA9IDEuMSAqIHRleHRNZXRyaWMudG1IZWlnaHQ7CisgICAgVEVYVE1FVFJJQyB0 ZXh0TWV0cmljOworICAgIDo6R2V0VGV4dE1ldHJpY3MoZGMsICZ0ZXh0TWV0cmljKTsKKyAgICA6 OlJlbGVhc2VEQygwLCBkYyk7CisKKyAgICAqaGVpZ2h0ID0gMS4xICogdGV4dE1ldHJpYy50bUhl aWdodDsKIAotICAgcmV0dXJuIFNfT0s7CisgICAgcmV0dXJuIFNfT0s7CiB9CiAKIEhSRVNVTFQg UHJpbnRXZWJVSURlbGVnYXRlOjp3ZWJWaWV3Rm9vdGVySGVpZ2h0KElXZWJWaWV3KiB3ZWJWaWV3 LCBmbG9hdCogaGVpZ2h0KQogewotICAgaWYgKCF3ZWJWaWV3IHx8ICFoZWlnaHQpCi0gICAgICBy ZXR1cm4gRV9QT0lOVEVSOworICAgIGlmICghd2ViVmlldyB8fCAhaGVpZ2h0KQorICAgICAgICBy ZXR1cm4gRV9QT0lOVEVSOwogCi0gICBIREMgZGMgPSA6OkdldERDKDApOworICAgIEhEQyBkYyA9 IDo6R2V0REMoMCk7CiAKLSAgIFRFWFRNRVRSSUMgdGV4dE1ldHJpYzsKLSAgIDo6R2V0VGV4dE1l dHJpY3MoZGMsICZ0ZXh0TWV0cmljKTsKLSAgIDo6UmVsZWFzZURDKDAsIGRjKTsKKyAgICBURVhU TUVUUklDIHRleHRNZXRyaWM7CisgICAgOjpHZXRUZXh0TWV0cmljcyhkYywgJnRleHRNZXRyaWMp OworICAgIDo6UmVsZWFzZURDKDAsIGRjKTsKIAotICAgKmhlaWdodCA9IDEuMSAqIHRleHRNZXRy aWMudG1IZWlnaHQ7CisgICAgKmhlaWdodCA9IDEuMSAqIHRleHRNZXRyaWMudG1IZWlnaHQ7CiAK LSAgIHJldHVybiBTX09LOworICAgIHJldHVybiBTX09LOwogfQogCi1IUkVTVUxUIFByaW50V2Vi VUlEZWxlZ2F0ZTo6ZHJhd0hlYWRlckluUmVjdCggCi0gICAgICAgICAgICAvKiBbaW5dICovIElX ZWJWaWV3ICp3ZWJWaWV3LAotICAgICAgICAgICAgLyogW2luXSAqLyBSRUNUICpyZWN0LAorSFJF U1VMVCBQcmludFdlYlVJRGVsZWdhdGU6OmRyYXdIZWFkZXJJblJlY3QoCisgICAgICAgICAgICAv KiBbaW5dICovIElXZWJWaWV3KiB3ZWJWaWV3LAorICAgICAgICAgICAgLyogW2luXSAqLyBSRUNU KiByZWN0LAogICAgICAgICAgICAgLyogW2luXSAqLyBPTEVfSEFORExFIGRyYXdpbmdDb250ZXh0 KQogewotICAgaWYgKCF3ZWJWaWV3IHx8ICFyZWN0KQotICAgICAgcmV0dXJuIEVfUE9JTlRFUjsK KyAgICBpZiAoIXdlYlZpZXcgfHwgIXJlY3QpCisgICAgICAgIHJldHVybiBFX1BPSU5URVI7CiAK LSAgIC8vIFR1cm4gb2ZmIGhlYWRlciBmb3Igbm93LgotICAgSERDIGRjID0gcmVpbnRlcnByZXRf Y2FzdDxIREM+KGRyYXdpbmdDb250ZXh0KTsKKyAgICAvLyBUdXJuIG9mZiBoZWFkZXIgZm9yIG5v dy4KKyAgICBIREMgZGMgPSByZWludGVycHJldF9jYXN0PEhEQz4oZHJhd2luZ0NvbnRleHQpOwog Ci0gICBIRk9OVCBoRm9udCA9IChIRk9OVCk6OkdldFN0b2NrT2JqZWN0KEFOU0lfVkFSX0ZPTlQp OwotICAgSEZPTlQgaE9sZEZvbnQgPSAoSEZPTlQpOjpTZWxlY3RPYmplY3QoZGMsIGhGb250KTsK KyAgICBIR0RJT0JKIGhGb250ID0gOjpHZXRTdG9ja09iamVjdChBTlNJX1ZBUl9GT05UKTsKKyAg ICBIR0RJT0JKIGhPbGRGb250ID0gOjpTZWxlY3RPYmplY3QoZGMsIGhGb250KTsKIAotICAgTFBD VFNUUiBoZWFkZXIoX1QoIltTYW1wbGUgSGVhZGVyXSIpKTsKLSAgIGludCBsZW5ndGggPSBfdGNz bGVuKGhlYWRlcik7CisgICAgTFBDV1NUUiBoZWFkZXIgPSBMIltTYW1wbGUgSGVhZGVyXSI7Cisg ICAgc2l6ZV90IGxlbmd0aCA9IHdjc2xlbihoZWFkZXIpOwogCi0gICBpbnQgcmMgPSA6OkRyYXdU ZXh0KGRjLCBoZWFkZXIsIGxlbmd0aCwgcmVjdCwgRFRfTEVGVCB8IERUX05PQ0xJUCB8IERUX1ZD RU5URVIgIHwgRFRfU0lOR0xFTElORSk7Ci0gICA6OlNlbGVjdE9iamVjdChkYywgaE9sZEZvbnQp OworICAgIGludCByYyA9IDo6RHJhd1RleHRXKGRjLCBoZWFkZXIsIGxlbmd0aCwgcmVjdCwgRFRf TEVGVCB8IERUX05PQ0xJUCB8IERUX1ZDRU5URVIgfCBEVF9TSU5HTEVMSU5FKTsKKyAgICA6OlNl bGVjdE9iamVjdChkYywgaE9sZEZvbnQpOwogCi0gICBpZiAoIXJjKQotICAgICAgcmV0dXJuIEVf RkFJTDsKKyAgICBpZiAoIXJjKQorICAgICAgICByZXR1cm4gRV9GQUlMOwogCi0gICA6Ok1vdmVU b0V4KGRjLCByZWN0LT5sZWZ0LCByZWN0LT5ib3R0b20sIDApOwotICAgSFBFTiBoUGVuID0gKEhQ RU4pOjpHZXRTdG9ja09iamVjdChCTEFDS19QRU4pOwotICAgSFBFTiBoT2xkUGVuID0gKEhQRU4p OjpTZWxlY3RPYmplY3QoZGMsIGhQZW4pOwotICAgOjpMaW5lVG8oZGMsIHJlY3QtPnJpZ2h0LCBy ZWN0LT5ib3R0b20pOwotICAgOjpTZWxlY3RPYmplY3QoZGMsIGhPbGRQZW4pOworICAgIDo6TW92 ZVRvRXgoZGMsIHJlY3QtPmxlZnQsIHJlY3QtPmJvdHRvbSwgMCk7CisgICAgSEdESU9CSiBoUGVu ID0gOjpHZXRTdG9ja09iamVjdChCTEFDS19QRU4pOworICAgIEhHRElPQkogaE9sZFBlbiA9IDo6 U2VsZWN0T2JqZWN0KGRjLCBoUGVuKTsKKyAgICA6OkxpbmVUbyhkYywgcmVjdC0+cmlnaHQsIHJl Y3QtPmJvdHRvbSk7CisgICAgOjpTZWxlY3RPYmplY3QoZGMsIGhPbGRQZW4pOwogCi0gICByZXR1 cm4gU19PSzsKKyAgICByZXR1cm4gU19PSzsKIH0KIAotSFJFU1VMVCBQcmludFdlYlVJRGVsZWdh dGU6OmRyYXdGb290ZXJJblJlY3QoIAotICAgICAgICAgICAgLyogW2luXSAqLyBJV2ViVmlldyAq d2ViVmlldywKLSAgICAgICAgICAgIC8qIFtpbl0gKi8gUkVDVCAqcmVjdCwKK0hSRVNVTFQgUHJp bnRXZWJVSURlbGVnYXRlOjpkcmF3Rm9vdGVySW5SZWN0KAorICAgICAgICAgICAgLyogW2luXSAq LyBJV2ViVmlldyogd2ViVmlldywKKyAgICAgICAgICAgIC8qIFtpbl0gKi8gUkVDVCogcmVjdCwK ICAgICAgICAgICAgIC8qIFtpbl0gKi8gT0xFX0hBTkRMRSBkcmF3aW5nQ29udGV4dCwKICAgICAg ICAgICAgIC8qIFtpbl0gKi8gVUlOVCBwYWdlSW5kZXgsCiAgICAgICAgICAgICAvKiBbaW5dICov IFVJTlQgcGFnZUNvdW50KQogewotICAgaWYgKCF3ZWJWaWV3IHx8ICFyZWN0KQotICAgICAgcmV0 dXJuIEVfUE9JTlRFUjsKKyAgICBpZiAoIXdlYlZpZXcgfHwgIXJlY3QpCisgICAgICAgIHJldHVy biBFX1BPSU5URVI7CiAKLSAgIEhEQyBkYyA9IHJlaW50ZXJwcmV0X2Nhc3Q8SERDPihkcmF3aW5n Q29udGV4dCk7CisgICAgSERDIGRjID0gcmVpbnRlcnByZXRfY2FzdDxIREM+KGRyYXdpbmdDb250 ZXh0KTsKIAotICAgSEZPTlQgaEZvbnQgPSAoSEZPTlQpOjpHZXRTdG9ja09iamVjdChBTlNJX1ZB Ul9GT05UKTsKLSAgIEhGT05UIGhPbGRGb250ID0gKEhGT05UKTo6U2VsZWN0T2JqZWN0KGRjLCBo Rm9udCk7CisgICAgSEdESU9CSiBoRm9udCA9IDo6R2V0U3RvY2tPYmplY3QoQU5TSV9WQVJfRk9O VCk7CisgICAgSEdESU9CSiBoT2xkRm9udCA9IDo6U2VsZWN0T2JqZWN0KGRjLCBoRm9udCk7CiAK LSAgIExQQ1RTVFIgZm9vdGVyKF9UKCJbU2FtcGxlIEZvb3Rlcl0iKSk7Ci0gICBpbnQgbGVuZ3Ro ID0gX3Rjc2xlbihmb290ZXIpOworICAgIExQQ1dTVFIgZm9vdGVyID0gTCJbU2FtcGxlIEZvb3Rl cl0iOworICAgIHNpemVfdCBsZW5ndGggPSB3Y3NsZW4oZm9vdGVyKTsKIAotICAgLy8gQWRkIGEg bGluZSwgMS8xMHRoIGluY2ggYWJvdmUgdGhlIGZvb3RlciB0ZXh0IGZyb20gbGVmdCBtYXJnaW4g dG8gcmlnaHQgbWFyZ2luLgotICAgOjpNb3ZlVG9FeChkYywgcmVjdC0+bGVmdCwgcmVjdC0+dG9w LCAwKTsKLSAgIEhQRU4gaFBlbiA9IChIUEVOKTo6R2V0U3RvY2tPYmplY3QoQkxBQ0tfUEVOKTsK LSAgIEhQRU4gaE9sZFBlbiA9IChIUEVOKTo6U2VsZWN0T2JqZWN0KGRjLCBoUGVuKTsKLSAgIDo6 TGluZVRvKGRjLCByZWN0LT5yaWdodCwgcmVjdC0+dG9wKTsKLSAgIDo6U2VsZWN0T2JqZWN0KGRj LCBoT2xkUGVuKTsKKyAgICAvLyBBZGQgYSBsaW5lLCAxLzEwdGggaW5jaCBhYm92ZSB0aGUgZm9v dGVyIHRleHQgZnJvbSBsZWZ0IG1hcmdpbiB0byByaWdodCBtYXJnaW4uCisgICAgOjpNb3ZlVG9F eChkYywgcmVjdC0+bGVmdCwgcmVjdC0+dG9wLCAwKTsKKyAgICBIR0RJT0JKIGhQZW4gPSA6Okdl dFN0b2NrT2JqZWN0KEJMQUNLX1BFTik7CisgICAgSEdESU9CSiBoT2xkUGVuID0gOjpTZWxlY3RP YmplY3QoZGMsIGhQZW4pOworICAgIDo6TGluZVRvKGRjLCByZWN0LT5yaWdodCwgcmVjdC0+dG9w KTsKKyAgICA6OlNlbGVjdE9iamVjdChkYywgaE9sZFBlbik7CiAKLSAgIGludCByYyA9IDo6RHJh d1RleHQoZGMsIGZvb3RlciwgbGVuZ3RoLCByZWN0LCBEVF9MRUZUIHwgRFRfTk9DTElQIHwgRFRf VkNFTlRFUiAgfCBEVF9TSU5HTEVMSU5FKTsKLSAgIDo6U2VsZWN0T2JqZWN0KGRjLCBoT2xkRm9u dCk7CisgICAgaW50IHJjID0gOjpEcmF3VGV4dFcoZGMsIGZvb3RlciwgbGVuZ3RoLCByZWN0LCBE VF9MRUZUIHwgRFRfTk9DTElQIHwgRFRfVkNFTlRFUiB8IERUX1NJTkdMRUxJTkUpOworICAgIDo6 U2VsZWN0T2JqZWN0KGRjLCBoT2xkRm9udCk7CiAKLSAgIGlmICghcmMpCi0gICAgICByZXR1cm4g RV9GQUlMOworICAgIGlmICghcmMpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CiAKLSAgIHJldHVy biBTX09LOworICAgIHJldHVybiBTX09LOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2luTGF1bmNo ZXIvV2luTGF1bmNoZXIuY3BwIGIvVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCmlu ZGV4IDVjYWYyMzAwMWRlOWQ5OTJjNDFkNzViY2ExZjIyODU0Y2NkOTFhZmUuLmY1NzJiMTU4ZDI1 NTBhMTFhYTVjOWNmNjA0YjFjODgzOTE0MjY0YmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dpbkxhdW5j aGVyL1dpbkxhdW5jaGVyLmNwcAorKysgYi9Ub29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci5j cHAKQEAgLTMyNywxMiArMzI3LDEyIEBAIHZvaWQgUHJpbnRWaWV3KEhXTkQgaFduZCwgVUlOVCBt ZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKQogewogICAgIEhEQyBwcmludERD ID0gZ2V0UHJpbnRlckRDKCk7CiAgICAgaWYgKCFwcmludERDKSB7Ci0gICAgICAgIDo6TWVzc2Fn ZUJveCgwLCBfVCgiRXJyb3IgY3JlYXRpbmcgcHJpbnRpbmcgREMiKSwgX1QoIkVycm9yIiksIE1C X0FQUExNT0RBTCB8IE1CX09LKTsKKyAgICAgICAgOjpNZXNzYWdlQm94VygwLCBMIkVycm9yIGNy ZWF0aW5nIHByaW50aW5nIERDIiwgTCJFcnJvciIsIE1CX0FQUExNT0RBTCB8IE1CX09LKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmICg6OlNldEFib3J0UHJvYyhwcmludERDLCBB Ym9ydFByb2MpID09IFNQX0VSUk9SKSB7Ci0gICAgICAgIDo6TWVzc2FnZUJveCgwLCBfVCgiRXJy b3Igc2V0dGluZyB1cCBBYm9ydFByb2MiKSwgX1QoIkVycm9yIiksIE1CX0FQUExNT0RBTCB8IE1C X09LKTsKKyAgICAgICAgOjpNZXNzYWdlQm94VygwLCBMIkVycm9yIHNldHRpbmcgdXAgQWJvcnRQ cm9jIiwgTCJFcnJvciIsIE1CX0FQUExNT0RBTCB8IE1CX09LKTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0KIApAQCAtMzUwLDcgKzM1MCw3IEBAIHZvaWQgUHJpbnRWaWV3KEhXTkQgaFduZCwgVUlO VCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKQogICAgIGZyYW1lUHJpdmF0 ZS0+Z2V0UHJpbnRlZFBhZ2VDb3VudChwcmludERDLCAmcGFnZUNvdW50KTsKIAogICAgIERPQ0lO Rk8gZGk7Ci0gICAgaW5pdERvY1N0cnVjdCgmZGksIF9UKCJXZWJLaXQgRG9jIikpOworICAgIGlu aXREb2NTdHJ1Y3QoJmRpLCBMIldlYktpdCBEb2MiKTsKICAgICA6OlN0YXJ0RG9jKHByaW50REMs ICZkaSk7CiAKICAgICAvLyBGSVhNRTogTmVlZCBDb3JlR3JhcGhpY3MgaW1wbGVtZW50YXRpb24K