58737 2011-04-16 18:08:15 -0700 [GTK] Undefined Symbol build error "_objc_registerThreadWithCollector" when building WebKit GTK Mac OS X on Snow Leopard 2014-12-09 14:06:16 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED N/A P2 Major --- 126492 1 devchan1 webkit-unassigned benjamin berto cgarcia cmarcelo commit-queue darin jeremyhu oldest_to_newest 387299 0 89935 devchan1 2011-04-16 18:08:15 -0700 Created attachment 89935 Patch to avoid including os x specific threading code when bullding WebKit GTK The following build error occurs when building WebKit GTK rev 84097 on Mac OS X Snow Leopard: Undefined symbols: "_objc_registerThreadWithCollector", referenced from: WTF::initializeCurrentThreadInternal(char const*)in libJavaScriptCore.a(libJavaScriptCore_la-ThreadingPthreads.o) ld: symbol(s) not found collect2: ld returned 1 exit status make[1]: *** [Programs/jsc] Error 1 make: *** [all] Error 2 387300 1 89936 devchan1 2011-04-16 18:10:15 -0700 Created attachment 89936 Patch to avoid including os x specific threading code when bullding WebKit GTK 758138 2 jeremyhu 2012-11-04 11:55:27 -0800 That's not the right fix. I think you actually want to change OS(MAC_OS_X) to PLATFORM(MAC). 758139 3 jeremyhu 2012-11-04 12:02:36 -0800 Yeah, that patch is no longer valid, but it is fixed with: sed -i "s:OS(MAC_OS_X):PLATFORM(MAC):" Source/WTF/wtf/ThreadingPthreads.cpp 927866 4 berto 2013-09-11 10:55:32 -0700 Is this still relevant? 927877 5 jeremyhu 2013-09-11 11:11:20 -0700 Yes. Please make the provided change. 927971 6 211348 berto 2013-09-11 14:05:14 -0700 Created attachment 211348 Patch 928007 7 211348 darin 2013-09-11 15:14:21 -0700 Comment on attachment 211348 Patch Are you sure this is what Qt wants on Mac too? 928008 8 211348 darin 2013-09-11 15:15:35 -0700 Comment on attachment 211348 Patch If Qt doesn’t also want this code, then I think the original that specifically called out PLATFORM(GTK) might in fact be what we want. 956396 9 berto 2013-12-04 08:02:25 -0800 (In reply to comment #8) > (From update of attachment 211348 [details]) > If Qt doesn’t also want this code, then I think the original that > specifically called out PLATFORM(GTK) might in fact be what we want. I guess this doesn't matter anymore and we can apply the patch as it is? 968460 10 berto 2014-01-15 13:54:43 -0800 Jeremy, can you confirm if this is still working fine? 968479 11 jeremyhu 2014-01-15 14:53:38 -0800 (In reply to comment #10) > Jeremy, can you confirm if this is still working fine? The issue still exists (at least in webkit-gtk 2.3.3). We're still doing the following OS/Platform fixes: # https://bugs.webkit.org/show_bug.cgi?id=99683 reinplace "s:PLATFORM(MAC):OS(DARWIN):g" \ ${worksrcpath}/Source/JavaScriptCore/heap/VTableSpectrum.cpp \ ${worksrcpath}/Source/JavaScriptCore/jit/ThunkGenerators.cpp \ ${worksrcpath}/Source/JavaScriptCore/tools/CodeProfile.cpp # https://bugs.webkit.org/show_bug.cgi?id=58737 reinplace "s:OS(MAC_OS_X):PLATFORM(MAC):" \ ${worksrcpath}/Source/WTF/wtf/ThreadingPthreads.cpp 968622 12 berto 2014-01-15 23:22:29 -0800 (In reply to comment #11) > # https://bugs.webkit.org/show_bug.cgi?id=58737 > reinplace "s:OS(MAC_OS_X):PLATFORM(MAC):" \ > ${worksrcpath}/Source/WTF/wtf/ThreadingPthreads.cpp Ok, this one is still fine, now it only needs to be reviewed. 1053036 13 211348 gustavo 2014-12-06 10:12:43 -0800 Comment on attachment 211348 Patch Is this change correct for iOS too? I'd r+, but I'd prefer someone who knows the apple ports to do it. 1053783 14 211348 darin 2014-12-09 07:41:34 -0800 Comment on attachment 211348 Patch This does no harm on iOS, but our long term direction is to use PLATFORM directly as little as possible and use more specific #if statements so the platform configuration system works and is not tied to specific platforms. I guess the real issue here is that GTK is choosing not to support garbage collection, so ideally the condition would be #if USE(COCOA_GC) or something along those lines. 1053833 15 berto 2014-12-09 10:11:09 -0800 (In reply to comment #14) > ideally the condition would be #if USE(COCOA_GC) or something along > those lines. It looks like a good policy, but I guess it doesn't make sense to define COCOA_GC just for this case. 1053837 16 berto 2014-12-09 10:20:46 -0800 Committed r177023: <http://trac.webkit.org/changeset/177023> 1053938 17 darin 2014-12-09 14:06:16 -0800 (In reply to comment #15) > It looks like a good policy, but I guess it doesn't make sense to > define COCOA_GC just for this case. I believe there are a number of other places in the code that should use COCOA_GC. It's just that the other places don't simply fail to compile. One possible example is the code in the adoptNS function in RetainPtr.h. It uses "#if defined(OBJC_NO_GC)" and instead it should use "#if !USE(COCOA_GC)". This is a missed optimization opportunity. 89935 2011-04-16 18:08:15 -0700 2013-09-11 15:14:42 -0700 Patch to avoid including os x specific threading code when bullding WebKit GTK patch-WebKit-gtk-ThreadingPthreads.cpp.diff text/plain 812 devchan1 LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCTIwMTEt MDQtMTYgMTM6MTA6NDYuMDAwMDAwMDAwIC0wNDAwCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcC5wYXRjaGVkCTIwMTEtMDQtMTYgMTM6MTA6MjMuMDAw MDAwMDAwIC0wNDAwCkBAIC01NSw3ICs1NSw3IEBACiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIu aD4KICNlbmRpZgogCi0jaWYgT1MoTUFDX09TX1gpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xF T1BBUkQpCisjaWYgT1MoTUFDX09TX1gpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQp ICYmICFQTEFURk9STShHVEspCiAjaW5jbHVkZSA8b2JqYy9vYmpjLWF1dG8uaD4KICNlbmRpZgog CkBAIC0xOTQsNyArMTk0LDcgQEAKICAgICBVTlVTRURfUEFSQU0odGhyZWFkTmFtZSk7CiAjZW5k aWYKIAotI2lmIE9TKE1BQ19PU19YKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKQor I2lmIE9TKE1BQ19PU19YKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhUExB VEZPUk0oR1RLKQogICAgIC8vIEFsbCB0aHJlYWRzIHRoYXQgcG90ZW50aWFsbHkgdXNlIEFQSXMg YWJvdmUgdGhlIEJTRCBsYXllciBtdXN0IGJlIHJlZ2lzdGVyZWQgd2l0aCB0aGUgT2JqZWN0aXZl LUMKICAgICAvLyBnYXJiYWdlIGNvbGxlY3RvciBpbiBjYXNlIEFQSSBpbXBsZW1lbnRhdGlvbnMg dXNlIGdhcmJhZ2UtY29sbGVjdGVkIG1lbW9yeS4KICAgICBvYmpjX3JlZ2lzdGVyVGhyZWFkV2l0 aENvbGxlY3RvcigpOwo= 89936 2011-04-16 18:10:15 -0700 2013-09-11 15:15:03 -0700 Patch to avoid including os x specific threading code when bullding WebKit GTK patch-WebKit-gtk-ThreadingPthreads.cpp.diff text/plain 812 devchan1 LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCTIwMTEt MDQtMTYgMTM6MTA6NDYuMDAwMDAwMDAwIC0wNDAwCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcC5wYXRjaGVkCTIwMTEtMDQtMTYgMTM6MTA6MjMuMDAw MDAwMDAwIC0wNDAwCkBAIC01NSw3ICs1NSw3IEBACiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIu aD4KICNlbmRpZgogCi0jaWYgT1MoTUFDX09TX1gpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xF T1BBUkQpCisjaWYgT1MoTUFDX09TX1gpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQp ICYmICFQTEFURk9STShHVEspCiAjaW5jbHVkZSA8b2JqYy9vYmpjLWF1dG8uaD4KICNlbmRpZgog CkBAIC0xOTQsNyArMTk0LDcgQEAKICAgICBVTlVTRURfUEFSQU0odGhyZWFkTmFtZSk7CiAjZW5k aWYKIAotI2lmIE9TKE1BQ19PU19YKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKQor I2lmIE9TKE1BQ19PU19YKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhUExB VEZPUk0oR1RLKQogICAgIC8vIEFsbCB0aHJlYWRzIHRoYXQgcG90ZW50aWFsbHkgdXNlIEFQSXMg YWJvdmUgdGhlIEJTRCBsYXllciBtdXN0IGJlIHJlZ2lzdGVyZWQgd2l0aCB0aGUgT2JqZWN0aXZl LUMKICAgICAvLyBnYXJiYWdlIGNvbGxlY3RvciBpbiBjYXNlIEFQSSBpbXBsZW1lbnRhdGlvbnMg dXNlIGdhcmJhZ2UtY29sbGVjdGVkIG1lbW9yeS4KICAgICBvYmpjX3JlZ2lzdGVyVGhyZWFkV2l0 aENvbGxlY3RvcigpOwo= 211348 2013-09-11 14:05:14 -0700 2014-12-09 07:41:34 -0800 Patch 58737.diff text/plain 1503 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTllM2M1My4uOWFhZmE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wOS0xMSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFVuZGVmaW5lZCBT eW1ib2wgYnVpbGQgZXJyb3IgIl9vYmpjX3JlZ2lzdGVyVGhyZWFkV2l0aENvbGxlY3RvciIgd2hl biBidWlsZGluZyBXZWJLaXQgR1RLIE1hYyBPUyBYIG9uIFNub3cgTGVvcGFyZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg3MzcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIE9TKE1BQ19PU19Y KSB3aXRoIFBMQVRGT1JNKE1BQykgdG8gcHJldmVudCB1c2luZworICAgICAgICBvc3gtc3BlY2lm aWMgY29kZSBpbiBXZWJLaXRHVEsrIGJ1aWxkcy4KKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQ dGhyZWFkcy5jcHA6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVDdXJyZW50VGhyZWFkSW50ZXJu YWwpOgorCiAyMDEzLTA5LTExICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFr b3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFdURjo6T3duUHRyIHNob3VsZCBiZWhhdmUgc2ltaWxh cmx5IHdpdGggdGhlIHJlc3Qgb2YgV1RGIHNtYXJ0IHBvaW50ZXJzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRp bmdQdGhyZWFkcy5jcHAKaW5kZXggMzNiYjdjNC4uYmIwNWU4YSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1RocmVh ZGluZ1B0aHJlYWRzLmNwcApAQCAtNTUsNyArNTUsNyBAQAogI2luY2x1ZGUgPHN5cy90aW1lLmg+ CiAjZW5kaWYKIAotI2lmIE9TKE1BQ19PU19YKQorI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRl IDxvYmpjL29iamMtYXV0by5oPgogI2VuZGlmCiAKQEAgLTIyMiw3ICsyMjIsNyBAQCB2b2lkIGlu aXRpYWxpemVDdXJyZW50VGhyZWFkSW50ZXJuYWwoY29uc3QgY2hhciogdGhyZWFkTmFtZSkKICAg ICBVTlVTRURfUEFSQU0odGhyZWFkTmFtZSk7CiAjZW5kaWYKIAotI2lmIE9TKE1BQ19PU19YKQor I2lmIFBMQVRGT1JNKE1BQykKICAgICAvLyBBbGwgdGhyZWFkcyB0aGF0IHBvdGVudGlhbGx5IHVz ZSBBUElzIGFib3ZlIHRoZSBCU0QgbGF5ZXIgbXVzdCBiZSByZWdpc3RlcmVkIHdpdGggdGhlIE9i amVjdGl2ZS1DCiAgICAgLy8gZ2FyYmFnZSBjb2xsZWN0b3IgaW4gY2FzZSBBUEkgaW1wbGVtZW50 YXRpb25zIHVzZSBnYXJiYWdlLWNvbGxlY3RlZCBtZW1vcnkuCiAgICAgb2JqY19yZWdpc3RlclRo cmVhZFdpdGhDb2xsZWN0b3IoKTsK